qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-23 04:42:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

Check for unused enum values in switch statements.

Browse source 
Unfortunately, it turns out the value lookup is broken (including for
duplicate cases).
This commit is contained in:
Bill Currie 2013-06-25 14:21:43 +09:00
parent 35bc981402
commit 8ac2c3a04d
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
tools/qfcc/source/switch.c
View file

@ -368,6 +368,24 @@ build_switch (expr_t *sw, case_node_t *tree, int op, expr_t *sw_val,
}
}
static void
check_enum_switch (switch_block_t *switch_block)
{
case_label_t cl;
symbol_t *enum_val;
type_t *type = get_type (switch_block->test);
for (enum_val = type->t.symtab->symbols; enum_val;
enum_val = enum_val->next) {
cl.value = new_integer_expr (enum_val->s.value->v.integer_val);
if (!Hash_FindElement (switch_block->labels, &cl)) {
warning (switch_block->test,
"enumeration value `%s' not handled in switch",
enum_val->name);
}
}
}
struct expr_s *
switch_expr (switch_block_t *switch_block, expr_t *break_label,
expr_t *statements)
@ -393,6 +411,8 @@ switch_expr (switch_block_t *switch_block, expr_t *break_label,
if (!default_label) {
default_label = &_default_label;
default_label->label = break_label;
if (is_enum (type))
check_enum_switch (switch_block);
}
append_expr (sw, assign_expr (sw_val, switch_block->test));