qf
/
quakeforge
mirror of https://git.code.sf.net/p/quake/quakeforge
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Treat aliases of the same basic type as no-ops. 

At the statement level, all pointer types are the same, so just return the
op obtained from the sub-expression when the low-level type of the alias
expression matches the low-level type of the type of type sub-expression
operand.

With this, the alias of a value code can be removed (I always thought it
was wrong), which is what broke calling obj_msgSend_super (type &.super
param lost the &).

Now I have to deal with pointer values in the optimizer :/
This commit is contained in:
Bill Currie 2012-12-11 20:44:40 +09:00
parent 76c9aa2930
commit 85e6dd965f
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/qfcc/source/statements.c
View File

@ -825,21 +825,21 @@ expr_alias (sblock_t *sblock, expr_t *e, operand_t **op)
etype_t type;
def_t *def;
type = low_level_type (e->e.expr.type);
sblock = statement_subexpr (sblock, e->e.expr.e1, &aop);
if (aop->type == type) {
*op = aop;
return sblock;
}
if (aop->op_type == op_temp) {
while (aop->o.tempop.alias) {
aop = aop->o.tempop.alias;
if (aop->op_type != op_temp)
internal_error (e, "temp alias of non-temp var");
}
type = low_level_type (e->e.expr.type);
if (aop->type == type) {
top = aop;
} else {
for (top = aop->o.tempop.alias_ops; top; top = top->next)
if (top->type == type)
break;
}
if (!top) {
top = new_operand (op_temp);
top->type = type;
@ -855,11 +855,6 @@ expr_alias (sblock_t *sblock, expr_t *e, operand_t **op)
*op = new_operand (op_def);
(*op)->type = low_level_type (e->e.expr.type);
(*op)->o.def = alias_def (def, ev_types[(*op)->type], 0);
} else if (aop->op_type == op_value && aop->o.value->type == ev_pointer) {
ex_pointer_t *ptr = &aop->o.value->v.pointer;
*op = new_operand (op_def);
(*op)->type = low_level_type (ptr->type);
(*op)->o.def = alias_def (ptr->def, ptr->type, ptr->val);
} else {
internal_error (e, "invalid alias target: %s: %s",
optype_str (aop->op_type), operand_string (aop));