qf
/
quakeforge
mirror of https://git.code.sf.net/p/quake/quakeforge
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[qfcc] Add flow defs for parameters 

Needed for proper analysis (ud-chains etc). Of course, it was then
necessary to remove the parameter defs from the uninitialized defs.

Also, plug a couple of memory leaks (forgot to free some temporary
sets).
This commit is contained in:
Bill Currie 2023-05-14 13:40:40 +09:00
parent 4435db0329
commit 7b7b2ef000
2 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/qfcc/include/function.h
View File

@ -117,6 +117,7 @@ typedef struct function_s {
struct flowvar_s **vars;
int num_vars; ///< total number of variables referenced
struct set_s *global_vars;///< set indicating which vars are global
struct set_s *param_vars; ///< set indicating which vars are params
struct statement_s **statements;
int num_statements;
int pseudo_addr;///< pseudo address space for flow analysis

29
tools/qfcc/source/flow.c
View File

@ -545,6 +545,14 @@ static int flow_def_clear_flowvars (def_t *def, void *data)
return 0;
}
static void
add_var_addrs (set_t *set, flowvar_t *var)
{
for (int i = 0; i < var->op->size; i++) {
set_add (set, var->flowaddr + i);
}
}
/** Build an array of all the variables used by a function
*
* The array exists so variables can be referenced by number and thus used
@ -682,23 +690,24 @@ flow_build_vars (function_t *func)
}
}
func->global_vars = set_new ();
// mark all global vars (except .return and .param_N)
func->param_vars = set_new ();
// mark all global vars (except .return and .param_N), and param vars
for (i = num_flow_params; i < func->num_vars; i++) {
if (flowvar_is_global (func->vars[i]))
if (flowvar_is_global (func->vars[i])) {
set_add (func->global_vars, i);
}
if (flowvar_is_param (func->vars[i])) {
add_var_addrs (func->param_vars, func->vars[i]);
}
}
// Put the local varibals in their place (set var->defined to the addresses
// spanned by the var)
for (i = 0; i < func->num_vars; i++) {
int j;
var = func->vars[i];
if (flowvar_is_global (var) || flowvar_is_param (var)) {
if (flowvar_is_global (var)) {// || flowvar_is_param (var)) {
continue;
}
for (j = 0; j < var->op->size; j++) {
set_add (var->define, var->flowaddr + j);
}
add_var_addrs (var->define, var);
}
set_delete (stuse);
@ -759,6 +768,7 @@ flow_kill_aliases (set_t *kill, flowvar_t *var, const set_t *uninit)
}
// merge the alias kills with the current def's kills
set_union (kill, tmp);
set_delete (tmp);
}
/** Compute reaching defs
@ -1036,6 +1046,8 @@ flow_uninitialized (flowgraph_t *graph)
uninitialized = set_new ();
node = graph->nodes[graph->num_nodes];
set_assign (uninitialized, node->reaching_defs.out);
// parameters are, by definition, initialized
set_difference (uninitialized, graph->func->param_vars);
defs = set_new ();
for (i = 0; i < graph->num_nodes; i++) {
@ -1058,6 +1070,7 @@ flow_uninitialized (flowgraph_t *graph)
flow_uninit_scan_statements (node, defs, uninitialized);
}
set_delete (defs);
set_delete (uninitialized);
}
static void