qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-16 17:01:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Revert "Kill dag leaf nodes on assignment."

Browse source 
This reverts commit 2fcda44ab0.

Killing the node is not the correcgt answer as it blocks many
optimization opportunities. The correct answer is adding edges to
describe the temporal dependencies. Of course, this breaks the swap.r
test.
This commit is contained in:
Bill Currie 2021-06-29 12:09:35 +09:00
parent 5291cfb03d
commit 76b3bedb72
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tools/qfcc/source/dags.c
View file

@ -640,11 +640,6 @@ dagnode_attach_label (dagnode_t *n, daglabel_t *l)
"attempt to attach non-identifer label to dagnode "
"identifiers");
if (l->dagnode) {
// if the node is a leaf, then kill its value so no attempt is made
// to reuse it.
if (l->dagnode->type == st_none) {
l->dagnode->killed = n;
}
dagnode_t *node = l->dagnode;
set_union (n->edges, node->parents);
set_remove (n->edges, n->number);