qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-21 03:01:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

[scene] Limit light efrags to leafs within range

Browse source 
This makes a pretty significant difference: 8-25% for demo1, demo2,
demo3 and bigass1. Many thanks to Nick Alger
(https://stackoverflow.com/questions/5122228/box-to-sphere-collision).
It took me a moment to recognize that it's the Minkowski difference (and
maybe GJK?). Of course, I adapted it for simd.
This commit is contained in:
Bill Currie 2023-07-22 20:08:15 +09:00
parent 72f6048a20
commit 7280e1d042
1 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
libs/scene/light.c
View file

@ -53,6 +53,37 @@ Light_ClearLights (lightingdata_t *ldata)
ldata->leaf = 0;
}
static bool
test_light_leaf (const light_t *light, const mleaf_t *leaf)
{
// FIXME directional lights should check the direction against the
// leaf's portals (need to find the portals first, though)
if (!light->position[3] || !light->attenuation[3]) {
// non-positional lights or lights with infinite radius always light
// the leafs they can see
return true;
}
// use Minkowski difference to see if the light hits the leaf's bounding
// box (thanks to Nick Alger:
// https://stackoverflow.com/questions/5122228/box-to-sphere-collision)
float r = 1/light->attenuation[3];
vec4f_t c = light->position / light->position[3];
vec4f_t mins = loadvec3f (leaf->mins);
vec4f_t maxs = loadvec3f (leaf->maxs);
vec4i_t tmin = c < mins;
vec4i_t tmax = maxs < c;
vec4i_t tcen = ~tmin & ~tmax;
vec4f_t p = (vec4f_t)((tmin & (vec4i_t)mins)
+ (tcen & (vec4i_t)c)
+ (tmax & (vec4i_t)maxs));
p[3] = 1;
vec4f_t d = p - c;
if (dotf (d, d)[0] > r * r) {
return false;
}
return true;
}
void
Light_AddLight (lightingdata_t *ldata, const light_t *light, int style)
{
@ -84,7 +115,9 @@ Light_AddLight (lightingdata_t *ldata, const light_t *light, int style)
efrag_t **lastlink = &efrags;
for (auto li = set_first (pvs); li; li = set_next (li)) {
mleaf_t *leaf = model->brush.leafs + li->element + 1;
lastlink = R_LinkEfrag (leaf, ent, mod_light, lastlink);
if (test_light_leaf (light, leaf)) {
lastlink = R_LinkEfrag (leaf, ent, mod_light, lastlink);
}
}
Ent_SetComponent (ent.id, scene_efrags, ent.reg, &efrags);
}