qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-05-31 08:41:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Detect aliased temopary variables.

Browse source 
This takes care of some temps not being freed.
This commit is contained in:
Bill Currie 2012-11-18 20:29:40 +09:00
parent 3d1792d2fc
commit 4e8e94a1b2
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tools/qfcc/source/emit.c
View file

@ -172,14 +172,18 @@ add_statement_op_ref (operand_t *op, dstatement_t *st, int field)
} }
static void static void
use_tempop (operand_t *op) use_tempop (operand_t *op, expr_t *expr)
{ {
while (op && op->op_type == op_alias)
op = op->o.alias;
if (!op || op->op_type != op_temp) if (!op || op->op_type != op_temp)
return; return;
if (--op->o.tempop.users == 0) if (--op->o.tempop.users == 0) {
free_temp_def (op->o.tempop.def); free_temp_def (op->o.tempop.def);
op->o.tempop.def = 0;
}
if (op->o.tempop.users <= -1) if (op->o.tempop.users <= -1)
bug (0, "temp users went negative: %s", operand_string (op)); bug (expr, "temp users went negative: %s", operand_string (op));
} }
static void static void
@ -191,11 +195,11 @@ emit_statement (statement_t *statement)
dstatement_t *s; dstatement_t *s;
def_a = get_operand_def (statement->expr, statement->opa); def_a = get_operand_def (statement->expr, statement->opa);
use_tempop (statement->opa); use_tempop (statement->opa, statement->expr);
def_b = get_operand_def (statement->expr, statement->opb); def_b = get_operand_def (statement->expr, statement->opb);
use_tempop (statement->opb); use_tempop (statement->opb, statement->expr);
def_c = get_operand_def (statement->expr, statement->opc); def_c = get_operand_def (statement->expr, statement->opc);
use_tempop (statement->opc); use_tempop (statement->opc, statement->expr);
op = opcode_find (opcode, def_a, def_b, def_c); op = opcode_find (opcode, def_a, def_b, def_c);
if (!op) { if (!op) {