qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-17 01:11:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vulkan] Copy array() parameters correctly

Browse source 
I had forgotten that the parameters are in reverse order, and even if I
had remembered, I forgot to reset offset before the second loop.
Pre-decrementing offset takes care of both issues at once.
This commit is contained in:
Bill Currie 2021-12-06 19:29:37 +09:00
parent a0c935e8bc
commit 3a742f59f7
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libs/video/renderer/vulkan/vkparse.c
View file

@ -800,6 +800,8 @@ static void
data_array (const exprval_t **params, exprval_t *result, exprctx_t *context)
{
size_t offset = 0;
// params are in reverse order, but this works for calculating the size
// of the buffer
for (const exprval_t **param = params; *param; param++) {
offset += (*param)->type->size;
}
@ -807,8 +809,9 @@ data_array (const exprval_t **params, exprval_t *result, exprctx_t *context)
cmemalloc, context->memsuper);
for (const exprval_t **param = params; *param; param++) {
size_t size = (*param)->type->size;
// pre-decrement offset because params are in reverse order
offset -= size;
memcpy (data->a + offset, (*param)->value, size);
offset += size;
}
*(data_array_t **) result->value = data;
}
@ -866,6 +869,10 @@ parse_specialization_data (const plitem_t *item, void **data,
} else {
*size_ptr = da->size;
*data_ptr = da->a;
//for (size_t i = 0; i < da->size; i++) {
// Sys_Printf (" %02x", da->a[i]);
//}
//Sys_Printf ("\n");
}
return ret;
}