qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-03-21 09:51:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Speed up two of the three deletion cases

Browse source 
The initial code was pretty much a port of the code in the editor I
wrote 25 years ago. Either I didn't think of the optimization back then,
or I tried to implement it, failed, and figured it wasn't worth it
(despite using it on a 386dx33). However, I noticed it now and it was
easy enough to get working, and it's always good to not do something
that's not needed.
This commit is contained in:
Bill Currie 2020-02-24 18:52:46 +09:00
parent f7493fe8fb
commit 3720956d88
1 changed files with 27 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
libs/util/txtbuffer.c
View file

@ -116,6 +116,32 @@ txtbuffer_open_gap (txtbuffer_t *buffer, size_t offset, size_t length)
return buffer->text + buffer->gapOffset;
}
static char *
txtbuffer_delete_text (txtbuffer_t *buffer, size_t offset, size_t length)
{
size_t len;
char *dst;
char *src;
if (offset > buffer->gapOffset) {
len = offset - buffer->gapOffset;
dst = buffer->text + buffer->gapOffset;
src = buffer->text + buffer->gapOffset + buffer->gapSize;
memmove (dst, src, len);
} else if (offset + length < buffer->gapOffset) {
len = buffer->gapOffset - (offset + length);
dst = buffer->text + buffer->gapSize + (offset + length);
src = buffer->text + (offset + length);
memmove (dst, src, len);
}
// don't need to do any copying when offset <= gapOffset &&
// offset + length >= offset
buffer->gapOffset = offset;
buffer->gapSize += length;
buffer->textSize -= length;
return buffer->text + buffer->gapOffset;
}
VISIBLE txtbuffer_t *
TextBuffer_Create (void)
{
@ -159,14 +185,10 @@ TextBuffer_DeleteAt (txtbuffer_t *buffer, size_t offset, size_t len)
if (offset > buffer->textSize) {
return 0;
}
// only moves, does not resize, the gap if necessary
txtbuffer_open_gap (buffer, offset, buffer->gapSize);
// clamp len to the amount of text beyond offset
if (len > buffer->textSize - offset) {
len = buffer->textSize - offset;
}
// delete the text
buffer->gapSize += len;
buffer->textSize -= len;
txtbuffer_delete_text (buffer, offset, len);
return 1;
}