qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-25 05:01:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Do type promotions for conditional expressions

Browse source 
Where possible of course, but the two results need to have the same
type. When not possible, an error is generated.
This commit is contained in:
Bill Currie 2025-01-20 10:17:01 +09:00
parent b1389ddb79
commit 332c991064
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tools/qfcc/source/expr_process.c
View file

@ -620,6 +620,17 @@ proc_cond (const expr_t *expr, rua_ctx_t *ctx)
if (is_error (false_expr)) { if (is_error (false_expr)) {
return false_expr; return false_expr;
} }
auto true_type = get_type (true_expr);
auto false_type = get_type (false_expr);
if (!type_same (true_type, false_type)) {
if (type_promotes (true_type, false_type)) {
false_expr = cast_expr (true_type, false_expr);
} else if (type_promotes (false_type, true_type)) {
true_expr = cast_expr (false_type, true_expr);
} else {
return error (expr, "incompatible types in conditional expression");
}
}
return new_cond_expr (test, true_expr, false_expr); return new_cond_expr (test, true_expr, false_expr);
} }