qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-29 23:52:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reduce the locking in the portal completion code.

Browse source 
It doesn't seem to make much difference, but the less room for contention,
the better.
This commit is contained in:
Bill Currie 2013-03-18 13:45:19 +09:00
parent ffb6d628bd
commit 134381f79b
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tools/qfvis/source/qfvis.c
View file

@ -292,6 +292,7 @@ UpdateMightsee (cluster_t *source, cluster_t *dest)
int i, clusternum; int i, clusternum;
portal_t *portal; portal_t *portal;
LOCK;
clusternum = dest - clusters; clusternum = dest - clusters;
for (i = 0; i < source->numportals; i++) { for (i = 0; i < source->numportals; i++) {
portal = source->portals[i]; portal = source->portals[i];
@ -303,6 +304,7 @@ UpdateMightsee (cluster_t *source, cluster_t *dest)
stats.mightseeupdate++; stats.mightseeupdate++;
} }
} }
UNLOCK;
} }
static void static void
@ -329,9 +331,10 @@ PortalCompleted (threaddata_t *thread, portal_t *completed)
stats.mighttest += thread->stats.mighttest; stats.mighttest += thread->stats.mighttest;
stats.vistest += thread->stats.vistest; stats.vistest += thread->stats.vistest;
stats.mightseeupdate += thread->stats.mightseeupdate; stats.mightseeupdate += thread->stats.mightseeupdate;
UNLOCK;
memset (&thread->stats, 0, sizeof (thread->stats)); memset (&thread->stats, 0, sizeof (thread->stats));
changed = set_new_size (portalclusters); changed = set_new_size_r (&thread->set_pool, portalclusters);
cluster = &clusters[completed->cluster]; cluster = &clusters[completed->cluster];
for (i = 0; i < cluster->numportals; i++) { for (i = 0; i < cluster->numportals; i++) {
portal = cluster->portals[i]; portal = cluster->portals[i];
@ -347,12 +350,12 @@ PortalCompleted (threaddata_t *thread, portal_t *completed)
else else
set_difference (changed, cluster->portals[j]->mightsee); set_difference (changed, cluster->portals[j]->mightsee);
} }
for (ci = set_first (changed); ci; ci = set_next (ci)) { for (ci = set_first_r (&thread->set_pool, changed); ci;
ci = set_next_r (&thread->set_pool, ci)) {
UpdateMightsee (&clusters[ci->element], cluster); UpdateMightsee (&clusters[ci->element], cluster);
} }
} }
set_delete (changed); set_delete_r (&thread->set_pool, changed);
UNLOCK;
} }
static void * static void *