From 05f6ddbb13f424fd8e54e6d835d3c7736945d859 Mon Sep 17 00:00:00 2001 From: Bill Currie Date: Sun, 23 Feb 2020 23:10:56 +0900 Subject: [PATCH] Print promoted warnings as errors This makes it much easier to see why a compilation failed when only warnings are visible. --- tools/qfcc/source/diagnostic.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/qfcc/source/diagnostic.c b/tools/qfcc/source/diagnostic.c index d38c1eecb..5ba576212 100644 --- a/tools/qfcc/source/diagnostic.c +++ b/tools/qfcc/source/diagnostic.c @@ -99,16 +99,21 @@ static __attribute__((format(printf, 4, 0))) void __warning (expr_t *e, const char *file, int line, const char *fmt, va_list args) { + static int promoted = 0; dstring_t *message = dstring_new (); report_function (e); if (options.warnings.promote) { - options.warnings.promote = 0; // want to do this only once - fprintf (stderr, "%s: warnings treated as errors\n", "qfcc"); + if (!promoted) { + promoted = 1; // want to do this only once + fprintf (stderr, "%s: warnings treated as errors\n", "qfcc"); + } pr.error_count++; + format_message (message, "error", e, fmt, args); + } else { + format_message (message, "warning", e, fmt, args); } - format_message (message, "warning", e, fmt, args); if (options.verbosity > 1) { dasprintf (message, " (%s:%d)", file, line); }