Ugh, when a player changes a userinfo string, please don't send the update to all connected players n times, but just 1 time. 'Fixes' the 'crashes' on busy servers, but the real problem is still there: Too much client input can clog up the server, effectively causing a DoS.

git-svn-id: https://svn.code.sf.net/p/fteqw/code/trunk@3103 fc73d0e0-1445-4013-8a0c-d673dee63da5
This commit is contained in:
Mark Olsen 2009-01-22 04:08:45 +00:00
parent 8b658df029
commit 3e6d9af3d4

View file

@ -3034,10 +3034,10 @@ void SV_SetInfo_f (void)
{
if (basic || (client->fteprotocolextensions & PEXT_BIGUSERINFOS))
{
MSG_WriteByte (&sv.reliable_datagram, svc_setinfo);
MSG_WriteByte (&sv.reliable_datagram, i);
MSG_WriteString (&sv.reliable_datagram, key);
MSG_WriteString (&sv.reliable_datagram, val);
ClientReliableWrite_Begin(client, svc_setinfo, 1+1+strlen(key)+1+strlen(val)+1);
ClientReliableWrite_Char(client, i);
ClientReliableWrite_String(client, key);
ClientReliableWrite_String(client, val);
}
}
}