ioquake/ioq3
0
0
Fork 0
mirror of https://github.com/ioquake/ioq3.git synced 2024-11-10 07:11:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't let VMs change engine latch cvars immediately

Browse source 
If a VM increases sv_maxclients while a server is running the engine
will crash. The value should be latched until engine decides to update
the cvar; the same as when a user sets it.
This commit is contained in:
Zack Middleton 2018-01-21 03:50:43 -06:00
parent adef4e6c9e
commit 78ca670d4f
1 changed files with 20 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
code/qcommon/cvar.c
View file

@ -638,18 +638,29 @@ Cvar_SetSafe
void Cvar_SetSafe( const char *var_name, const char *value )
{
int flags = Cvar_Flags( var_name );
qboolean force = qtrue;
if((flags != CVAR_NONEXISTENT) && (flags & CVAR_PROTECTED))
if ( flags != CVAR_NONEXISTENT )
{
if( value )
Com_Error( ERR_DROP, "Restricted source tried to set "
"\"%s\" to \"%s\"", var_name, value );
else
Com_Error( ERR_DROP, "Restricted source tried to "
"modify \"%s\"", var_name );
return;
if ( flags & CVAR_PROTECTED )
{
if( value )
Com_Error( ERR_DROP, "Restricted source tried to set "
"\"%s\" to \"%s\"", var_name, value );
else
Com_Error( ERR_DROP, "Restricted source tried to "
"modify \"%s\"", var_name );
return;
}
// don't let VMs or server change engine latched cvars instantly
if ( ( flags & CVAR_LATCH ) && !( flags & CVAR_VM_CREATED ) )
{
force = qfalse;
}
}
Cvar_Set( var_name, value );
Cvar_Set2 (var_name, value, force);
}
/*