From 780f0a5d3ef4a24147de819f7fa5cf18d494f86a Mon Sep 17 00:00:00 2001 From: Zack Middleton Date: Wed, 15 Jun 2016 13:26:08 -0500 Subject: [PATCH] Prevent CL_RunCinematic from reading cinTable[-1] At the end of CL_RunCinematic, RoQShutdown sets currentHandle to -1. This causes the return at the end to be return cinTable[-1].status. Use return FMV_EOF when RoQShutdown is called. I think FMV_EOF should be returned instead of FMV_IDLE which is set in RoQShutdown because RoQShutdown is clearing out state so it can be reused for a new cinematic. The return value isn't actually read by the ioq3 client, renderers, cgame, or ui. --- code/client/cl_cin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/code/client/cl_cin.c b/code/client/cl_cin.c index be4fb1bc..327e5c37 100644 --- a/code/client/cl_cin.c +++ b/code/client/cl_cin.c @@ -1384,6 +1384,7 @@ e_status CIN_RunCinematic (int handle) RoQReset(); } else { RoQShutdown(); + return FMV_EOF; } }