* Fix to buffer overflow in lightmap loading code from misanthropia

This commit is contained in:
Tim Angus 2005-10-20 16:14:05 +00:00
parent 653c5621ac
commit 769372e2f9
1 changed files with 4 additions and 1 deletions

View File

@ -140,7 +140,7 @@ static void R_LoadLightmaps( lump_t *l ) {
float maxIntensity = 0; float maxIntensity = 0;
double sumIntensity = 0; double sumIntensity = 0;
len = l->filelen; len = l->filelen;
if ( !len ) { if ( !len ) {
return; return;
} }
@ -155,6 +155,9 @@ static void R_LoadLightmaps( lump_t *l ) {
//FIXME: HACK: maps with only one lightmap turn up fullbright for some reason. //FIXME: HACK: maps with only one lightmap turn up fullbright for some reason.
//this avoids this, but isn't the correct solution. //this avoids this, but isn't the correct solution.
tr.numLightmaps++; tr.numLightmaps++;
} else if ( tr.numLightmaps >= MAX_LIGHTMAPS ) { // 20051020 misantropia
ri.Printf( PRINT_WARNING, "WARNING: number of lightmaps > MAX_LIGHTMAPS\n" );
tr.numLightmaps = MAX_LIGHTMAPS;
} }
// if we are in r_vertexLight mode, we don't need the lightmaps at all // if we are in r_vertexLight mode, we don't need the lightmaps at all