Ricardo Barreira
5e308f9056
Fix undefined behavior in FreeStackWinding
...
Fix subtraction of unrelated pointers and integer overflow in FreeStackWinding (both are undefined behavior).
In rare cases "i" would non-deterministically be between 0 and 2 even though the
pointers were in unrelated addresses, which caused a spurious free of one of
the three windings - eventually the real free would happen, be detected as a
double free and an exit(1) would ensue.
Example contents of w and stack->windings that triggered this in a test: 0xa9251c0 0x7f440a924f78
Checking for pointer equality makes the behavior defined and correct: http://port70.net/~nsz/c/c99/n1256.html#6.5.9
2017-10-31 13:05:32 +00:00
Thomas Debesse
b1c4fb1304
make “hide empty directories” an option
2017-09-03 20:16:53 +02:00
Thomas Debesse
e9e095b4c6
empty shader dir checking: some useful comments
2017-09-02 05:09:18 +02:00
Thomas Debesse
a9583eb1e6
also check against shader script file name when looking for non-empty shader dir
...
Greeting Pan
2017-09-02 04:42:39 +02:00
Thomas Debesse
8051dd88ca
avoid to misread an unbracketed for loop
2017-09-02 04:38:00 +02:00
Thomas Debesse
bdecace973
add more well known preview/gloss/normal suffixes
2017-09-02 04:38:00 +02:00
Thomas Debesse
c832a55910
avoid “unused” warning because usage is in debug code only
2017-09-02 04:38:00 +02:00
Thomas Debesse
e179e2b4a4
more strict shader dir checking
2017-09-02 04:38:00 +02:00
Thomas Debesse
67647ac470
do not list empty texture dir
2017-09-02 04:38:00 +02:00
Thomas Debesse
a9e54ea54f
move texture name validation outside of texture listing
2017-09-02 04:38:00 +02:00
Thomas Debesse
39ec17cfd9
move texture listing outside of texture showing
2017-09-02 04:38:00 +02:00
Thomas Debesse
41ed9c2ce5
do not list empty shader dir
2017-09-02 04:37:58 +02:00
Thomas Debesse
4c4ba27094
scons: use system compiler instead of gcc on FreeBSD
2017-08-31 00:45:30 +02:00
Thomas Debesse
8535f26206
scons: add CheckUnresolved stub for FreeBSD
2017-08-31 00:45:30 +02:00
Thomas Debesse
1e71b1fc39
scons: do not require libdl on FreeBSD since it's provided by libc
2017-08-31 00:45:30 +02:00
Thomas Debesse
38b0faf0da
preproc: more unknown architecture error
2017-08-31 00:45:30 +02:00
Thomas Debesse
417032e526
bikeshedding: move some misplaced comment
2017-08-31 00:45:30 +02:00
Thomas Debesse
413564daa3
preproc: add some FreeBSD defines (path sep etc.)
2017-08-31 00:45:29 +02:00
Thomas Debesse
9d7cc6cd17
preproc: FreeBSD game names are like Linux ones
2017-08-31 00:45:29 +02:00
Thomas Debesse
9f595b664b
preproc: FreeBSD also provides pthread
2017-08-31 00:45:24 +02:00
Thomas Debesse
8d176b75c8
gcc8: static_cast NULL instead of reinterpret_cast
2017-08-30 18:16:07 +02:00
Thomas Debesse
3e859fb81e
preproc: FreeBSD also has LibGL.so
2017-08-30 14:20:01 +00:00
Thomas Debesse
a3773852a4
preproc: add a FreeBSD condition everytime there is Linux or MacOS
2017-08-30 14:20:01 +00:00
Pan7
69972f9458
Merge branch 'master' of https://github.com/TTimo/GtkRadiant into fixTexCrash
2017-08-27 17:58:14 +02:00
Pan7
8896c609ed
Fix a crash when enabling Texture Directory List
2017-08-27 17:57:19 +02:00
Pan7
c968f9c87a
Explicit type instead auto
2017-08-26 01:39:24 +02:00
Jay Dolan
4dbf7727c6
Fix bug (regression?) in Apple Makefile that left .svn turds around, and also broke subsequent scons invocations.
2017-08-22 08:22:45 -04:00
Jay Dolan
98c4cba5da
Merge branch 'master' of https://github.com/TTimo/GtkRadiant
2017-08-22 07:57:14 -04:00
Timothee Besset
62d0a93fda
#162 bobtoolz brush cleanup wasn't loading patches, so it was dropping them from rebuilding func_group entities after fixing bad brushes in them
2017-08-20 16:57:09 -05:00
Timothee Besset
8ea7e52fa0
if CSG substracting with a (set of) brush(es) that are all caulk, new splits will be caulk
2017-08-20 16:38:02 -05:00
Timothee Besset
732497b098
make hollow uses caulk, based on a pref setting
2017-08-20 16:24:56 -05:00
Timothee Besset
3a6c9d30ed
fix compile warning
2017-08-20 15:46:40 -05:00
Timothee Besset
156fc19c13
fix warning
2017-08-20 15:04:49 -05:00
Pan7
93f88ca829
Merge pull request #560 from Pan7/fixTexAbs
...
Fix warning using floating point absolute value function fabs
2017-08-20 00:16:44 +02:00
Pan7
5f7efeecc8
Fix warning using floating point absolute value function fabs
2017-08-20 00:11:53 +02:00
Pan7
366fa91888
Merge pull request #559 from Pan7/fixq3data7
...
Q3data: Fix warning format %d expects argument of type int
2017-08-19 03:25:18 +02:00
Pan7
b2c2c8d378
Q3data: Fix warning format %d expects argument of type int
2017-08-19 03:21:29 +02:00
Pan7
e594c90a60
Merge pull request #558 from Pan7/fixq3data6
...
Q3data: Fix warning passing unsigned short * to parameter of type sho…
2017-08-18 20:05:09 +02:00
Pan7
d1c1de1253
Q3data: Fix warning passing unsigned short * to parameter of type short *
2017-08-18 20:00:41 +02:00
Pan7
16d42f3e64
Merge pull request #551 from Pan7/fixq3data2
...
Q3data: Fix warning variable shortestSide is used uninitialized
2017-08-18 12:08:02 +02:00
Pan7
91f2e55b1a
Merge pull request #553 from Pan7/fixq3data4
...
Q3data: Fix warning variable psets is used uninitialized
2017-08-18 12:07:31 +02:00
Pan7
93ec80ed9a
Merge pull request #554 from Pan7/fixq3data5
...
Q3data: Fix warning incompatible pointer types passing
2017-08-18 12:07:06 +02:00
Pan7
e40228629e
Merge pull request #552 from Pan7/fixq3data3
...
Q3data: Fix warning format specifies type int but the argument has ty…
2017-08-18 12:06:12 +02:00
Pan7
ff878eaee2
Merge pull request #557 from Pan7/fixCommon
...
Fix warning variable bcHeight is used uninitialized
2017-08-18 12:05:26 +02:00
Pan7
a9e28b5507
Fix warning variable bcHeight is used uninitialized
2017-08-18 02:18:31 +02:00
Pan7
af45a9d65c
Q3data: Fix warning incompatible pointer types passing
2017-08-16 16:29:45 +02:00
Pan7
465cb3ce3f
Q3data: Fix warning variable psets is used uninitialized
2017-08-15 22:21:05 +02:00
Pan7
614f97d425
Q3data: Fix warning format specifies type int but the argument has type long
2017-08-15 22:04:30 +02:00
Pan7
fc7e215e80
Q3data: Fix warning variable shortestSide is used uninitialized
2017-08-15 22:02:16 +02:00
Timothee "TTimo" Besset
1439c10043
Merge pull request #549 from Pan7/fixSenWarn3
...
Fix warning missing sentinel in function call 3
2017-08-13 14:05:33 -05:00
