Commit graph

85 commits

Author SHA1 Message Date
Ricardo Barreira
5e308f9056
Fix undefined behavior in FreeStackWinding
Fix subtraction of unrelated pointers and integer overflow in FreeStackWinding (both are undefined behavior).

In rare cases "i" would non-deterministically be between 0 and 2 even though the
pointers were in unrelated addresses, which caused a spurious free of one of
the three windings - eventually the real free would happen, be detected as a
double free and an exit(1) would ensue.

Example contents of w and stack->windings that triggered this in a test: 0xa9251c0 0x7f440a924f78

Checking for pointer equality makes the behavior defined and correct: http://port70.net/~nsz/c/c99/n1256.html#6.5.9
2017-10-31 13:05:32 +00:00
Timothee Besset
3a6c9d30ed fix compile warning 2017-08-20 15:46:40 -05:00
Timothee "TTimo" Besset
578fd09625 Merge pull request #526 from Pan7/fixAddWarn
Fix warning variable add is used uninitialized
2017-07-11 10:35:16 +02:00
Pan7
714cc90ce7 Fix warning variable add is used uninitialized 2017-07-10 15:30:04 +02:00
Pan7
a8925cbedb Fix xml passing to parameter warnings 2017-07-10 01:04:28 +02:00
Pan7
cc8cbd8a72 Fix uninitialized use of ext warning 2017-04-27 18:12:09 +02:00
Matthias Krüger
1498ce667d q3map2: don't store lightmap if the last bounce computation ran empty. 2017-03-13 10:58:35 +01:00
TTimo
a26c818a1e remove the old .vcproj 2017-01-01 09:08:37 -06:00
Rudolf Polzer
1342e8ae5f fix two obvious typos 2016-10-14 02:10:02 +02:00
TTimo
8557f1820f more cleanups 2016-08-20 17:50:23 -06:00
TTimo
de8105beb4 readability 2016-08-20 16:06:09 -06:00
Timothee "TTimo" Besset
28e9b8ec59 Merge pull request #364 from tkoeppe/memsize
[tools/quake3/q3map2] Fix memset size bugs
2016-08-20 16:03:57 -06:00
Timothee "TTimo" Besset
cee35a43d7 Merge pull request #367 from tkoeppe/nan
[tools/quake3/q3map2/light{,maps}_ydnar.c] Fix float-to-int conversion
2016-08-20 15:56:26 -06:00
Thomas Köppe
7ea2c399ad [tools/quake3/q3map2] Fix memset size bugs 2016-08-16 23:41:29 +01:00
Thomas Köppe
87002dc31a [quake3/q3map2/brush.c] Fix misnamed variable 2016-08-16 22:50:14 +01:00
Thomas Köppe
f463907e46 [tools/quake3/q3map2/light{,maps}_ydnar.c] Fix float-to-int conversion by preventing NaN values 2016-08-14 12:16:13 +01:00
Thomas Köppe
d18d90278e [quake3/q3map2/brush.c] Fix arithmetic bug 2016-08-14 01:14:17 +01:00
Timothee "TTimo" Besset
c918a29cd0 Merge pull request #352 from Pan7/Sys_FPrintf
Using Sys_FPrintf with SYS_WRN and SYS_ERR
2016-06-11 13:01:13 -05:00
Pan7
5105fc5db8 Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
Timothee Besset
cc68a76900 phrasing.. 2016-04-24 15:05:09 -05:00
Timothee Besset
a88ef20680 fix short alloc and heap corruption for winding_accu_t and brush_t - brought about by https://github.com/TTimo/bspc/pull/4 2016-04-24 15:02:50 -05:00
Timothee Besset
b36b3ba4b6 Visual Studio 2015 on debug configs too 2016-04-24 14:52:52 -05:00
Thomas Debesse
d58490f20b split fixaas stuff from q3map2 2016-02-13 04:54:26 +01:00
Thomas Debesse
cd07f71691 split bsp analyze/info/scale stuff from q3map2 2016-02-13 04:54:26 +01:00
Thomas Debesse
cd5ff8d96c split bsp conversion stuff from q3map2 2016-02-12 20:02:35 +01:00
Timothee "TTimo" Besset
8428b75fcb Merge pull request #273 from QBall147/master
Increase MAX_MAP_VISIBILITY as certain QuakeLive maps are starting to hi...
2016-01-10 11:31:47 -06:00
Timothee Besset
4e08b4bd49 compile x64 q3map2 against new libxml2 x64 lib folder 2015-12-24 22:31:49 -06:00
Timothee Besset
5ed4d02c78 more Visual Studio 2015 conversion 2015-12-24 19:21:23 -06:00
TTimo
48369d78f9 - Convert to Visual Studio 2015
- Drop STLPort
- Rebuild libxml2 binaries, update project files accordingly
- Rebuild jpeg-9 binaries
2015-11-07 23:44:49 -06:00
QBall147
17349a28db Increase MAX_MAP_VISIBILITY as certain QuakeLive maps are starting to hit the limit 2014-08-14 19:05:13 +01:00
Alex Lo
76ea7385dd Fixed a number of out of bounds accesses.
Visual Studio's static code analyser found a number of out of bounds array
accesses. This commit fixes a number of them as well as a few other problems
the analyser brought up.

This also fixes #1 in the issue tracker.
2013-11-01 00:24:58 +00:00
TTimo
666847b0ce switch to xp compatible compiler toolchain, add/fix an archive and upload script for the VM builder 2013-08-24 22:50:12 +00:00
Chris Brooke
3e5bc317d0 Added -exportents to q3map2. 2013-07-15 04:58:15 +01:00
Timothee Besset
0241ec6d9b put q3map2.exe x64 in install/x64, and copy the dependent DLLs 2013-06-07 05:13:20 +01:00
Timothee Besset
7c1f101a29 spitting x64 q3map2 now 2013-06-02 00:56:33 +01:00
Timothee Besset
f397e4a8d6 link libxml2 2013-06-01 23:39:34 +01:00
Timothee Besset
9f425c0c72 add include path for gdk-pixbuf 2013-06-01 23:26:37 +01:00
Timothee Besset
1ec0ec94ba switching to newer gtk and libxml. wip 2013-06-01 23:05:35 +01:00
Timothee "TTimo" Besset
ca29808460 missed those - q3map2 x64 2013-05-30 03:22:29 -05:00
Timothee "TTimo" Besset
2ca658fe9f convert projects to msvc 2012 2013-05-23 20:44:41 -05:00
Timothee 'TTimo' Besset
2bd4ea84f0 better QL Linux homepath config 2012-08-29 21:43:19 -05:00
Timothee 'TTimo' Besset
c692d7b5c5 point to the right QL homepath 2012-08-29 20:49:09 -05:00
Chris Brooke
2101cf6ae7 QuakeLive PK3 support for Q3Map2 2012-07-27 17:46:54 +01:00
Chris Brooke
26d3246edf Additional Surface parameters for Quake Live -
snowsteps
woodsteps

The below params have been added but have not been implemented yet in ql
(been told it probably will be re-purposed at a later date)

dmgthrough <-- Missile dmg through surface(?)
2012-07-02 05:54:59 +01:00
Timothee 'TTimo' Besset
b19c4bc879 this was built on top of 1.5, so it never got properly transformed to a GPL license. took care of that now 2012-05-28 18:29:36 -05:00
Timothee 'TTimo' Besset
b36ee55e96 cleanup 2012-05-27 18:53:14 -05:00
Timothee 'TTimo' Besset
6476802ae8 dunno what happened there, someone brain farted hard 2012-05-06 15:55:10 -05:00
alex8664
67411cb18e This is fix for failure of compilation on new libpng 2012-03-31 17:31:50 +04:00
Ben Noordhuis
3a959349ac q3map2: harden UNIX path sniffer against buffer overflows 2012-03-18 02:17:09 +01:00
Ben Noordhuis
808e1c9f6f q3map2: fix dangling pointer dereference
`last` was used but not initialized.

Also fixes a segmentation fault if PATH is not in the environment.
2012-03-18 02:17:09 +01:00