Ricardo Barreira
5e308f9056
Fix undefined behavior in FreeStackWinding
...
Fix subtraction of unrelated pointers and integer overflow in FreeStackWinding (both are undefined behavior).
In rare cases "i" would non-deterministically be between 0 and 2 even though the
pointers were in unrelated addresses, which caused a spurious free of one of
the three windings - eventually the real free would happen, be detected as a
double free and an exit(1) would ensue.
Example contents of w and stack->windings that triggered this in a test: 0xa9251c0 0x7f440a924f78
Checking for pointer equality makes the behavior defined and correct: http://port70.net/~nsz/c/c99/n1256.html#6.5.9
2017-10-31 13:05:32 +00:00
Pan7
69972f9458
Merge branch 'master' of https://github.com/TTimo/GtkRadiant into fixTexCrash
2017-08-27 17:58:14 +02:00
Pan7
8896c609ed
Fix a crash when enabling Texture Directory List
2017-08-27 17:57:19 +02:00
Pan7
c968f9c87a
Explicit type instead auto
2017-08-26 01:39:24 +02:00
Jay Dolan
4dbf7727c6
Fix bug (regression?) in Apple Makefile that left .svn turds around, and also broke subsequent scons invocations.
2017-08-22 08:22:45 -04:00
Jay Dolan
98c4cba5da
Merge branch 'master' of https://github.com/TTimo/GtkRadiant
2017-08-22 07:57:14 -04:00
Timothee Besset
62d0a93fda
#162 bobtoolz brush cleanup wasn't loading patches, so it was dropping them from rebuilding func_group entities after fixing bad brushes in them
2017-08-20 16:57:09 -05:00
Timothee Besset
8ea7e52fa0
if CSG substracting with a (set of) brush(es) that are all caulk, new splits will be caulk
2017-08-20 16:38:02 -05:00
Timothee Besset
732497b098
make hollow uses caulk, based on a pref setting
2017-08-20 16:24:56 -05:00
Timothee Besset
3a6c9d30ed
fix compile warning
2017-08-20 15:46:40 -05:00
Timothee Besset
156fc19c13
fix warning
2017-08-20 15:04:49 -05:00
Pan7
93f88ca829
Merge pull request #560 from Pan7/fixTexAbs
...
Fix warning using floating point absolute value function fabs
2017-08-20 00:16:44 +02:00
Pan7
5f7efeecc8
Fix warning using floating point absolute value function fabs
2017-08-20 00:11:53 +02:00
Pan7
366fa91888
Merge pull request #559 from Pan7/fixq3data7
...
Q3data: Fix warning format %d expects argument of type int
2017-08-19 03:25:18 +02:00
Pan7
b2c2c8d378
Q3data: Fix warning format %d expects argument of type int
2017-08-19 03:21:29 +02:00
Pan7
e594c90a60
Merge pull request #558 from Pan7/fixq3data6
...
Q3data: Fix warning passing unsigned short * to parameter of type sho…
2017-08-18 20:05:09 +02:00
Pan7
d1c1de1253
Q3data: Fix warning passing unsigned short * to parameter of type short *
2017-08-18 20:00:41 +02:00
Pan7
16d42f3e64
Merge pull request #551 from Pan7/fixq3data2
...
Q3data: Fix warning variable shortestSide is used uninitialized
2017-08-18 12:08:02 +02:00
Pan7
91f2e55b1a
Merge pull request #553 from Pan7/fixq3data4
...
Q3data: Fix warning variable psets is used uninitialized
2017-08-18 12:07:31 +02:00
Pan7
93ec80ed9a
Merge pull request #554 from Pan7/fixq3data5
...
Q3data: Fix warning incompatible pointer types passing
2017-08-18 12:07:06 +02:00
Pan7
e40228629e
Merge pull request #552 from Pan7/fixq3data3
...
Q3data: Fix warning format specifies type int but the argument has ty…
2017-08-18 12:06:12 +02:00
Pan7
ff878eaee2
Merge pull request #557 from Pan7/fixCommon
...
Fix warning variable bcHeight is used uninitialized
2017-08-18 12:05:26 +02:00
Pan7
a9e28b5507
Fix warning variable bcHeight is used uninitialized
2017-08-18 02:18:31 +02:00
Pan7
af45a9d65c
Q3data: Fix warning incompatible pointer types passing
2017-08-16 16:29:45 +02:00
Pan7
465cb3ce3f
Q3data: Fix warning variable psets is used uninitialized
2017-08-15 22:21:05 +02:00
Pan7
614f97d425
Q3data: Fix warning format specifies type int but the argument has type long
2017-08-15 22:04:30 +02:00
Pan7
fc7e215e80
Q3data: Fix warning variable shortestSide is used uninitialized
2017-08-15 22:02:16 +02:00
Timothee "TTimo" Besset
1439c10043
Merge pull request #549 from Pan7/fixSenWarn3
...
Fix warning missing sentinel in function call 3
2017-08-13 14:05:33 -05:00
Pan7
816bfc0081
Fix warning missing sentinel in function call 3
2017-08-13 20:46:34 +02:00
Jay Dolan
8819c711cc
Give Q2 CTF it's proper name.
2017-08-13 14:17:58 -04:00
Timothee "TTimo" Besset
604563f2c3
Merge pull request #548 from Pan7/scaledigit
...
Allow 6 default texture scale digits
2017-08-13 11:10:07 -05:00
Timothee "TTimo" Besset
f33c27d596
Merge pull request #546 from Pan7/fixLightDlg
...
Fix Light Intensity Dialog when using accelerator
2017-08-13 11:09:48 -05:00
Timothee "TTimo" Besset
eda71c8de5
Merge pull request #545 from Pan7/fixEdTexFocus
...
Fix focusing of texture selecting
2017-08-13 11:09:30 -05:00
Pan7
5e4b1607f7
Allow 6 default texture scale digits
2017-08-13 14:04:57 +02:00
Pan7
7d96eec99a
Fix Light Intensity Dialog when using accelerator
2017-08-13 03:12:28 +02:00
Pan7
c49d2f5ef1
Fix focusing of texture selecting
2017-08-13 02:42:48 +02:00
Timothee "TTimo" Besset
0ce9827961
Merge pull request #543 from Pan7/fixEdTexLoad
...
Fix/Add missing loading of fixed texture size settings
2017-08-12 19:01:43 -05:00
Pan7
0a83bde73e
Fix/Add missing loading of fixed texture size settings
2017-08-13 00:52:15 +02:00
Timothee "TTimo" Besset
da71e11fc8
Merge pull request #541 from Pan7/fixSurf540
...
Fix Surface Inspector texture name
2017-08-12 10:36:14 -05:00
Timothee "TTimo" Besset
6d6ad7cc65
Merge pull request #539 from Pan7/fixStrdown
...
Fix g_ascii_strdown usage
2017-08-12 10:35:39 -05:00
Pan7
902e311149
Fix Surface Inspector texture name
2017-08-10 21:42:09 +02:00
Pan7
7a936d6832
Fix g_ascii_strdown usage
2017-08-08 01:24:41 +02:00
TTimo
db467908ad
Re-enable intel HD GL workaround, still needed .. see issue #512
2017-08-05 15:50:28 -05:00
Timothee "TTimo" Besset
222adc1c87
Merge pull request #530 from Pan7/fixedTex
...
Fixed textures for the texture browser
2017-08-05 15:12:16 -05:00
Timothee "TTimo" Besset
ef68d9d7ad
Merge pull request #521 from Pan7/multifocus
...
Adjusting Focus 2d View for multiselect
2017-08-05 15:05:45 -05:00
Timothee "TTimo" Besset
4d2404df86
Merge pull request #529 from Pan7/fixStrdownWarn
...
Fix warning g_strdown is deprecated
2017-08-05 11:34:51 -05:00
Timothee "TTimo" Besset
1c62ceb060
Merge pull request #528 from Pan7/fixImpWarn
...
Fix warning implicit declaration of function
2017-08-05 11:34:20 -05:00
Timothee "TTimo" Besset
da829ed928
Merge pull request #520 from Pan7/fixPCrash
...
Fix crash with too many patch planes
2017-08-05 11:28:09 -05:00
Pan7
2d23567675
Fixed textures for the texture browser
2017-07-22 06:11:47 +02:00
Pan7
6acfd910ae
Fix warning g_strdown is deprecated
2017-07-11 23:08:05 +02:00