Commit graph

799 commits

Author SHA1 Message Date
Alex Lo
fcefc8b9de Fix crash when deleting a misc_model
The following sequence of events and conditions will cause a segfault to
occur:

1. Delete a misc_model
2. Undo the delete
3. Delete the same model again
4. Undo the delete

A segfault will occur in CEntityMiscModel::Draw when m_model is
dereferenced as it has been deleted and cleared.

When cloning the misc_model entity, a new CEntityMiscModel is created and
the name is set. However, CEntityMiscModel::BuildCacheRequestString relies
on all epairs to be present before being able to generate the *correct*
request string for the misc_model. Not doing so will cause incorrect
behaviour - in this case, the reference count for the CEntityMiscModel is
decremented one too many times and causes the object to be deleted. The
misc_model object is then used later on after it has been freed.

This commit fixes the problem by copying all epairs, before firing the
OnKeyValueChanged events. This way, all epairs will be available when
BuildCacheRequestString is called.
2015-07-21 00:08:31 +01:00
Timothee "TTimo" Besset
d9d76af697 Merge pull request #290 from ericwa/quake1
Quake 1 Support
2015-05-29 08:03:53 -05:00
Eric Wasylishen
01f7a979ae vfswad: lowercase the wad name at load time, because queries from map/parse.cpp come in as lowercase 2015-05-26 21:23:29 -06:00
Eric Wasylishen
12bc0b1633 Add basic quake1 support to preferences.{h,cpp} 2015-05-26 21:23:29 -06:00
Timothee "TTimo" Besset
0f75c22b0d Merge pull request #287 from jdolan/master
Use g_get_user_special_dir rather than hard-coded "My Documents"
2015-03-18 11:59:15 -05:00
Jay Dolan
e750bb0972 Merge remote-tracking branch 'upstream/master' 2015-03-18 11:01:59 -04:00
Jay Dolan
c626a12e7a Use glib's g_get_user_special_dir to resolve 'Documents'. This works on XP (My Documents) and Vista+ (Documents). 2015-03-18 11:00:57 -04:00
Timothee "TTimo" Besset
7d4b7ad362 Merge pull request #286 from jdolan/master
Fix "My Games" folder on Wintoons.
2015-03-08 10:40:54 -05:00
Jay Dolan
3446bf9b27 Merge branch 'master' of https://github.com/TTimo/GtkRadiant 2015-03-08 11:32:56 -04:00
Jay Dolan
7cd4aa4fe0 Use \My Documents\My Games\ on Windows. This aligns us with NetRadiant and the actual location of this folder on Windows systems. It was an error to use /Users/jdolan\My Games. That's not a thing. 2015-03-08 11:31:53 -04:00
Timothee "TTimo" Besset
b648ceddbc Merge pull request #263 from neumond/defflag
entity.def: parser fix
2015-03-08 10:24:17 -05:00
Timothee "TTimo" Besset
f555e3d13e Merge pull request #261 from neumond/imzoom
Improved mousewheel zoom-in
2015-03-08 10:23:43 -05:00
Timothee "TTimo" Besset
3f58715a04 Merge pull request #241 from xycaleth/master
Fixed a number of out of bounds accesses.
2015-03-08 10:22:26 -05:00
Timothee "TTimo" Besset
3d3418e77f Merge pull request #280 from bigjilm/master
Option to color detail brushes in 2d views
2015-03-08 10:20:54 -05:00
Timothee "TTimo" Besset
c285bb6119 Merge pull request #284 from jdolan/master
Skip Quake4 per-pixel lighting assets in texture window
2015-03-08 10:19:31 -05:00
Jay Dolan
6a5412d95c Updates for Quake2World -> Quetoo project renaming. 2015-03-08 09:55:36 -04:00
Jay Dolan
bca10b6337 Eclipse project file updates. 2015-02-10 10:08:15 -05:00
Jay Dolan
636b1010b3 Suppress a warning. 2015-02-10 10:08:05 -05:00
Jay Dolan
2beef62683 Skip glow, heightmap, normalmap and specularmap files for Q4 texture sets. 2015-02-10 10:07:31 -05:00
Josh Steffen
805ceb9df6 brace alignment 2015-01-16 17:10:09 -05:00
Josh Steffen
c55e260114 only color detail brush if it's not part of an entity 2015-01-15 15:54:54 -05:00
Josh Steffen
a1fd52a8c2 Changed 'Detail brushes...' to 'Detail Brush...' for consistency 2015-01-15 11:08:46 -05:00
Josh Steffen
19bd95b0a2 Added option to change detail brush color in 2d view 2015-01-15 07:14:03 -05:00
neumond
6f6ee7f713 removed unused flag 2014-03-25 19:15:58 +04:00
neumond
27946b2e13 Zoom option in preferences 2014-03-24 07:46:49 +04:00
neumond
09c0da616c Improved mousewheel zoom-in 2014-03-24 06:57:46 +04:00
Jay Dolan
73b5b0dca7 Merge pull request #255 from ericwa/clang
Use clang on OS X instead of gcc48
2014-01-20 04:38:10 -08:00
Eric Wasylishen
adbace1da2 Use clang on OS X instead of gcc48
Also - add 'pkgconfig' to list of MacPorts to install, as it's a required dependency.
2014-01-19 22:25:08 -07:00
Timothee 'TTimo' Besset
5b1bb1ce7e asdf 2013-12-28 10:25:07 -06:00
Timothee 'TTimo' Besset
f3132c982b asdf 2013-12-28 10:24:29 -06:00
Timothee 'TTimo' Besset
64d8539105 rawwr 2013-12-28 10:23:45 -06:00
Timothee 'TTimo' Besset
00d0891ee4 also, markup and stuff 2013-12-28 10:20:07 -06:00
Timothee 'TTimo' Besset
46a144e7cd updated OSX instructions 2013-12-28 10:17:42 -06:00
Timothee "TTimo" Besset
d12e955133 wtf. better 2013-11-26 16:11:55 -06:00
Timothee Besset
4d6d4d8f6c fix surface dialog closing up when typing in the texture box 2013-11-26 20:45:15 +00:00
Timothee Besset
10bcc6548f older glib compat fix 2013-11-20 20:21:58 +00:00
Timothee "TTimo" Besset
26d8547ea0 Merge pull request #245 from jdolan/master
Stabilize BSP monitoring code
2013-11-19 19:53:47 -08:00
jdolan
43594358c1 Enable decimal precision for texture rotation in idTech2 surface dialog. 2013-11-19 21:30:28 -05:00
jdolan
8520a7c3ae Silly debug statement. 2013-11-19 21:23:36 -05:00
jdolan
a6934fb21b Fix umpteen fails in the BSP monitoring state management. Probably introduce 1 or 2 new ones. 2013-11-19 21:15:06 -05:00
Alex Lo
76ea7385dd Fixed a number of out of bounds accesses.
Visual Studio's static code analyser found a number of out of bounds array
accesses. This commit fixes a number of them as well as a few other problems
the analyser brought up.

This also fixes #1 in the issue tracker.
2013-11-01 00:24:58 +00:00
jdolan
58c425637e Merge branch 'master' of https://github.com/TTimo/GtkRadiant 2013-10-12 12:29:32 -04:00
jdolan
b4a4dc55be Whitespace cleanup. 2013-10-12 12:29:11 -04:00
Timothee "TTimo" Besset
9c75082063 Merge pull request #238 from jdolan/master
Restore quake2 game description flag as idTech2 flag, fix launching legacy games.
2013-10-05 12:26:47 -07:00
jdolan
084169f348 Re-introduce 'quake2' flag is 'idTech2' flag for properly launching legacy games. 2013-10-05 15:21:27 -04:00
jdolan
5101b5b0aa Setup engine, enginepath, executablespath and prefix more thoroughly for q2w.game. 2013-10-05 11:21:44 -04:00
jdolan
7c0ca95b7b Use executables path for launching engine. This is defaulted to engine path for most games, but adjusted for those which have their binaries in a different directory (e.g. Quake2World). 2013-10-05 11:20:49 -04:00
jdolan
7d092b3417 Cleanup to idTech2 surface inspector. 2013-10-05 11:20:01 -04:00
Timothee "TTimo" Besset
99e8d5c211 Remove some old quake2 support code that is not being used in this new implementation of q2/q2w support. Set the BSP monitoring pref to off since q2wmap does not support it atm. 2013-09-22 16:07:47 -05:00
Timothee "TTimo" Besset
69db7ec003 cleanup 2013-09-22 15:53:34 -05:00