Commit Graph

150 Commits

Author SHA1 Message Date
Timothee "TTimo" Besset 94849adc93
Merge pull request #534 from illwieckz/noradiosity
Proper working with noradiosity 1 lights
2018-01-07 13:06:03 -06:00
Timothee "TTimo" Besset fe4fbe25a8
Merge pull request #568 from rsfbarreira/patch-1
Fix undefined behavior in FreeStackWinding
2018-01-07 13:01:27 -06:00
Ricardo Barreira 5e308f9056
Fix undefined behavior in FreeStackWinding
Fix subtraction of unrelated pointers and integer overflow in FreeStackWinding (both are undefined behavior).

In rare cases "i" would non-deterministically be between 0 and 2 even though the
pointers were in unrelated addresses, which caused a spurious free of one of
the three windings - eventually the real free would happen, be detected as a
double free and an exit(1) would ensue.

Example contents of w and stack->windings that triggered this in a test: 0xa9251c0 0x7f440a924f78

Checking for pointer equality makes the behavior defined and correct: http://port70.net/~nsz/c/c99/n1256.html#6.5.9
2017-10-31 13:05:32 +00:00
Thomas Debesse 9f595b664b preproc: FreeBSD also provides pthread 2017-08-31 00:45:24 +02:00
Thomas Debesse a3773852a4 preproc: add a FreeBSD condition everytime there is Linux or MacOS 2017-08-30 14:20:01 +00:00
Timothee Besset 3a6c9d30ed fix compile warning 2017-08-20 15:46:40 -05:00
Timothee Besset 156fc19c13 fix warning 2017-08-20 15:04:49 -05:00
Pan7 b2c2c8d378 Q3data: Fix warning format %d expects argument of type int 2017-08-19 03:21:29 +02:00
Pan7 d1c1de1253 Q3data: Fix warning passing unsigned short * to parameter of type short * 2017-08-18 20:00:41 +02:00
Pan7 16d42f3e64 Merge pull request #551 from Pan7/fixq3data2
Q3data: Fix warning variable shortestSide is used uninitialized
2017-08-18 12:08:02 +02:00
Pan7 91f2e55b1a Merge pull request #553 from Pan7/fixq3data4
Q3data: Fix warning variable psets is used uninitialized
2017-08-18 12:07:31 +02:00
Pan7 93ec80ed9a Merge pull request #554 from Pan7/fixq3data5
Q3data: Fix warning incompatible pointer types passing
2017-08-18 12:07:06 +02:00
Pan7 e40228629e Merge pull request #552 from Pan7/fixq3data3
Q3data: Fix warning format specifies type int but the argument has ty…
2017-08-18 12:06:12 +02:00
Pan7 a9e28b5507 Fix warning variable bcHeight is used uninitialized 2017-08-18 02:18:31 +02:00
Pan7 af45a9d65c Q3data: Fix warning incompatible pointer types passing 2017-08-16 16:29:45 +02:00
Pan7 465cb3ce3f Q3data: Fix warning variable psets is used uninitialized 2017-08-15 22:21:05 +02:00
Pan7 614f97d425 Q3data: Fix warning format specifies type int but the argument has type long 2017-08-15 22:04:30 +02:00
Pan7 fc7e215e80 Q3data: Fix warning variable shortestSide is used uninitialized 2017-08-15 22:02:16 +02:00
Pan7 7a936d6832 Fix g_ascii_strdown usage 2017-08-08 01:24:41 +02:00
neumond 89c8c7355d Proper working with noradiosity 1 lights 2017-08-06 02:31:22 +02:00
Timothee "TTimo" Besset 4d2404df86 Merge pull request #529 from Pan7/fixStrdownWarn
Fix warning g_strdown is deprecated
2017-08-05 11:34:51 -05:00
Pan7 6acfd910ae Fix warning g_strdown is deprecated 2017-07-11 23:08:05 +02:00
Pan7 2398bd71a2 Fix warning implicit declaration of function 2017-07-11 22:24:07 +02:00
Timothee "TTimo" Besset 578fd09625 Merge pull request #526 from Pan7/fixAddWarn
Fix warning variable add is used uninitialized
2017-07-11 10:35:16 +02:00
Pan7 714cc90ce7 Fix warning variable add is used uninitialized 2017-07-10 15:30:04 +02:00
Pan7 a8925cbedb Fix xml passing to parameter warnings 2017-07-10 01:04:28 +02:00
Pan7 cc8cbd8a72 Fix uninitialized use of ext warning 2017-04-27 18:12:09 +02:00
Matthias Krüger 1498ce667d q3map2: don't store lightmap if the last bounce computation ran empty. 2017-03-13 10:58:35 +01:00
TTimo a26c818a1e remove the old .vcproj 2017-01-01 09:08:37 -06:00
Jay Dolan 5938d4e49f Fix a handful of compiler warnings. 2016-12-31 16:02:08 -05:00
Timothee "TTimo" Besset e933f41d07 Merge pull request #385 from illwieckz/importfixes
import a q3map2 fix from netradiant
2016-10-15 20:34:13 -05:00
Thomas Debesse 75e2a70823 More: Using Sys_FPrintf with SYS_WRN and SYS_ERR
This commit do the same as “Using Sys_FPrintf with SYS_WRN and SYS_ERR” commit by @Pan7 (5105fc5) for occurrences that were left untouched (tools/ subtree only).
2016-10-15 20:16:14 +02:00
Rudolf Polzer 1342e8ae5f fix two obvious typos 2016-10-14 02:10:02 +02:00
Timothee Besset 5432b04490 update git ignores 2016-09-30 10:24:25 -05:00
TTimo 8557f1820f more cleanups 2016-08-20 17:50:23 -06:00
TTimo de8105beb4 readability 2016-08-20 16:06:09 -06:00
Timothee "TTimo" Besset 28e9b8ec59 Merge pull request #364 from tkoeppe/memsize
[tools/quake3/q3map2] Fix memset size bugs
2016-08-20 16:03:57 -06:00
Timothee "TTimo" Besset cee35a43d7 Merge pull request #367 from tkoeppe/nan
[tools/quake3/q3map2/light{,maps}_ydnar.c] Fix float-to-int conversion
2016-08-20 15:56:26 -06:00
Thomas Köppe 7ea2c399ad [tools/quake3/q3map2] Fix memset size bugs 2016-08-16 23:41:29 +01:00
Thomas Köppe 87002dc31a [quake3/q3map2/brush.c] Fix misnamed variable 2016-08-16 22:50:14 +01:00
Timothee "TTimo" Besset d1109f70e5 Merge pull request #363 from tkoeppe/zipbrace
[quake3/common/unzip.c] Add braces to make nested if/else less brittle
2016-08-16 06:21:24 -06:00
Timothee "TTimo" Besset c49832c272 Merge pull request #365 from tkoeppe/abs
[quake3/q3map2/brush.c] Fix arithmetic bug
2016-08-16 06:18:15 -06:00
Thomas Köppe f463907e46 [tools/quake3/q3map2/light{,maps}_ydnar.c] Fix float-to-int conversion by preventing NaN values 2016-08-14 12:16:13 +01:00
Thomas Köppe 683e9415f7 [quake3/common/aselib.c] Remove unused local variables 2016-08-14 01:22:03 +01:00
Thomas Köppe d18d90278e [quake3/q3map2/brush.c] Fix arithmetic bug 2016-08-14 01:14:17 +01:00
Thomas Köppe df3ebf5173 [quake3/common/unzip.c] Add braces to make nested if/else less brittle; attempt to make whitespace a bit more uniform 2016-08-14 01:01:05 +01:00
Thomas Köppe 3b2fb7f27e [unzip.c{,pp}] Change zc{alloc,free} to internal linkage 2016-08-03 15:53:59 +01:00
Timothee "TTimo" Besset c918a29cd0 Merge pull request #352 from Pan7/Sys_FPrintf
Using Sys_FPrintf with SYS_WRN and SYS_ERR
2016-06-11 13:01:13 -05:00
Pan7 5105fc5db8 Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
Timothee Besset cc68a76900 phrasing.. 2016-04-24 15:05:09 -05:00