From 74c8a9f94ea8a56590f9411ca00de347ff5164df Mon Sep 17 00:00:00 2001 From: Robert Beckebans Date: Sun, 20 Nov 2022 13:34:46 +0100 Subject: [PATCH] Always write the constant buffer -> BAD but works --- neo/renderer/NVRHI/RenderProgs_NVRHI.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/neo/renderer/NVRHI/RenderProgs_NVRHI.cpp b/neo/renderer/NVRHI/RenderProgs_NVRHI.cpp index 5f961b06..964630f4 100644 --- a/neo/renderer/NVRHI/RenderProgs_NVRHI.cpp +++ b/neo/renderer/NVRHI/RenderProgs_NVRHI.cpp @@ -309,7 +309,9 @@ void idRenderProgManager::ZeroUniforms() // Only updates the constant buffer if it was updated at all bool idRenderProgManager::CommitConstantBuffer( nvrhi::ICommandList* commandList ) { - if( uniformsChanged ) + // RB: It would be better to NUM_BINDING_LAYOUTS uniformsChanged entrys but we don't know the current binding layout type when we set the uniforms. + // The vkDoom3 backend even didn't bother with this and always fired the uniforms for each draw call. + //if( uniformsChanged ) { commandList->writeBuffer( constantBuffer[BindingLayoutType()], uniforms.Ptr(), uniforms.Allocated() );