From 4f6f65f4b80757d0628047e396bf43b1f99e09dc Mon Sep 17 00:00:00 2001 From: Robert Beckebans Date: Mon, 20 Jun 2022 22:33:01 +0200 Subject: [PATCH 1/2] Ignore line definitions in OBJ files --- neo/renderer/Model_obj.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/neo/renderer/Model_obj.cpp b/neo/renderer/Model_obj.cpp index 26fe9389..4e9143b6 100644 --- a/neo/renderer/Model_obj.cpp +++ b/neo/renderer/Model_obj.cpp @@ -125,6 +125,12 @@ objModel_t* OBJ_Parse( const char* fileName, const char* objFileBuffer, int leng idStr line; src.ReadRestOfLine( line ); } + else if( token == "l" ) + { + // We don't support lines + idStr line; + src.ReadRestOfLine( line ); + } else if( token == "o" || token == "g" ) { idStr line; From 5f58f73845cb75b9a7af92709ca7c85574ff5755 Mon Sep 17 00:00:00 2001 From: Robert Beckebans Date: Mon, 20 Jun 2022 23:57:13 +0200 Subject: [PATCH 2/2] Fixed missing generation of tangent spaces for glTF files --- neo/renderer/Model_gltf.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/neo/renderer/Model_gltf.cpp b/neo/renderer/Model_gltf.cpp index 431b1eca..7894c9e8 100644 --- a/neo/renderer/Model_gltf.cpp +++ b/neo/renderer/Model_gltf.cpp @@ -480,6 +480,9 @@ void idRenderModelGLTF::ProcessNode( gltfNode* modelNode, idMat4 trans, gltfData { ProcessNode( nodeList[child], curTrans, data ); } + + // derive mikktspace tangents from normals + FinishSurfaces( true ); } //constructs a renderModel from a gltfScene node found in the "models" scene of the given gltfFile.