Commit graph

5355 commits

Author SHA1 Message Date
Gregory John Casamento
eeffa67a4e * Headers/AppKit/NSCollectionView.h
* Headers/AppKit/NSCollectionViewItem.h
	* Source/GNUmakefile
	* Source/NSCollectionViewItem.m
	* Source/NSCollectionView.m: Added NSCollectionView and
	NSCollectionViewItem classes from testplant branch.  Made changes
	to original patch to conform to coding standards, NSCoding for
	non-keyed archiving and moved instances of float/integer to
	CGFloat and NSInteger/NSUInteger as appropriate.
	Patch by Doug Simons (dsimons@testplant.com) and
	Frank LeGrand (flegrand@testplant.com).



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36545 72102866-910b-0410-8b05-ffd578937521
2013-04-18 03:57:49 +00:00
Fred Kiefer
3aa97e1975 * Headers/AppKit/NSKeyValueBinding.h,
* Source/externs.m: Additional binding name
        * NSContentValuesBinding.
        * Source/NSPopUpButton.m: Add KVB for NSContentValuesBinding.
        Patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>
        * Source/NSArrayController.m: Encode/decode
        * clearsFilterPredicateOnInsertion.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36540 72102866-910b-0410-8b05-ffd578937521
2013-04-15 20:20:38 +00:00
Eric Wasylishen
67daa51afa * Source/GSTheme.m:
* Source/NSImage.m: Revert previous commit and write a much cleaner
implementation that fixes the same bug.

I removed the step in theme activation where we call
+[NSImage _setImagePath:name:] on each image in the theme, and instead
modified +[NSImage _pathForImageNamed:] to also search the theme images
directory.

When a GSTheme activates now, it only calls +[NSImage _reloadCachedImages]
which checks all NSImage cached by name and reloads any whose path has
changed.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36482 72102866-910b-0410-8b05-ffd578937521
2013-04-06 19:30:48 +00:00
Eric Wasylishen
23d47ca882 Revert "Allow themes to override only a "base" image like"
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36481 72102866-910b-0410-8b05-ffd578937521
2013-04-06 19:30:30 +00:00
Eric Wasylishen
5dcf9e3251 Allow themes to override only a "base" image like
common_3DArrowRight and have images that map to it (NSMenuArrow)
automatically update.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36474 72102866-910b-0410-8b05-ffd578937521
2013-04-06 07:57:57 +00:00
Fred Kiefer
808e830952 * Source/NSBitmapImageRep+GIF.m (-_bitmapIsGIF:): Prepare for
additional argument to function DGifOpen in newer libgif
versions.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36459 72102866-910b-0410-8b05-ffd578937521
2013-04-03 18:30:46 +00:00
Fred Kiefer
60383e72fe Remove commented out old code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36394 72102866-910b-0410-8b05-ffd578937521
2013-03-20 22:15:26 +00:00
Fred Kiefer
f35d315dfb * Source/GSToolTips.m (+initialize): Set the level of the tool
* tip
        window to NSPopUpMenuWindowLevel.
        Change suggested by Wolfgang Lux  <wolfgang.lux@gmail.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36393 72102866-910b-0410-8b05-ffd578937521
2013-03-20 22:10:38 +00:00
Fred Kiefer
4765d0f314 * Tests/gui/NSImage/basic.m: Add basic tests for NSImage.
* Tests/gui/NSCell/basic.m: Extend basic tests for NSCell.
        * Source/NSImage.m: Try to correct keyed encoding/decoding. Add
        incomplete isEqual: method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36384 72102866-910b-0410-8b05-ffd578937521
2013-03-18 22:50:11 +00:00
Fred Kiefer
9a15cb6b88 * Source/NSViewController.m: Retain the view.
* Source/NSOutline.m(-drawRow:clipRect:): The selected cell
        * shows
        its first responder state.
        Patch by Frank LeGrand <frank.legrand@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36378 72102866-910b-0410-8b05-ffd578937521
2013-03-17 22:36:34 +00:00
Fred Kiefer
12c4d6cbdb * Source/NSEvent.m,
* Source/NSParagraphStyle.m: Use NSInteger instead of enumerator
        type name for decoding and encoding.
        * Header/AppKit/NSFontPanel.h,
        * Header/AppKit/NSOpenPanel.h,
        * Header/AppKit/NSDataLinkPanel.h,
        * Source/NSDataLinkPanel.m,
        * Header/AppKit/NSForm.h,
        * Source/NSForm.m,
        * Header/AppKit/NSHelpPanel.h,
        * Source/NSHelpPanel.m,
        * Source/NSColorPanel.m: Remove unused encoding/decoding
        * methods.
        * Source/NSCustomImageRep.m,
        * Source/NSEPSImageRep.m,
        * Source/NSMovie.m,
        * Source/NSRulerMarker.m,
        * Source/NSColorList.m: Flag missing keyed encoding/decoding.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36377 72102866-910b-0410-8b05-ffd578937521
2013-03-17 19:53:50 +00:00
Fred Kiefer
6b09581658 * Source/NSTableView.m: Use new method -_isCellSelectableColumn:row:,
that checks the cells selectable state, in -mouseDown:.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36363 72102866-910b-0410-8b05-ffd578937521
2013-03-15 16:39:31 +00:00
Fred Kiefer
b9cd78229f * Source/GSNibLoading.m (NSCustomView -nibInstantiateWithCoder:):
Re-add call to -replaceObject:withObject: on decoder, but this
time in the right place.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36329 72102866-910b-0410-8b05-ffd578937521
2013-03-10 13:39:00 +00:00
Fred Kiefer
14584bb4e2 * Source/NSTableColumn.m (-initWithCoder:): Make columns
non-editable by default.
* Source/NSTableView.m (-editColumn:...select:): Make editing
here independ of the datasource.
* Source/NSTableView.m: Split -_isCellEditableColumn:row: in two
methods and ignore the cell isEditable state in -mouseDown:.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36307 72102866-910b-0410-8b05-ffd578937521
2013-03-08 11:51:51 +00:00
Fred Kiefer
86b587e9d7 * Source/NSBezierPath.m (-elementAtIndex:associatedPoints:): Fix
handling of close element.
Patch by Bluna Ratimonkey <object@gmail.com>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36304 72102866-910b-0410-8b05-ffd578937521
2013-03-08 08:59:18 +00:00
Fred Kiefer
a0616ff819 * Source/GSHorizontalTypesetter.m: Change floats into CGFloats to
stop infinite loop.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36282 72102866-910b-0410-8b05-ffd578937521
2013-03-05 22:33:57 +00:00
Fred Kiefer
2f6cc73444 * Source/NSBezierPath.m: Implement keyed coding and complete
keyed decoding.
Patch by Christopher Armstrong <carmstrong@fastmail.com.au>
* Source/NSBezierPath.m: Rewrote -elementAtIndex:associatedPoints:
to return a point for NSClosePathBezierPathElement. And adjust
all callers to make use of that point. Complete non-keyed coding and
decoding.
* Tests/gui/NSBezierPath/basic.m: Add basic tests for NSBezierPath.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36267 72102866-910b-0410-8b05-ffd578937521
2013-03-04 16:51:10 +00:00
Sebastian Reitenbach
1bda279897 * Source/NSMenuItemCell.m
* Headers/AppKit/NSMenuItemCell.h
          float -> CGFloat transitions



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36238 72102866-910b-0410-8b05-ffd578937521
2013-03-02 18:06:25 +00:00
Eric Wasylishen
8d6ce17b24 * Source/GSPDFPrintOperation.m: Update -_print and -deliverResult
to match GSEPSPrintOperation to get the class to at least partly
working. Output is appearing up-side-down for me though.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36203 72102866-910b-0410-8b05-ffd578937521
2013-02-28 09:40:36 +00:00
Fred Kiefer
ae607757b3 * Source/NSindow.m (-setDelegate:): Don't unregister delegate
notifications if same delegate is set twice.
        Patch by Doug Simons <doug.simons@testplant.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36192 72102866-910b-0410-8b05-ffd578937521
2013-02-23 15:36:46 +00:00
Fred Kiefer
0561a46d2f Correct problems found by valgrind.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36188 72102866-910b-0410-8b05-ffd578937521
2013-02-22 15:39:29 +00:00
Fred Kiefer
28ff5825aa Add the timers for NSModalPanelRunLoopMode as well.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36187 72102866-910b-0410-8b05-ffd578937521
2013-02-22 11:28:06 +00:00
Fred Kiefer
a070f43ca7 * Source/NSTabView.m (-minimumSize, -contentRect): Make the
* values
        here consistent with the code in GSThemeDrawing.
        * Source/GSThemeDrawing.m (-drawTabViewRect:...): Remove useless
        line of code. 


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36184 72102866-910b-0410-8b05-ffd578937521
2013-02-22 09:26:55 +00:00
Riccardo Mottola
ffa04cc800 Encode and decode lineBreakMode with NSInteger and not NSLineBreakMode
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36182 72102866-910b-0410-8b05-ffd578937521
2013-02-21 17:19:00 +00:00
Fred Kiefer
374047524a * Source/NSBitmapImageRep+PNG.m
(-_PNGRepresentationWithProperties:): Revert last change and
don't use png_info_init_3() on PNG >= 1.5.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36178 72102866-910b-0410-8b05-ffd578937521
2013-02-21 08:53:31 +00:00
Riccardo Mottola
1e8942edec Define png_sizeof() to allow compilation on 1.6.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36177 72102866-910b-0410-8b05-ffd578937521
2013-02-20 23:42:11 +00:00
Quentin Mathe
478148da52 Fixed typo in comment
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36171 72102866-910b-0410-8b05-ffd578937521
2013-02-19 17:01:31 +00:00
Quentin Mathe
b3c302d8c4 Cleaned drop handling code a bit more in NSTableView
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36170 72102866-910b-0410-8b05-ffd578937521
2013-02-19 16:59:21 +00:00
Quentin Mathe
da5449b7a8 Don't update the drop row and operation if the drop target hasn't changed (this prevents to overwrite a custom drop row and operation set by the user)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36169 72102866-910b-0410-8b05-ffd578937521
2013-02-19 16:03:28 +00:00
Quentin Mathe
f896752208 Extracted table view drop indicator drawing from -draggingUpdated: into a new method -_drawDropIndicator
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36168 72102866-910b-0410-8b05-ffd578937521
2013-02-19 15:57:04 +00:00
Quentin Mathe
fea485cea2 Modularized the first part of -draggingUpdated: into several smaller methods
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36167 72102866-910b-0410-8b05-ffd578937521
2013-02-19 15:18:53 +00:00
Fred Kiefer
941afdac86 Fix compiler warnings reported by
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36165 72102866-910b-0410-8b05-ffd578937521
2013-02-18 20:29:10 +00:00
Fred Kiefer
0c95f32580 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36163 72102866-910b-0410-8b05-ffd578937521
2013-02-17 22:44:47 +00:00
Fred Kiefer
b1fc7cb066 Correct coding/decoding after type changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36160 72102866-910b-0410-8b05-ffd578937521
2013-02-17 16:53:48 +00:00
Fred Kiefer
4d953a5122 * Source/NSBezierPath.m: More keyed decoding.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36157 72102866-910b-0410-8b05-ffd578937521
2013-02-17 13:02:46 +00:00
Fred Kiefer
152b94069f More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36154 72102866-910b-0410-8b05-ffd578937521
2013-02-17 00:49:04 +00:00
Fred Kiefer
7ef53c8232 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36153 72102866-910b-0410-8b05-ffd578937521
2013-02-16 21:37:29 +00:00
Fred Kiefer
270baf4037 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36148 72102866-910b-0410-8b05-ffd578937521
2013-02-16 00:08:33 +00:00
Quentin Mathe
e4e5428122 Replaced -_dataCellForTableColumn:row: by -preparedCellAtColumn:row: new public method from Mac OS X 10.5
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36136 72102866-910b-0410-8b05-ffd578937521
2013-02-14 10:34:20 +00:00
Fred Kiefer
0e308561c1 * Source/GSXibLoader.m (GSXibKeyedUnarchiver -_preProcessXib:):
Release the document.
        Patch by Doug Simons <doug.simons@testplant.com>
        * Source/GSXibLoader.m: Fix a problem where owner,
        * firstResponder and application
        were put in the list of top-level objects, creating a
retain-cycle.
        * Source/NSViewController.m: Fix a problem where view
        * controllers
        did not release their top-level objects as expected.
        * Source/NSWindowController.m: Fix a problem where window
        controllers did not release their top-level objects as expected.
        Changes made in occordance with
        https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/LoadingResources/CocoaNibs/CocoaNibs.html
        Patch by Jonathan Gillaspie <jonathan.gillaspie@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36134 72102866-910b-0410-8b05-ffd578937521
2013-02-14 09:22:56 +00:00
Fred Kiefer
0a4708d4d0 Resolve clang warnings about wrong format specifiers for NSLog.
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36133 72102866-910b-0410-8b05-ffd578937521
2013-02-14 08:58:05 +00:00
Fred Kiefer
d7fbd2f6af Resolve memory leak for GSXibElement.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36122 72102866-910b-0410-8b05-ffd578937521
2013-02-13 08:54:34 +00:00
Fred Kiefer
d4f80c2258 Change NSEvent to CGFloat, NSUInteger and NSInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36121 72102866-910b-0410-8b05-ffd578937521
2013-02-13 08:40:36 +00:00
Fred Kiefer
f078b2daaf * Headers/AppKit/NSSplitView.h
* Source/NSSplitView.m: Change to CGFloat, NSUInteger and NSInteger.
Patch partly by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36109 72102866-910b-0410-8b05-ffd578937521
2013-02-10 21:32:07 +00:00
Fred Kiefer
cda7dc977f * Headers/AppKit/NSPageLayout.h
* Source/NSPageLayout.m: Change int to NSInteger.
        Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36092 72102866-910b-0410-8b05-ffd578937521
2013-02-08 17:50:25 +00:00
Riccardo Mottola
9e67500f35 Add tooltips to buttons.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36081 72102866-910b-0410-8b05-ffd578937521
2013-02-07 17:14:20 +00:00
Quentin Mathe
37311e0e04 Fixed -encodeWithCoder: in NSView to encode the superview conditionally as Cocoa
does (Apple discusses  superview encoding as a use case for conditional encoding 
in the Archiving related documentation).

Note: A view can now be archived (or copied) without having to remove the view 
from its hierarchy before archiving it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36065 72102866-910b-0410-8b05-ffd578937521
2013-02-06 17:28:52 +00:00
Fred Kiefer
340c7eb879 Change DPS/PS functions to CGFloat and NSInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36063 72102866-910b-0410-8b05-ffd578937521
2013-02-05 19:18:49 +00:00
David Chisnall
9d153b9b8b Fix the NSBrowser delegate methods in NSSavePanel to have the correct types.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36061 72102866-910b-0410-8b05-ffd578937521
2013-02-05 12:51:11 +00:00
David Chisnall
15a3aec436 When displaying the horizontal menu, set the title of the main menu to the name
of the application, not the name of the process, if the info bundle contains an
application name.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36060 72102866-910b-0410-8b05-ffd578937521
2013-02-05 12:14:20 +00:00