NSDocument.m where the error return parameter was written to without a
null pointer check.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29580 72102866-910b-0410-8b05-ffd578937521
1pt gap underneath table headers to GSThemeDrawing, since it only
looks decent with a NeXT-like theme. This fixes the
misalignment between the table corner and the table headers visible
in the Narcissus theme
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29567 72102866-910b-0410-8b05-ffd578937521
selected item as needing display. This fixes the 'popup' indicators
not being erased.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29502 72102866-910b-0410-8b05-ffd578937521
views.
NSTableView non-keyed unarchiving was not always initializing _columnOrigins.
NSScrollView keyed unarchiving was decoding non-encoded flags (the flags were
thus initialized with random memory content).
See ChangeLog for detailed explanations.
Also added double action keyed archiving to NSTableView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29494 72102866-910b-0410-8b05-ffd578937521
the first responder. We don't give anymore the first responder status to a
button on a click.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29471 72102866-910b-0410-8b05-ffd578937521
to draw segmented controls, chosen based on the segment style constant,
and falling back to drawing buttons if the segment tiles are not
available.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29452 72102866-910b-0410-8b05-ffd578937521
declaration for updateAllWindowsWithMenu:
* Source/GSThemeMenu.m: Added default implementation of
updateAllWindowsWithMenu:
* Source/NSMenu.m: Added call to updateAllWindowsWithMenu: on
current theme.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29445 72102866-910b-0410-8b05-ffd578937521
only after a short delay so that all observers can process the
NSWindowWillCloseNotification. This ensures that a modified document
associated with the closed window has been closed before -terminate:
is called and therefore the user isn't asked twice whether she wants
to save the unsaved changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29428 72102866-910b-0410-8b05-ffd578937521
any icon placement performed by the user does not get lost when a
miniwindow is deminiaturized.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29427 72102866-910b-0410-8b05-ffd578937521
pasting, and deleting full words in a text view or text field.
Note: I have changed NSTextView initialization to enable smart insert
and delete by default, since this is the default on OS X. (It is even
documented, though in a maybe obscure place, cf. "Text Editing
Programming Guide for Cocoa: Subclassing NSTextView".) However, this
means that support for this feature will be somewhat inconsistent.
Smart insert and delete is enabled for text views created
programmatically (including the field editor), but not for text views
loaded from existing nib files.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29426 72102866-910b-0410-8b05-ffd578937521
Use the new contentRect when calculating the border for tiles
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29425 72102866-910b-0410-8b05-ffd578937521
event the current event in order to be consistent with Mac OS X behavior.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29418 72102866-910b-0410-8b05-ffd578937521
call -setNeedsDisplay:YES on the superview, rather than self
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29417 72102866-910b-0410-8b05-ffd578937521
from nib's, with subviews. The subview coordinates just need to be
invalidated when the view is unhidden.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29416 72102866-910b-0410-8b05-ffd578937521
drag the color from a well before it is treated as a drag.
TODO: Unify this with the dragging threshold in other parts of
gui and make a user default called GSDragThreshold, maybe?
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29377 72102866-910b-0410-8b05-ffd578937521
background before getting the theme to draw its background.
This makes windows with semitransparent background colors work
properly.
NOTE: While the clear operation is very fast, we may want to only do
it if the window background colour has an alpha value of < 1.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29376 72102866-910b-0410-8b05-ffd578937521
8 pixels of padding to the left of the first menu item as activating
the first menu item.
This lets you open the application menu with a Macintosh-syle
menu bar when the mouse is on the top-left pixel of the screen.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29375 72102866-910b-0410-8b05-ffd578937521
Cocoa does, and remove the toggle selection behavior when a column is clicked
twice (in conflict with the ability to change the sort direction).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29296 72102866-910b-0410-8b05-ffd578937521
These flags are getting out of sync due to different behavior on
different backends. Also, it's better to keep the state in one place
instead of keeping them in sync. I changed all of the instances of
_f.is_key to [self isKeyWindow] and all of the instances of _f.is_main
to [self isMainWindow] and those methods now check with NSApp to
determine if the current window is main. I realize this is slower
than the previous method of using flags, but it is also more resilient
and reliable when the backend sends extra events. This corrects the
issue on Windows where we were losing the main window and had two
windows marked as "main".
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29295 72102866-910b-0410-8b05-ffd578937521
More changes are needed to get proper sorting support (e.g. visual feedback).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29293 72102866-910b-0410-8b05-ffd578937521
back menuHeightForWindow:
* Source/GSThemeMenu.m: Added default implementation of
menuHeightForWindow:. Default implementation returns NSMenuView
menuBarHeight.
* Source/GSWindowDecorationView.m: Use menuHeightForWindow: instead
of getting it directly from the menu view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29288 72102866-910b-0410-8b05-ffd578937521
on Windows, since hiding the app causes it to be inaccessible on
that platform.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29281 72102866-910b-0410-8b05-ffd578937521
to support adding menus and processing commands from windows, if
appropriate.
* Headers/Additions/GNUstepGUI/GSWindowDecorationView.h: Added
new methods for menu and toolbar flags.
* Headers/AppKit/NSInterfaceStyle.h: Added new interface style.
* Source/GNUmakefile: Added header.
* Source/GSStandardWindowDecorationView.m: Change include
to include header in new location.
* Source/GSThemeMenu.m: Default theme implementation for
Menus.
* Source/GSWindowDecorationView.m: Add the setHasMenu:/setHasToolbar:
flags.
* Source/NSWindow.m: Use the theme to set the menu instead of
setting it directly.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29271 72102866-910b-0410-8b05-ffd578937521
NSWindows95InterfaceStyle mode.
NOTE: This is the first half of the commits for the in-window menu
changes. The next change will entail regenerating the menu for each
window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29210 72102866-910b-0410-8b05-ffd578937521
if a toolbar or menu is present in the window decorations. Modified
code to set these to YES/NO.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29203 72102866-910b-0410-8b05-ffd578937521
of a table view now can change the cell's state even when the table
view allows dragging.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29161 72102866-910b-0410-8b05-ffd578937521
redo: actions if available. Avoids the need for overriding these
methods in any responder class which supports undo/redo and is
compatible with OS X.
Generalize user interface validation for NSWindow.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29158 72102866-910b-0410-8b05-ffd578937521
panel wrap its text to the scroll view's width. Limit the width and
height of alert panels to 60% of the screen's width and height
respectively.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29157 72102866-910b-0410-8b05-ffd578937521
is disabled. This prevents bogus directories being returned from the
next modal session of the panel.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29155 72102866-910b-0410-8b05-ffd578937521
Allows to get icon placement from separate process.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29153 72102866-910b-0410-8b05-ffd578937521
- activation of the now happens on mouseUp, not mouseDown
- non-bordered NSColorWells can't be activated by clicking
- non-bordered NSColorWells start a drag operation upon mouseDown
- disabled NSColorWells don't accept colours being dropped on them
- dropping a colour on the well inside the NSColorPanel now
also updates the active NSColorWell
Also moved the static variable for keeping track of where the mouseDown
occurred to an instance variable.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29150 72102866-910b-0410-8b05-ffd578937521
BezierPathLab working, and a test suite in
tests/testsuite/gui/NSSliderCell. Set the doubleValue to 0 in -init,
unarchive the @"NSValue" key and set the floatValue to it when
unarchiving, adjust setObjectValue: so that when minValue > maxValue,
the slider cell takes its value to be minValue.
Also override setContinuous: and isContinuous to use
NSLeftMouseDraggedMask rather than NSPeriodicMask, which makes
the continuous setting of sliders in Nibs work properly in GNUstep.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29148 72102866-910b-0410-8b05-ffd578937521
-DPSsetflat: and -DPScurrentflat should not have been transforming
the flatness value with the current transformation matrix.
The effect of this could be seen in the Apple BezierPathLab example;
zooming in on the circle caused it to look more and more like a
polygon.
Also set NSBezierPath default flatness to 0.6 to match OS X
(it was 1.0, which made circles look a bit rough)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29145 72102866-910b-0410-8b05-ffd578937521
remove special case from NSCell setString:.
Removed unneeded NSSliderCell methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29142 72102866-910b-0410-8b05-ffd578937521
Rework the handling of maxValue and minValue. The cell's value is now
clamped to the permisible range when it is set, rather than in
floatValue, matching OS X behaviour. setMinValue: and setMaxValue:
also clamp the current value.
Also make NSSliderCell continuous by default when unarchived (matches
OS X).
Patch by Eric Wasylishen!
(Please someone give him commit access)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29139 72102866-910b-0410-8b05-ffd578937521
spinning or indeterminate progress indicator.
Ensure that a running animation is stopped when an indeterminate
indicator is changed into a determinate one.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29136 72102866-910b-0410-8b05-ffd578937521
the cell's ellipsis button.
Fix bug where the pop up window of a combo box might stay open when
the user leaves the combo box with the keyboard.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29135 72102866-910b-0410-8b05-ffd578937521
lineBreakMode attribute. Note that with this change cells now wrap by
default, as has always been the case on OS X.
Also fix a related inconsistency where text that is wrapped by the
cell was displayed in a single line during editing.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29134 72102866-910b-0410-8b05-ffd578937521
includes a fix for the problem of properly resizing and redrawing the
editor when the cell is resized or moved during editing (bug #22678).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29133 72102866-910b-0410-8b05-ffd578937521
the previous "fix" for bug #25471, which made it impossible to use the
open panel for choosing directories (except by entering a fake file
name into the panel) and actually did not fix that bug other than by
coincidence.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29129 72102866-910b-0410-8b05-ffd578937521
selection is enabled and allowsBranchSelection is set to NO. Also
replace the workaround for bug #18881 by a better fix.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29128 72102866-910b-0410-8b05-ffd578937521
type extension and the user has entered a file name without an
extension. In addition fix the filename method so that setting
allowsOtherFileTypes to YES works as advertised.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29126 72102866-910b-0410-8b05-ffd578937521
with nib loading.
* Source/NSTextContainer.m: -[NSTextContainer initWithCoder:]
removed call to unarchive the textview to prevent a leak. Also
don't set the textview as the text container. Currently we
just get the contents of the text container and rebuild it
in NSTextView.m.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29116 72102866-910b-0410-8b05-ffd578937521
These new additions remain to be fully implemented and the archiving code to be
updated.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29107 72102866-910b-0410-8b05-ffd578937521
row and is based on the horizontal pointer position.
NSOutlineView drag and drop behavior matches Mac OS X very closely now and all
the bugs I was aware of have been corrected.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29103 72102866-910b-0410-8b05-ffd578937521
Added drop on root indicator support.
Fixed exception with auto-expand and root area.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29098 72102866-910b-0410-8b05-ffd578937521
Fix bug where an attributed string would not be considered a valid
object value of a cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29059 72102866-910b-0410-8b05-ffd578937521
