Commit graph

170 commits

Author SHA1 Message Date
fredkiefer
be61e98fac * Source/NSBrowser.m (-selectionIndexPaths): Actually do the correction.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37404 72102866-910b-0410-8b05-ffd578937521
2013-11-24 11:08:02 +00:00
fredkiefer
929048423f * Source/NSBrowser.m (-selectionIndexPaths): Correct off by one
error in last change.
  Detected by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37403 72102866-910b-0410-8b05-ffd578937521
2013-11-23 17:04:56 +00:00
fredkiefer
9be38fcc46 * configure.ac: Try to improve the ICU detection.
* configure: regenerate
        * Headers/AppKit/NSTrackingArea.h
        * Source/NSTrackingArea.m: Remove compiler warnings.
        * Headers/AppKit/NSBrowser.h,
        * Source/NSBrowser.m: Add a few new Cocoa methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37399 72102866-910b-0410-8b05-ffd578937521
2013-11-22 22:44:37 +00:00
ericwa
240f754c33 * Headers/Additions/GNUstepGUI/GSTheme.h: Remove GSScrollViewBottomCorner
part name, instead themes should just provide a part called NSScrollView.

	Add -scrollViewScrollersOverlapBorders method.

	* Source/GSTheme.m: Remove GSScrollViewBottomCorner part name.
	* Source/GSThemeDrawing.m: Add -scrollViewScrollersOverlapBorders.
	* Source/GSThemeDrawing.m (-drawBrowserRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the browser background
	with the NSScrollView tile.
	* Source/GSThemeDrawing.m (-drawScrollViewRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the scroll view background
	with the NSScrollView tile.
	* Source/NSScroller.m (-rectForPart:): Change the meaning of the
	GSScrollerKnobOvershoot default so the knob only overlaps the buttons
	by this much (rather than both ends of the track). Turns out this is more
	useful for themes.
	* Source/NSScrollView.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders]
	* Source/NSBrowser.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders] and
	-[GSTheme scrollViewUseBottomCorner]

	The overall point of these additions is to support NSScrollView and
	NSBrowser looking like: http://jesseross.com/clients/gnustep/ui/concepts/


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37238 72102866-910b-0410-8b05-ffd578937521
2013-10-15 23:26:51 +00:00
ericwa
e6357523a4 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSThemeDrawing.m:
* Source/NSBrowser.m:
* Source/NSTableHeaderCell.m: Add custom color names
tableHeaderTextColor and browserHeaderTextColor for
table and browser headers.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37193 72102866-910b-0410-8b05-ffd578937521
2013-10-04 02:23:16 +00:00
ericwa
c84655da3d * Source/NSBrowser.m: Fix some position calculations from the last
commit


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37175 72102866-910b-0410-8b05-ffd578937521
2013-09-30 02:29:28 +00:00
ericwa
17303e9182 * Source/NSBrowser.m:
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSBrowserUseBezels
user default. Themes can set it to NO to prevent NSBrowser from
drawing any bezels, even if separatesColumns is set to YES.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37174 72102866-910b-0410-8b05-ffd578937521
2013-09-30 00:38:09 +00:00
ericwa
b44e528c8c * Source/NSBrowser.m: Small refactoring to simplify code.
Remove update logic from -setSeparatesColumns: and just use
-tile. Tested by toggling "separates columns" flag in Gorm.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37173 72102866-910b-0410-8b05-ffd578937521
2013-09-29 22:44:57 +00:00
ericwa
176305a0e8 * Source/NSBrowser.m: Change NSBR_COLUMN_SEP and NSBR_VOFFSET
macros to static floats. Cache the values in +initialize and
when GSThemeDidActivateNotification is sent, by calling the
new GSTheme methods.
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add
-browserColumnSeparation and -browserVerticalPadding methods
which access user defaults GSBrowserColumnSeparation and
GSBrowserVerticalPadding. These determine the padding between
browser columns, and the vertical padding between the bottom
scroller, contents, and headers.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37171 72102866-910b-0410-8b05-ffd578937521
2013-09-29 19:36:08 +00:00
ericwa
d81d463a64 * Source/NSCell.m (-highlight:withFrame:inView:):
Remove call to [controlView displayRect: cellFrame];
There was a comment saying it should be removed, and when
combined with the -[NSButtonCell isOpaque] change, it
was casuing scroller buttons to stay "stuck" down.
* Source/NSBrowser.m (-isOpaque):
* Source/NSButtonCell.m (-isOpaque):
* Source/NSColorWell.m (-isOpaque):
Force -isOpaque to return NO, because it's
possible to make all of these controls semitransparent with
theme tiles. This was visible with the Narcissus theme
(svn://svn.gna.org/svn/etoile/trunk/Etoile/Themes/Narcissus.theme)


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37164 72102866-910b-0410-8b05-ffd578937521
2013-09-28 21:38:29 +00:00
fredkiefer
00dc04169b * Source/NSBrowser.m (-setPath:): Fixed a bug where setting the
path to "/" would not deselect the cells.
  Based on patch by Frank Le Grand <frank.legrand@testplant.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37081 72102866-910b-0410-8b05-ffd578937521
2013-09-16 18:18:07 +00:00
fredkiefer
6880e50086 Correct coding/decoding after type changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36160 72102866-910b-0410-8b05-ffd578937521
2013-02-17 16:53:48 +00:00
fredkiefer
6a52d99499 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36154 72102866-910b-0410-8b05-ffd578937521
2013-02-17 00:49:04 +00:00
fredkiefer
0f6458d613 * Headers/AppKit/NSBrowser.h
* Headers/AppKit/NSFontPanel.h
        * Headers/AppKit/NSMatrix.h
        * Headers/AppKit/NSTableView.h
        * Source/NSBrowser.m
        * Source/NSFontPanel.m
        * Source/NSMatrix.m: Small fixes to last change.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36042 72102866-910b-0410-8b05-ffd578937521
2013-01-30 22:13:32 +00:00
theraven
d07b4ef40f Next bit of NSInteger cleanup for -gui.
Fix all of the current warnings in Gorm so that it can be used to test
NSInteger things.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36039 72102866-910b-0410-8b05-ffd578937521
2013-01-30 12:43:27 +00:00
theraven
30eb57e642 Fix all current compiler warnings on FreeBSD/x86-64.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36038 72102866-910b-0410-8b05-ffd578937521
2013-01-30 09:48:54 +00:00
ericwa
c7e05f2c7b * Source/GSGuiPrivate.h: New rounding rounding function
GSRoundTowardsInfinity which is simply floor(x+0.5)
* Source/NSBrowser.m:
* Source/NSSliderCell.m:
* Source/NSButtonCell.m:
* Source/NSClipView.m:
* Source/NSOutlineView.m:
* Source/NSRulerView.m:
Switch rint[f] to GSRoundTowardsInfinity


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33539 72102866-910b-0410-8b05-ffd578937521
2011-07-12 21:12:22 +00:00
fredkiefer
8cf1cd3bab Correct issues with missing or incorrect self
tests in initXXX methods pointed out by static analyser.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32588 72102866-910b-0410-8b05-ffd578937521
2011-03-14 22:59:20 +00:00
fredkiefer
9fcd522c8a Removed dead assignments found by static code analyser.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32551 72102866-910b-0410-8b05-ffd578937521
2011-03-13 15:26:20 +00:00
fredkiefer
475f2d07aa Remove dead assignments found by static code analysis.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32022 72102866-910b-0410-8b05-ffd578937521
2011-02-09 22:20:00 +00:00
fredkiefer
ad08ca9dc4 Add method -scrollRowToVisible:inColumn: to NSBrowser.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31980 72102866-910b-0410-8b05-ffd578937521
2011-01-31 22:42:49 +00:00
gcasa
7c12759c52 Adding theme method for NSBrowser drawing.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31658 72102866-910b-0410-8b05-ffd578937521
2010-11-26 19:49:04 +00:00
fredkiefer
7957a90007 Add support for backtab character.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31026 72102866-910b-0410-8b05-ffd578937521
2010-07-25 20:51:40 +00:00
ericwa
dcebe1ef37 NSBrowser header themeing
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30189 72102866-910b-0410-8b05-ffd578937521
2010-04-19 03:14:36 +00:00
fredkiefer
9768ee6425 Next bit of #include -> #import replacement.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30029 72102866-910b-0410-8b05-ffd578937521
2010-03-24 09:18:14 +00:00
rmottola
8db14fce17 use controlColor to match cocoa behaviour
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29712 72102866-910b-0410-8b05-ffd578937521
2010-02-23 23:05:57 +00:00
gcasa
f7fa51234e * Source/NSBrowser.m: Make sure that the matrix used in the
browser draws its cell backgrounds properly.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29598 72102866-910b-0410-8b05-ffd578937521
2010-02-13 00:42:13 +00:00
wlux
44c81fa9a7 Fix NSBrowser so that branch cells are really deselected when multiple
selection is enabled and allowsBranchSelection is set to NO. Also
replace the workaround for bug #18881 by a better fix.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29128 72102866-910b-0410-8b05-ffd578937521
2009-12-15 23:21:16 +00:00
rfm
f48b5d132e Small theme update, plus documentation fixes and tweaks to avoid warnings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28538 72102866-910b-0410-8b05-ffd578937521
2009-08-25 07:46:37 +00:00
rfm
a3849e0898 Make code a little easier to read (and a tiny bit more efficient).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27452 72102866-910b-0410-8b05-ffd578937521
2008-12-29 12:28:50 +00:00
fredkiefer
be90447def Try to stop redundant redars of the NSBrowser, by only getting the
ownership of the titlecell during drawing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27284 72102866-910b-0410-8b05-ffd578937521
2008-12-12 20:16:14 +00:00
fredkiefer
481d7e44a0 Clean up for NSTextFieldCell and resulting changes to sub classes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27260 72102866-910b-0410-8b05-ffd578937521
2008-12-08 16:28:13 +00:00
rfm
d600101078 fix uninitialised variable
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27191 72102866-910b-0410-8b05-ffd578937521
2008-12-02 22:39:37 +00:00
fredkiefer
a1b47c0986 Forgotten NSBrowser commit.
Fix to make ICNS loading more stable.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26993 72102866-910b-0410-8b05-ffd578937521
2008-10-31 09:53:21 +00:00
fedor
ce41d782c1 Revert library license version to 2 until applications can be converted
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
fredkiefer
6212a911c4 Propagate settings from NSBrowser to underlying matrixes.
Stronger typing in NSBrowser.
Clearer drawing code in different classes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26020 72102866-910b-0410-8b05-ffd578937521
2008-02-02 21:01:43 +00:00
fredkiefer
aa25aa65c7 Get titles of browser working for browser loaded from Gorm file.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25550 72102866-910b-0410-8b05-ffd578937521
2007-11-01 14:16:19 +00:00
fredkiefer
e25cceb710 Change all files to use GPL 3 and LGPL 3.
Prepare for next release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00
fredkiefer
a7ba44ca0b Add MacOSX 10.3 methods and constants.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25362 72102866-910b-0410-8b05-ffd578937521
2007-07-28 13:41:18 +00:00
stoyan
9a62b838d3 * Source/NSBrowser.m: ([drawWithFrame:inView:]) pass inset rect by
1 to drawInteriorWithFrame:.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25224 72102866-910b-0410-8b05-ffd578937521
2007-06-06 23:56:26 +00:00
ratmice
7a8d12467d * Source/NSBrowser.m (-doClick:): Don't reselect the selected cells.
Fixes bug #18881
        * Source/NSMatrix.m (-_selectPreviousSelectableCellBeforeRow:column):
        Update _selectedCells for the new selection.
        (-_selectNextSelectableCellAfterRow:column:):
        Ditto.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24483 72102866-910b-0410-8b05-ffd578937521
2007-02-06 10:13:43 +00:00
rfm
cc3cafa874 tidyups and minor theme tiling updates.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23871 72102866-910b-0410-8b05-ffd578937521
2006-10-15 08:34:47 +00:00
rfm
8bf3cdc94e theme reorganisation/tidy up
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23586 72102866-910b-0410-8b05-ffd578937521
2006-09-22 11:53:40 +00:00
fredkiefer
fb90084f9a Moved variable declaration to work with older compilers.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23320 72102866-910b-0410-8b05-ffd578937521
2006-08-21 12:09:38 +00:00
gcasa
e30f29705f * Source/NSBrowser.m: Added comment in encodeWithCoder:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23316 72102866-910b-0410-8b05-ffd578937521
2006-08-19 19:56:47 +00:00
gcasa
d24ee43d13 * Source/NSBrowserCell.m: Improved encoding and decoding in
encodeWithCoder: and initWithCoder:
	* Source/NSBrowser.m: Improved encoding and decoding in
	encodeWithCoder: and initWithCoder:
	* Source/NSScrollView.m: Improved encoding and decoding in
	encodeWithCoder: and initWithCoder:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23315 72102866-910b-0410-8b05-ffd578937521
2006-08-19 14:34:52 +00:00
gcasa
f6fb00fad1 Prevent initWithCoder: from calling initWithFrame: in NSView. According to the documentation, initWithFrame: should not be called when the view is unarchiving itself. Similar changes were needed in other classes since they depended on this call to initialize themselves, so some init code was added to initWithCoder:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23143 72102866-910b-0410-8b05-ffd578937521
2006-07-07 01:39:16 +00:00
Fabien_
7830a54ae8 Improved documentation
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22101 72102866-910b-0410-8b05-ffd578937521
2005-11-25 11:23:28 +00:00
CaS
6988bf34c2 Coding style fixups
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22019 72102866-910b-0410-8b05-ffd578937521
2005-11-16 11:34:25 +00:00
Fabien_
2ef2559a75 Improve documentation
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@21968 72102866-910b-0410-8b05-ffd578937521
2005-11-08 15:27:06 +00:00