Commit graph

486 commits

Author SHA1 Message Date
ericwa
0095d55636 * Source/NSWindow.m: Only invoke -prepareForDragOperation: if the
most recent -draggingEntered: or -draggingUpdated: call returned
something other than NSDragOperationNone.
* Source/NSOutlineView.m (-draggingUpdated:): Save the drag operation
value returned from the data source in a static variable.
Previously it was fetched once and then discarded, so all drags were
being mistakenly permitted.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34910 72102866-910b-0410-8b05-ffd578937521
2012-03-09 08:03:45 +00:00
fredkiefer
972f5fa575 * Source/NSWindow.m (-setFrameFromString:): Correct bug in
handling of in-window menus.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34798 72102866-910b-0410-8b05-ffd578937521
2012-02-20 17:46:28 +00:00
fredkiefer
ccf59ac3ca Replace some occurences of int with NSInteger
and unsigned with NSUInteger. This allows to recompile gui on 
64 bit systems after the change to NSNotFound in base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
fredkiefer
b678eba9cb * Source/NSAnimation.m (NSViewAnimation -dealloc): Use DESTROY
instead of RELEASE as _viewAnimationDesc to prevent segmentation
        fault in super call.
        * Source/NSWindow.m (-setFrame:display:animate:): Use
        NSViewAnimation instead of local blocking code.
        * Source/NSWindow.m (-animationResizeTime:): Use abs() in all
        * directions.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33624 72102866-910b-0410-8b05-ffd578937521
2011-07-24 18:53:07 +00:00
fredkiefer
e04f21516d Unbind key bindings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33511 72102866-910b-0410-8b05-ffd578937521
2011-07-11 08:40:31 +00:00
wlux
479baf70bf Fix management of windows whose hide on deactivate attribute is set.
In particular, such windows remain ordered out when the application
orders them out while it is not active and then is activated again.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33213 72102866-910b-0410-8b05-ffd578937521
2011-05-31 09:59:48 +00:00
theraven
dbd4c1b77c Turn release messages sent to autorelease pools into drain messages. No
functionality change in non-GC mode, in GC mode it invokes a quick GC pass to
try to delete the short-lived objects.

Also deleted some [pool release] lines just before exit() or return-from-main
statements.  These cause objects to be swapped in and destructors to be run to
no benefit (the OS will reclaim this memory without requiring stuff to be
swapped in when the process exits).



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33146 72102866-910b-0410-8b05-ffd578937521
2011-05-27 12:42:37 +00:00
ericwa
899b4e5139 * Source/NSWindow.m: Remove unnecessary FIXMEs related to
user space scale factor
* Source/NSAppliation.m: Correct app icon sizing which was
mixing up window frame coordinates and user space coordinates
* Source/NSCachedImageRep.m: Add NSUnscaledWindowMask to the
window used internally


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32897 72102866-910b-0410-8b05-ffd578937521
2011-04-19 08:23:01 +00:00
fredkiefer
a823988b7a Release the key value binding as it will be
retained in the binding table.
Leak found by static code analyser.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32484 72102866-910b-0410-8b05-ffd578937521
2011-03-07 13:35:37 +00:00
fredkiefer
de705cc3db * Source/GSNibLoading.m (NSCustomView): Correct implementation of
-initWithCoder: and remove -awakeAfterUsingCoder:.
* Source/NSSound.m: Remove method -awakeAfterUsingCoder:.
* Source/NSWindow.m (-_captureMouse:, -_releaseMouse:) Add some
  debug log code here to simplify debugging these methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32460 72102866-910b-0410-8b05-ffd578937521
2011-03-05 16:10:43 +00:00
fredkiefer
7c2a5cddf0 Fix memory leaks found by analyser.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32255 72102866-910b-0410-8b05-ffd578937521
2011-02-20 22:36:49 +00:00
fredkiefer
6d94be87c6 Remove direct usage of isa.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32248 72102866-910b-0410-8b05-ffd578937521
2011-02-20 18:24:44 +00:00
fredkiefer
f2c7420e36 Bug fix to last commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32177 72102866-910b-0410-8b05-ffd578937521
2011-02-15 21:48:00 +00:00
fredkiefer
75e90462d5 Revert Wolfgangs change and add a different solution as explained in his mail.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32176 72102866-910b-0410-8b05-ffd578937521
2011-02-15 19:50:54 +00:00
wlux
13e3cc042d Add user default to allow placing app icons and mini windows at normal
window level. This is particularly convenient with some window
managers (*cough*, kwin) where application and pop up menus would be
obscured by dock level windows.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32165 72102866-910b-0410-8b05-ffd578937521
2011-02-14 22:25:57 +00:00
wlux
41ae772523 Fix bug where a stray view could leak when changing the content view
of a window. This view then could make the title bar buttons
inaccessible when -gui handles window decorations.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32163 72102866-910b-0410-8b05-ffd578937521
2011-02-14 22:11:26 +00:00
fredkiefer
475f2d07aa Remove dead assignments found by static code analysis.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32022 72102866-910b-0410-8b05-ffd578937521
2011-02-09 22:20:00 +00:00
wlux
b76ae956ac Improve last but one commit by not including an in-window menu in a
window's saved frame as well. Also avoid a redundant cast from float
to int and back.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31941 72102866-910b-0410-8b05-ffd578937521
2011-01-24 13:19:30 +00:00
wlux
c1c4e6e3ea Merge change from the testplant_1 branch:
Do not include the toolbar in a window's saved frame. Makes saving and
restoring window frame sizes independent of whether the toolbar is
present at the time when the frame is saved or restored.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31939 72102866-910b-0410-8b05-ffd578937521
2011-01-24 08:59:10 +00:00
espectador
b3d789fcec Applied changes in menuInWindow.patch
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31895 72102866-910b-0410-8b05-ffd578937521
2011-01-16 00:32:54 +00:00
wlux
865193b4bf Rename color (list) change notifications to match Cocoa (and OpenStep).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31893 72102866-910b-0410-8b05-ffd578937521
2011-01-15 19:28:24 +00:00
espectador
4122ebfd3f Fixed the behaviour of menu in window when hide the app
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31859 72102866-910b-0410-8b05-ffd578937521
2011-01-09 06:10:02 +00:00
wlux
8e7f35e5e6 Don't show a toolbar customization palette for a toolbar when user
customization is disabled.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31799 72102866-910b-0410-8b05-ffd578937521
2010-12-30 18:58:12 +00:00
nicola
b854f2da8a Explicitly encode/decode enumerated types as 'int' which is what all
the existing archives use (even if it is incorrect as in many cases
the types are actually 'unsigned int')


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31785 72102866-910b-0410-8b05-ffd578937521
2010-12-27 11:57:04 +00:00
wlux
43e10b9aa1 Allow any window that responds YES to -worksWhenModal to become key in
a modal session.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31714 72102866-910b-0410-8b05-ffd578937521
2010-12-07 07:55:48 +00:00
wlux
3e2112f215 Do not discard close requests for a window in a modal session when the
window has -worksWhenModal==YES.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31653 72102866-910b-0410-8b05-ffd578937521
2010-11-26 16:07:19 +00:00
fredkiefer
54f345dd83 * Source/NSWindow.m (-validRequestorForSendType:returnType:):
Don't forward this method if the delegate is a NSResponder.
Patch by Georg Fleischmann <G.Fleischmann@vhf.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31586 72102866-910b-0410-8b05-ffd578937521
2010-11-03 20:06:00 +00:00
ericwa
82ac6117e8 Replace sel_eq with sel_isEqual
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31285 72102866-910b-0410-8b05-ffd578937521
2010-09-09 23:50:38 +00:00
fredkiefer
da660947da Correction of last changes as pointed out by Derek Fawcus
<dfawcus@employees.org>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31032 72102866-910b-0410-8b05-ffd578937521
2010-07-26 11:05:07 +00:00
fredkiefer
7957a90007 Add support for backtab character.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31026 72102866-910b-0410-8b05-ffd578937521
2010-07-25 20:51:40 +00:00
wlux
e225579e41 Avoid a race with some lame window managers, which could lead to a
crash when a window is closed and deallocated while a tool tip is
visible.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30513 72102866-910b-0410-8b05-ffd578937521
2010-05-31 21:55:33 +00:00
fredkiefer
e64aca8bb2 few compiler warning fixes plus a lot of #import replacement.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30448 72102866-910b-0410-8b05-ffd578937521
2010-05-24 10:48:14 +00:00
wlux
afd9a10680 Fix a rather long standing incompatibility between GNUstep and Cocoa
and make -initWithContentRect:styleMask:backing:defer: the designated
initializer of NSWindow.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30368 72102866-910b-0410-8b05-ffd578937521
2010-05-12 14:47:10 +00:00
fredkiefer
b308995696 Make dealloc of NSWindow a tiny bit saver.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30321 72102866-910b-0410-8b05-ffd578937521
2010-05-08 20:18:14 +00:00
dpsimons
a3603ff386 Handle nil view passed to _checkTrackingRectangles:forEvent:
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30233 72102866-910b-0410-8b05-ffd578937521
2010-04-24 17:21:22 +00:00
dpsimons
259dc054b6 fix problems with overlaps between toolbars, window contents, and in-window menus
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30206 72102866-910b-0410-8b05-ffd578937521
2010-04-20 19:37:10 +00:00
rmottola
ee1aa5dc70 removed c99-ism
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30144 72102866-910b-0410-8b05-ffd578937521
2010-04-13 22:54:33 +00:00
ericwa
f2fd7b10c2 Fix for delivery of rightMouseDragged: and otherMouseDragged: which were not working
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30120 72102866-910b-0410-8b05-ffd578937521
2010-04-11 00:31:59 +00:00
dpsimons
d5c7b875c9 Fix crash caused by close being called recursively
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30087 72102866-910b-0410-8b05-ffd578937521
2010-04-05 16:07:46 +00:00
wlux
b69e5ffdbd Remove a stray semicolon, which made NSWindow ignore all GSAppKitWindowLeave
events. This was the cause for, e.g., somewhat too sticky tooltips.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30075 72102866-910b-0410-8b05-ffd578937521
2010-03-30 07:28:05 +00:00
theraven
14205ea54b Removed all uses of @defs() from -gui, so it now compiles cleanly with the non-fragile ABI. All ivars that must be accessed from other classes are now wrapped in PACKAGE_SCOPE. With clang, this expands to @package, with GCC it expands to @public.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30045 72102866-910b-0410-8b05-ffd578937521
2010-03-27 00:01:03 +00:00
fredkiefer
46bba406d0 Add two Cocoa debug helper methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29924 72102866-910b-0410-8b05-ffd578937521
2010-03-13 15:17:21 +00:00
jonathanosx
5c1cbe5755 Fix to prevent restoring an NSWindowFrame to a completely off-screen location.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29747 72102866-910b-0410-8b05-ffd578937521
2010-02-25 18:30:10 +00:00
gcasa
87c74dc4c2 * Source/NSWindow.m: Remove private menu - (void) _menuUpdate, since
it was causing performance issue on windows as the menu was updating
	each time through the runloop.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29668 72102866-910b-0410-8b05-ffd578937521
2010-02-18 22:19:27 +00:00
rmottola
d1ecd0f9e2 revert accidental commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29544 72102866-910b-0410-8b05-ffd578937521
2010-02-11 11:22:52 +00:00
rmottola
e536c19dce do not draw form background
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29534 72102866-910b-0410-8b05-ffd578937521
2010-02-10 11:14:21 +00:00
qmathe
613b3813bd Fixed button actions which were sent to the button itself when the target is
the first responder. We don't give anymore the first responder status to a 
button on a click.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29471 72102866-910b-0410-8b05-ffd578937521
2010-02-03 19:12:02 +00:00
gcasa
48a4ef2ece * Source/NSWindow.m: Uncomment updateMenu:.. method call in
-[NSWindow update] method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29383 72102866-910b-0410-8b05-ffd578937521
2010-01-24 08:05:45 +00:00
gcasa
3daab3781d Update menu code and set menu on window creation.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29373 72102866-910b-0410-8b05-ffd578937521
2010-01-23 23:41:07 +00:00
rmottola
13e9913ec8 do not process GSAppKitWindowLeave events for closed windows
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29332 72102866-910b-0410-8b05-ffd578937521
2010-01-20 14:58:59 +00:00