gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-30 10:10:39 +00:00
Code Issues Projects Releases Packages Wiki Activity
9622 commits 87 branches 112 tags 32 MiB
Commit graph

277 commits

Author SHA1 Message Date
Gregory John Casamento
b2cf3b32a2 Merged master into NSTreeController_branch 2024-04-27 07:06:48 -04:00
Gregory Casamento
82dce67eb4
Reduce code duplication in GSThemeDrawing table/outline view drawing methods (#262) 
* Reduce code duplication in drawViewCell:... method

* Further reduce code duplication, add common private method for calculating starting and ending column

* Use the tableView in the method that calculates the starting and ending rows

* Add code to properly handle prototypeViews, the XIB is NOT split, I was confused

* Call awakeFromNib on view as well

* Refactor so that the outlineColumn drawing code is shared

* Adjust the image drawing and the clickable area to be more aligned also make it easier to expand or collapse an item in the outline view
 2024-04-26 18:40:11 +02:00
Gregory John Casamento
3ff5efed30 Encapsulate the renderedPaths and pathsToViews ivars that track which views were displayed in a viewBased table 2024-04-22 09:00:53 -04:00
Gregory John Casamento
42bae42431 Fix issues mentioned by @fredkiefer 2024-04-22 09:00:53 -04:00
Gregory John Casamento
e55babb04e Add code to handle Title property on NSTableColumn, add code to NSTableView to set the table view to _viewBased if it responds to tableView:viewForTableColumn:row: 2024-04-22 09:00:53 -04:00
Gregory John Casamento
f787edfcfb Consolidate and refactor the cellview methods in the theme drawing code, so that there is no repeated code 2024-04-22 09:00:53 -04:00
Gregory John Casamento
fbb94af67b Add methods to register views 2024-04-22 09:00:53 -04:00
Gregory John Casamento
d9d4f63c24 Whitespace cleanup 2024-04-22 09:00:53 -04:00
Gregory John Casamento
8d9cb6f933 Add logic to get the column / row for a given view 2024-04-22 09:00:53 -04:00
Gregory John Casamento
182427bf97 Add code to support item identifier to NSTableView 2024-04-22 09:00:53 -04:00
Gregory John Casamento
f71ee8641b Initial changes for NSOutlineView view-based support 2024-04-22 09:00:53 -04:00
Gregory John Casamento
d99f82896b Remove uneeded checks for _viewBased 2024-04-22 09:00:53 -04:00
Gregory John Casamento
e19038665b Use an NSMapTable to store which views have been displayed 2024-04-22 09:00:53 -04:00
Gregory John Casamento
a73c3cc876 Add code to track if a view has been rendered, fix issue with duplication of the view, I am not sure if this method of tracking that the view has been rendered is correct, but it works for now 2024-04-22 09:00:53 -04:00
Gregory John Casamento
20f29b2d1d Add code to cause delegate methods which are not used for viewBased tables to be called in viewBased mode, add code to instantiate the prototypeCellView when adding it to the tableView 2024-04-22 09:00:53 -04:00
Gregory John Casamento
ebdbe0930f Add methods to theme and to NSTableView to get the view from the delegate, this is a partial commit to save my place here... will follow up shortly 2024-04-22 09:00:53 -04:00
Gregory John Casamento
0be95eba5b Update gorm version and add new code to store/retrieve NSViewBased key 2024-04-22 09:00:53 -04:00
Gregory John Casamento
0276e307cc Fix compile error, add new class 2024-04-22 09:00:53 -04:00
Gregory John Casamento
20a08a894f Minor updates 2024-04-22 09:00:53 -04:00
Gregory John Casamento
3acf49a33d Fix compile error, add new class 2024-04-22 09:00:53 -04:00
Gregory John Casamento
a7a7a1e691 Minor updates 2024-04-22 09:00:53 -04:00
Frederik Carlier
85b8a3e495
[NSTableView initWithCoder]: Read alternatingRowBackgroundColors, from tableViewFlags (#252) 
* [NSTableView initWithCoder]: Read alternatingRowBackgroundColors,  from tableViewFlags

* [NSTableView _numRows]: Check _tableColumns is not empty

* [NSTableView encodeWithCoder]: add autosaveTableColumns, usesAlternatingRowBackgroundColors
 2024-04-03 23:54:10 +02:00
Gregory John Casamento
9dc09bed61 Move Outline drawing code to GSThemeDrawing category 2023-10-01 08:00:04 -04:00
Riccardo
62d16bff24
Implement acceptsFirstMouse so to return YES, otherwise tablees in new windows do not get mouse selection events. (#173) 
Seems to match Apple's implementation.
 2023-03-02 12:13:50 +01:00
Gregory John Casamento
98ebe51150 Remove exception when [indexes lastIndex] > numberOfColumns 2021-10-13 13:54:43 -04:00
Fred Kiefer
a4ec02e613 * Source/NSTableView.m (-_numRows): Take column value binding into 
consideration.
* Source/NSTableColumn.m (-setValue:forKey:): Reload table data.
 2021-01-22 22:48:13 +01:00
fredkiefer
36772d25a1 * Source/NSTableView.m (-validateEditing): Reset _isValidating on 
intermediate return.
Patch by Andreas Höschler <ahoesch@smartsoft.de>.
 2020-10-18 23:52:19 +02:00
fredkiefer
09853bffc8 Fix indentation 2020-01-20 19:10:15 +01:00
fredkiefer
00bb2396a6 Diverse imporvements to get my XIB5 test application running. 2020-01-18 16:03:24 +01:00
fredkiefer
97cb13a5ff Add some more bindings 2020-01-10 20:53:53 +01:00
fredkiefer
8e57d2a127 * Documentation/news.texi: Fill in some details for pending release. 
* Source/NSTableView.m (encodeWithCoder:,initWithCoder:): Use
unsigned int instead of unsigned long for flags.
 2019-01-04 17:01:57 +01:00
Fred Kiefer
099257dac9 Fix some clang static analyser warnings reported by 
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40484 72102866-910b-0410-8b05-ffd578937521
 2017-04-16 11:54:21 +00:00
Fred Kiefer
2b401268fc Don't try to get the advancement for GSAttachmentGlyph. 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40272 72102866-910b-0410-8b05-ffd578937521
 2016-12-18 11:58:31 +00:00
Fred Kiefer
6974bf8a4f Some int -> NSInteger and float -> CGFloat transitions. 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40138 72102866-910b-0410-8b05-ffd578937521
 2016-10-08 21:17:53 +00:00
Richard Frith-MacDonald
08910fb913 lintian spelling correctes provided by Eric Heintzmann 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39816 72102866-910b-0410-8b05-ffd578937521
 2016-05-28 09:49:15 +00:00
Riccardo Mottola
fab20ad389 Add NSTableViewSelectionHighlightStyle type and stub accessors 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39019 72102866-910b-0410-8b05-ffd578937521
 2015-10-02 09:47:29 +00:00
Fred Kiefer
903a37dd68 * Headers/AppKit/NSTableView.h, 
* Source/NSTableView.m:
        Create working stubs for table view batch insertions/removals of
rows
        Patch by Marcian Lytwyn <gna@advcsi.com>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38240 72102866-910b-0410-8b05-ffd578937521
 2014-12-08 15:08:53 +00:00
Fred Kiefer
9600bd7614 * Source/NSTableView.m (-numberOfRows): Return the current number 
of rows not the internal cached value.
  Replace some occurences of int with NSInteger
  and unsigned with NSUInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37461 72102866-910b-0410-8b05-ffd578937521
 2013-12-13 15:08:32 +00:00
Eric Wasylishen
4e1aeabe94 * Source/NSTableView.m (-tile): Check the GSScrollViewNoInnerBorder 
user default to see whether to expand the corner view by 1pt or not.
* Source/GSThemeDrawing.m (-drawTableHeaderRect:inView:): Remove
special case which reduced the width of the last column header by 1pt.

I don't see any reason for doing that and it looks better to me without
the gap, and more uniform for themeing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37237 72102866-910b-0410-8b05-ffd578937521
 2013-10-15 20:33:46 +00:00
Fred Kiefer
18d741ce80 * Source/NSTableView.m (-selectedColumnIndexes, 
* -selectedRowIndexes): Return an
        autoreleased copy of the corresponding ivar. Returning a
reference to the ivar
        leads to issues (and behavior different from Cocoa) when
iterating thru the
        indexsets if at a time they would be being altered.
        Patch by Frank LeGrand (flegrand@testplant.com).
        * Source/GNUmakefile: Add NSCollectionViewItem.
        * Headers/AppKit/NSCollectionView.h,
        * Headers/AppKit/NSCollectionViewItem.h,
        * Source/NSCollectionViewItem.m,
        * Source/NSCollectionView.m: Bring closer to the GNUstep coding
        * standard.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36551 72102866-910b-0410-8b05-ffd578937521
 2013-04-21 13:28:47 +00:00
Fred Kiefer
6b09581658 * Source/NSTableView.m: Use new method -_isCellSelectableColumn:row:, 
that checks the cells selectable state, in -mouseDown:.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36363 72102866-910b-0410-8b05-ffd578937521
 2013-03-15 16:39:31 +00:00
Fred Kiefer
14584bb4e2 * Source/NSTableColumn.m (-initWithCoder:): Make columns 
non-editable by default.
* Source/NSTableView.m (-editColumn:...select:): Make editing
here independ of the datasource.
* Source/NSTableView.m: Split -_isCellEditableColumn:row: in two
methods and ignore the cell isEditable state in -mouseDown:.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36307 72102866-910b-0410-8b05-ffd578937521
 2013-03-08 11:51:51 +00:00
Quentin Mathe
478148da52 Fixed typo in comment 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36171 72102866-910b-0410-8b05-ffd578937521
 2013-02-19 17:01:31 +00:00
Quentin Mathe
b3c302d8c4 Cleaned drop handling code a bit more in NSTableView 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36170 72102866-910b-0410-8b05-ffd578937521
 2013-02-19 16:59:21 +00:00
Quentin Mathe
da5449b7a8 Don't update the drop row and operation if the drop target hasn't changed (this prevents to overwrite a custom drop row and operation set by the user) 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36169 72102866-910b-0410-8b05-ffd578937521
 2013-02-19 16:03:28 +00:00
Quentin Mathe
f896752208 Extracted table view drop indicator drawing from -draggingUpdated: into a new method -_drawDropIndicator 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36168 72102866-910b-0410-8b05-ffd578937521
 2013-02-19 15:57:04 +00:00
Quentin Mathe
fea485cea2 Modularized the first part of -draggingUpdated: into several smaller methods 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36167 72102866-910b-0410-8b05-ffd578937521
 2013-02-19 15:18:53 +00:00
Fred Kiefer
0c95f32580 More CGFloat, NSUInteger and NSInteger changes. 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36163 72102866-910b-0410-8b05-ffd578937521
 2013-02-17 22:44:47 +00:00
Quentin Mathe
e4e5428122 Replaced -_dataCellForTableColumn:row: by -preparedCellAtColumn:row: new public method from Mac OS X 10.5 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36136 72102866-910b-0410-8b05-ffd578937521
 2013-02-14 10:34:20 +00:00
Fred Kiefer
d4f80c2258 Change NSEvent to CGFloat, NSUInteger and NSInteger. 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36121 72102866-910b-0410-8b05-ffd578937521
 2013-02-13 08:40:36 +00:00