Commit graph

166 commits

Author SHA1 Message Date
Fred Kiefer
cc412d3a43 Set the background colour of the text object and make it draw its
background.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25091 72102866-910b-0410-8b05-ffd578937521
2007-04-27 14:15:39 +00:00
Fred Kiefer
01e550219a Corrected handling of _allowsEmptySelection in noteNumberOfRowsChanged.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25070 72102866-910b-0410-8b05-ffd578937521
2007-04-24 19:09:10 +00:00
Matt Rice
7030dbfbb9 * Source/NSTableView.m (-_numRows): New quasi private method.
(-noteNumberOfRowsChanged:): Call _numRows instead of data source
        method.
        * Source/NSOutlineView.m (-noteNumberOfRowsChanged:): Don't override
        supers.
        (-_numRows): Implement.
        (-collapseItem:collapseChildren:): Remove use of _selectedObjects.
        (-expandItem:expandChildren:): Ditto.
        (-_removeChildren:): Ditto.
        (-initWithFrame:): Don't initialize _selectedObjects.
        (-initWithCoder:): Ditto.
        * Headers/AppKit/NSOutlineView.h: Mark _selectedObjects as unused.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24478 72102866-910b-0410-8b05-ffd578937521
2007-02-06 01:07:44 +00:00
Matt Rice
1c2821470e * Source/NSTableView (-mouseDown:): Release oldSelectedRows.
Mark done as yes instead of returning early, and avoid sending action
        multiple times.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24469 72102866-910b-0410-8b05-ffd578937521
2007-02-05 08:04:10 +00:00
Matt Rice
2d12498c2e * Source/NSTableView (-mouseDown:): Compute the selection immediately
instead of at the end of the loop.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24468 72102866-910b-0410-8b05-ffd578937521
2007-02-05 06:15:42 +00:00
Matt Rice
16fcaeab83 * Source/NSTableView.m (-mouseDown:): Return early after tracking a
cell which prefersTrackingUntilMouseUp.
        * Source/NSPopUpButtonCell.m (+prefersTrackingUntilMouseUp:): Return
        yes.
        (-trackMouse:inRect:ofView:untilMouseUp:): Return yes or no
        depending on whether the mouse went up inside the menu or not.
        Fixes bug #18946



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24465 72102866-910b-0410-8b05-ffd578937521
2007-02-04 12:53:49 +00:00
Matt Rice
0a9783724b * Source/NSTableView.m: Revert previous patch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24431 72102866-910b-0410-8b05-ffd578937521
2007-01-30 03:37:11 +00:00
Matt Rice
c222792abd * Source/NSTableView.m (-textDidEndEditing:): Add missing break
to previous commit.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24426 72102866-910b-0410-8b05-ffd578937521
2007-01-28 21:00:11 +00:00
Matt Rice
a4eddcb158 * Source/NSTableView.m (-textDidEndEditing:): Handle
NSIllegalTextMovement.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24425 72102866-910b-0410-8b05-ffd578937521
2007-01-28 18:20:54 +00:00
Fred Kiefer
91dccc4280 Mark for redisplay when selecting or deselecting the whole table.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24403 72102866-910b-0410-8b05-ffd578937521
2007-01-23 15:46:42 +00:00
Fred Kiefer
ebc0de97f3 Added MacOSX 10.4 methods to NSControl and reworked the whole cell
editing mechanism.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24380 72102866-910b-0410-8b05-ffd578937521
2007-01-18 17:24:33 +00:00
Matt Rice
a61f6e5479 * Source/NSTableView.m (rectOfColumn:): Use the height of the rows,
not the bounds.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24290 72102866-910b-0410-8b05-ffd578937521
2006-12-28 23:18:44 +00:00
Matt Rice
640612f030 * Source/NSTableView.m (_trackCellAtColumn:row:withEvent:):
Remove check for column editablity.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24152 72102866-910b-0410-8b05-ffd578937521
2006-11-23 11:57:03 +00:00
Matt Rice
4475b975b8 * Source/NSTableView.m (-noteNumberOfRowsChanged:): Post selection
is and did change notifications if changing the selected rows.
        * Source/NSSliderCell.m (-copyWithZone:): Make a little clearer.
        * Source/NSMatrix.m (-_rebuildLayoutAfterResize): Don't change the
        intercell spacing if not autosizing cells.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24080 72102866-910b-0410-8b05-ffd578937521
2006-11-13 05:23:24 +00:00
Matt Rice
84a0a59321 * Source/NSOutlineView.m: Handle rowAtPoint: returning -1.
* Source/NSTableView.m (drawRect:): Only call
        -highlightSelectionInClipRect: and -drawGridInClipRect: once.
        (-drawGridInClipRect:): Constrain the vertical grid line to the last
	 row drawn in the rect.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24071 72102866-910b-0410-8b05-ffd578937521
2006-11-10 19:12:32 +00:00
Matt Rice
86c8735342 * Source/NSTableView.m (rowAtPoint:): Return -1 if the point is under
the last row.
        (mouseDown:): Handle rowAtPoint: returning -1.
        (rectOfRows:): Ditto.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24070 72102866-910b-0410-8b05-ffd578937521
2006-11-10 17:05:20 +00:00
Matt Rice
edf055a980 * Source/NSTableView.m (mouseDown:): Rename some local variables
to be less ambiguous.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24068 72102866-910b-0410-8b05-ffd578937521
2006-11-10 14:35:31 +00:00
Matt Rice
1fcec7ffe9 * Headers/AppKit/NSTableView.h: Add ivar for
verticalMotionCanBeginDrag.
        * Source/NSTableView.m: Implement verticalMotionCanBeginDrag
        bump class version.
        * Source/NSTextView_actions.m: Fix method name from previous changes.
        * KeyBindings/DefaultKeyBindings.dict: Add new key bindings.
        * ChangeLog: Add to description of a previous change.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24067 72102866-910b-0410-8b05-ffd578937521
2006-11-10 13:40:28 +00:00
Matt Rice
affd41f5b1 * Source/NSTableView.m (selectContiguousRegion): Remove usage of
offsets.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24060 72102866-910b-0410-8b05-ffd578937521
2006-11-09 12:59:04 +00:00
Matt Rice
ab28e892bb * Source/NSTableView.m: Implement keyboard navigation/selection.
Fixes bug #11942.
        (-selectRow:byExtendingSelection:): Update _clickedRow.
        (-mouseDown:): Ditto.
        * Source/NSSlider.m (keyDown:): Call supers implementation if we don't
        use the key stroke.




git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24054 72102866-910b-0410-8b05-ffd578937521
2006-11-09 01:28:58 +00:00
Matt Rice
e2e8357e71 * Source/NSTableView.m: Whitespace changes to conform to coding
standards.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24049 72102866-910b-0410-8b05-ffd578937521
2006-11-07 10:46:10 +00:00
Matt Rice
55623d70f7 * Source/NSTableView.m (-mouseDown): Only call editWithFrame: from a
double click. Don't track cells from a mouse dragged.
        Add comments.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24048 72102866-910b-0410-8b05-ffd578937521
2006-11-07 10:26:57 +00:00
Matt Rice
a138f13d9c * Source/NSTableView (_editNextCellAfterRow:inColumn:):
Wrap around when number of rows is exceeded.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24019 72102866-910b-0410-8b05-ffd578937521
2006-11-03 09:44:05 +00:00
Matt Rice
ece0182c72 * Source/NSTableView.m:
(-editColumn:row:withEvent:select:): Raise when passed an unselected
        row.
        (-textDidEndEditing:): Handle NSReturnTextMovement.
        (_editNextCellAfterRow:inColumn:): New private method.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24008 72102866-910b-0410-8b05-ffd578937521
2006-11-01 10:17:55 +00:00
Matt Rice
3d20848a26 * Source/NSTableView.m: Add new private methods.
(-mouseDown:): Reorganize and don't track cells until dragging
        has been ruled out.
        * Source/NSCell.m (trackMouse:inRect:ofView:untilMouseUp:):
        Handle events no longer in the queue.
        * Source/GSDragView.m: Change NSLog to NSDebugLLog.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24007 72102866-910b-0410-8b05-ffd578937521
2006-11-01 09:50:00 +00:00
Matt Rice
d1397ca777 * Source/NSTableView.m (-setFrame:,-setFrameSize:): Use
documentVisibleRect. Shrink if table is larger than needed height.
        fixes bug #18117.
        (-drawBackgroundInClipRect:): Draw the background.
        * Source/NSClipView.m (-documentVisibleRect:): Return the clip views
        visible rect converted to the document views coordinate system.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23972 72102866-910b-0410-8b05-ffd578937521
2006-10-27 17:48:54 +00:00
Matt Rice
36e68226f8 * Source/NSTableView.m (-mouseDown:): Check for empty selection.
when adding to the current selection. Fixes bug #15261.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23945 72102866-910b-0410-8b05-ffd578937521
2006-10-22 18:26:31 +00:00
Gregory John Casamento
c687a15b00 Minor indentation cleanup.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23932 72102866-910b-0410-8b05-ffd578937521
2006-10-21 15:41:51 +00:00
Gregory John Casamento
f4cd637e0d Correction for #bug9608 and bug#18073.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23931 72102866-910b-0410-8b05-ffd578937521
2006-10-21 15:34:16 +00:00
Richard Frith-MacDonald
57435da7d5 tidyups and minor theme tiling updates.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23871 72102866-910b-0410-8b05-ffd578937521
2006-10-15 08:34:47 +00:00
Matt Rice
07eeaa998d * Source/NSTableView.m (_shouldEditTableColumn:row:):
Dont invert delegate return value.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23629 72102866-910b-0410-8b05-ffd578937521
2006-09-26 16:03:10 +00:00
Matt Rice
c0f89a63f2 * Source/NSTableView.m (_isCellEditableColumn:row:): Allow
delegate to limit editablility of editable columns.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23599 72102866-910b-0410-8b05-ffd578937521
2006-09-23 21:53:25 +00:00
Richard Frith-MacDonald
ed5990f599 theme reorganisation/tidy up
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23586 72102866-910b-0410-8b05-ffd578937521
2006-09-22 11:53:40 +00:00
Fred Kiefer
c7839ee576 Corrected bug in latest patch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23545 72102866-910b-0410-8b05-ffd578937521
2006-09-17 14:08:29 +00:00
Fred Kiefer
69a8fabe3d Allow read only table views to select the text in a cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23538 72102866-910b-0410-8b05-ffd578937521
2006-09-16 23:19:48 +00:00
Gregory John Casamento
aaa0f632ce * Source/NSTableView.m: initWithCoder: minor cleanup.
* Source/NSTextFieldCell.m: initWithCoder retain 
	text/background colors to prevent crash.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23339 72102866-910b-0410-8b05-ffd578937521
2006-08-26 22:28:47 +00:00
Gregory John Casamento
63e4a9aebd * Source/GSNibCompatibility.m: In [NSIBObjectData initWithCoder:]
clean up the buildMap calls.  In NSCustomResource retain the resource
	that is returned to prevent a crash.  Add dealloc method to 
	NSCustomObject.
	* Source/NSClipView.m: In initWithCoder: retain and release
	documentView before removing it from the view and resetting
	it as the document view.   This ensures that the view will
	not be deallocated.
	* Source/NSScrollView.m: Retain the contentView before exchanging
	it and then release to prevent the view from being deallocated in
	initWithCoder:
	* Source/NSTableView.m: Replace call to "new" with alloc/init for
	NSTableHeaderView in initWithCoder:
	* Source/NSView.m: in initWithCoder: keyed coding don't release
	the subs array since it's already autoreleased.  This was causing
	a crash.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23336 72102866-910b-0410-8b05-ffd578937521
2006-08-26 14:10:18 +00:00
Gregory John Casamento
baf3f68d20 encoding improvements.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23285 72102866-910b-0410-8b05-ffd578937521
2006-08-13 20:21:46 +00:00
Gregory John Casamento
74049ce6bc Added NSPSMatrix private class, added GS specific keys to NSProgressIndicator for info that GS encodes, but Cocoa doesn't. All GS specific keys shall have GS* as the prefix. Implemented encodeWithCoder: in NSTableColumn and corrected NSTable encoding to correct problems during IB loading.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23265 72102866-910b-0410-8b05-ffd578937521
2006-08-12 22:44:56 +00:00
Fred Kiefer
f2beece4f3 Small clean ups in NSView, NSTableView and the headers included in
AppKit.h


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23257 72102866-910b-0410-8b05-ffd578937521
2006-08-11 20:04:53 +00:00
Gregory John Casamento
48db9c7614 Correction for window size in -[NSWindowTemplate nibInstantiate]. Implemented encoding in encodeWithCoder: for some classes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23207 72102866-910b-0410-8b05-ffd578937521
2006-08-06 04:32:16 +00:00
Gregory John Casamento
53ca2a14c2 Prevent initWithCoder: from calling initWithFrame: in NSView. According to the documentation, initWithFrame: should not be called when the view is unarchiving itself. Similar changes were needed in other classes since they depended on this call to initialize themselves, so some init code was added to initWithCoder:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@23143 72102866-910b-0410-8b05-ffd578937521
2006-07-07 01:39:16 +00:00
Gregory John Casamento
d68950d71a Nib compatibility code merge.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22957 72102866-910b-0410-8b05-ffd578937521
2006-05-20 22:12:46 +00:00
Fred Kiefer
43537498de Adopted dragging destination method return values to MacOSX 10.4
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22893 72102866-910b-0410-8b05-ffd578937521
2006-05-10 22:11:28 +00:00
Fred Kiefer
d346b59f9f Small patches by Andreas Höschler to NSTableView and NSComboBoxCell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22861 72102866-910b-0410-8b05-ffd578937521
2006-05-05 22:41:40 +00:00
Fred Kiefer
fb2b9aa03e Intercell spacing change for NSTableView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22264 72102866-910b-0410-8b05-ffd578937521
2006-01-08 17:48:34 +00:00
Matt Rice
9bb51c5a9d * Source/NSTableView.m (-mouseDown:): Copy the selected cell before
tracking mouse, add comment. (patch previously reverted 2005-05-30)
(-mouseDown:): Check for pointer equality in addition to isEqual:
        which doesn't work with nil. (fix for bug #15316)


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22230 72102866-910b-0410-8b05-ffd578937521
2005-12-31 13:50:30 +00:00
Richard Frith-Macdonald
7971a89c72 Coding style fixups
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22019 72102866-910b-0410-8b05-ffd578937521
2005-11-16 11:34:25 +00:00
Fred Kiefer
162d86266e Applyed patch by Matt Rice.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@21269 72102866-910b-0410-8b05-ffd578937521
2005-05-30 17:01:21 +00:00
Fred Kiefer
eb7eaa1654 Improved mouseDown call handling for table view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@21262 72102866-910b-0410-8b05-ffd578937521
2005-05-26 13:38:11 +00:00