gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-05-06 02:10:43 +00:00
Code Issues Projects Releases Packages Wiki Activity
9850 commits 87 branches 112 tags 32 MiB
Commit graph

7234 commits

Author SHA1 Message Date
Gregory John Casamento
3acf49a33d Fix compile error, add new class 2024-04-22 09:00:53 -04:00
Gregory John Casamento
a7a7a1e691 Minor updates 2024-04-22 09:00:53 -04:00
Gregory John Casamento
d939fdfd1e Add objectValue accessors 2024-04-22 09:00:53 -04:00
Gregory John Casamento
edb517ceca Initial skeleton for NSTableCellView 2024-04-22 09:00:53 -04:00
Gregory John Casamento
968e78ab34 Add initial versions of NSTableCellView.[hm] and NSTableRowView.[hm] 2024-04-22 09:00:53 -04:00
williameveretteggplant
d1562a37cd
Left shift key equivalent modifier mask in xib unarchiver (#259) 
* Left shift key equivalent modifier mask in xib unarchiver

This is necessary to offset the 8 bit right shift that occurs in the initWithCoder: method in NSButtonCell

* Shift modifier mask in xib unarchiver
 2024-04-19 18:58:00 +02:00
williameveretteggplant
192c121a9d
Set editable property in NSCell default to false (#257) 
Unarchiving a NSCell element from a xib will have the editable property set to false unless explicitly set to true.
 2024-04-09 17:26:30 +02:00
williameveretteggplant
7b8c02182e
Fix NSImageView intercepting mouse events when not editable (#256) 
* Update NSImageView.m

* Refactor editable condition

* Remove empty line, left over from previous changes

---------

Co-authored-by: Fred Kiefer <fredkiefer@gmx.de>
 2024-04-08 20:54:47 +02:00
Frederik Carlier
892ed4877e
NSBox: (re-)implement isOpaque (#254) 
This (re-)implements logic where a box is marked
as opaque if it is a custom box which is not
transparent, but moves the logic to `GSTheme`,
allowing themes to override this loggic.

This fixes the rendering of custom boxes with a
custom fill color; the current implementation
would mark them as non-opaque and hence the fill
color would not be rendered.

- The original implementation (from 1999) always
  returned `YES`
  (53bcb50240)
- A more complete implementation was backported
  from the Testplant branch in 2012
  (e85b16bc05, by
  @fredkiefer, upstream commit
  36e77b95f7)
- More recently, the a return value of `NO` was
  hardcoded
  (02bc49e2d5, by
  @ericwa)
 2024-04-04 22:23:14 +02:00
Frederik Carlier
95f302442c
NSBox: decode NSBorderColor2 and NSFillColor2 (#255) 2024-04-04 20:34:42 +02:00
Frederik Carlier
85b8a3e495
[NSTableView initWithCoder]: Read alternatingRowBackgroundColors, from tableViewFlags (#252) 
* [NSTableView initWithCoder]: Read alternatingRowBackgroundColors,  from tableViewFlags

* [NSTableView _numRows]: Check _tableColumns is not empty

* [NSTableView encodeWithCoder]: add autosaveTableColumns, usesAlternatingRowBackgroundColors
 2024-04-03 23:54:10 +02:00
Frederik Carlier
059d13f5ab
highlightTableViewSelection: Always use default selection color if not set. (#253) 
The current implementation will attempt to assign a default value for selectionColor if backgroundColor is white.  There's two issues with that:

1. `backgroundColor` is likely in the `NSNamedColorSpace`,  whereas it is being compared to `[NSColor whiteColor]`, which is in the `NSCalibratedWhiteColorSpace`. That comparision will always return false.
2. Users will probably expect the selected item to be highlighted in a different color even if the background color is not white.  For example, the consider a scenario where the default background color is white, and the alternate background color is grey.  It makes sense to always highlight the selected row in blue.  This aligns with the behavior when `highlightedTableRowBackgroundColor` is defined.
 2024-04-03 23:43:33 +02:00
Frederik Carlier
f46accfa9c
GSXib5KeyedUnarchiver: Add mapping for NSSegmentItemLabel, NSSegmentItemImage (#251) 2024-04-03 23:24:22 +02:00
Frederik Carlier
c6082e31db
NSGraphicsContext: Suppress incompatible pointer type warning (#250) 
```
NSGraphicsContext.m:349:50: warning: incompatible pointer types sending 'Class' to parameter of type 'id<NSCopying>' [-Wincompatible-pointer-types]
      methods = [[classMethodTable objectForKey: [self class]] pointerValue];
                                                 ^~~~~~~~~~~~
/usr/local/include/Foundation/NSDictionary.h:115:26: note: passing argument to parameter 'aKey' here
  (GS_GENERIC_TYPE(KeyT))aKey;                          // Primitive
                         ^
NSGraphicsContext.m:354:37: warning: incompatible pointer types sending 'Class' to parameter of type 'id<NSCopying>' [-Wincompatible-pointer-types]
                            forKey: [self class]];
                                    ^~~~~~~~~~~~
```
 2024-04-01 22:54:57 +02:00
Frederik Carlier
c50123f870
GSTextStorage: Add function prototypes (#249) 
Add a function prototype for:
- `addImp` (`(void)addObject:(ObjectType)anObject`)
- `insImp` (`(void)insertObject:(ObjectType)anObject atIndex:(NSUInteger)index`)
- `remImp` (`(void)removeObject:(ObjectType)anObject`)
-  cntImp (`count`)

Fixes warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
 2024-04-01 22:53:23 +02:00
Frederik Carlier
4470a157d7
Remove unused variables (#247) 
Fixes a compiler warnings
 2024-04-01 21:05:46 +02:00
Frederik Carlier
1c26da1f27
NSInterfaceStyle: Fix void-pointer-to-enum-cast warning (#248) 
Cast to `uintptr_t` before casting to `enum` to suppress warning.

```
NSInterfaceStyle.m:134:15: warning: cast to smaller integer type 'NSInterfaceStyle' from 'void *' [-Wvoid-pointer-to-enum-cast]
      style = (NSInterfaceStyle)NSMapGet(styleMap, key);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NSInterfaceStyle.m:234:24: warning: cast to smaller integer type 'NSInterfaceStyle' from 'void *' [-Wvoid-pointer-to-enum-cast]
      if (newStyle != ((NSInterfaceStyle)val))
                       ^~~~~~~~~~~~~~~~~~~~~
```
 2024-04-01 16:49:46 +02:00
Frederik Carlier
2372b76cc8
This commits updates the libs-gui build process to generate a gnustep-gui.pc file which is installed in /lib/pkgconfig and contains the GNUstep gui version number, the libraries to link (equivalent to gnustep-config --gui-libs) with and the C flags to use (equivalent to gnustep-config --objc-flags). (#246) 
This can be useful when linking with libs-gui in projects which don't use the GNUstep build system.
 2024-03-27 23:39:23 +01:00
Fred Kiefer
c12fdd26f7 Set delegate of NSTextView to nil in dealloc. 2024-03-26 22:53:44 +01:00
Fred Kiefer
a054b21355 * Source/NSTextView.m: Add support for NSFilenamenPboardType. 
Change by OnFlApp (https://githup.com/onflapp)
 2024-03-18 22:53:46 +01:00
OnFlApp
1e956c96df
NSTextView: support drop for NSFilenamesPboardType (#156) 
* NSTextView: support drop for NSFilenamesPboardType

* code cleanup

* code fixes
 2024-03-18 22:35:29 +01:00
rfm
324308b4e8 fixup error in pasteboard types provided when png is available 2024-03-04 22:08:00 +00:00
Riccardo
7a215fcb01
Magick fix (#244) 
* Fix include for ImageMagick 7

* add version test for MagickCore and conditionally include the path to MagickCore.h

* autoreconf with 2.69
 2024-02-29 09:26:24 +01:00
rfm
cff4f39db3 Set timeout for pasteboard to 30 seconds rather than 2 (for slow providers). 2024-02-20 10:10:32 +00:00
ethanc8
9202dfeece Implement -appearannce, -setAppearance: and -effectiveApperance for NSView 2024-02-10 12:25:59 -06:00
ethanc8
12ca9f6996 Stylistic fixes for -[NSAppearance effectiveAppearance] 2024-02-05 15:27:03 -06:00
ethanc8
9db91f702e Rename the new NSScroller methods to the names used by Apple 2024-02-05 15:26:42 -06:00
ethanc8
61c9699021 Re-add layout code that was mistakenly removed 2024-02-05 14:43:31 -06:00
ethanc8
a91815f70a Add scroller styling options. 2023-12-31 20:05:11 -06:00
ethanc8
2303052e50 Add NSAppearanceCustomization to NSApplication and NSView 2023-12-31 20:03:21 -06:00
ethanc8
6aff0bd0f8 Add -[NSMenu popUpMenuPositioningItem:atLocation:inView:] 2023-12-31 19:27:38 -06:00
ethanc8
ea6c43911f Add beginSheet:completionHandler:-related methods: 
-[NSWindow beginSheet:completionHandler:]
-[NSAlert beginSheetModalForWindow:completionHandler:]
 2023-12-31 17:37:07 -06:00
Gregory John Casamento
969fe4c870 Add getting, additional change from branch, quick fix 2023-12-28 11:20:12 -05:00
Gregory Casamento
a5f92ecb8b
Merge pull request #233 from gnustep/NSShadow_issue217_nsgraphicscontext 2023-12-28 11:18:14 -05:00
Fred Kiefer
3a6dce02be Remove some gcc compiler warnings 2023-12-28 14:45:16 +01:00
Gregory John Casamento
9fab419042 Add shadow method to NSGraphicsContext and add set method to NSShadow 2023-12-28 06:47:25 -05:00
Gregory John Casamento
345b1b4065 Add call to setter as suggested by @fredkiefer 2023-12-27 12:37:33 -05:00
Gregory John Casamento
7be6c722e4 Add RETAIN, per review from @fredkiefer 2023-12-27 12:20:54 -05:00
Gregory John Casamento
874515c5b7 Add RETAIN, per review from @fredkiefer 2023-12-27 12:19:48 -05:00
Gregory John Casamento
ff90453263 Fix indentation issue and remove uneeded local var, per review from @fredkiefer 2023-12-27 12:17:48 -05:00
Gregory John Casamento
4e4755c533 Remove uneeded comments 2023-12-26 11:53:38 -05:00
Gregory John Casamento
cb4987ff47 Minor cleanup in NSView, add code to get NSShadowHoriz, NSShadowVert 2023-12-26 11:43:33 -05:00
Gregory John Casamento
702f7bb9af Untabify, add shadow keys for vert, color, horiz 2023-12-26 10:32:46 -05:00
Gregory John Casamento
468030a982 Add correct key for the NSShadow object which is NSViewShadow 2023-12-24 16:48:41 -05:00
Gregory John Casamento
70019a695a Add decoding logic for shadow to NSView 2023-12-24 16:16:52 -05:00
Gregory John Casamento
9cb00ba871 Add ivar for shadow 2023-12-24 13:59:12 -05:00
Gregory John Casamento
33d66e0ddc Update NSView with setShadow:/shadow methods 2023-12-24 13:28:08 -05:00
Gregory John Casamento
3f30d139bc Quick fix, resolves issue #153: Remove incorrect decoding of constraint 2023-12-22 16:47:40 -05:00
Gregory John Casamento
d9fa73870a Fix handling of custom classes for XIB v5. This corrects an issue in Gorm as well 2023-12-16 08:00:33 -05:00
Riccardo Mottola
e5c346351c doc fixes 2023-12-12 21:37:09 +01:00
Gregory John Casamento
3efb4ce9f3 Update per comments by @fredkiefer 2023-11-27 06:58:43 -05:00
Gregory John Casamento
87a73db572 Update calls to awakeFromNib and add call to prepareForInterfaceBuilder if we are in Gorm 2023-11-27 02:26:16 -05:00
Gregory John Casamento
8c421a3c8e Add method -prepareForInterfaceBuilder since it is in the same place as awakeFromNib and is trivial to add, this method will be useful in Gorm in the future 2023-11-24 22:22:14 -05:00
Gregory John Casamento
4b3014922c Move awakeFromNib implementation to NSObject instead of NSView, as discussed in the documentation 2023-11-24 21:32:15 -05:00
Riccardo Mottola
bdcced992c fix redundant semicolons 2023-11-20 22:43:49 +01:00
Riccardo Mottola
35aa22588a add IBOutlet and IBAction to doc WordList 2023-11-20 22:25:37 +01:00
Riccardo Mottola
08411ea68f fix some trailing semicolons 2023-11-17 16:53:43 +01:00
rfm
fb358c3b03 Fix missing semicolon 2023-11-14 21:36:12 +00:00
Riccardo Mottola
aa36664153 fix various autogsdoc warnings and issues 2023-11-14 01:29:01 +01:00
Kyle J Cardoza
dfa829bf38
Merge pull request #201 from KyleCardoza/add-gstheme-hooks 
add gstheme hooks
 2023-11-09 15:42:50 -05:00
Riccardo Mottola
34c5a5e841 use defined() to check if a variable is defined, also, rename it to be clearer about a feature availability and not enabling one 2023-10-26 02:38:29 +02:00
Frederik Carlier
31a71a1090
NSWorkspace: Throw a descriptive exception when make_services could not be found (#208) 
`[NSTask launchPathForTool: @"make_services"]; can return nil when the tool is not found. In this case, [NSTask launchedTaskWithLaunchPath] would raise a NSInvalidArgumentException with error message "NSTask - no launch path set" which is not very descriptive.
 2023-10-11 17:54:38 +02:00
Frederik Carlier
8619fe33c2
GifQuantizeBuffer is considered private API in libgif 5.2 and later (#207) 
See befe188771/
 2023-10-09 19:35:37 +02:00
Gregory John Casamento
2ac57c147f Remove uneeded calls to orderOut: and setDelegate: as this is done in the close method 2023-10-08 06:23:26 -04:00
Gregory John Casamento
a4beb1266f Fix spaces / formatting issue for return types 2023-10-08 05:43:18 -04:00
Gregory John Casamento
791a5d0aaf Cleanup classes. 2023-10-08 04:44:31 -04:00
Gregory John Casamento
4bb0270759 Update NSViewController with lifeCycle methods 2023-10-08 04:44:31 -04:00
Gregory John Casamento
24eee8e7dd Allow popover to be dismissed 2023-10-08 04:44:31 -04:00
Frederik Carlier
bcc8011580
Avoid accessing instance variables in inline functions when compiling with msvc (#205) 
* Rename `DPSshfill` to `DPSshfill_`

This method takes one argument, so by convention, the name of the variable in the method table should end with a single underscore

* DPSOperators.h: Use macros to define inline functions

* Don't access instance variables when compiling with Visual Studio
 2023-10-01 22:56:02 +02:00
Kyle J Cardoza
7f70818be2 Added the ability for GSTheme subclasses to provide custom implementations of GSWindowDecorator. 2023-09-22 21:17:15 -04:00
Kyle J Cardoza
225eea02d5 Addressed request for change in NSMenu.m, and moved function of 
-[_organizeMenu] to GSTheme-[organizeMenu:isHorizontal].
 2023-09-22 18:57:15 -04:00
Kyle J Cardoza
096327e87b Addressed changes requested in PR 201 2023-09-22 15:20:23 -04:00
Kyle J Cardoza
07f1b8759a Added window titlebar GSTheme hooks. 2023-09-22 01:42:47 -04:00
Kyle J Cardoza
a9f33627f1 Added menu organization hooks 2023-09-20 12:52:01 -04:00
Kyle J Cardoza
81b59ad0a0 Initial implementation of new GSTheme hooks and default implementations. 2023-09-19 22:20:12 -04:00
Riccardo Mottola
9faf904349 Merge branch 'warningfix' of https://github.com/gnustep/libs-gui into warningfix 2023-09-18 18:05:35 +02:00
Riccardo Mottola
670a86bb59 cleanup trailing backslash 2023-09-18 18:02:28 +02:00
Riccardo Mottola
5e68ebec91 fix warning, comparison with NULL 2023-09-13 01:11:48 +02:00
Riccardo Mottola
88a0e1e390 use destroy instead of assigning nil, avoids warnings and make smore sense anyway 2023-09-13 00:40:58 +02:00
Riccardo Mottola
a3117e5598 Put in methd in a private category to silence warning. Apple doesn't expose the method in its header, but we don't we don't know if it has it private. In case it is a GS extension, perhaps we should name it private with an _. 2023-09-12 23:49:05 +02:00
Riccardo Mottola
9e0685b315 do not install private headers 2023-09-12 23:19:06 +02:00
Riccardo Mottola
1815556e4e remove unused functions 2023-09-12 23:09:08 +02:00
Richard Frith-Macdonald
2e4af41c70 Fixup for APPKIT_EXPORT_CLASS 2023-09-05 17:02:06 +01:00
Gregory Casamento
3575f0af77 Add implementation of removeAllItems 2023-09-01 17:12:05 +00:00
Gregory Casamento
3f35da7860
Update code in GSXib5KeyedUnarchiver.m to read alternative toolTip format (#193) 
* Update code in GSXib5KeyedUnarchiver.m to read alternative toolTip format

* Update to make the code a bit tighter, per suggestion by @fredkiefer
 2023-08-31 23:46:34 +02:00
Gregory Casamento
629d065b91
Add dummy awakeFromNib dummy method (#195) 2023-08-31 23:41:46 +02:00
eukara
d99c96efcc
* Source/NSMenuItemCell.m (-_keyEquivalentString): Fix the 'and' check so that shiftKeyString can display (#190) 2023-08-26 11:32:30 +02:00
Fred Kiefer
570f2b4d2a * Source/NSSwitch.m (-drawRect:): Correct drawing as suggested by Austin Clow (dr_clow@me.com). 2023-08-13 20:27:48 +02:00
Benjamin Johnson
305bcd56a3
Implement GSCSTableau, GSCSEditInfo, GSCSEditVariableManager (#186) 
* Implement GSCSTableau, GSCSEditInfo, GSCSEditVariableManager

* Update GSTableau based on feedback

* Remove adding expression term variable to external parameteric variables
 2023-08-05 10:26:22 +02:00
Frederik Carlier
eb480b7748
NSGraphicsContext: Add methods method (#179) 
gnustep-back uses the `NSGraphicsContext->methods` _variable_, but using an instance variable across module boundaries is not supported when building with Visual Studio.

This commits adds a `[NSGraphicsContext methods]` _method_, which can be accessed across module boundaries (and hence when building with Visual Studio).
 2023-08-01 22:39:46 +02:00
Riccardo Mottola
0b9924e094 reduce scope of _imageRep from ivar to local to init 2023-07-27 14:35:25 +02:00
Gregory Casamento
f2b79365f4
NSDockTile - Implement methods to update the icon and show badge (#185) 
NSDockTile - Implement methods to update the icon and show badge using a NSCustomImageRep. Link the NSDockTile view with the AppIcon window contentView.
GSTheme - add badgeColor color and corresponding methods to theme background, decoration and text color
 2023-07-27 09:17:18 +02:00
Gregory Casamento
a34867faee
Merge pull request #184 from gnustep/gsdisplayserver_cleanup 2023-05-31 17:10:55 -04:00
Riccardo Mottola
3341f6f149 Remove now unused NSCurrentServerThreadKey key, previously it was used tor GSCurrentServer(), but it it is not needed anymore. Please use the function directly. 2023-05-30 00:15:47 +02:00
Benjamin Johnson
47a945603b Fix typo and spacing 2023-05-29 22:14:11 +00:00
Benjamin Johnson
1f7f4cd40f Fix typo in intrinsic and address comments 2023-05-28 22:10:14 +00:00
Benjamin Johnson
2e98bd5366 Implement layout constraint conversion to internal solver constraints 2023-05-28 18:33:44 +10:00
Benjamin Johnson
0c493d9e7a Address PR feedback on #181 2023-05-09 06:26:26 +10:00
Benjamin Johnson
bddf6cfd03 Implement GSCSConstraint and suppoorting classes 2023-05-07 08:01:25 +10:00
Benjamin Johnson
2be7334ce2
Implement part of GSAutoLayoutEngine dependency management logic (#178) 
* Implement part of GSAutoLayoutEngine dependency management logic

* Fix formatting of GSAutoLayoutEngine, GSCSFloatComparator and GSCSSolution

* Address PR feedback

* Address PR feedback

* Replace assignment with ASSIGN macro and fix makefile

* Add back dealloc in GSAutoLayoutEngine.m and GSCSSolution.m
 2023-04-19 09:06:53 +02:00
Gregory John Casamento
5c098cc539 Minor fix in glyph info 2023-04-09 21:09:22 -04:00
Gregory Casamento
e64d8d4b02
Merge pull request #170 from gnustep/NSDictionaryController2_branch 2023-03-24 18:33:52 -04:00
Gregory John Casamento
58748243d5 Update per comments by Fred before merge 2023-03-24 17:57:29 -04:00
Gregory Casamento
81f21e2094
Merge pull request #172 from BennyKJohnson/bootstrap-layout-engine 2023-03-17 14:11:20 -04:00
Riccardo
62d16bff24
Implement acceptsFirstMouse so to return YES, otherwise tablees in new windows do not get mouse selection events. (#173) 
Seems to match Apple's implementation.
 2023-03-02 12:13:50 +01:00
Benjamin Johnson
708f7c337e Address feedback on bootstrap layout engine PR 2023-03-01 18:57:08 +11:00
Gregory Casamento
09e9cc0330
Update NSDictionaryController.m. Correct removeObjects: 2023-02-28 16:58:21 -05:00
Gregory John Casamento
99e921ea35 Fix type issue with getting value from KVP in a couple of places and fix memory issue with NSDictionaryControllerKeyValuePair 2023-02-28 03:55:34 -05:00
Gregory John Casamento
dcf5fbe74b Update using rearrangeObjects, clean up white space for review 2023-02-28 03:42:43 -05:00
Gregory John Casamento
b9841fe493 Update build array to properly exclude keys 2023-02-28 03:33:50 -05:00
Benjamin Johnson
7b9bede733 Improve memory management with layout engine 2023-02-28 19:18:52 +11:00
Gregory John Casamento
08fc055321 Override addObject(s):, removeObject(s): update _contentDictionary 2023-02-28 03:17:07 -05:00
Gregory John Casamento
99e25244af Remove uneeded bind: code 2023-02-28 00:40:40 -05:00
Benjamin Johnson
f6f1a7ef82 Remove unnecessary check for _layoutEngine 2023-02-27 21:39:14 +00:00
Benjamin Johnson
2a1c0f88b3 Move layoutEngine ownership to NSWindow 2023-02-27 19:56:37 +11:00
Benjamin Johnson
93769f3a52 Implement bootstrapping auto layout 2023-02-27 17:46:39 +11:00
Gregory John Casamento
5799e4a9c7 Update how key/value is generated in newObject 2023-02-24 17:54:17 -05:00
Gregory John Casamento
917585cfab Update how key/value is generated in newObject 2023-02-24 17:51:54 -05:00
Gregory John Casamento
3fdccf627e Add code to handle strings->dictionary and dictionary->strings for setLocalizedKeyTable/Dictionary methods 2023-02-24 17:38:30 -05:00
Gregory John Casamento
0d5ab325ab update bind:toObject:withKeyPath:options: method for all bindings, sort resulting array of NSDictionaryControllerKeyValuePair objects by key value 2023-02-23 18:39:06 -05:00
Gregory John Casamento
386bec0435 use superclass implementation of valueClassForBinding: 2023-02-23 16:17:44 -05:00
Gregory John Casamento
728968505e Get rid of white space and minor cleanup 2023-02-23 16:17:44 -05:00
Gregory John Casamento
2b20808ddd Add preserves_selection encoding/decoding 2023-02-23 16:17:44 -05:00
Gregory John Casamento
c1ad87a546 Eliminate white space, some experimental changes 2023-02-23 16:17:44 -05:00
Gregory John Casamento
8de600877b simplify existing implementation of dictionary controller 2023-02-23 16:17:44 -05:00
Gregory John Casamento
7250e3fac1 Remove uneeded GSObservableDictionary class declaration and implementation, start to diagnose and fix the issue with NSDictionaryController 2023-02-23 16:17:44 -05:00
Gregory John Casamento
c6c0dc7c3f Expose more bindings and override some methods from NSArrayController 2023-02-23 16:17:44 -05:00
Gregory John Casamento
03f1ddecd5 latest changes 2023-02-23 16:17:44 -05:00
Gregory John Casamento
5958734de0 Implement NSDictionaryControllerKeyValuePair. Add implementation for the rest of the methods. 2023-02-23 16:17:44 -05:00
Gregory John Casamento
8760ff9b7b Add externs for key bindings. 2023-02-23 16:17:44 -05:00
Gregory John Casamento
3d850f7eae Add method definitions. 2023-02-23 16:17:44 -05:00
Gregory John Casamento
67966d6cdd Initial template for NSDictionaryController 2023-02-23 16:17:44 -05:00
Benjamin Johnson
928dd71439 Fix whitespace between argument in method call 2023-02-23 01:29:28 +00:00
Benjamin Johnson
75fcf49b62 Refactor layout core methods implementation to use ivars 2023-02-20 18:09:23 +11:00
Benjamin Johnson
571ad7a613 Implement supporting core layout methods on NSView 2023-02-19 15:21:13 +11:00
Fred Kiefer
72b05b514a
Merge pull request #169 from BennyKJohnson/nsautoresizingMaskLayoutConstraint 
Implement NSAutoresizingMaskLayoutConstraint class
 2023-02-17 19:58:34 +01:00
Gregory John Casamento
95c7e31ccb Remove uneeded item object 2023-02-12 15:32:21 -05:00
Gregory John Casamento
30c2f1da6b Minor update, remove redundant setSelected: calls 2023-02-12 15:27:50 -05:00
Gregory John Casamento
ea398eab4c Remove extra call to setSelected: in selectAll: deselectAll: etc methods, this should only happen in setSelectionIndexes and setSelectionIndexPaths 2023-02-12 14:25:36 -05:00
Gregory John Casamento
b6048a27f4 Run cleanup-whitespace in emacs to eliminate all extraneous whitespace 2023-02-12 14:19:37 -05:00
Gregory John Casamento
1c879a1522 Add private methods to internal private category 2023-02-12 09:55:29 -05:00
Gregory John Casamento
41e6a45e8d Add private methods to internal private category 2023-02-12 09:33:48 -05:00
Gregory John Casamento
50889771d0 Fix issue with FOR_IN loop 2023-02-11 18:27:55 -05:00
Gregory John Casamento
2eb23858d6 Methods to keep selectionIndexes and selectionIndexPaths in sync per discussion with @fredkiefer 2023-02-11 18:20:36 -05:00
Benjamin Johnson
f46e6596cc Make layout constraint attribute constants static and add comment for ordering 2023-02-12 08:47:55 +11:00
Gregory John Casamento
731f5a248d Fix OVERIDDEN macro, override method in NSCollectionViewGridLayout 2023-02-09 14:39:37 -05:00
Gregory John Casamento
fd4b07ff09 Get rid of extranous include 2023-02-07 21:56:26 -05:00
Gregory John Casamento
b891dea575 Update as discussed, get rid of extra commented out code and of uneeded imports 2023-02-07 21:41:13 -05:00
Gregory John Casamento
0ad9143b39 Add better var names in flow layout 2023-02-07 21:39:05 -05:00
Gregory John Casamento
bb77c072cb Correct spaces 2023-02-07 21:30:46 -05:00
Gregory John Casamento
4bcdf6f5d4 Fix issues mentioned by @fredkiefer in review, remove check in NSViewController 2023-02-07 21:27:39 -05:00
Gregory John Casamento
d6d2f430ad Update encode/decode to remove unecessary 64bit call 2023-02-07 21:09:23 -05:00
Gregory John Casamento
2a33aab039 Update implemention suggested by @fredkiefer 2023-02-07 21:05:12 -05:00
Gregory John Casamento
7244519365 Change call indexPathsForVisibleSupplementaryElementsOfKind to call indexPathForItem: as suggested by @fredkiefer 2023-02-07 20:55:22 -05:00
Gregory John Casamento
330599e248 Inline the frame update 2023-02-04 11:37:36 -05:00
Gregory John Casamento
73759407bb Add delegate call to collectionView:didSelectItemsAtIndexPaths: 2023-02-04 10:28:11 -05:00
Gregory John Casamento
ec6a845cb1 Suggestions by @fredkiefer, correct spacing and fix comment 2023-02-04 09:39:48 -05:00
Gregory John Casamento
99103a83dc Fix more suggestions by @fredkiefer. Add AUTORELEASE for nib, generate indexes for visible items 2023-02-04 09:31:13 -05:00
Gregory John Casamento
cf16dde246 Update selectAll:, deselectAll:, selectItemsAtIndexPaths:..., deselectItemsAtPaths: to correctly update setSelectionIndexPaths: 2023-02-04 07:41:42 -05:00
Benjamin Johnson
4fec29a66b Implement NSAutoresizingMaskLayoutConstraint class 2023-02-04 19:24:03 +11:00
Gregory John Casamento
e754180dcf Add OVERRIDDEN macro per suggestion from @fredkiefer 2023-01-30 18:12:53 -05:00
Gregory John Casamento
19e8a48ba3 Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
4e49c2a8cf Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
8afffbb121 Fix leak and add to maps in makeItemWithIdentifier:forIndexPath:, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
cd52649076 Fix encoding issue, formatting issues, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
d4d60dd5de Remove strange comment, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e1fa590102 Remove commented out code, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
dd01e8b59b Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c6d887e2 Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c3c65f4e Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
03cbc95076 Remove log per review by @fredkiefer 2023-01-30 10:48:03 -05:00
Gregory John Casamento
20a59e45b5 Add code to call viewWillLoad/viewDidLoad into loadView 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5e5e2bd317 Add proper error 2023-01-30 10:48:03 -05:00
Gregory John Casamento
cb8e805d0d Add method to check if method is overriden on layout subclass 2023-01-30 10:48:03 -05:00
Gregory John Casamento
af643cc821 Fix externs for collection view, correct NSFontIdentityMatrix type 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5612120c06 Remove extra #import directives 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3e8b8386b1 Add correct API version defines for NSCollectionViewItem 2023-01-30 10:48:03 -05:00
Gregory John Casamento
fe2a988111 Fix duplicate _size and use the _frame in the attributes class 2023-01-30 10:48:03 -05:00
Gregory John Casamento
95fa4e0368 Add tracking view to allow easier selection 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c95bbcf714 Changes to fix item selection when an NSImageView is present 2023-01-30 10:48:03 -05:00
Gregory John Casamento
7ee05a6869 Make sure to consider when view is flipped when calculating which indexPath was hit; minor cleanup of code; remove uneeded comments 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bfa088fd0e Fix size issue with flow view 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3b44aa3608 Fix size issue with grid view 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bbfa1d84bc Fix proportions of each item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5ff478ac85 Fix implementation of resize when elements overflow the size of the view 2023-01-30 10:48:03 -05:00
Gregory Casamento
b96dbcba2e Update GSXib5KeyedUnarchiver.m 
Remove extra space.
 2023-01-30 10:48:03 -05:00
Gregory John Casamento
627c51ec45 Changes to implement grid layout 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a5b878c690 Implement selectAll:, deselectAll:, selectItemsAtIndex:..., deselectItemsAtIndexPaths: 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e9e1615cdb Don't update the delegate unless the selection actually changes 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a6f83ab00b Add code to clean up views when resizing. Prevent recursion. Call reload when 'tile' method is called 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2d70c42790 Fix issue with loading collectionview. Correct sprious calls to reloadData and tile method. Fix call back to delegate when item is clicked 2023-01-30 10:48:03 -05:00
Gregory John Casamento
94f616436f Add mapping to XmlKeyMapTable for NSBackroundColors 2023-01-30 10:48:03 -05:00
Gregory John Casamento
f1552faaee Remove uneeded ivars, release maps 2023-01-30 10:48:03 -05:00
Gregory John Casamento
01ca2cb6c2 Fix compilation error in CI 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2bec53bf0f Switch to using maptables to track some metadata bout items so that we can match items up when we need to find them by indexPath or point. Remove uneeded ivar from layout. Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bf3ddc8cad Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
b7156def8f Implement setSelectionIndexPaths: 2023-01-30 10:48:03 -05:00
Gregory John Casamento
8a9185ee84 Update selection methods 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a16ad6168b Update selection methods 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3ea04c0e36 Fix compilation issue, comment out temporary code in _selectWithEvent:indexPath: 2023-01-30 10:48:02 -05:00
Gregory John Casamento
eeb8718452 Add indexpath methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
5108348ca6 Add code to return the item properly from layoutAttributesForElementsInRect:, add missing NSCopying declaration to NSCollectionViewItem.h, minor cleanup in NSCollectionViewCompositionalLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f3672c31e9 Update attributes 2023-01-30 10:48:02 -05:00
Gregory John Casamento
5b57e65002 Update attributes 2023-01-30 10:48:02 -05:00
Gregory John Casamento
3f402d292b Return attributes for items that intersect 2023-01-30 10:48:02 -05:00
Gregory John Casamento
9c1aec70e7 Fix resize issue with flow 2023-01-30 10:48:02 -05:00
Gregory John Casamento
2246da3d0e Implement re-flow when view is resized 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b28eaac9eb Minor updates and formatting change 2023-01-30 10:48:02 -05:00
Gregory John Casamento
466ebedd04 Add calls to additional delegate methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
00ac1adf7f Implement collapse section 2023-01-30 10:48:02 -05:00
Gregory John Casamento
83e8cf6a15 Add non-keyed decoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
fdf39cf110 Add non-keyed encoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
64a5d19b19 Update encoding/decoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
d6b78ff06e Change encode/init to use encode/decode functions to handle integers 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f7730c97d3 Encode all information for the grid layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
dade8c4068 Decode all information for the grid layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
35e0e62144 Add implementation of setters and getters in NSCollectionViewGridLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
7d46f9f69a Update to the correct size when laying out the collection view. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
9c0f4ed731 Update visibleItems when arranging items 2023-01-30 10:48:02 -05:00
Gregory John Casamento
04b0a15526 Implement makeItemWithIdentifier:atIndexPath: 2023-01-30 10:48:02 -05:00
Gregory John Casamento
8948aecae5 Update implementation to calculate position of items for the flow layout. implementation of copyWithZone. Implementation of initWithCoder for flow layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
7fe30c6db2 Update flow layout. Fix decoding issue with Xib interpretation for NSCollectionViewLayout. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
fc56a78840 Add implementation of new methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f8e99166e2 Add documentation to methods in NSCollectionView and remove initWithCoder call from NSCollectionViewLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b65c5bca9d Add implementation of reloadSections and reloadItemsAtIndexPaths 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b7eb68b67c Fix warnings and errors, apply attributes from NSCollectionViewLayoutAttributes to view 2023-01-30 10:48:02 -05:00
Gregory John Casamento
68f1444de3 Add all overriden methods in flow layout. In NSCollectionView set collectionView in layout. Minor code cleanup. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
42a5f34095 Add code to correctly read information for NSCollectiViewLayout from xib file 2023-01-30 10:48:02 -05:00
Gregory John Casamento
a90ddfc9c5 Add changes for Xib reading and some minor cleanup for NSCollectionView 2023-01-30 10:48:02 -05:00
Gregory John Casamento
8572458a5d Add methods and actions for layout classes as well as the abstract classes for NSCollectionViewLayout. 
Declarations added to collectionview layout header.

Clean compile for NSCollectionViewLayout abstract class

Add header for NSCollectionViewFlowLayout.h

Add skeleton implementation of NSCollectionViewFlowLayout

Add implementation for simple setter/getter methods.

Correct compilation error with non-clang compilers

Fix compilation issues

Add getter/setter for collectionViewLayout

Skeleton of NSCollectionViewTransitionLayout implementation

Add encoding/decoding for collectionViewLayout key

Make NSCollectionViewGridLayout default if the NSCollectionViewLayoutKey is not set

Add protocols for DataSource and Prefetching for NSCollectionView

Add 10.11 methods to delegate declaration

remove templating from NSCollectionViewDelegate that gcc can't handle.

New delegate methods for NSCollectionViewDelegate to support NSSets of NSIndexPaths and multiple selection.

Reset .travis.yml to the proper version and modify NSCollectionView.h to use forward declarations for both NSPasteboard and NSPasteboardWriting so that we don't explicitly import.

Add declarations for missing methods from 10.11 version of NSCollectionView

Add new methods for 10.11 for moving, deleting and collapsing sections.

Add new methods from 10.11

Add the remaining missing methods as well as delcarations for blocks needed for batch handler and completion handler.

Add skeleton implementations for all new methods

Changes to add new methods to collection view for delegate

Consolidate the registeredClass and registeredNib maps.

Implementation of dataSource related methods

Implment nib loading for NSCollectionViewItem subclasses

Remove uneeded ivars, add categories for override and layout

Minor formatting change

Update categories and organization of code

Add init method to NSCollectionViewFlowLayoutInvalidationContext

Add collectionview layout subclasses

Declarations added to collectionview layout header.

Clean compile for NSCollectionViewLayout abstract class

Add skeleton implementation of NSCollectionViewFlowLayout

Add implementation for simple setter/getter methods.

Correct compilation error with non-clang compilers

Fix compilation issues

Add getter/setter for collectionViewLayout

Add encoding/decoding for collectionViewLayout key

Make NSCollectionViewGridLayout default if the NSCollectionViewLayoutKey is not set

Add protocols for DataSource and Prefetching for NSCollectionView

New delegate methods for NSCollectionViewDelegate to support NSSets of NSIndexPaths and multiple selection.

Reset .travis.yml to the proper version and modify NSCollectionView.h to use forward declarations for both NSPasteboard and NSPasteboardWriting so that we don't explicitly import.

Add declarations for missing methods from 10.11 version of NSCollectionView

Add new methods for 10.11 for moving, deleting and collapsing sections.

Add new methods from 10.11

Changes to add new methods to collection view for delegate

Consolidate the registeredClass and registeredNib maps.

Add init method to NSCollectionViewFlowLayoutInvalidationContext

Fix issues with rebase
 2023-01-30 10:48:02 -05:00
Gregory John Casamento
aee03ee7c4 Add collectionview layout subclasses 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b803d348fb Set size to size of the view that was added as the content view 2023-01-14 03:34:04 -05:00
Gregory John Casamento
e87e48a4b2 Add spaces 2023-01-12 18:40:27 -05:00
Gregory John Casamento
0f650158a8 Attempt to capture what @fredkiefer had suggested and fix issue mentioned by @rmotolla 2023-01-12 18:40:27 -05:00
Gregory John Casamento
b12d151163 Implement it the way @fredkiefer suggested. Check which side has more room. 2023-01-12 18:40:27 -05:00
Gregory John Casamento
d649b99418 Minor positional adjustment 2023-01-12 18:40:27 -05:00
Gregory John Casamento
5a71c1c944 Fix issues raised by fred's comments 2023-01-12 18:40:27 -05:00
Gregory John Casamento
b434708d5e Fix issue where drawer opens for a moment on the preferredEdge instead of the computed one 2023-01-12 18:40:27 -05:00
Gregory John Casamento
3f1e8af9c4 Open on side away from the edge of the screen if there is not enough room 2023-01-12 18:40:27 -05:00
Richard Frith-Macdonald
3477b3f1d9 Fix potential call of null block 2022-12-29 09:01:33 +00:00
Fred Kiefer
8ccc89b83d
Merge pull request #161 from BennyKJohnson/constraint-vfl-support 
Implement constraintsWithVisualFormat method on NSLayoutConstraint
 2022-11-24 22:52:34 +01:00
Benjamin Johnson
a1c2115bc3 Fix GCC compiler warnings for GSAutoLayoutVFLParser.m 2022-11-22 08:21:05 +11:00
Benjamin Johnson
44f8950e3b Address for feedback for GSAutoLayoutVFLParser 
- Move assertion for empty string to parse method
- Add missing spaces between colon and parameter
- Use GSFastEnumeration macro
- Modify parseObjectOfPredicate to use in out parameter of struct and remove heap allocation
 2022-11-13 06:15:02 +11:00
Benjamin Johnson
609d03ac41 Address feedback on GSAutoLayoutVFLParser 
- Add space between parameter name and parameter
- Use release macro in constraintsWithVisualFormat
 2022-11-12 12:09:29 +11:00
Benjamin Johnson
13123a054e Fix formatting of GSAutoLayoutVFLParser and add copyright notice 2022-11-11 05:55:02 +11:00
Fred Kiefer
e4ecfb0801 * Headers/Additions/GNUstepGUI/GSLayoutManager.h, 
* Source/GSLayoutManager.m: Add new methods
-defaultLineHeightForFont: and -defaultBaselineOffsetForFont:.
 2022-11-05 21:01:53 +01:00
Benjamin Johnson
1aff56cb9b Implement constraintsWithVisualFormat method on NSLayoutConstraint 2022-11-05 20:33:23 +11:00
Fred Kiefer
59558a519d
Merge pull request #160 from gnustep/AttachmentIndexFix 
Fix click on TextAttachmentCells, where the left side was not respected.
 2022-10-25 23:06:47 +02:00
Riccardo Mottola
85155fd64f Fix click on TextAttachmentCells, where the left side was not respected. 
This was because index was respecting fraction and thus loosing the attachment when clicking on the right part, only for this case, recalculate character index without respectFraction.
 2022-10-11 23:26:51 +02:00
Gregory John Casamento
92d27c494f Add defines for export of classes to DLL when building on WIndows 2022-09-29 12:09:13 -04:00
Gregory John Casamento
0633f214c5 Remove unneeded import 2022-09-01 15:39:45 -04:00
Gregory John Casamento
a2b57fd1f3 Move logic to detect if it's a radio button to NSButtonCell, also simplify logic to flip the button state and prevent switch to off if button is currently on and is a radio button. This is consistent with 10.7+ behavior 2022-09-01 09:22:45 -04:00
Gregory John Casamento
3558247662 Move the call to a more centralized method so that it will be called in all cases without repeating code. 2022-08-28 05:22:16 -04:00
Gregory John Casamento
fdba6d2be6 Fixes as discussed with @fredkiefer 2022-08-27 10:09:56 -04:00
Gregory John Casamento
a9ca806c2b Changes to address issue #151. This should correct behavior of NSRadio buttons in GS and should implement the behavior seen in 10.7+ 2022-08-27 03:46:12 -04:00
Sebastian Reitenbach
857c173d03 Don't misuse libgnustep-gui_INTERFACE_VERSION to define Resource Install paths 
$(GNUSTEP_INSTANCE)_INTERFACE_VERSION is used in gnustep-make to define
the version of the shared object.

As a packager, there might be various reasons to
override the $(GNUSTEP_INSTANCE)_INTERFACE_VERSION
in order to control the library version.

So I do for gnustep-gui on OpenBSD packages. The problem here is, that
the libgnustep-gui_INTERFACE_VERSION is additionally used to specify the path
where resources like Panels, Localizations etc. get installed, however,
in Source/NSApplication.m, the use of
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION

As long as the libgnustep-gui_INTERFACE_VERSION is not overridden with
some other value, everything is fine. However, as in my case, Applications
aren't able to find the Panels/Translations provided by -gui anymore.

Decided to just remove the definition of libgnustep-gui_INTERFACE_VERSION
in these three Makefiles, as it was only used once, and used the
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION directly.

Alternatively, libgnustep-gui_INTERFACE_VERSION in these Makefiles
could could have been renamed to avoid this conflict.
 2022-08-19 15:54:41 +02:00
Gregory John Casamento
bd3c954807 Merge branch 'master' of github.com:gnustep/libs-gui 2022-08-09 01:25:59 -04:00
Fred Kiefer
34423da47e * Source/NSImageCell.m, 
* Source/NSAccessibilityCustomAction.m,
* Source/NSStackView.m,
* Source/NSGridView.m: Fix compiler warnings
 2022-06-12 22:13:06 +02:00
Gregory John Casamento
751d94aa2c Temporary fix for issue caused by libs-base change 2022-04-30 02:27:38 -04:00
Riccardo Mottola
e0012349f6 Refactor resize bar notch width to be a constant and private inside GSTheme, making it accessible through -[GSTheme resizebarNotchWidth]. 2022-03-31 23:43:52 +02:00
Riccardo Mottola
96db5bf89c Fix resizing mode by fixing initialization order. 2022-03-31 22:58:02 +02:00
Gregory John Casamento
f21aa20815 Move check of index in 'key' before the xpath call 2022-03-29 20:06:53 -04:00
Gregory John Casamento
5f3b54e330 GSXibKeyedUnarchiver: Change format of customClasses dictionary 2022-03-29 19:49:35 -04:00
Gregory John Casamento
39bd359505 Move createCustomClassRecordForId:... to parent class 2022-03-28 18:47:41 -04:00
Gregory Casamento
33fea1762d
Merge branch 'master' into custom_class_xib3_changes 2022-03-26 11:28:29 -04:00
Gregory John Casamento
790b686f0d Move _customClasses to GSXibKeyedUnarchiver and implement logic to build the _customClasses array for use in Gorm when loading the xib file. 2022-03-26 11:19:59 -04:00
Gregory John Casamento
de767ac0e0 Add version logic to correct issue for older gorm archives 2022-03-24 07:57:09 -04:00
Riccardo Mottola
6ec6f20f19 subclass initImageCell, so that RefusesFirstResponder can be set, matching Mac. 2022-03-22 22:52:06 +01:00
Wolfgang Lux
efb9bcb2e7 Select the first item of a NSPopUpButtonCell's new menu 2022-02-26 15:30:26 +01:00
Wolfgang Lux
ec3353ecd8 Never change the state of the selected item of a NSPopUpButton configured as a pull down 2022-02-26 15:21:04 +01:00
Gregory John Casamento
606505326c Minor change: Add all new headers to DocMakefile 2022-02-21 14:22:47 -05:00
Fred Kiefer
7c1af2c874
Merge pull request #140 from williameveretteggplant/autoreleasepool_NSTextView 
Fix memory leak in NSTextView
 2022-02-14 23:42:08 +01:00
williameveretteggplant
b70fad26a6
Use autorelease pool macros 2022-02-14 15:35:37 -07:00
williameveretteggplant
0211713766
Remove extra line 2022-02-14 14:16:42 -07:00
williameveretteggplant
9925f50aef
Indentation 2022-02-14 14:15:26 -07:00
williameveretteggplant
aae1f34d0d
Undo change 2022-02-14 14:09:34 -07:00
williameveretteggplant
2403c21978
Fix memory leak of tool tips 
Prevents the creation of tool tips where they don't already exist. Tool tips only need to be removed in the rect if there are tool tips.
 2022-02-14 14:03:49 -07:00
williameveretteggplant
f37e93a440
Fix memory leak in NSTextView 
On Windows, there is an occasional sporadic failure of autorelease to work correctly. In particular, this seems to happen when autorelease is invoked on an object while a call stack is in the middle of draining an autorelease pool. So, for example, when dealloc is called on an NSTextContainer, it then calls setTextContainer: on the associated NSTextView, which in turn calls textContainers on the layoutManager, which returns an autoreleased array of NSTextContainers. This array is sometimes released and sometimes it isn't.
Wrapping the setTextContainer: in an autorelease pool, which will then drain at the end of the method, rather than relying on the main autorelease pool in the run loop (which is in the middle of being drained), appears to fix this problem. This adds a small amount of overhead, but also makes the memory usage a little more efficient, since anything autoretained during the course of this method is released more quickly.
 2022-02-11 17:12:50 -07:00
williameveretteggplant
3190ce4363
Merge pull request #1 from williameveretteggplant/patch-1 
Fix memory leak in NSBox
 2022-02-11 16:17:11 -07:00
williameveretteggplant
d744b26429
Fix GSToolTips leak in NSView 
ToolTips can be present even when the flag is false, and it does no harm to invoke removeTipsForView: even if there are none. So this fixes a memory leak without any downside.
 2022-02-11 16:15:28 -07:00
williameveretteggplant
db5ad42d8a
Fix memory leak in NSBox 2022-02-11 16:09:35 -07:00
Wolfgang Lux
f5ebdcd1d2 Do not update selected item's state when changing the menu 2022-02-08 22:21:38 +01:00
Wolfgang Lux
c50ef9d8fa Restore fix for @97351199e 2022-02-07 18:19:03 +01:00
Wolfgang Lux
e4bd00f6eb Fix to avoid dangling pointer when changing the menu of a NSPopUpButtonCell 2022-02-06 15:58:18 +01:00
Gregory John Casamento
67860bf8c1 Add declarations for setPlaceholderString:/setPlaceholderAttributedString and getters to header and implementation to NSTextField.m 2022-01-12 04:45:56 -05:00
Gregory John Casamento
ebc6eb99a3 Quick fix for compilation error 2022-01-12 01:45:49 -05:00
Gregory John Casamento
937c309c15 Quick fix for compilation error 2022-01-12 01:45:10 -05:00
Gregory John Casamento
fda74bfde8 Add changelog 2022-01-11 20:13:00 -05:00
Gregory John Casamento
93a0fc46ea Use macro for fast enumeration 2022-01-11 20:10:09 -05:00
anthony
49e30a3378 GSStandardWindowDecorationView: Apply userSpaceScaleFactor to title bar height when calculating offsets 2022-01-11 19:51:45 +00:00
Fred Kiefer
b84d8cc3fd * Headers/Additions/GNUstepGUI/GSWindowDecorationView.h: 
Move new addon methods for Wayland to correct class
GSStandardWindowDecorationView.
* Source/GSWindowDecorationView.m: Keep variables declarations together.
 2021-12-28 17:23:48 +01:00
Fred Kiefer
bc9d477a9f
Merge pull request #124 from nongio/windowdecoration-expose 
Add helper methods in GSWindowDecorator protocol
 2021-12-27 17:51:50 +01:00
Riccardo Canalicchio
8ec514e049 pointInTitleBarRect: remove hit-test from window buttons 2021-12-27 15:12:17 +01:00
Fred Kiefer
97351199e3 * Source/NSPopUpButtonCell.m: Try to prevent segmenation fault 
when deallocating a popup button.
 2021-12-26 23:46:02 +01:00
Fred Kiefer
4ad217d5c3 * Source/NSMenu.m: Rename method on NSMenuPanel for the Wayland 
backend to -_menu to keep it apart from the already existing method
-menu on NSResponder.
* Source/NSSplitView.m: Correct decoded integer type.
 2021-12-26 14:50:50 +01:00
Riccardo Canalicchio
4eafb6f34c Add helper methods in GSWindowDecorator protocol for pointer hit test on window decorations 2021-12-17 09:09:37 +01:00
Gregory John Casamento
1d3f33b694 Restore older behavior for version 0 of NSSplitView. The previous change broke some older .gorm files. 2021-12-01 19:42:40 -05:00
Gregory John Casamento
d20fa6cc61 Make sure that the setDividerStyle: mthod is called only once when decoding from a gorm file 2021-11-18 18:01:45 -05:00
Gregory John Casamento
dae13af553 Check [bc isLoaded] before making window first responder 2021-11-18 13:17:56 -05:00
Gregory John Casamento
334e26eeb0 Add support for Thick/Thin/PaneSplitter NSSplitView settings 2021-11-15 10:20:33 -05:00