Gregory John Casamento
4e95021973
Update to simplify code per discussion with @fredkiefer
2024-07-27 16:59:05 -04:00
Gregory John Casamento
1d266d7a9b
Add back informational comments
2024-07-27 13:49:24 -04:00
Gregory John Casamento
9712490625
Minor cleanup
2024-07-26 21:24:21 -04:00
Gregory John Casamento
71304617b2
Move logic for finding the item for a given column to a private method, call method to get a view controller from the delegate
2024-07-26 10:56:52 -04:00
Gregory John Casamento
3ae1a4b41d
Minor whitespace cleanup
2024-07-25 08:39:21 -04:00
Gregory John Casamento
ab737b81d5
Get the previous column when loading a column in item-based mode in _performLoadOfColumn
2024-07-25 08:23:06 -04:00
Gregory John Casamento
782321e063
Consolidate _performLoad methods, get the last item selected
2024-07-25 08:12:49 -04:00
Gregory John Casamento
f5decac3ba
Add code to reset column if the delegate is item-based
2024-07-24 11:28:51 -04:00
Gregory John Casamento
ffdf8fb6da
Partially correct implementation
2024-07-23 13:08:35 -04:00
Gregory John Casamento
a1dd317d29
Add delegate calls to method _performLoadOfItem:forColumn:
2024-07-22 18:48:54 -04:00
Gregory Casamento
f55d937ab2
Update NSTreeController.m
...
Remove NSLog from initWithContent:
2024-07-20 12:27:00 -04:00
Gregory John Casamento
1df45b788e
Initial changes to start loading each column based on items
2024-07-20 12:11:47 -04:00
Gregory John Casamento
d22d839b0c
Correct minor formatting issues
2024-07-19 11:12:24 -04:00
Gregory John Casamento
dc78b11291
Add code to handle insertion methods that are based on selection
2024-07-19 10:14:18 -04:00
Gregory John Casamento
cd41f301a8
Add selection logic for computing indexPaths
2024-07-19 08:04:13 -04:00
Riccardo Mottola
da2803481b
Pietas, Enrico passed way, remove email
2024-07-18 13:17:06 +02:00
Gregory John Casamento
c68c459584
Add code to set selection indexes on the controller
2024-07-16 18:03:30 -04:00
Gregory John Casamento
c39095cd61
Add comment/documentation
2024-07-15 07:06:49 -04:00
Gregory John Casamento
74e0c19503
Add bindigns to NSTableColumn and handle font bindings in _applyBindingsToCell:... method
2024-07-15 06:50:20 -04:00
Gregory John Casamento
766a358fb7
Move code to handle enabled/editable bindings to a common method in the parent class
2024-07-14 16:00:18 -04:00
Gregory John Casamento
ca4fe0e078
Add code to get the value of the NSEnabledBinding
2024-07-14 15:40:47 -04:00
Gregory John Casamento
45c0368602
Add code to get the value of the NSEditableBinding
2024-07-14 15:14:07 -04:00
Gregory John Casamento
f253f3fa0e
Formatting fixes.. add space before * in return value
2024-07-12 10:39:47 -04:00
Gregory John Casamento
2ba9843537
Add removeSelectionIndexPaths:
2024-07-12 09:42:26 -04:00
Gregory John Casamento
4ddce03859
Add removeObjects... methods
2024-07-12 08:49:52 -04:00
Gregory John Casamento
9b481f10b3
Correctly refresh after adding an item at an index path
2024-07-12 08:11:23 -04:00
Gregory John Casamento
90b3913a1f
Add implementation for methods that add nodes at a given indexPath or set of indexPaths
2024-07-12 06:22:56 -04:00
Gregory John Casamento
bbbe9d00b4
Update _setObjectValue:... to update items in arrangedObjects when there is a binding
2024-07-11 12:18:52 -04:00
Gregory John Casamento
8da3d0afb7
Update to use NSObservedKeyPathKey instead of string, add code to _setObjectValue:... in NSTableView to set the value when we have a binding
2024-07-10 07:06:08 -04:00
Gregory John Casamento
aa86a96c55
Update to use NSObservedKeyPathKey instead of string, add code to _setObjectValue:... in NSTableView to set the value when we have a binding
2024-07-10 06:31:55 -04:00
Gregory John Casamento
060b27a854
Update _setObjectValue:...
2024-07-06 23:44:31 -04:00
Gregory John Casamento
fdb35eb869
Add value/setValue:
2024-07-06 23:06:26 -04:00
Gregory John Casamento
435ccfb2c7
Add value/setValue:
2024-07-06 23:03:31 -04:00
Gregory John Casamento
23bcb99166
Initial changes to NSBrowser for NSTreeController/binding integration
2024-07-06 22:02:10 -04:00
Gregory John Casamento
8fbcbdb380
Changes to allow editing
2024-07-05 01:57:09 -04:00
Gregory John Casamento
90d94fea22
Add unbind call to dealloc methods, add children method to proxy class, cleanup
2024-07-05 01:40:51 -04:00
Gregory John Casamento
7aee7f6667
Use ...ForNode: methods so that the path is dependent on the kind of node
2024-07-03 04:08:43 -04:00
Gregory John Casamento
ebf6bdb8d2
Update add method, fix white space issue, remove duplicate methods
2024-07-02 04:05:53 -04:00
Gregory John Casamento
860e1863da
Minor correction to spelling
2024-06-30 22:07:54 -04:00
Gregory John Casamento
6b2bddab4c
Add code to determine if a node has children and the number if the count key is not specified
2024-06-30 21:58:37 -04:00
Gregory John Casamento
ff97a5bbe2
Remove private method entirely, per discussion with @fredkiefer
2024-06-29 22:06:09 -04:00
Gregory John Casamento
aa4f9b5dbf
Remove NSString category per discussion with @fredkiefer
2024-06-29 21:48:27 -04:00
Gregory John Casamento
9a91d04bc0
Merge ChangeLog
2024-06-29 01:48:43 -04:00
Gregory John Casamento
ab2de84a90
Remove unneeded method, per discussion with @fredkiefer
2024-06-28 19:39:10 -04:00
Gregory John Casamento
786b48dd1b
Remove unneeded method
2024-06-28 09:45:41 -04:00
Gregory John Casamento
647076cb8a
Update copyWithZone: method, provide simple implementation of addSelectionIndexPaths:
2024-06-28 08:39:39 -04:00
Gregory Casamento
b0d02aa7e8
Merge branch 'master' into NSMenuToolbarItem_branch
2024-06-28 08:31:11 -04:00
Gregory John Casamento
6b808f2d24
Whitespace cleanup, remove unneeded methods, remove NSLogs
2024-06-27 05:54:06 -04:00
Gregory John Casamento
930e3b6c0f
Update isExpandable: to be used either in the case where we have a dataSource or if we have a binding, also use it in the loadItem... method so the logic for this is in ONE place
2024-06-27 05:37:01 -04:00
Gregory John Casamento
fb2f605e18
Update drawing code to handle binding, add NSString private method to helpers, remove debugging code from binding connector and outline
2024-06-26 18:17:21 -04:00
Gregory John Casamento
340b95c9fa
Limit the items we grab from the binding. Check if item is expanded, etc
2024-06-25 19:43:12 -04:00
Gregory John Casamento
3dfcdf6570
Update loading mechanism and add new proxy class for tree node
2024-06-25 17:11:57 -04:00
Gregory John Casamento
f7afc331eb
Interim changes before refactor of NSTreeController
2024-06-24 08:50:22 -04:00
Gregory John Casamento
1d29613491
Progress, thusfar...
2024-06-19 03:28:39 -04:00
Gregory John Casamento
bfb33156cf
Move code over from old branch, startint new branch since NSOutlineView was refactored
2024-06-19 01:46:27 -04:00
Gregory John Casamento
baca2ae98a
Minor cleanup, move storage of view code to conditional where it is created, suggested by @fredkiefer
2024-06-16 21:01:41 -04:00
Gregory John Casamento
cf7b9ebd39
Final changes suggested by @fredkiefer and some small fixes before merge
2024-06-16 20:52:06 -04:00
Gregory John Casamento
f9b89c41e6
Correct minor theme drawing issues, fix issue pointed out by @fredkiefer to address out of order row fetching
2024-06-16 17:36:15 -04:00
Gregory John Casamento
77bf2f823b
Move method back, eliminate possible duplicate call to render outline cell, changes suggested by review with @fredkiefer
2024-06-16 16:25:00 -04:00
Gregory John Casamento
b4c98b329b
Move method that renders the outline icon per discussion with @fredkiefer, also includes some whitespace fixes
2024-06-16 08:38:12 -04:00
Gregory John Casamento
a815ad5bb8
Edits suggested by @fredkiefer during review
2024-06-16 07:25:44 -04:00
Gregory John Casamento
1d6a850081
Make correctiongs as suggested by @fredkiefer
2024-06-16 07:12:32 -04:00
Gregory John Casamento
f83098bd8d
Update changelog
2024-06-16 07:02:13 -04:00
rfm
d312fbe168
Fix for #276
2024-06-03 16:55:33 +01:00
rfm
f93ca6eeb6
Don't use lazy locks any more
2024-05-30 11:15:19 +01:00
rfm
7a98157dc7
gnustep_global_lock is removed
2024-05-30 10:35:02 +01:00
Riccardo
6094e40e8e
Merge pull request #275 from gnustep/Magick_TGA
...
ImageMagick TGA support fix
2024-05-22 15:06:32 +02:00
Riccardo Mottola
3ec731943c
use a constant for signature and use for now only the bytes needed for TGA
2024-05-21 14:38:26 +02:00
Riccardo Mottola
7feeccceab
use memset instead of bzeo, to conform to the rest of the file
2024-05-17 11:37:57 +02:00
Riccardo Mottola
f02d54ee8a
code reformat
2024-05-17 10:58:37 +02:00
Riccardo
8913711a6d
Merge pull request #271 from gnustep/Endianess_BitmapRep
...
Improve Endianness support for BitmapRep
2024-05-15 09:48:23 +02:00
Riccardo Mottola
656fe6e576
seek for trailing signature and recognize v2 TGA files and hint that to ImageMagick
2024-05-14 00:56:39 +02:00
Riccardo Mottola
d9b291085d
some come indenting cleanup
2024-05-13 22:10:31 +02:00
Riccardo Mottola
41ba427101
call SWAP_LINE_ENDIANNESS iniside the WRITE_SCANLINE macro and thus remove if() duplication
2024-05-13 21:53:06 +02:00
Riccardo Mottola
2328f7e99a
use char for bool
2024-05-13 21:43:58 +02:00
Adam Fox
ae6323b042
Revert to defaultParagraphStyle tab stops from 10 years ago ( #272 )
...
* Uncomment defaultParagraphStyle tab stop defaults from 10 years ago.
* move creation of tab stops for defaultParagraphStyle into the init method
* Update ChangeLog
* fix build error
* Update ChangeLog
2024-05-13 18:47:42 +02:00
Riccardo Mottola
22dbbbb1f6
swap only if 16 or 32 bits, otherwise endianness has no meaningwq
2024-05-09 01:17:01 +02:00
Riccardo Mottola
f77370178a
update include guard to actual file name
2024-05-08 11:24:15 +02:00
Riccardo Mottola
b35b5714ed
update Adam's historic mail and copyright dates
2024-05-08 11:18:13 +02:00
Riccardo Mottola
4ea49b0260
now that we have individual flags to check, group swapping into a one big macro
2024-05-08 11:12:11 +02:00
Riccardo Mottola
55b75b9e33
instad of using NSBitmapFormat use individual flags
2024-05-08 10:28:49 +02:00
Riccardo Mottola
7c833cb5a6
try to swap 16bit and 32bit images line-per-line always into host byte order for TIFF library to write
2024-05-07 23:22:05 +02:00
Gregory John Casamento
27c9dc9207
Fix whitespace in NSTableRowView.[hm]
2024-05-06 10:09:39 -04:00
Gregory John Casamento
8fc0bffc5c
Eliminate white-space
2024-05-06 09:49:19 -04:00
Gregory John Casamento
d3f05037eb
Finish implementation of NSMenuToolbarItem
2024-05-04 09:27:05 -04:00
Gregory Casamento
52423a430c
Revert questionable change to NSTextView
2024-05-04 06:26:19 -04:00
Gregory John Casamento
5ab8768283
Add code to show image for NSMenuToolbarItem
2024-05-03 16:28:24 -04:00
Gregory John Casamento
bd4e093bad
Add NSMenuToolbarItem skeleton
2024-05-03 13:52:23 -04:00
Gregory John Casamento
b7bea0213b
Fix issue with view refresh/editability, refactor so that view sizing happens in the correct place
2024-05-03 10:40:08 -04:00
Gregory John Casamento
bec2392e33
Fix to NSTextView issue where it goes into an infinite loop if the event is returned as nil
2024-05-01 19:19:45 -04:00
Gregory John Casamento
b9c5ba35be
Rename variables to be a bit more meaningful
2024-04-30 04:38:41 -04:00
Gregory John Casamento
9070a9d30f
Move view rendering to viewAtColumn:row:makeIfNecessary: and eliminate uneeded private method
2024-04-28 15:04:29 -04:00
Gregory John Casamento
4d5957eaf7
Fully refactor delegate calls into NSTableView/NSOutlineView and move outlineColumn drawing to a public method
2024-04-28 09:49:19 -04:00
Gregory John Casamento
77ce97c266
Update to use NSTableRowView
2024-04-28 07:17:43 -04:00
Gregory John Casamento
f7e4b70f54
Return the NSTableRowView for the current row
2024-04-27 09:07:56 -04:00
Gregory John Casamento
d3a0dd23c0
Add 10.7 methods to NSTableView, implement viewAtColumn:row:makeIfnecessary:
2024-04-26 13:08:35 -04:00
Gregory John Casamento
41c7257d4b
Add 10.7 methods and add next/prev row selected ivars
2024-04-26 13:08:35 -04:00
Gregory John Casamento
dfef9c9e1f
Finish skeleton
2024-04-26 13:08:35 -04:00
Gregory John Casamento
4d2dcb9e04
Add skeleton for NSTableRowView class that includes set/get methods
2024-04-26 13:08:35 -04:00
Gregory Casamento
82dce67eb4
Reduce code duplication in GSThemeDrawing table/outline view drawing methods ( #262 )
...
* Reduce code duplication in drawViewCell:... method
* Further reduce code duplication, add common private method for calculating starting and ending column
* Use the tableView in the method that calculates the starting and ending rows
* Add code to properly handle prototypeViews, the XIB is NOT split, I was confused
* Call awakeFromNib on view as well
* Refactor so that the outlineColumn drawing code is shared
* Adjust the image drawing and the clickable area to be more aligned also make it easier to expand or collapse an item in the outline view
2024-04-26 18:40:11 +02:00
Frederik Carlier
2ebf167e6f
It looks like GNUstep backend is not yet installed ( #263 )
2024-04-25 17:22:57 +02:00
Gregory John Casamento
930eb54290
Merge branch 'master' of github.com:gnustep/libs-gui into NSTableCellView_branch
2024-04-24 13:55:35 -04:00
williameveretteggplant
140124ed35
Revert "Left shift key equivalent modifier mask in xib unarchiver ( #259 )" ( #260 )
...
This reverts commit d1562a37cd
.
2024-04-23 20:09:39 +02:00
Gregory John Casamento
0e36b42837
Add a check to make sure that ov is set
2024-04-23 02:19:17 -04:00
Gregory John Casamento
3ff5efed30
Encapsulate the renderedPaths and pathsToViews ivars that track which views were displayed in a viewBased table
2024-04-22 09:00:53 -04:00
Gregory John Casamento
c1e3cf2f08
Fix the image position and refresh when opening and closing items if it is a viewBased outline view. Tested and behavior seems consistent with macOS 14.
2024-04-22 09:00:53 -04:00
Gregory John Casamento
3c01238988
Remove checks for the class/subclass of NSTableView/NSOutlineView, but make the decision about how to render by depending on which delegate method is implemented
2024-04-22 09:00:53 -04:00
Gregory John Casamento
64150ff2ba
Minor cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
abde29dbe3
Remove GSXibInternal.h reference from GSXib5KeyedUnarchiver to correct compilation error
2024-04-22 09:00:53 -04:00
Gregory John Casamento
a11f562997
Remove GSXibInternal, since it is not needed for this PR. Make drawing method parameter types more explicit, correct delegate method name in NSOutlineView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
48d031a14a
Add improvements suggested by @fredkiefer
2024-04-22 09:00:53 -04:00
Gregory John Casamento
42bae42431
Fix issues mentioned by @fredkiefer
2024-04-22 09:00:53 -04:00
Gregory John Casamento
5d17658b0e
Add 10.12 imageViewWithImage to NSImageView, show outline view image to let the user know the item is expandable
2024-04-22 09:00:53 -04:00
Gregory John Casamento
9da7bd4502
Add implementation of NSUserInterfaceItemIdentifier to NSView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8c9278e12a
Fix memory leak when creating the blank image, the image is retained by -[NSCell initImageCell:]
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e74144b1bd
Fix memory leak when creating the blank image, the image is retained by -[NSCell initImageCell:]
2024-04-22 09:00:53 -04:00
Gregory John Casamento
829d5367f9
Correct mispelling of key
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e55babb04e
Add code to handle Title property on NSTableColumn, add code to NSTableView to set the table view to _viewBased if it responds to tableView:viewForTableColumn:row:
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8895bd0335
Code cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
6ca3708722
Code cleanup, remove duplicates, reorganize some methods so that it is the same as in the header
2024-04-22 09:00:53 -04:00
Gregory John Casamento
f787edfcfb
Consolidate and refactor the cellview methods in the theme drawing code, so that there is no repeated code
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8e2df65156
Add GSInternal.h
2024-04-22 09:00:53 -04:00
Gregory John Casamento
110b650a95
Add new class to hold deferred XIB data
2024-04-22 09:00:53 -04:00
Gregory John Casamento
fbb94af67b
Add methods to register views
2024-04-22 09:00:53 -04:00
Gregory John Casamento
726485fdc9
Add code to encode/initWithCoder to keys
2024-04-22 09:00:53 -04:00
Gregory John Casamento
d9d4f63c24
Whitespace cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8d9cb6f933
Add logic to get the column / row for a given view
2024-04-22 09:00:53 -04:00
Gregory John Casamento
182427bf97
Add code to support item identifier to NSTableView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
53e040a6bb
Changes to support view based NSOutlineView, untested
2024-04-22 09:00:53 -04:00
Gregory John Casamento
f71ee8641b
Initial changes for NSOutlineView view-based support
2024-04-22 09:00:53 -04:00
Gregory John Casamento
d99f82896b
Remove uneeded checks for _viewBased
2024-04-22 09:00:53 -04:00
Gregory John Casamento
db773ae9ec
Don't add the view again if it's one that has already been added, this causes the application to poll unneccessarily
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e19038665b
Use an NSMapTable to store which views have been displayed
2024-04-22 09:00:53 -04:00
Gregory John Casamento
a73c3cc876
Add code to track if a view has been rendered, fix issue with duplication of the view, I am not sure if this method of tracking that the view has been rendered is correct, but it works for now
2024-04-22 09:00:53 -04:00
Gregory John Casamento
20f29b2d1d
Add code to cause delegate methods which are not used for viewBased tables to be called in viewBased mode, add code to instantiate the prototypeCellView when adding it to the tableView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
5294e2a126
Add private method to return the prototypeCellViews array
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e4c7bb540c
Add prototype cell view support, remove code that forces prototypeCellView to be NSView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
b06b23c97c
Add code to instnatiate the NSTableCellView if the delegate method does not exist
2024-04-22 09:00:53 -04:00
Gregory John Casamento
74487bcfa5
Remove comment
2024-04-22 09:00:53 -04:00
Gregory John Casamento
d11c7e3dbc
Remove unused variables
2024-04-22 09:00:53 -04:00
Gregory John Casamento
a9653a71a2
Draw the view in the confines of the cell frame
2024-04-22 09:00:53 -04:00
Gregory John Casamento
ebdbe0930f
Add methods to theme and to NSTableView to get the view from the delegate, this is a partial commit to save my place here... will follow up shortly
2024-04-22 09:00:53 -04:00
Gregory John Casamento
0be95eba5b
Update gorm version and add new code to store/retrieve NSViewBased key
2024-04-22 09:00:53 -04:00
Gregory John Casamento
c9539af267
Add new classes
2024-04-22 09:00:53 -04:00
Gregory John Casamento
0276e307cc
Fix compile error, add new class
2024-04-22 09:00:53 -04:00
Gregory John Casamento
20a08a894f
Minor updates
2024-04-22 09:00:53 -04:00
Gregory John Casamento
1b467763bc
Rebased to master
2024-04-22 09:00:53 -04:00
Gregory John Casamento
cad79f2e0e
Add non-keyed coding
2024-04-22 09:00:53 -04:00
Gregory John Casamento
b895ffe953
Add NSTableCellView class header and simple implementation
2024-04-22 09:00:53 -04:00
Gregory John Casamento
4800a950ef
Add new classes
2024-04-22 09:00:53 -04:00