Eric Wasylishen
d8ed82a8a8
* Source/NSTableView.m (-_isCellEditableColumn:row:): Tweak
...
criteria for determining cell editability::
- the delegate (if present) must say YES
- and the cell itself must return YES for isEditable
- and the table column must return YES for isEditable
Previously you could edit cells that returned NO for
isEditable if the column they were in was editable.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34320 72102866-910b-0410-8b05-ffd578937521
2011-12-19 00:18:58 +00:00
Fred Kiefer
8ad4aa86c4
Replace some occurences of int with NSInteger
...
and unsigned with NSUInteger. This allows to recompile gui on
64 bit systems after the change to NSNotFound in base.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
Gregory John Casamento
f69ffcb8e3
Changes to encode and decode sortDescriptors into the gorm file.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33430 72102866-910b-0410-8b05-ffd578937521
2011-07-02 19:41:38 +00:00
Fred Kiefer
2cb8461350
Implement the drag and drop support method
...
namesOfPromisedFilesDroppedAtDestination:
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32628 72102866-910b-0410-8b05-ffd578937521
2011-03-17 10:19:11 +00:00
Fred Kiefer
8bacce8660
Send the sort message to the data source not the delegate.
...
This should fix bug #32806 .
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32624 72102866-910b-0410-8b05-ffd578937521
2011-03-16 19:07:53 +00:00
Fred Kiefer
b7d056ae43
Removed dead assignments found by static code analyser.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32551 72102866-910b-0410-8b05-ffd578937521
2011-03-13 15:26:20 +00:00
Fred Kiefer
906201acf6
Remove dead assignments found by static code analysis.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32022 72102866-910b-0410-8b05-ffd578937521
2011-02-09 22:20:00 +00:00
Fred Kiefer
de9abfb7ee
Correct the definition of NSDragOperation and all its usages.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31754 72102866-910b-0410-8b05-ffd578937521
2010-12-22 16:16:14 +00:00
Gregory John Casamento
285bafeebe
Correcting spelling error in one of the theme methods.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31701 72102866-910b-0410-8b05-ffd578937521
2010-12-02 17:23:00 +00:00
Gregory John Casamento
64516b7af5
Additional table view methods for themeing.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31679 72102866-910b-0410-8b05-ffd578937521
2010-11-28 03:55:58 +00:00
Gregory John Casamento
529856ef33
Added NSTableView to the drawing methods for GSTheme.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31678 72102866-910b-0410-8b05-ffd578937521
2010-11-28 00:05:46 +00:00
Fred Kiefer
d08b23d9b0
First batch of corrections based on David's static analysis.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31337 72102866-910b-0410-8b05-ffd578937521
2010-09-12 16:34:22 +00:00
Wolfgang Lux
545782e338
Fix bug where the _selectedRow attribute of an NSTableView could be
...
updated incorrectly.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31207 72102866-910b-0410-8b05-ffd578937521
2010-08-30 06:59:00 +00:00
Wolfgang Lux
a8e617e01f
Correct serious nib loading bug on big endian machines.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30472 72102866-910b-0410-8b05-ffd578937521
2010-05-29 08:32:02 +00:00
Fred Kiefer
63638ee055
Remove compiler warnings from clang.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30117 72102866-910b-0410-8b05-ffd578937521
2010-04-10 17:48:46 +00:00
Fred Kiefer
7e289df84b
Yet another set of #include -> #import replacement.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30083 72102866-910b-0410-8b05-ffd578937521
2010-03-31 08:14:50 +00:00
Gregory John Casamento
bb7df81e99
* Source/NSTableView.m: Add nil check to make sure that the
...
nil values set for certain keys don't get set since they are
normally set by connections later in the nib loading process.
I'm not sure why IB includes these when they're set to nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30082 72102866-910b-0410-8b05-ffd578937521
2010-03-31 04:02:03 +00:00
Jonathan Gillaspie
4b4cc7452c
Don't attempt to add a nil sort descriptor
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30005 72102866-910b-0410-8b05-ffd578937521
2010-03-19 23:39:07 +00:00
Quentin Mathe
2da78331b1
Fixed table header/content random disappearance with unarchived table/outline
...
views.
NSTableView non-keyed unarchiving was not always initializing _columnOrigins.
NSScrollView keyed unarchiving was decoding non-encoded flags (the flags were
thus initialized with random memory content).
See ChangeLog for detailed explanations.
Also added double action keyed archiving to NSTableView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29494 72102866-910b-0410-8b05-ffd578937521
2010-02-06 11:32:34 +00:00
Quentin Mathe
b9306be2f8
Fixed sort direction stuck to the reverse of the sort descriptor prototype
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29298 72102866-910b-0410-8b05-ffd578937521
2010-01-16 22:43:31 +00:00
Quentin Mathe
668fbe236a
Rewrote _selectColumn:modifiers: to be simpler, support selection by range as
...
Cocoa does, and remove the toggle selection behavior when a column is clicked
twice (in conflict with the ability to change the sort direction).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29296 72102866-910b-0410-8b05-ffd578937521
2010-01-16 20:29:59 +00:00
Quentin Mathe
f616b91157
Finished to implement the NSTable/OutlineView sort descriptor support.
...
More changes are needed to get proper sorting support (e.g. visual feedback).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29293 72102866-910b-0410-8b05-ffd578937521
2010-01-16 14:45:13 +00:00
Quentin Mathe
c444ae92d2
Added -columnIndexesInRect: and updated documentation
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29175 72102866-910b-0410-8b05-ffd578937521
2009-12-27 16:05:48 +00:00
Wolfgang Lux
fbf8c3edb5
Fix incorrect assignment in last commit.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29162 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:27:56 +00:00
Wolfgang Lux
f1f4f87395
Usability improvement: A single click into a cell of an unselected row
...
of a table view now can change the cell's state even when the table
view allows dragging.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29161 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:21:40 +00:00
Quentin Mathe
0f48d893e8
Corrected table view to support drop on root with -1 as the drop row (as
...
explained in the Cocoa documentation).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29137 72102866-910b-0410-8b05-ffd578937521
2009-12-17 13:51:40 +00:00
Wolfgang Lux
786f376f1b
Fix various issues when drawing controls with edited cells. This
...
includes a fix for the problem of properly resizing and redrawing the
editor when the cell is resized or moved during editing (bug #22678 ).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29133 72102866-910b-0410-8b05-ffd578937521
2009-12-17 01:03:07 +00:00
Quentin Mathe
19dad5cba6
Modified the drag code to call -canDragRowsWithIndexes:atPoint: as expected
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29100 72102866-910b-0410-8b05-ffd578937521
2009-12-05 23:22:39 +00:00
Richard Frith-MacDonald
8a7cfaf918
fix drawing bug when number of rows decreases
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29065 72102866-910b-0410-8b05-ffd578937521
2009-11-26 20:33:44 +00:00
Fred Kiefer
17ef668924
Move corner view drawing into GSTheme.
...
Add new 10.3 methods for NSTableHeaderCell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28985 72102866-910b-0410-8b05-ffd578937521
2009-11-09 14:53:59 +00:00
Richard Frith-MacDonald
452ffee567
Small theme update, plus documentation fixes and tweaks to avoid warnings.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28538 72102866-910b-0410-8b05-ffd578937521
2009-08-25 07:46:37 +00:00
Fred Kiefer
e00133c375
* Source/NSTableView.m (-_editPreviousEditableCellBeforeRow:column:,
...
-_editNextEditableCellAfterRow:column:): Comment out the loop
around of the last change. This leads to wrong results, when the
table view isn't the only view in the window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28383 72102866-910b-0410-8b05-ffd578937521
2009-07-06 14:21:22 +00:00
Fred Kiefer
1dc747bf5d
Better implementation of changing the edited cell in a table view.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28381 72102866-910b-0410-8b05-ffd578937521
2009-07-05 21:52:17 +00:00
Fred Kiefer
45726cd72c
Compare row against _numberOfRows not _numberOfColumns.
...
Patch by Tim Schmielau <tim@smmo.org>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28379 72102866-910b-0410-8b05-ffd578937521
2009-07-05 09:45:18 +00:00
Gregory John Casamento
8369481079
* Source/NSScrollView.m: If the scrollview has scrollers,
...
don't pay attention to the hidden flag in nib loading.
* Source/NSTableView.m: if the table has a cornerview, don't
pay attention to the hidden flag in nib loading.
NOTE: In both instances it appears that Cocoa sets the hidden flag
when autohide is set to true. GNUstep handles this case differently,
so it's okay to ignore this flag when the scroller is in an
NSScrollView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28231 72102866-910b-0410-8b05-ffd578937521
2009-04-19 03:23:11 +00:00
Richard Frith-MacDonald
25dc9dc650
fix for bug #25553 reported by Lu Liyi
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27842 72102866-910b-0410-8b05-ffd578937521
2009-02-11 08:32:50 +00:00
Gregory John Casamento
8e20be5f2d
* Source/NSTableView.m: Switch to the alternate highlighting color
...
only when the background is white.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27252 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:44:52 +00:00
Gregory John Casamento
5518bc8938
* Source/NSTableView.m: Change highlighting color so that it shows
...
on both white and grey backgrounds.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27251 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:26:23 +00:00
Adam Fedor
7afdd32ac1
Revert library license version to 2 until applications can be converted
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
Fred Kiefer
1a9a9468c0
Check in the control not in the text field whether the cell is currently
...
being edited.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26613 72102866-910b-0410-8b05-ffd578937521
2008-06-09 10:04:49 +00:00
Fred Kiefer
0cb8c36a82
Don't raise exception on invalid row or column indexes for table view.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26486 72102866-910b-0410-8b05-ffd578937521
2008-05-03 18:05:07 +00:00
Fred Kiefer
0cba457027
Better check for click on table column border.
...
Allow table column identifier to be nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26482 72102866-910b-0410-8b05-ffd578937521
2008-05-01 19:48:28 +00:00
Fred Kiefer
68fc3bc403
Made data source method optional on NSTableView.
...
Add marker objects for KVB.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25751 72102866-910b-0410-8b05-ffd578937521
2007-12-17 13:35:31 +00:00
Fred Kiefer
8730f4cab8
Allow table views without header.
...
Popup buttons no longer display values from old menus after a change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25702 72102866-910b-0410-8b05-ffd578937521
2007-12-07 18:46:27 +00:00
Fred Kiefer
3cbe23c511
Patch for bezier path encoding.
...
Add support for new dragging methods in table view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25660 72102866-910b-0410-8b05-ffd578937521
2007-12-02 20:43:32 +00:00
Fred Kiefer
74841fc8ad
Add MacOS 10.4 methods.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25653 72102866-910b-0410-8b05-ffd578937521
2007-12-01 22:15:48 +00:00
Richard Frith-MacDonald
03a4a96a40
Update includes ... closer MacOS-X compatibility.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25635 72102866-910b-0410-8b05-ffd578937521
2007-11-29 20:28:03 +00:00
Fred Kiefer
00a7c05d91
Add binding implementation.
...
Clean up table view decoding.
Move image draw code to back.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25602 72102866-910b-0410-8b05-ffd578937521
2007-11-22 12:15:50 +00:00
Fred Kiefer
5ddb7aac7c
Two small patches by Wolfgang Lux <wolfgang.lux@gmail.com>.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25549 72102866-910b-0410-8b05-ffd578937521
2007-11-01 10:15:35 +00:00
Fred Kiefer
193e31e678
Change all files to use GPL 3 and LGPL 3.
...
Prepare for next release.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00