Commit graph

5606 commits

Author SHA1 Message Date
Eric Wasylishen
a4fa237d9e * Source/GSThemePrivate.h:
* Source/GSThemeTools.m:
	* Source/GSThemeDrawing.m: Add explicit isFlipped: param to
	-[GSDrawTiles contentRectForRect:]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37239 72102866-910b-0410-8b05-ffd578937521
2013-10-16 03:36:01 +00:00
Eric Wasylishen
310b7d5786 * Headers/Additions/GNUstepGUI/GSTheme.h: Remove GSScrollViewBottomCorner
part name, instead themes should just provide a part called NSScrollView.

	Add -scrollViewScrollersOverlapBorders method.

	* Source/GSTheme.m: Remove GSScrollViewBottomCorner part name.
	* Source/GSThemeDrawing.m: Add -scrollViewScrollersOverlapBorders.
	* Source/GSThemeDrawing.m (-drawBrowserRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the browser background
	with the NSScrollView tile.
	* Source/GSThemeDrawing.m (-drawScrollViewRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the scroll view background
	with the NSScrollView tile.
	* Source/NSScroller.m (-rectForPart:): Change the meaning of the
	GSScrollerKnobOvershoot default so the knob only overlaps the buttons
	by this much (rather than both ends of the track). Turns out this is more
	useful for themes.
	* Source/NSScrollView.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders]
	* Source/NSBrowser.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders] and
	-[GSTheme scrollViewUseBottomCorner]

	The overall point of these additions is to support NSScrollView and
	NSBrowser looking like: http://jesseross.com/clients/gnustep/ui/concepts/


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37238 72102866-910b-0410-8b05-ffd578937521
2013-10-15 23:26:51 +00:00
Eric Wasylishen
4e1aeabe94 * Source/NSTableView.m (-tile): Check the GSScrollViewNoInnerBorder
user default to see whether to expand the corner view by 1pt or not.
* Source/GSThemeDrawing.m (-drawTableHeaderRect:inView:): Remove
special case which reduced the width of the last column header by 1pt.

I don't see any reason for doing that and it looks better to me without
the gap, and more uniform for themeing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37237 72102866-910b-0410-8b05-ffd578937521
2013-10-15 20:33:46 +00:00
Eric Wasylishen
74bd902874 * Source/NSButtonCell.m:
* Source/NSMenuItemCell.m: Make a shared -themeControlState in
NSButtonCell and eliminate duplicated code.
* Source/NSPopUpButtonCell.m: Add private declaration for
-[NSButtonCell themeControlState]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37236 72102866-910b-0410-8b05-ffd578937521
2013-10-15 18:41:17 +00:00
Eric Wasylishen
1fdf58e506 * Headers/Additions/GNUstepGUI/GSTheme.h: Add -tabViewContentRectForBounds:
method.
* Source/GSThemeDrawing.m:
* Source/NSTabView.m: Move the -contentRect implementation to GSTheme
so we can delegate to GSDrawTiles, if used.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37234 72102866-910b-0410-8b05-ffd578937521
2013-10-15 07:27:44 +00:00
Eric Wasylishen
2cdd882e36 * Source/NSTabViewItem.m (-drawLabel:inRect:): Center label vertically
inside the tab.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37233 72102866-910b-0410-8b05-ffd578937521
2013-10-15 07:08:01 +00:00
Eric Wasylishen
fc5c32e1b3 * Source/NSTabView.m (-initWithCoder:): Make non-keyed archives
call -selectTabViewItem: to select the current tab at unarchiving
	time (keyed archives were already doing this.)

	Comment: "N.B.: As a side effect, this discards the subview frame
	and sets it to [self contentRect].

	This is desirable because the subview frame will be different
	depending on whether the arcive is from Cocoa or GNUstep,
	and which GNUstep theme was active at save time.

	However, it does mean that the tab view contents should be
	prepared to resize slightly."

	The immediate need for this is tab views were changed to use
	flipped coordinates, so the subview frames stored in existing
	archives are now in the wrong coordinate system.

	This is essentially the same idea as NSScrollView calling -tile at the
	end of -initWithCoder: so I hope it makes sense for tab views too.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37232 72102866-910b-0410-8b05-ffd578937521
2013-10-15 06:17:36 +00:00
Eric Wasylishen
a55c2a9189 * Source/GSThemeDrawing.m (-tabHeightForType:): Check for nil
before calling -size on an NSImage, for systems where this
corrupts the stack.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37231 72102866-910b-0410-8b05-ffd578937521
2013-10-15 04:21:45 +00:00
Eric Wasylishen
77b7b9558e * Source/GSThemeDrawing.m: Change stepper drawing methods to use
images. The stepper is too small to make decomposing it in to
border + bezel + arrow worthwhile; it's simpler to just use images.
* Images/GNUmakefile:
* Images/common_StepperDown.tiff:
* Images/common_StepperDownHighlighted.tiff:
* Images/common_StepperUp.tiff:
* Images/common_StepperUpHighlighted.tiff: Add stepper images


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37229 72102866-910b-0410-8b05-ffd578937521
2013-10-14 20:52:55 +00:00
Eric Wasylishen
6f4a16835b * Headers/Additions/GNUstepGUI/GSTheme.h: Add three new theme
control state: GSThemeFirstResponderState,
GSThemeHighlightedFirstResponderState,
and GSThemeSelectedFirstResponderState. This lets themes draw
custom first responder tiles, if the desired effect can't be
accomplished by drawing on top of an existing button.
* Source/GSThemeDrawing.m (-drawFocusFrame:inRect:):
Use tiles named "NSFocusRing" if available, else draw dotted
rect.
* Source/GSTheme.m:
* Source/NSButtonCell.m: Use new GSTheme*FirstResponderState
states


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37227 72102866-910b-0410-8b05-ffd578937521
2013-10-14 17:18:38 +00:00
Eric Wasylishen
856b71dd2f * Source/GSThemeDrawing.m (-drawTableViewBackgroundInClipRect:...):
Add support for drawing striped table backgrounds, using the colors
returned by [NSColor controlAlternatingRowBackgroundColors].
Currently not used because
-[NSTableView usesAlternatingRowBackgroundColors] is hardcoded to
return NO.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37226 72102866-910b-0410-8b05-ffd578937521
2013-10-14 07:05:05 +00:00
Eric Wasylishen
9dfd31dc6e * Source/NSSliderCell.m (-drawKnob:): Don't fill the knob
with a background color before drawing the cell. Seems pointless
- GNUstep's default knob image is opaque, but filling with a solid
color prevents transparent knob images from looking good.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37224 72102866-910b-0410-8b05-ffd578937521
2013-10-14 04:16:30 +00:00
Eric Wasylishen
5501a5a4b7 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSTheme.m: Add GSProgressIndicatorBezel part name
* Source/GSThemeDrawing.m (-drawProgressIndicatorBezel:withClip:):
Use GSProgressIndicatorBezel to draw bezel if available.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37222 72102866-910b-0410-8b05-ffd578937521
2013-10-14 03:31:54 +00:00
Eric Wasylishen
bd3426dd41 * Source/GSThemeTools.m (-initWithNinePatchImage:): Parse the
"optiacal bounds" metadata in 9-patch images. It's stored
in the layoutRect ivar but not used otherwise.

See "Optical bounds layout" section of:
http://developer.android.com/about/versions/android-4.3.html
* Source/GSThemePrivate.h (GSDrawTiles): Add layoutRect ivar


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37219 72102866-910b-0410-8b05-ffd578937521
2013-10-12 18:24:33 +00:00
Eric Wasylishen
a627839460 * Source/NSColorWell.m (-drawRect:): Remove incorrect intersection
with clipping rect that was causing artifacts when scrolling a list
of color wells in Thematic.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37218 72102866-910b-0410-8b05-ffd578937521
2013-10-12 04:48:04 +00:00
Eric Wasylishen
1411fdfa3a * Source/GSThemeTools.m: Fix unflipped/flipped coordinates bug
in the 9-patch content rect parsing code. Add some comments.
Simplify contentRectForRect: implementation.
* Source/GSThemeDrawing.m (-browserHeaderDrawingRectForCell:...):
Use -contentRectForRect: to get the content rect instead of
incorrectly reading from ivar. Fixes broken text positioning
in browser header with Nesedah theme.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37217 72102866-910b-0410-8b05-ffd578937521
2013-10-12 04:33:59 +00:00
Germán Arias
c713f8cb04 Fix last commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37215 72102866-910b-0410-8b05-ffd578937521
2013-10-09 19:45:55 +00:00
Germán Arias
123703e8e1 Send events mouse entered only if the cursor rectangle is valid.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37214 72102866-910b-0410-8b05-ffd578937521
2013-10-09 19:07:36 +00:00
Germán Arias
a0f6ce809f Set _lastPoint after update the cursor in NSWindow.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37213 72102866-910b-0410-8b05-ffd578937521
2013-10-09 18:52:39 +00:00
Eric Wasylishen
3e533f43b1 * Source/GSThemeDrawing.m:
* Source/GSTheme.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add part names for
themeing bottom tabs.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37211 72102866-910b-0410-8b05-ffd578937521
2013-10-09 01:48:50 +00:00
Eric Wasylishen
3d3125cdde * Source/GSThemeDrawing.m (-drawBoxInClipRect:...):
* Source/NSBox.m (-calcSizesAllowingNegative):
Special case for box type NSBoxSeparator to draw a centered line


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37210 72102866-910b-0410-8b05-ffd578937521
2013-10-08 23:42:30 +00:00
Eric Wasylishen
74fa44060f * Source/NSTabView.m: Fix incorrect content rect now that view
is flipped.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37209 72102866-910b-0410-8b05-ffd578937521
2013-10-08 20:30:28 +00:00
Eric Wasylishen
8624e56f43 * Source/GSTheme.m (-tilesNamed:state:): Interpret .9.png files
as NinePatch=YES. If a tile isn't listed in GSThemeTiles in the
plist, try to find it in the ThemeTiles directory anyway. This
lets you avoid declaring tiles in the info plist.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37208 72102866-910b-0410-8b05-ffd578937521
2013-10-08 19:32:09 +00:00
Eric Wasylishen
02bc49e2d5 * Source/GSThemeDrawing.m (NSBox): If drawing with theme tiles,
use actual clipping to clip a hole in the border, so we can avoid
filling anything with the background color.
* Source/NSBox.m (-isOpaque:): change to NO.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37207 72102866-910b-0410-8b05-ffd578937521
2013-10-08 18:22:15 +00:00
Eric Wasylishen
0786f621f2 * Source/NSTabView.m: Uncomment - (BOOL) isFlipped { return YES; }
* Source/GSThemeDrawing.m: Change tab drawing to assume flipped
coordinates


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37206 72102866-910b-0410-8b05-ffd578937521
2013-10-08 17:35:44 +00:00
Eric Wasylishen
7d7cac6780 * Source/GSThemeDrawing.m: Rewrite tab drawing code to be more
organized, lay out the images in a straightforward way, and
allow themeing the fill part of the tab between the end images.
The output is almost pixel-identical to
the old code (only some unnoticable 1-pixel differences
in where shadows end). It's also organized so that adding support
for left and right tabs should be easy.
* Headers/Additions/GNUstepGUI/GSTheme.h: Add some part names
* Images/common_Tab*.tiff: Tweak to work with the new layout code.
All top images are now the same size, as are all bottom images.
* Images/GNUmakefile:
* Images/common_TabUnSelectToSelectedJunction.tiff: Renamed to
Images/common_TabUnSelectedToSelectedJunction.tiff
* Source/GSThemePrivate.h:
* Source/GSTheme.m: Add GSStringFromTabViewType utility function


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37205 72102866-910b-0410-8b05-ffd578937521
2013-10-08 08:01:23 +00:00
Eric Wasylishen
11d5fc7902 * Source/GSThemeDrawing.m (-drawTableViewGridInClipRect:inView:):
Clean up grid drawing code; use rect fills to avoid blurriness.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37204 72102866-910b-0410-8b05-ffd578937521
2013-10-07 23:32:14 +00:00
Eric Wasylishen
69acbb22b1 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSThemeDrawing.m:
* Source/NSPopUpButtonCell.m:
Remove -[GSTheme drawBorderAndBackgroundForPopUpButtonCell:
withFrame:inView:state:] which I added recently, and just use
-[GSTheme drawButton:in:view:style:state]. This way,
NSPopUpButtonCell automatically supports all of the different
NSBezelStyles.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37202 72102866-910b-0410-8b05-ffd578937521
2013-10-07 07:29:13 +00:00
Eric Wasylishen
d651b3154c * Source/GSTitleView.m: Use the GSTheme
-setName:forElement:temporary: mechanism to bind the menu close
button's cell to the name GSMenuCloseButton, so themes can provide
a custom border for this button.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37201 72102866-910b-0410-8b05-ffd578937521
2013-10-07 06:23:02 +00:00
Eric Wasylishen
e72fe86870 * Documentation/GuiUser/DefaultsSummary.gsdoc:
* Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSThemeDrawing.m:
* Source/NSScroller.m: Add defaults GSScrollerScrollsByPage
and GSScrollerArrowsSameEnd to allow customizing scroller
behaviour beyond the combinations provided by NSInterfaceStyle.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37200 72102866-910b-0410-8b05-ffd578937521
2013-10-07 03:29:14 +00:00
Eric Wasylishen
481d535880 * Source/NSColor.m:
* Source/NSColorWell.m: Move code to draw the black and white
triangles background for transparent colors to
-[NSColor drawSwatchInRect:].


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37194 72102866-910b-0410-8b05-ffd578937521
2013-10-04 07:18:27 +00:00
Eric Wasylishen
53dcd018ad * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSThemeDrawing.m:
* Source/NSBrowser.m:
* Source/NSTableHeaderCell.m: Add custom color names
tableHeaderTextColor and browserHeaderTextColor for
table and browser headers.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37193 72102866-910b-0410-8b05-ffd578937521
2013-10-04 02:23:16 +00:00
Eric Wasylishen
467edcbeef * Source/NSMenuItemCell.m: If the cell is highlighted, draw
the arrow using NSHighlightedMenuArrow (if available).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37192 72102866-910b-0410-8b05-ffd578937521
2013-10-04 00:50:45 +00:00
Eric Wasylishen
fb723f8241 * Source/GSThemeDrawing.m: Use new -[GSDrawTiles themeMargins]
to get the margins for draw tiles.
* Source/GSThemePrivate.h:
* Source/GSThemeTools.m: Get the 9-patch content rect support
working from end-to-end.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37191 72102866-910b-0410-8b05-ffd578937521
2013-10-03 22:24:57 +00:00
Eric Wasylishen
c63df23ba8 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSTheme.m:
* Source/GSThemeDrawing.m:
* Source/NSBox.m: Factor out -[NSBox drawRect:] to GSTheme
method -drawBoxInClipRect:boxType:borderType:inView:.
Add a tiles name GSBoxBorder for themeing the box border.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37188 72102866-910b-0410-8b05-ffd578937521
2013-10-03 19:52:05 +00:00
Eric Wasylishen
5cd9dd8b7e * Source/NSSliderCell.m: Support themeing the circular slider
with the image @"common_CircularSlider". Draw the dimple
with @"common_Dimple" instead of an NSBezierPath.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37186 72102866-910b-0410-8b05-ffd578937521
2013-10-03 06:55:45 +00:00
Eric Wasylishen
2347347cf9 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSTheme.m:
Declare GSSliderHorizontalTrack and GSSliderVerticalTrack
part names for themeing the background of NSSlider
* Source/GSThemeDrawing.m:
Add new drawSliderBorderAndBackground:frame:inCell:isHorizontal:
method to draw the slider border and background.
* Source/GSThemePrivate.h:
* Source/GSThemeTools.m:
Add a -size method on GSDrawTiles which returns the total
original size of the tiles, so we can easily compute a rect
that scales the tiles in only one dimension.
* Source/NSSliderCell.m:
Override _drawBorderAndBackgroundWithFrame: to call new
GSTheme method. Also, tweak the knob drawing code; the knob
is now centered and drawn at its native size. This still looks
correct with the default slider sizes create by Gorm.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37185 72102866-910b-0410-8b05-ffd578937521
2013-10-03 04:51:10 +00:00
Eric Wasylishen
d3be1c555f * Source/NSMenuView.m (heightForItem:, yOriginForItem:):
Accept negative item indicies, which are passed in when
opening the preferences window in TextEdit. Need to investigate
further why that is happening.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37184 72102866-910b-0410-8b05-ffd578937521
2013-10-03 00:35:27 +00:00
Eric Wasylishen
dfab5c6196 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSTheme.m:
* Source/GSThemeDrawing.m:
* Source/NSPopUpButtonCell.m: Add a theme part GSPopUpButton
so NSPopUpButtonCell can be drawn with a different background
than NSMenuItemCell.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37183 72102866-910b-0410-8b05-ffd578937521
2013-10-02 23:56:16 +00:00
Eric Wasylishen
ea8ded398f * Source/NSMenuView.m: Read the menu item/menu bar/separator
height from GSTheme.
* Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/GSThemeDrawing.m: Add -menuBarHeight, -menuItemHeight,
-menuSeparatorHeight. Corresponding defaults are GSMenuBarHeight,
GSMenuItemHeight, GSMenuSeparatorHeight


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37182 72102866-910b-0410-8b05-ffd578937521
2013-10-02 22:06:24 +00:00
Eric Wasylishen
3bbfcbaab2 * Headers/Additions/GNUstepGUI/GSTheme.h:
* Source/NSScrollView.m:
* Source/GSThemeDrawing.m:
* Source/GSTheme.m: Add GSScrollViewUseBottomCorner default,
which themes can set to NO to leave a square gap in the bottom-
left (or bottom-right) corner where the horizontal and vertical
scrollers meet.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37176 72102866-910b-0410-8b05-ffd578937521
2013-09-30 05:53:21 +00:00
Eric Wasylishen
52f8843480 * Source/NSBrowser.m: Fix some position calculations from the last
commit


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37175 72102866-910b-0410-8b05-ffd578937521
2013-09-30 02:29:28 +00:00
Eric Wasylishen
67de37f017 * Source/NSBrowser.m:
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSBrowserUseBezels
user default. Themes can set it to NO to prevent NSBrowser from
drawing any bezels, even if separatesColumns is set to YES.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37174 72102866-910b-0410-8b05-ffd578937521
2013-09-30 00:38:09 +00:00
Eric Wasylishen
f0b96e967f * Source/NSBrowser.m: Small refactoring to simplify code.
Remove update logic from -setSeparatesColumns: and just use
-tile. Tested by toggling "separates columns" flag in Gorm.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37173 72102866-910b-0410-8b05-ffd578937521
2013-09-29 22:44:57 +00:00
Eric Wasylishen
8b6fffb7fc * Source/NSBrowser.m: Change NSBR_COLUMN_SEP and NSBR_VOFFSET
macros to static floats. Cache the values in +initialize and
when GSThemeDidActivateNotification is sent, by calling the
new GSTheme methods.
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add
-browserColumnSeparation and -browserVerticalPadding methods
which access user defaults GSBrowserColumnSeparation and
GSBrowserVerticalPadding. These determine the padding between
browser columns, and the vertical padding between the bottom
scroller, contents, and headers.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37171 72102866-910b-0410-8b05-ffd578937521
2013-09-29 19:36:08 +00:00
Fred Kiefer
47145c6c46 * Source/NSImage.m: Better protection against representation being nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37169 72102866-910b-0410-8b05-ffd578937521
2013-09-29 16:37:59 +00:00
Germán Arias
f006045995 Check the scrollview style to display the autocomplete window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37166 72102866-910b-0410-8b05-ffd578937521
2013-09-29 07:14:01 +00:00
Eric Wasylishen
2fe4c2e708 * Source/GSTheme.m:
* Source/GSTitleView.m:
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSMenuTitleBackground
theme tile for themeing the background of GSTitleView.

NOTE: I removed some code that was in -[GSTitleView drawRect:] for
drawing with a different style when the GSTitleView is NOT owned
by an NSMenu, but by an NSWindow/NSPanel (_ownedByMenu == NO).
If needed, this can be added back, but it doesn't appear to ever
be used in gnustep-gui - GSTitleView is only created in one place,
with NSMenu as the owner.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37165 72102866-910b-0410-8b05-ffd578937521
2013-09-29 00:30:59 +00:00
Eric Wasylishen
ef5f2cf19f * Source/NSCell.m (-highlight:withFrame:inView:):
Remove call to [controlView displayRect: cellFrame];
There was a comment saying it should be removed, and when
combined with the -[NSButtonCell isOpaque] change, it
was casuing scroller buttons to stay "stuck" down.
* Source/NSBrowser.m (-isOpaque):
* Source/NSButtonCell.m (-isOpaque):
* Source/NSColorWell.m (-isOpaque):
Force -isOpaque to return NO, because it's
possible to make all of these controls semitransparent with
theme tiles. This was visible with the Narcissus theme
(svn://svn.gna.org/svn/etoile/trunk/Etoile/Themes/Narcissus.theme)


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37164 72102866-910b-0410-8b05-ffd578937521
2013-09-28 21:38:29 +00:00
Eric Wasylishen
d3a8560cc5 * Source/GSThemeDrawing.m: Add GSScrollerDefaultWidth user default
so non-code themes can change -[GSTheme defaultScrollerWidth]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37163 72102866-910b-0410-8b05-ffd578937521
2013-09-28 20:40:42 +00:00
Eric Wasylishen
894b5b0059 * Source/NSScroller.m: Add GSScrollerKnobOvershoot default which
allows themes to make the scroller knob overlap the scroller buttons
by a specified amount.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37162 72102866-910b-0410-8b05-ffd578937521
2013-09-28 18:51:00 +00:00
Germán Arias
b8217cb63e Don't change the location of submenus in NSMacintoshInterfaceStyle.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37161 72102866-910b-0410-8b05-ffd578937521
2013-09-27 22:20:12 +00:00
Fred Kiefer
f1b45bbcad * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:): Don't
draw string when editing.
        * Source/NSBrowserCell.m (-titleRectForBounds:): Implement to
        exactly match calculation in -drawInteriorWithFrame:inView:.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37159 72102866-910b-0410-8b05-ffd578937521
2013-09-27 13:10:23 +00:00
Germán Arias
2decccabe0 Close popup if user press a modifier flag an theme process events.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37158 72102866-910b-0410-8b05-ffd578937521
2013-09-27 07:47:01 +00:00
Germán Arias
4877916592 Revert last change and implement a better solution.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37157 72102866-910b-0410-8b05-ffd578937521
2013-09-27 04:33:30 +00:00
Germán Arias
5559a2dfd1 Improvements at pulldown popups when the theme process events.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37154 72102866-910b-0410-8b05-ffd578937521
2013-09-25 05:42:27 +00:00
Ivan Vučica
baabe32c27 * Source/NSImage.m: Missing -retain inside the method
-drawInRect:fromRect:... caused a crash inside Opal backend.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37141 72102866-910b-0410-8b05-ffd578937521
2013-09-23 17:12:25 +00:00
Ivan Vučica
fa522babc4 * Source/NSImage.m: Missing -retain inside the method
-compositeToPoint:fromRect:operation:fraction caused a crash
inside Opal backend.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37140 72102866-910b-0410-8b05-ffd578937521
2013-09-23 16:58:18 +00:00
Gregory John Casamento
04a8a1e1a9 2013-09-18 18:17-EDT Gregory John Casamento <greg.casamento@gmail.com>
* Headers/AppKit/AppKit.h: Add NSTrackingArea.h                                                                                                         
        * Headers/AppKit/NSTrackingArea.h: Add interface for NSTrackingArea                                                                                     
        * Source/GNUmakefile: Add NSTrackingArea.[hm] to makefile.                                                                                              
        * Source/NSTrackingArea.m: Add implementation for NSTrackingArea  


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37112 72102866-910b-0410-8b05-ffd578937521
2013-09-18 22:19:12 +00:00
Riccardo Mottola
04f1819d3c silence more warnings
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37102 72102866-910b-0410-8b05-ffd578937521
2013-09-17 23:19:12 +00:00
Ivan Vučica
42f7c46547 NSLayoutManager: advancementbuf[0] was not being filled. Most backends, including cairo, ignore advancements, so the bug was not immediately apparent until opal backend started using the advancements.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37100 72102866-910b-0410-8b05-ffd578937521
2013-09-17 21:58:21 +00:00
Riccardo Mottola
5478f1e00c warning fix
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37088 72102866-910b-0410-8b05-ffd578937521
2013-09-17 09:39:47 +00:00
Fred Kiefer
581d7fcd0c * Source/NSBrowser.m (-setPath:): Fixed a bug where setting the
path to "/" would not deselect the cells.
  Based on patch by Frank Le Grand <frank.legrand@testplant.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37081 72102866-910b-0410-8b05-ffd578937521
2013-09-16 18:18:07 +00:00
Riccardo Mottola
c0c27b5f8c Prepare for additional argument to function DGifOpen in newer libgif versions.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37078 72102866-910b-0410-8b05-ffd578937521
2013-09-13 15:50:05 +00:00
Fred Kiefer
c75ec40019 * Source\NSAttributedString.m (-fixFontAttributeInRange:): In
* the
        absence of a NSFontAttributeName attribute, use a default font
to
        prevent the substitution from stopping. This fixes a bug where
        unicode characters would not get the proper font substitution.
        Patch by: Frank Le Grand <frank.legrand@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37027 72102866-910b-0410-8b05-ffd578937521
2013-08-30 15:30:22 +00:00
Fred Kiefer
9ad339a73a * Headers/Additions/GNUstepGUI/GSDisplayServer.h
* Source/GSDisplayServer.m: Add new method -_printEventQueue.
* Source/NSWindow.m (-_checkCursorRectangles:forEvent:): Replace
  hack with proper functions that handle cursor rectangles.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37026 72102866-910b-0410-8b05-ffd578937521
2013-08-30 11:27:10 +00:00
Fred Kiefer
aa9d40fcfd * Source/NSCursor.m (-mouseEntered:, -mouseExited:):
Add better debug output.
* Source/NSWindow.m (-_checkCursorRectangles:forEvent:): Add
hack that updates cursor rectangles more correctly.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37022 72102866-910b-0410-8b05-ffd578937521
2013-08-27 21:00:42 +00:00
Fred Kiefer
a93d126191 * Headers/AppKit/NSTreeController.h,
* Headers/AppKit/NSTreeNode.h: Add method declarations to these
        * files.
        * Headers/AppKit/AppKit.h,
        * Source/GNUmakefile: Include new files.
        * Source/NSObjectController.m (+initialize, -selection): Get
        * basic
        binding example working.
        * Source/NSTreeController.m: Minimal implementation.
        * Source/NSTreeNode.m: Full implementation of this class.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36991 72102866-910b-0410-8b05-ffd578937521
2013-08-19 19:10:22 +00:00
Fred Kiefer
ef49975949 Add code by Nikolaus Schaller <hns@computer.org>, reformatted and
simplified.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36982 72102866-910b-0410-8b05-ffd578937521
2013-08-17 13:39:16 +00:00
Luboš Doležel
ceb8720fb2 * Headers/AppKit/NSSavePanel.h,
* Source/NSSavePanel.m: beginSheetModalForWindow: and
beginWithCompletionHander: implementations



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36968 72102866-910b-0410-8b05-ffd578937521
2013-08-12 18:10:38 +00:00
Gregory John Casamento
4032737cf0 Add placeholder for NSStatusItem.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36950 72102866-910b-0410-8b05-ffd578937521
2013-08-08 20:28:33 +00:00
Quentin Mathe
4db314841a Fixed missing theme images if not listed in the theme bundle Info.plist.
Theme bundles that contain theme images named using either GNUstep or 
OPENSTEP names now work properly again (bug introduced in r36836).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36916 72102866-910b-0410-8b05-ffd578937521
2013-07-22 15:24:32 +00:00
Germán Arias
7eb3256964 Move code of previous commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36906 72102866-910b-0410-8b05-ffd578937521
2013-07-18 23:04:22 +00:00
Germán Arias
bb09eb6bca Improvements for PopUp when should process events.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36902 72102866-910b-0410-8b05-ffd578937521
2013-07-17 23:34:20 +00:00
Riccardo Mottola
28fff5bc13 Add license to the Theme properties
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36889 72102866-910b-0410-8b05-ffd578937521
2013-07-15 13:20:41 +00:00
Germán Arias
405b577cd1 Use arrow cursor in transient menus.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36875 72102866-910b-0410-8b05-ffd578937521
2013-07-12 05:03:34 +00:00
Fred Kiefer
32299abf5b * Headers/Additions/GNUstepGUI/GSDisplayServer.h
* Source/GSDisplayServer.m: Add new method -setIgnoreMouse::
        * with
        empty implementation.
        * Source/NSWindow.m (-setIgnoresMouseEvents:): Use this new
        * method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36854 72102866-910b-0410-8b05-ffd578937521
2013-07-08 20:42:49 +00:00
Germán Arias
4fe34147c1 Ignore the first mouse up in transient menus if style is NSWindows95InterfaceStyle.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36852 72102866-910b-0410-8b05-ffd578937521
2013-07-08 19:20:36 +00:00
Germán Arias
17db14c969 Revert last commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36849 72102866-910b-0410-8b05-ffd578937521
2013-07-08 01:33:25 +00:00
Germán Arias
5cfee62130 Prevent duplicate the cursor with -push.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36848 72102866-910b-0410-8b05-ffd578937521
2013-07-07 18:33:01 +00:00
Fred Kiefer
a5412c1f42 * Source/NSImageRep.m (-guiDrawInRect:...fraction:): Readd special
handling for printing as suggested by Eric Wasylishen <ewasylishen@gmail.com>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36847 72102866-910b-0410-8b05-ffd578937521
2013-07-07 15:26:21 +00:00
Quentin Mathe
da2351d2b2 Added support for providing custom theme control images (e.g. checkbox) in the same way we support it for tiles
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36836 72102866-910b-0410-8b05-ffd578937521
2013-07-04 15:46:11 +00:00
Richard Frith-MacDonald
461dcd25c9 fixes for bug reported by marcus
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36834 72102866-910b-0410-8b05-ffd578937521
2013-07-04 07:54:52 +00:00
Eric Wasylishen
2e67252907 Improve NSDrawThreePartImage implementation
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36827 72102866-910b-0410-8b05-ffd578937521
2013-07-03 22:03:59 +00:00
Eric Wasylishen
520993931f Add NSDrawThreePartImage
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36824 72102866-910b-0410-8b05-ffd578937521
2013-07-03 16:19:24 +00:00
Germán Arias
571a79bd47 Revert last change in NSCursor.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36806 72102866-910b-0410-8b05-ffd578937521
2013-07-03 00:05:31 +00:00
Germán Arias
34d629e05a Improvements to handle cursors.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36802 72102866-910b-0410-8b05-ffd578937521
2013-07-02 16:57:54 +00:00
Germán Arias
f2a56be6f5 Fix memory leak in GSComboWindow.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36744 72102866-910b-0410-8b05-ffd578937521
2013-06-22 22:47:35 +00:00
Germán Arias
dc0ac1b635 Fix problems with last commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36734 72102866-910b-0410-8b05-ffd578937521
2013-06-20 18:33:52 +00:00
Germán Arias
70b54d1f0d Add autocomplete in NSTextView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36733 72102866-910b-0410-8b05-ffd578937521
2013-06-19 18:40:28 +00:00
Sebastian Reitenbach
494399d5f4 bump version of NSParagraphStyle, and fix the decoder
makes Grr happy again loading its gorm files

OK Fred Kiefer



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36646 72102866-910b-0410-8b05-ffd578937521
2013-05-17 15:50:53 +00:00
Germán Arias
316ee53b63 Add -resetCursorRect:inView: in NSFormCell.m
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36620 72102866-910b-0410-8b05-ffd578937521
2013-05-14 18:39:36 +00:00
Fred Kiefer
66ffc52ca2 * Source/GSNibLoading.m: Remove method [NSKeyedUnarchiver
-replaceObject:withObject:] which was moved to base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36619 72102866-910b-0410-8b05-ffd578937521
2013-05-13 21:01:47 +00:00
Fred Kiefer
5f248d6a39 * Source/NSColorPanel.m (-_magnify:): Use a local auto release
pool in loop.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36613 72102866-910b-0410-8b05-ffd578937521
2013-05-11 20:32:20 +00:00
Germán Arias
621fb86745 Handle correctly the mouse cursor in NSSearchField.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36595 72102866-910b-0410-8b05-ffd578937521
2013-05-06 22:58:46 +00:00
Gregory John Casamento
f14cc1f3bc * Headers/AppKit/NSPopover.h: correct delegate method
for popoverShouldClose:
	* Headers/AppKit/NSWindow.h: add convertRectToScreen: and
	convertRectFromScreen: methods.
	* Source/NSPopover.m: Correct delegate method for popoverShouldClose:.
	Changes to align popover window with rect it is being placed relative
	to.
	* Source/NSWindow.m: implementation of convertRectToScreen: and
	convertRectFromScreen: methods.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36577 72102866-910b-0410-8b05-ffd578937521
2013-04-24 09:25:56 +00:00
Fred Kiefer
7bd5a864cd * Source/GSXibLoader.m: Add -replaceObject:withObject: method.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36573 72102866-910b-0410-8b05-ffd578937521
2013-04-23 21:40:34 +00:00
Fred Kiefer
4d4147aab9 * Headers/AppKit/NSPopover.h,
* Source/NSPopover.m: Adjust to GNUstep coding standards.
        * Source/externs.m: Move new strings to here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36555 72102866-910b-0410-8b05-ffd578937521
2013-04-21 21:32:36 +00:00
Fred Kiefer
12a29ad4d7 * Source/NSCollectionView.m (-_moveUpAndExpandSelection:):
* Correct
        the comparision. Bug reported by Gregory John Casamento
        <greg.casamento@gmail.com>
        * Headers/AppKit/NSPopover.h: Add missing import.
        * Source/GSXibLoader.m: Disable NSCustomView hack again.
        * Headers/AppKit/NSApplication.h: Replace GSAppDelegateProtocol
        with NSApplicationDelegate.
        * Source/NSApplication.m: Adjust documentation to this
        * replacement.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36553 72102866-910b-0410-8b05-ffd578937521
2013-04-21 16:57:58 +00:00
Gregory John Casamento
eab097631c * Headers/AppKit/AppKit.h: Add NSPopover.h to set of files
included.
	* Headers/AppKit/NSApplication.h: Add NSApplicationDelegate.
	Inherit from GSAppDelegateProtocol.
	* Headers/AppKit/NSPopover.h: NSPopover header.
	* Source/GNUmakefile: Added NSPopover.[hm]
	* Source/GSXibLoader.m: Translate NSCustomView to NSView when
	unarchiving.
	* Source/NSPopover.m: Skeletal implementation of NSPopover.m.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36552 72102866-910b-0410-8b05-ffd578937521
2013-04-21 13:45:20 +00:00
Fred Kiefer
18d741ce80 * Source/NSTableView.m (-selectedColumnIndexes,
* -selectedRowIndexes): Return an
        autoreleased copy of the corresponding ivar. Returning a
reference to the ivar
        leads to issues (and behavior different from Cocoa) when
iterating thru the
        indexsets if at a time they would be being altered.
        Patch by Frank LeGrand (flegrand@testplant.com).
        * Source/GNUmakefile: Add NSCollectionViewItem.
        * Headers/AppKit/NSCollectionView.h,
        * Headers/AppKit/NSCollectionViewItem.h,
        * Source/NSCollectionViewItem.m,
        * Source/NSCollectionView.m: Bring closer to the GNUstep coding
        * standard.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36551 72102866-910b-0410-8b05-ffd578937521
2013-04-21 13:28:47 +00:00
Gregory John Casamento
eeffa67a4e * Headers/AppKit/NSCollectionView.h
* Headers/AppKit/NSCollectionViewItem.h
	* Source/GNUmakefile
	* Source/NSCollectionViewItem.m
	* Source/NSCollectionView.m: Added NSCollectionView and
	NSCollectionViewItem classes from testplant branch.  Made changes
	to original patch to conform to coding standards, NSCoding for
	non-keyed archiving and moved instances of float/integer to
	CGFloat and NSInteger/NSUInteger as appropriate.
	Patch by Doug Simons (dsimons@testplant.com) and
	Frank LeGrand (flegrand@testplant.com).



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36545 72102866-910b-0410-8b05-ffd578937521
2013-04-18 03:57:49 +00:00
Fred Kiefer
3aa97e1975 * Headers/AppKit/NSKeyValueBinding.h,
* Source/externs.m: Additional binding name
        * NSContentValuesBinding.
        * Source/NSPopUpButton.m: Add KVB for NSContentValuesBinding.
        Patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>
        * Source/NSArrayController.m: Encode/decode
        * clearsFilterPredicateOnInsertion.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36540 72102866-910b-0410-8b05-ffd578937521
2013-04-15 20:20:38 +00:00
Eric Wasylishen
67daa51afa * Source/GSTheme.m:
* Source/NSImage.m: Revert previous commit and write a much cleaner
implementation that fixes the same bug.

I removed the step in theme activation where we call
+[NSImage _setImagePath:name:] on each image in the theme, and instead
modified +[NSImage _pathForImageNamed:] to also search the theme images
directory.

When a GSTheme activates now, it only calls +[NSImage _reloadCachedImages]
which checks all NSImage cached by name and reloads any whose path has
changed.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36482 72102866-910b-0410-8b05-ffd578937521
2013-04-06 19:30:48 +00:00
Eric Wasylishen
23d47ca882 Revert "Allow themes to override only a "base" image like"
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36481 72102866-910b-0410-8b05-ffd578937521
2013-04-06 19:30:30 +00:00
Eric Wasylishen
5dcf9e3251 Allow themes to override only a "base" image like
common_3DArrowRight and have images that map to it (NSMenuArrow)
automatically update.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36474 72102866-910b-0410-8b05-ffd578937521
2013-04-06 07:57:57 +00:00
Fred Kiefer
808e830952 * Source/NSBitmapImageRep+GIF.m (-_bitmapIsGIF:): Prepare for
additional argument to function DGifOpen in newer libgif
versions.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36459 72102866-910b-0410-8b05-ffd578937521
2013-04-03 18:30:46 +00:00
Fred Kiefer
60383e72fe Remove commented out old code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36394 72102866-910b-0410-8b05-ffd578937521
2013-03-20 22:15:26 +00:00
Fred Kiefer
f35d315dfb * Source/GSToolTips.m (+initialize): Set the level of the tool
* tip
        window to NSPopUpMenuWindowLevel.
        Change suggested by Wolfgang Lux  <wolfgang.lux@gmail.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36393 72102866-910b-0410-8b05-ffd578937521
2013-03-20 22:10:38 +00:00
Fred Kiefer
4765d0f314 * Tests/gui/NSImage/basic.m: Add basic tests for NSImage.
* Tests/gui/NSCell/basic.m: Extend basic tests for NSCell.
        * Source/NSImage.m: Try to correct keyed encoding/decoding. Add
        incomplete isEqual: method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36384 72102866-910b-0410-8b05-ffd578937521
2013-03-18 22:50:11 +00:00
Fred Kiefer
9a15cb6b88 * Source/NSViewController.m: Retain the view.
* Source/NSOutline.m(-drawRow:clipRect:): The selected cell
        * shows
        its first responder state.
        Patch by Frank LeGrand <frank.legrand@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36378 72102866-910b-0410-8b05-ffd578937521
2013-03-17 22:36:34 +00:00
Fred Kiefer
12c4d6cbdb * Source/NSEvent.m,
* Source/NSParagraphStyle.m: Use NSInteger instead of enumerator
        type name for decoding and encoding.
        * Header/AppKit/NSFontPanel.h,
        * Header/AppKit/NSOpenPanel.h,
        * Header/AppKit/NSDataLinkPanel.h,
        * Source/NSDataLinkPanel.m,
        * Header/AppKit/NSForm.h,
        * Source/NSForm.m,
        * Header/AppKit/NSHelpPanel.h,
        * Source/NSHelpPanel.m,
        * Source/NSColorPanel.m: Remove unused encoding/decoding
        * methods.
        * Source/NSCustomImageRep.m,
        * Source/NSEPSImageRep.m,
        * Source/NSMovie.m,
        * Source/NSRulerMarker.m,
        * Source/NSColorList.m: Flag missing keyed encoding/decoding.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36377 72102866-910b-0410-8b05-ffd578937521
2013-03-17 19:53:50 +00:00
Fred Kiefer
6b09581658 * Source/NSTableView.m: Use new method -_isCellSelectableColumn:row:,
that checks the cells selectable state, in -mouseDown:.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36363 72102866-910b-0410-8b05-ffd578937521
2013-03-15 16:39:31 +00:00
Fred Kiefer
b9cd78229f * Source/GSNibLoading.m (NSCustomView -nibInstantiateWithCoder:):
Re-add call to -replaceObject:withObject: on decoder, but this
time in the right place.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36329 72102866-910b-0410-8b05-ffd578937521
2013-03-10 13:39:00 +00:00
Fred Kiefer
14584bb4e2 * Source/NSTableColumn.m (-initWithCoder:): Make columns
non-editable by default.
* Source/NSTableView.m (-editColumn:...select:): Make editing
here independ of the datasource.
* Source/NSTableView.m: Split -_isCellEditableColumn:row: in two
methods and ignore the cell isEditable state in -mouseDown:.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36307 72102866-910b-0410-8b05-ffd578937521
2013-03-08 11:51:51 +00:00
Fred Kiefer
86b587e9d7 * Source/NSBezierPath.m (-elementAtIndex:associatedPoints:): Fix
handling of close element.
Patch by Bluna Ratimonkey <object@gmail.com>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36304 72102866-910b-0410-8b05-ffd578937521
2013-03-08 08:59:18 +00:00
Fred Kiefer
a0616ff819 * Source/GSHorizontalTypesetter.m: Change floats into CGFloats to
stop infinite loop.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36282 72102866-910b-0410-8b05-ffd578937521
2013-03-05 22:33:57 +00:00
Fred Kiefer
2f6cc73444 * Source/NSBezierPath.m: Implement keyed coding and complete
keyed decoding.
Patch by Christopher Armstrong <carmstrong@fastmail.com.au>
* Source/NSBezierPath.m: Rewrote -elementAtIndex:associatedPoints:
to return a point for NSClosePathBezierPathElement. And adjust
all callers to make use of that point. Complete non-keyed coding and
decoding.
* Tests/gui/NSBezierPath/basic.m: Add basic tests for NSBezierPath.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36267 72102866-910b-0410-8b05-ffd578937521
2013-03-04 16:51:10 +00:00
Sebastian Reitenbach
1bda279897 * Source/NSMenuItemCell.m
* Headers/AppKit/NSMenuItemCell.h
          float -> CGFloat transitions



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36238 72102866-910b-0410-8b05-ffd578937521
2013-03-02 18:06:25 +00:00
Eric Wasylishen
8d6ce17b24 * Source/GSPDFPrintOperation.m: Update -_print and -deliverResult
to match GSEPSPrintOperation to get the class to at least partly
working. Output is appearing up-side-down for me though.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36203 72102866-910b-0410-8b05-ffd578937521
2013-02-28 09:40:36 +00:00
Fred Kiefer
ae607757b3 * Source/NSindow.m (-setDelegate:): Don't unregister delegate
notifications if same delegate is set twice.
        Patch by Doug Simons <doug.simons@testplant.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36192 72102866-910b-0410-8b05-ffd578937521
2013-02-23 15:36:46 +00:00
Fred Kiefer
0561a46d2f Correct problems found by valgrind.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36188 72102866-910b-0410-8b05-ffd578937521
2013-02-22 15:39:29 +00:00
Fred Kiefer
28ff5825aa Add the timers for NSModalPanelRunLoopMode as well.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36187 72102866-910b-0410-8b05-ffd578937521
2013-02-22 11:28:06 +00:00
Fred Kiefer
a070f43ca7 * Source/NSTabView.m (-minimumSize, -contentRect): Make the
* values
        here consistent with the code in GSThemeDrawing.
        * Source/GSThemeDrawing.m (-drawTabViewRect:...): Remove useless
        line of code. 


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36184 72102866-910b-0410-8b05-ffd578937521
2013-02-22 09:26:55 +00:00
Riccardo Mottola
ffa04cc800 Encode and decode lineBreakMode with NSInteger and not NSLineBreakMode
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36182 72102866-910b-0410-8b05-ffd578937521
2013-02-21 17:19:00 +00:00
Fred Kiefer
374047524a * Source/NSBitmapImageRep+PNG.m
(-_PNGRepresentationWithProperties:): Revert last change and
don't use png_info_init_3() on PNG >= 1.5.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36178 72102866-910b-0410-8b05-ffd578937521
2013-02-21 08:53:31 +00:00
Riccardo Mottola
1e8942edec Define png_sizeof() to allow compilation on 1.6.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36177 72102866-910b-0410-8b05-ffd578937521
2013-02-20 23:42:11 +00:00
Quentin Mathe
478148da52 Fixed typo in comment
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36171 72102866-910b-0410-8b05-ffd578937521
2013-02-19 17:01:31 +00:00
Quentin Mathe
b3c302d8c4 Cleaned drop handling code a bit more in NSTableView
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36170 72102866-910b-0410-8b05-ffd578937521
2013-02-19 16:59:21 +00:00
Quentin Mathe
da5449b7a8 Don't update the drop row and operation if the drop target hasn't changed (this prevents to overwrite a custom drop row and operation set by the user)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36169 72102866-910b-0410-8b05-ffd578937521
2013-02-19 16:03:28 +00:00
Quentin Mathe
f896752208 Extracted table view drop indicator drawing from -draggingUpdated: into a new method -_drawDropIndicator
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36168 72102866-910b-0410-8b05-ffd578937521
2013-02-19 15:57:04 +00:00
Quentin Mathe
fea485cea2 Modularized the first part of -draggingUpdated: into several smaller methods
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36167 72102866-910b-0410-8b05-ffd578937521
2013-02-19 15:18:53 +00:00
Fred Kiefer
941afdac86 Fix compiler warnings reported by
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36165 72102866-910b-0410-8b05-ffd578937521
2013-02-18 20:29:10 +00:00
Fred Kiefer
0c95f32580 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36163 72102866-910b-0410-8b05-ffd578937521
2013-02-17 22:44:47 +00:00
Fred Kiefer
b1fc7cb066 Correct coding/decoding after type changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36160 72102866-910b-0410-8b05-ffd578937521
2013-02-17 16:53:48 +00:00
Fred Kiefer
4d953a5122 * Source/NSBezierPath.m: More keyed decoding.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36157 72102866-910b-0410-8b05-ffd578937521
2013-02-17 13:02:46 +00:00
Fred Kiefer
152b94069f More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36154 72102866-910b-0410-8b05-ffd578937521
2013-02-17 00:49:04 +00:00
Fred Kiefer
7ef53c8232 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36153 72102866-910b-0410-8b05-ffd578937521
2013-02-16 21:37:29 +00:00
Fred Kiefer
270baf4037 More CGFloat, NSUInteger and NSInteger changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36148 72102866-910b-0410-8b05-ffd578937521
2013-02-16 00:08:33 +00:00
Quentin Mathe
e4e5428122 Replaced -_dataCellForTableColumn:row: by -preparedCellAtColumn:row: new public method from Mac OS X 10.5
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36136 72102866-910b-0410-8b05-ffd578937521
2013-02-14 10:34:20 +00:00
Fred Kiefer
0e308561c1 * Source/GSXibLoader.m (GSXibKeyedUnarchiver -_preProcessXib:):
Release the document.
        Patch by Doug Simons <doug.simons@testplant.com>
        * Source/GSXibLoader.m: Fix a problem where owner,
        * firstResponder and application
        were put in the list of top-level objects, creating a
retain-cycle.
        * Source/NSViewController.m: Fix a problem where view
        * controllers
        did not release their top-level objects as expected.
        * Source/NSWindowController.m: Fix a problem where window
        controllers did not release their top-level objects as expected.
        Changes made in occordance with
        https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/LoadingResources/CocoaNibs/CocoaNibs.html
        Patch by Jonathan Gillaspie <jonathan.gillaspie@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36134 72102866-910b-0410-8b05-ffd578937521
2013-02-14 09:22:56 +00:00
Fred Kiefer
0a4708d4d0 Resolve clang warnings about wrong format specifiers for NSLog.
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36133 72102866-910b-0410-8b05-ffd578937521
2013-02-14 08:58:05 +00:00
Fred Kiefer
d7fbd2f6af Resolve memory leak for GSXibElement.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36122 72102866-910b-0410-8b05-ffd578937521
2013-02-13 08:54:34 +00:00
Fred Kiefer
d4f80c2258 Change NSEvent to CGFloat, NSUInteger and NSInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36121 72102866-910b-0410-8b05-ffd578937521
2013-02-13 08:40:36 +00:00
Fred Kiefer
f078b2daaf * Headers/AppKit/NSSplitView.h
* Source/NSSplitView.m: Change to CGFloat, NSUInteger and NSInteger.
Patch partly by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36109 72102866-910b-0410-8b05-ffd578937521
2013-02-10 21:32:07 +00:00
Fred Kiefer
cda7dc977f * Headers/AppKit/NSPageLayout.h
* Source/NSPageLayout.m: Change int to NSInteger.
        Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36092 72102866-910b-0410-8b05-ffd578937521
2013-02-08 17:50:25 +00:00
Riccardo Mottola
9e67500f35 Add tooltips to buttons.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36081 72102866-910b-0410-8b05-ffd578937521
2013-02-07 17:14:20 +00:00
Quentin Mathe
37311e0e04 Fixed -encodeWithCoder: in NSView to encode the superview conditionally as Cocoa
does (Apple discusses  superview encoding as a use case for conditional encoding 
in the Archiving related documentation).

Note: A view can now be archived (or copied) without having to remove the view 
from its hierarchy before archiving it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36065 72102866-910b-0410-8b05-ffd578937521
2013-02-06 17:28:52 +00:00
Fred Kiefer
340c7eb879 Change DPS/PS functions to CGFloat and NSInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36063 72102866-910b-0410-8b05-ffd578937521
2013-02-05 19:18:49 +00:00
David Chisnall
9d153b9b8b Fix the NSBrowser delegate methods in NSSavePanel to have the correct types.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36061 72102866-910b-0410-8b05-ffd578937521
2013-02-05 12:51:11 +00:00
David Chisnall
15a3aec436 When displaying the horizontal menu, set the title of the main menu to the name
of the application, not the name of the process, if the info bundle contains an
application name.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36060 72102866-910b-0410-8b05-ffd578937521
2013-02-05 12:14:20 +00:00
Fred Kiefer
27897b75e8 * Source/NSBezierPath.m: Started the implementation of keyed
encoding and decoding.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36059 72102866-910b-0410-8b05-ffd578937521
2013-02-03 22:40:14 +00:00
Fred Kiefer
e62fddeea0 Change NSBezierPath to use NSInteger and CGFloat and adjust uses to
this.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36054 72102866-910b-0410-8b05-ffd578937521
2013-02-01 14:03:08 +00:00
David Chisnall
a2aa2001da Fix warnings in NSForm.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36046 72102866-910b-0410-8b05-ffd578937521
2013-01-31 09:04:21 +00:00
Fred Kiefer
1aa1803744 * Headers/AppKit/NSBrowser.h
* Headers/AppKit/NSFontPanel.h
        * Headers/AppKit/NSMatrix.h
        * Headers/AppKit/NSTableView.h
        * Source/NSBrowser.m
        * Source/NSFontPanel.m
        * Source/NSMatrix.m: Small fixes to last change.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36042 72102866-910b-0410-8b05-ffd578937521
2013-01-30 22:13:32 +00:00
David Chisnall
40fb48e5de Next bit of NSInteger cleanup for -gui.
Fix all of the current warnings in Gorm so that it can be used to test
NSInteger things.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36039 72102866-910b-0410-8b05-ffd578937521
2013-01-30 12:43:27 +00:00
David Chisnall
4850a9feac Fix all current compiler warnings on FreeBSD/x86-64.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36038 72102866-910b-0410-8b05-ffd578937521
2013-01-30 09:48:54 +00:00
Fred Kiefer
fe0444e231 * Source/externs.m: Change predefined colour values to CGFloat.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36037 72102866-910b-0410-8b05-ffd578937521
2013-01-30 08:43:56 +00:00
Fred Kiefer
d870275b7f * Headers/AppKit/NSCell.h
* Headers/AppKit/NSColor.h
        * Headers/AppKit/NSGraphics.h
        * Headers/AppKit/NSView.h
        * Source/Functions.m
        * Source/GSThemeDrawing.m
        * Source/GSTitleView.m
        * Source/NSApplication.m
        * Source/NSCell.m
        * Source/NSView.m: More NSInteger/NSUInteger/CGFloat cleanup



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36035 72102866-910b-0410-8b05-ffd578937521
2013-01-29 21:57:41 +00:00
Fred Kiefer
3205b3037d * Headers/AppKit/NSApplication.h
* Source/NSApplication.m: NSInteger/NSUInteger cleanup
        * Source/externs.m: Add NSAppKitVersionNumber.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36032 72102866-910b-0410-8b05-ffd578937521
2013-01-29 08:35:49 +00:00
Fred Kiefer
a612305757 First set of NSInteger/NSUInteger cleanup in gui.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36029 72102866-910b-0410-8b05-ffd578937521
2013-01-27 20:28:35 +00:00
Fred Kiefer
ec2f64f7a9 * Source/NSTextContainer.m (lineFragmentRectForProposedRect:...):
Prevent negative width/height from being returned.
  Bug found by unit test from Nikolaus Schaller
<hns@computer.org>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36026 72102866-910b-0410-8b05-ffd578937521
2013-01-27 14:51:26 +00:00
Gregory John Casamento
128032c291 * Source/NSPopUpButtonCell.m: Revert previous change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36019 72102866-910b-0410-8b05-ffd578937521
2013-01-25 17:59:08 +00:00
Gregory John Casamento
4f8b519eb3 Remove setAction for _popUpItemAction: from insertItem:atIndex:
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36017 72102866-910b-0410-8b05-ffd578937521
2013-01-25 00:47:51 +00:00
Fred Kiefer
e370aab73b * Headers/AppKit/NSTextContainer.h,
* Source/NSTextContainer.m,
        * Source/GSHorizontalTypesetter.m: Correct the definition of
        NSLineMovementDirection.
        * Headers/AppKit/NSFont.h
        * Source/NSFont.m: Add a few missing 10.4 methods.
        * Header/AppKit/NSLayoutManager.h,
        * Source/NSLayoutManager.m: Add one 10.5 method.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35999 72102866-910b-0410-8b05-ffd578937521
2013-01-19 18:22:45 +00:00
Wolfgang Lux
4f88674d9a And return proper error messages
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35959 72102866-910b-0410-8b05-ffd578937521
2013-01-13 13:57:37 +00:00
Wolfgang Lux
0d760caf50 Disable to support to create gif image representations when giflib
does not define QuantizeBuffer. Fixes #38024.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35958 72102866-910b-0410-8b05-ffd578937521
2013-01-13 13:47:51 +00:00
Fred Kiefer
29157408d9 * Source/NSStringDrawing.m(is_size_match): Disable matches
where one has size information, but the other hasn't.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35935 72102866-910b-0410-8b05-ffd578937521
2013-01-06 21:49:59 +00:00
Fred Kiefer
30da16dafc * Source/NSView.m (-_rebuildCoordinates): Check if the flipped
state of the view has changed. Call this method all the times
        instead of checking _coordinates_valid.
        This change allows views to dynamically change their flipped
state.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35928 72102866-910b-0410-8b05-ffd578937521
2012-12-31 18:55:36 +00:00
Fred Kiefer
df4578bc13 * Source/NSFont.m (-setInContext:): Remove usage of
matrixExplicitlySet.
Patch by Derek Fawcus <dfawcus@cisco.com>.
* Source/NSFont.m: Remove all other usages of
matrixExplicitlySet.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35926 72102866-910b-0410-8b05-ffd578937521
2012-12-31 17:34:13 +00:00
Fred Kiefer
89fed0244c * Headers/Additions/GNUstepGUI/GSLayoutManager_internal.h: Make
-_invalidateEverything visible.
        * Source/GSLayoutManager.m
        * (-invalidateGlyphsForCharacterRange:...): Call
        -_invalidateEverything when the whole character range is
invalidated.
        * Source/NSStringDrawing.m: Remove workarounds for full layout
        * invalidation.
        Move initialisation check into cache_lock().
        Extract size match code in function.
        Put #ifdef around all statistics code.
        Use same LARGE_SIZE value as Apple does.
        Make the methods taking options the main ones.
        * Source/GSHorizontalTypesetter.m (-fullJustifyLine::,
        -rightAlignLine::, -centerAlignLine::): Don't align when the
line
        width is bigger than 1e7.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35925 72102866-910b-0410-8b05-ffd578937521
2012-12-30 15:48:21 +00:00
Fred Kiefer
60fcb3622e * Headers/AppKit/NSOpenGL.h,
* Source/NSOpenGLPixelFormat.m: NSOpenGLPixelFormat directly
        * implements
        initWithCoder so that it may marshall the pixel attributes prior
to
        initWithAttributes:. Change the getValues:... method to take an
        int argument instead of long. GLint is mapped to int on most
systems.
        * Source/NSOpenGLContext.m: Use the format decoding to decode an
        * OpenGL context.
        Patch by Clint Smullen <daemonae>.

        * Source/GSLayoutManager.m: Small cleanup in glyph code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35923 72102866-910b-0410-8b05-ffd578937521
2012-12-26 19:19:50 +00:00
Fred Kiefer
e93fd24f0d * Source/NSFont.m (-initWithName:...): Move replacement name into
separate method -_replacementFontName and add replacement for
"Helvetica-" prefix.
* Header/AppKit/NSLayoutManager.h: Add some 10.5 methods.
* Source/NSLayoutManager.m: Simple implementations for these new
methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35922 72102866-910b-0410-8b05-ffd578937521
2012-12-23 23:24:14 +00:00
Fred Kiefer
0f3af93a92 Reworked version of patches by Marcian Lytwyn
<marcian.lytwyn@advcsi.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35899 72102866-910b-0410-8b05-ffd578937521
2012-12-16 22:51:23 +00:00
Riccardo Mottola
3ef13c9a23 Add a special case for popup buttons, akin imageRectForBounds
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35868 72102866-910b-0410-8b05-ffd578937521
2012-12-09 23:13:49 +00:00
Fred Kiefer
7761771a56 Add missing #import for NSArray.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35866 72102866-910b-0410-8b05-ffd578937521
2012-12-08 11:41:44 +00:00
Wolfgang Lux
7e5f0c199c Set save panel accessory view before calling -prepareSavePanel: to
allow clients to modify the accessory view.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35791 72102866-910b-0410-8b05-ffd578937521
2012-11-12 08:14:03 +00:00
Fred Kiefer
e0e4395cd7 * Source/NSApplication.m (-_openFiles): Protect agains empty arguments.
Patch by Luboš Doležel <lubos@dolezel.info>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35785 72102866-910b-0410-8b05-ffd578937521
2012-11-05 22:10:07 +00:00
Fred Kiefer
65cac93a7b * Source/NSTabView.m (-dealloc): Reset _selected to nil at top of
dealloc.
* Source/NSBox.m(-drawRect:, -initWithCoder:): Implement
transparent handling for custom boxes.
Patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>

* Source/NSTabView.m (-selectTabViewItem:): Remove duplicated
code.
* Source/NSTabView.m (-removeTabViewItem:): Retain the item
while removing it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35773 72102866-910b-0410-8b05-ffd578937521
2012-11-01 00:06:46 +00:00
Germán Arias
3e2aacab04 Revert last change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35745 72102866-910b-0410-8b05-ffd578937521
2012-10-26 06:33:45 +00:00
Germán Arias
4bab57213d Fix problem when try to remove an old menu in a window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35744 72102866-910b-0410-8b05-ffd578937521
2012-10-26 01:35:04 +00:00
Gregory John Casamento
235cfca2db * Source/NSButtonCell.m: Correct issues when decoding a .gorm
file with key equivalent.  Make sure that the image is properly
	set.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35717 72102866-910b-0410-8b05-ffd578937521
2012-10-19 03:20:44 +00:00
Gregory John Casamento
8ca0f08715 * Source/GSThemeDrawing.m: Changes per discussion with Fred.
Added check to make sure the image is not overriden.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35705 72102866-910b-0410-8b05-ffd578937521
2012-10-17 12:15:52 +00:00
Gregory John Casamento
f248bc9988 * Headers/Additions/GNUstepGUI/GSTheme.h: Add declaration
for method setKeyEquivalent:forButtonCell:
	* Source/GSThemeDrawing.m: Add implementation for method
	setKeyEquivalent:forButtonCell:
	* Source/NSButtonCell.m: Add call to new method.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35702 72102866-910b-0410-8b05-ffd578937521
2012-10-16 21:23:48 +00:00
Gregory John Casamento
9cd6adf8a6 2012-10-15 18:02-EDT Gregory John Casamento <greg.casamento@gmail.com>
* Source/NSButtonCell.m



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35696 72102866-910b-0410-8b05-ffd578937521
2012-10-15 22:06:22 +00:00
Fred Kiefer
ce25719c03 * Source/GSThemeDrawing.m (-drawTabViewRect:...selectedItem:),
* Source/NSTabView.m (-drawRect:): Move the select logic from
theme into normal code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35686 72102866-910b-0410-8b05-ffd578937521
2012-10-14 19:21:55 +00:00
Fred Kiefer
e85b16bc05 Merge selected changes from testplant branch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35681 72102866-910b-0410-8b05-ffd578937521
2012-10-13 18:43:38 +00:00
Fred Kiefer
4f5c219ed9 * Source/NSComboBoxCell.m (-textDidChange:):
Handle nil string from delegate completed string processing
Patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35677 72102866-910b-0410-8b05-ffd578937521
2012-10-12 17:29:11 +00:00
Fred Kiefer
8c0d5b3dff * Source/GSToolTips.m: Use separate view to draw tooltip text.
Patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35674 72102866-910b-0410-8b05-ffd578937521
2012-10-12 16:36:20 +00:00
Fred Kiefer
70baebe674 * Source/GSInfoPanel.m (value_from_info_plist_for_key): Use
NSBundle method to get the info dictionary.
Patch by: Luboš Doležel <lubos@dolezel.info>


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35673 72102866-910b-0410-8b05-ffd578937521
2012-10-12 15:19:29 +00:00
Wolfgang Lux
be389d2459 Remove incorrect transformation of tracking rectangle coordinates
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35663 72102866-910b-0410-8b05-ffd578937521
2012-10-10 08:13:56 +00:00
Gregory John Casamento
5b8d9117c5 Merges from the testplant branch for NSTabView, GSXibLoader.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35661 72102866-910b-0410-8b05-ffd578937521
2012-10-09 17:29:51 +00:00
Wolfgang Lux
b0b86079ca Fix implementation of tracking rectangles to use the coordinate system
of their views, as they do under Cocoa.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35645 72102866-910b-0410-8b05-ffd578937521
2012-10-06 19:42:56 +00:00
Wolfgang Lux
c29763d8cc Improve keyboard navigation by automatically computing a key view loop
for a window (and tab view item). This implicit key view is created
when a window is made key and does not have an explicit key view loop,
which is detected by checking the initial first responder of the
window.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35632 72102866-910b-0410-8b05-ffd578937521
2012-10-04 09:20:08 +00:00
Wolfgang Lux
81708584a5 Adjust key view loop when adding a new document view to a NSClipView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35631 72102866-910b-0410-8b05-ffd578937521
2012-10-04 08:26:01 +00:00
Wolfgang Lux
3e8bc54cd3 Abbreviate home directory in window titles.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35627 72102866-910b-0410-8b05-ffd578937521
2012-10-03 12:58:26 +00:00
Wolfgang Lux
2f3297119b Fix memory management for cursors. In particular prevent the current
cursor from being deallocated when client code releases the last
reference to it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35586 72102866-910b-0410-8b05-ffd578937521
2012-09-21 20:24:53 +00:00
Wolfgang Lux
daf0be3455 Make sure actions can be sent to the dialog window of a modal session
even if another panel (with worksWhenModal=YES) is key window.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35585 72102866-910b-0410-8b05-ffd578937521
2012-09-21 11:26:02 +00:00
Germán Arias
f3d8072b00 Improvements for tooltips and Drag&Drop operations.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35566 72102866-910b-0410-8b05-ffd578937521
2012-09-14 01:01:23 +00:00
Germán Arias
57fef8379e Improvements for cursor.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35565 72102866-910b-0410-8b05-ffd578937521
2012-09-13 22:29:20 +00:00