Commit graph

5194 commits

Author SHA1 Message Date
fredkiefer
486ffcb4bd * Source/NSPasteboard.m (+pasteboardByFilteringFile:): Correct
typo in Richard's change.
* Source/NSPasteboard.m (-pasteboard:provideDataForType:): Use
 the file name directly instead of reading the file contents.
* Source/NSImageRep.m (+imageRepsWithContentsOfFile:,
+imageFileTypes):
Start working on filter service support for images.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34741 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:42:46 +00:00
rfm
3f7774c17c fixup error in filtering file by name
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34740 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:21:06 +00:00
ericwa
f5dd4730cf * Headers/AppKit/NSOutlineView.h:
* Source/NSOutlineView.m: Add support for
outlineView:dataCellForTableColumn:item: delegate method
* Headers/AppKit/NSTableView.h:
* Source/NSTableView.m: Add support for
tableView:dataCellForTableColumn:row: delegate method


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34717 72102866-910b-0410-8b05-ffd578937521
2012-02-03 21:41:41 +00:00
rmottola
e631fa73be centerScanRect button to avoid blurring
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34693 72102866-910b-0410-8b05-ffd578937521
2012-02-01 22:07:41 +00:00
fredkiefer
9635fb6007 * Source/GSThemeInspector.m: Add missing include.
This was causing prblems on Windows.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34692 72102866-910b-0410-8b05-ffd578937521
2012-02-01 18:42:10 +00:00
fredkiefer
05514b6ac5 Deal with images taht result in no data. This happens in themes that
have to small images to be split up into 9 tiles.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34688 72102866-910b-0410-8b05-ffd578937521
2012-02-01 10:49:35 +00:00
fredkiefer
b1db7ee743 * Source/NSMenu.m (-setMain:): Rearrange code to avoid duplicate
menu for in-window menu themes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34687 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:12:34 +00:00
fredkiefer
94e4660f98 * Source/GSThemeInspector.m (-update:): Don't get the frame from a
non-existing view. This was currupting the stack with gcc 4.6 on i386.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34686 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:00:23 +00:00
ericwa
2c748a834c * Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Only
draw at 50% opacity if no bezel is set for cocoa compatibility.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34674 72102866-910b-0410-8b05-ffd578937521
2012-01-31 02:27:18 +00:00
ericwa
daab3df5c2 * Source/GNUmakefile: Remove GSGhostscriptImageRep from the build
* Source/NSImageRep.m: Remove GSGhostscriptImageRep
* configure.ac: Disable ImageMagic by default
* configure: Regenerate


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34671 72102866-910b-0410-8b05-ffd578937521
2012-01-30 21:06:08 +00:00
fredkiefer
424237e4d9 * Source/NSMenu.m (-setMain:): Remove the in-window menu when
switching to a theme without that.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34652 72102866-910b-0410-8b05-ffd578937521
2012-01-29 00:43:50 +00:00
fredkiefer
a5612f4bcb * Source/NSMenu.m (-performActionForItemAtIndex:): Check for the
popup button cell and its action, before checking for the item
action. This caused a problem due to NIB decoding changes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34642 72102866-910b-0410-8b05-ffd578937521
2012-01-26 22:38:50 +00:00
fredkiefer
af8b7fd367 Revert last change and replace with something a little bit better. The
whole ruler handling will need some deeper inspection.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34636 72102866-910b-0410-8b05-ffd578937521
2012-01-26 09:25:29 +00:00
dpsimons
5c3e0f4903 Call setClientView: before calling setMarkers: to fix a problem when a textView's text is set or changed when the textView is not the first responder, such as at windowControllerDidLoadNib: time.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34633 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:28:51 +00:00
ericwa
6ee426e0ee * Source/NSImage.m (+imageNamed:): Don't try to look up path
if called with nil (just return nil).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34632 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:25:14 +00:00
ericwa
0d31480972 * Source/NSClipView.m: Disable copy-on-scroll until after release
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34631 72102866-910b-0410-8b05-ffd578937521
2012-01-25 22:17:53 +00:00
ericwa
cb99611173 * Source/NSClipView (-constrainScrollPoint:): Revert last change
until after the release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34630 72102866-910b-0410-8b05-ffd578937521
2012-01-25 22:13:58 +00:00
fredkiefer
1db386a9ad * Source/NSSecureTextField.m: Add GSSimpleSecureGlyphGenerator and
use this to generate the bullet glyphs.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34622 72102866-910b-0410-8b05-ffd578937521
2012-01-24 10:40:13 +00:00
ericwa
dc3dead8c0 * Source/NSClipView.m (-constrainScrollPoint:): Restore old code
which correctly rounded the scroll point to an integer point in
device-space. It seems the correct code was commented out in 2002,
perhaps as a performance optimisation?


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34614 72102866-910b-0410-8b05-ffd578937521
2012-01-24 01:33:17 +00:00
fredkiefer
e278d9956c Fix clang compiler warnings as reported by Sebastian Reitenbach
<sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34608 72102866-910b-0410-8b05-ffd578937521
2012-01-23 14:27:58 +00:00
ericwa
81b8b6a826 * Source/NSView.m (-setBounds:, -setBoundsOrigin:, -setBoundsSize:):
Revert a portion of r32955 which I committed last april but I now
see was a mistake, and I just discovered is breaking the  copy-on-scroll
behaviour of NSClipView - we end up always redrawing the entire visible
portion of the document view right now.

In r32955 I added [self setNeedsDisplay: YES] calls to these methods
even though these are documented explicitly as not marking the view for
needing display. Approved by Fred for commit during the code freeze.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34606 72102866-910b-0410-8b05-ffd578937521
2012-01-21 19:15:51 +00:00
espectador
73222b4de7 Fix bug #35335
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34599 72102866-910b-0410-8b05-ffd578937521
2012-01-20 06:10:03 +00:00
fredkiefer
b8d7da1687 * Source/NSCell.m (-setStringValue:, setObjectValue:): Always use
ASSIGNCOPY for the contents. This fixes memory leak of last commit.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34585 72102866-910b-0410-8b05-ffd578937521
2012-01-19 08:47:52 +00:00
rmottola
28d954f7cd Copy contents before setting it [setObjectValue]
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34584 72102866-910b-0410-8b05-ffd578937521
2012-01-19 00:40:47 +00:00
fredkiefer
0b99ca07c2 * Headers/AppKit/NSImageView.h,
* Source/NSImageView.m: Protect image drag with new ivar that
gets set via a new GNUstep extension method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34580 72102866-910b-0410-8b05-ffd578937521
2012-01-18 21:03:37 +00:00
ericwa
2ca95e6a5b * Source/NSImageCell.m (-drawInteriorWithFrame:inView:):
Draw image with 50% opacity if the cell is disabled


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34548 72102866-910b-0410-8b05-ffd578937521
2012-01-15 21:35:47 +00:00
ericwa
df6635d6a8 * Source/NSTableColumn.m (-initWithIdentifier:): Make data
cell editable by default.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34547 72102866-910b-0410-8b05-ffd578937521
2012-01-15 21:34:40 +00:00
rfm
4354640dd1 Attempt to get gnome and windows themes working again.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34528 72102866-910b-0410-8b05-ffd578937521
2012-01-14 17:55:43 +00:00
rfm
39fbad9a42 Cleanup/simplify code for handling theme names in defaults system
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34527 72102866-910b-0410-8b05-ffd578937521
2012-01-14 16:10:48 +00:00
fredkiefer
5c85e19d23 * Source/GSStandardWindowDecorationView.m (-mouseDown:): Pass the
event on to the super implementation if we don't handle it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34500 72102866-910b-0410-8b05-ffd578937521
2012-01-12 09:42:03 +00:00
fredkiefer
346452eefa * Source/NSImage.m (+_clearFileTypeCaches): Use DESTROY instead of
RELEASE.
Patch by Philippe Roussel <p.o.roussel@free.fr>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34492 72102866-910b-0410-8b05-ffd578937521
2012-01-11 08:12:43 +00:00
ericwa
ad0fe2f336 * Source/NSImage.m: Remove duplicate #import
* Source/NSImage.m: Correct _clearFileTypeCaches notification
method to take a NSNotification* parameter.
* Soure/NSImage.m (themeDidActivate:): Move to a class method,
and move the GSThemeDidActivateNotification subscription
to +[NSImage initialize]. Now the +_themeDidActivate: updates
all images by looking at all the values in nameDict. This should
function exactly the same as before, but seems to be quite a bit
faster due to fewer notifications being sent (?)
* Source/NSImage.m (+imageNamed:): Remove redundant fetch from
nameDict pointed out by Fred


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34482 72102866-910b-0410-8b05-ffd578937521
2012-01-10 19:16:46 +00:00
ericwa
665c0c8657 * Source/NSImage.m (+pathForImageNamed:): Add underscore and
move to private category. Also remove use of lock as it is
unnecessary
* Source/NSImage.m: (-themeDidActivate:): Extract method
_resetAndUseFromFile:. Don't reset _size if
flags.sizeWasExplicitlySet was true.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34481 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:55:57 +00:00
ericwa
25f1571c3f * Source/NSOpenPanel.m: Rewrite/simplify selection handling,
fix bug reported by Riccardo where OK button is disabled when
selecting directories after selecting a file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34480 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:42:04 +00:00
ericwa
39002fdfca * Source/GSGhostscriptImageRep.m: Add missing ASSIGN
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34479 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:39:34 +00:00
ericwa
450a7402db * Source/GSTheme.m: Remove code which sets and unsets images
on theme activation/deactivation.
* Source/NSImage.m (+imageNamed:): Factor out code for finding
the path for a name to a separate method, +pathForImageNamed.
The code is unchanged otherwise, except for fixing the retrieval
of images from the theme bundle, which was broken.
* Source/NSImage.m (-setName:): Remove code for creating theme
proxy. Subscribe/unscribe to theme change notification when
the receiver is added/removed from the name dictionary.
* Source/NSImage.m (-themeDidActivate:): Method called in
response to a GSThemeDidActivateNotification on images with
a name set. It does a path lookup in the same way that
+imageNamed: would, and checks if the path has changed due
to the theme change. If it has, all reps are discarded and
the image at the new path is loaded. This avoids the need for
the theme proxy objects.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34474 72102866-910b-0410-8b05-ffd578937521
2012-01-10 04:38:10 +00:00
fredkiefer
d78ffd47fd Declare the new method
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34470 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:40:45 +00:00
fredkiefer
552d54d637 Cache the file type results for the image reps and clear the cache when these change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34469 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:39:50 +00:00
fredkiefer
175d0b6ac0 Raise an exception if the PPD file cannot be read. Change make based on
request by Riccardo on the mailing list.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34397 72102866-910b-0410-8b05-ffd578937521
2012-01-03 09:18:51 +00:00
wlux
30328c2e85 Fix two incorrect comparisons in NSLayoutManager which were causing
range exceptions when moving the cursor up in the first line and down
in the last line of a NSTextView, respectively.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34375 72102866-910b-0410-8b05-ffd578937521
2012-01-01 11:29:20 +00:00
ericwa
c0a86ff5ea * Source/NSPrintOperation.m (_print): Fix read of uninitialized
variable, which was breaking printing of wrap-to-page mode in
TextEdit. TODO: Run the printing code through valgrind, there is
a lot of suspicious code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34373 72102866-910b-0410-8b05-ffd578937521
2011-12-31 22:37:55 +00:00
wlux
cdfd43b2d4 Change the default text container inset for NSTextView to (0,0) to
reduce blank space around text.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34367 72102866-910b-0410-8b05-ffd578937521
2011-12-29 22:16:50 +00:00
wlux
39aff9e704 Get the insertion point rectangle right for character index 0.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34364 72102866-910b-0410-8b05-ffd578937521
2011-12-29 18:34:27 +00:00
wlux
1c792c4b66 Adjust the minimum and maximum sizes of a NSTextView to ensure that
the minimum size is not greater than the current size and the maximum
size is not smaller than the current size.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34362 72102866-910b-0410-8b05-ffd578937521
2011-12-29 16:48:17 +00:00
ericwa
aaefd51968 Undo last change as it broke Graphos printing
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34353 72102866-910b-0410-8b05-ffd578937521
2011-12-23 21:22:41 +00:00
ericwa
e54e42c0ca * Source/NSView.m (-beginPageInRect:atPlacement:): Always translate
by the placement value. Previously, we would translate only if the
rect parameter was empty, which doesn't make sense to me.
This fixes the bug where the last page of a document printed from
Ink/TextEdit was incorrectly positioned at the bottom of the
printed page.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34352 72102866-910b-0410-8b05-ffd578937521
2011-12-23 20:33:19 +00:00
fredkiefer
1ae39a679a * Source/NSTextView.m (-setFieldEditor:): Use different values for
both cases.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34347 72102866-910b-0410-8b05-ffd578937521
2011-12-22 22:00:42 +00:00
ericwa
2163d6d3ed * Source/NSSavePanel.m (-browser:createRowsForColumn:inMatrix:):
Set icon size based on cell's cellSize


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34346 72102866-910b-0410-8b05-ffd578937521
2011-12-22 19:08:47 +00:00
fredkiefer
cd1d8d3174 Removed a few compiler warnings found by gcc 4.6
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34344 72102866-910b-0410-8b05-ffd578937521
2011-12-22 09:16:04 +00:00
ericwa
2a35bb6397 * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:):
Restore code to draw the background when the cell is highligted


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34337 72102866-910b-0410-8b05-ffd578937521
2011-12-21 06:43:42 +00:00