Commit graph

166 commits

Author SHA1 Message Date
Gregory John Casamento
c2324e102d Minor cleanup in NSOutlineView code 2024-10-08 12:49:59 -04:00
Gregory John Casamento
1a188b7eb7 Add method _keyPathForValueBinding in _setObjectValue for Outline view 2024-08-20 22:56:18 -04:00
Gregory John Casamento
27d57fe5eb Add method _keyPathForValueBinding to encapsulate the code for getting the path 2024-08-20 22:53:31 -04:00
Gregory John Casamento
5befed5855 Fix a number of issues pointed out by @fredkiefer 2024-08-18 17:25:47 -04:00
Gregory Casamento
6474e53fb6
Update NSOutlineView.m - remove unbind per discussion with @fredkiefer 2024-08-09 02:28:29 -04:00
Gregory John Casamento
854af0901e Cleanup of unused or commented out methods 2024-08-08 17:48:16 -04:00
Gregory John Casamento
d8c4c14018 Move _applyBindingsToCell:atRow: to NSTableColumn 2024-08-07 22:55:14 -04:00
Gregory John Casamento
d694efc941 Fix compilation error 2024-08-03 21:44:02 -04:00
Gregory John Casamento
a1b9dc546e Eliminate category, move logic for prepend inline 2024-08-03 21:40:04 -04:00
Gregory John Casamento
300a84c493 Improve adding a child, also do whitespace-cleanup 2024-08-03 21:02:33 -04:00
Gregory John Casamento
13f86ebfa9 Add child index, add category that properly prepends the index to the NSIndexPath 2024-08-03 20:48:09 -04:00
Gregory John Casamento
8059cdadd0 Slight improvements 2024-08-03 20:05:23 -04:00
Gregory John Casamento
27718ee794 Slightly better attempt at getting the index path 2024-08-03 15:05:44 -04:00
Gregory John Casamento
1a8f0fa8e6 First cut at recursive method to find NSIndexPath for non NSTreeNode items 2024-08-03 14:31:51 -04:00
Gregory John Casamento
fbee6dce81 If no indexPaths are found, return the root 2024-08-02 11:20:58 -04:00
Gregory John Casamento
ad75804102 Remove method, minor cleanup, per discussion with @fredkiefer 2024-07-28 20:49:18 -04:00
Gregory John Casamento
abfc782a6c Move check for dataSource or binding into NSOutlineView before calling method to draw the row per discussion with @fredkiefer 2024-07-27 18:29:00 -04:00
Gregory John Casamento
3d59afd2c9 Improvements, per discussion with @fredkiefer 2024-07-27 17:37:04 -04:00
Gregory John Casamento
d22d839b0c Correct minor formatting issues 2024-07-19 11:12:24 -04:00
Gregory John Casamento
cd41f301a8 Add selection logic for computing indexPaths 2024-07-19 08:04:13 -04:00
Gregory John Casamento
766a358fb7 Move code to handle enabled/editable bindings to a common method in the parent class 2024-07-14 16:00:18 -04:00
Gregory John Casamento
ca4fe0e078 Add code to get the value of the NSEnabledBinding 2024-07-14 15:40:47 -04:00
Gregory John Casamento
45c0368602 Add code to get the value of the NSEditableBinding 2024-07-14 15:14:07 -04:00
Gregory John Casamento
aa86a96c55 Update to use NSObservedKeyPathKey instead of string, add code to _setObjectValue:... in NSTableView to set the value when we have a binding 2024-07-10 06:31:55 -04:00
Gregory John Casamento
060b27a854 Update _setObjectValue:... 2024-07-06 23:44:31 -04:00
Gregory John Casamento
fdb35eb869 Add value/setValue: 2024-07-06 23:06:26 -04:00
Gregory John Casamento
23bcb99166 Initial changes to NSBrowser for NSTreeController/binding integration 2024-07-06 22:02:10 -04:00
Gregory John Casamento
8fbcbdb380 Changes to allow editing 2024-07-05 01:57:09 -04:00
Gregory John Casamento
90d94fea22 Add unbind call to dealloc methods, add children method to proxy class, cleanup 2024-07-05 01:40:51 -04:00
Gregory John Casamento
7aee7f6667 Use ...ForNode: methods so that the path is dependent on the kind of node 2024-07-03 04:08:43 -04:00
Gregory John Casamento
860e1863da Minor correction to spelling 2024-06-30 22:07:54 -04:00
Gregory John Casamento
6b2bddab4c Add code to determine if a node has children and the number if the count key is not specified 2024-06-30 21:58:37 -04:00
Gregory John Casamento
ff97a5bbe2 Remove private method entirely, per discussion with @fredkiefer 2024-06-29 22:06:09 -04:00
Gregory John Casamento
aa4f9b5dbf Remove NSString category per discussion with @fredkiefer 2024-06-29 21:48:27 -04:00
Gregory John Casamento
6b808f2d24 Whitespace cleanup, remove unneeded methods, remove NSLogs 2024-06-27 05:54:06 -04:00
Gregory John Casamento
930e3b6c0f Update isExpandable: to be used either in the case where we have a dataSource or if we have a binding, also use it in the loadItem... method so the logic for this is in ONE place 2024-06-27 05:37:01 -04:00
Gregory John Casamento
fb2f605e18 Update drawing code to handle binding, add NSString private method to helpers, remove debugging code from binding connector and outline 2024-06-26 18:17:21 -04:00
Gregory John Casamento
340b95c9fa Limit the items we grab from the binding. Check if item is expanded, etc 2024-06-25 19:43:12 -04:00
Gregory John Casamento
3dfcdf6570 Update loading mechanism and add new proxy class for tree node 2024-06-25 17:11:57 -04:00
Gregory John Casamento
f7afc331eb Interim changes before refactor of NSTreeController 2024-06-24 08:50:22 -04:00
Gregory John Casamento
1d29613491 Progress, thusfar... 2024-06-19 03:28:39 -04:00
Gregory John Casamento
bfb33156cf Move code over from old branch, startint new branch since NSOutlineView was refactored 2024-06-19 01:46:27 -04:00
Gregory John Casamento
baca2ae98a Minor cleanup, move storage of view code to conditional where it is created, suggested by @fredkiefer 2024-06-16 21:01:41 -04:00
Gregory John Casamento
cf7b9ebd39 Final changes suggested by @fredkiefer and some small fixes before merge 2024-06-16 20:52:06 -04:00
Gregory John Casamento
77bf2f823b Move method back, eliminate possible duplicate call to render outline cell, changes suggested by review with @fredkiefer 2024-06-16 16:25:00 -04:00
Gregory John Casamento
b4c98b329b Move method that renders the outline icon per discussion with @fredkiefer, also includes some whitespace fixes 2024-06-16 08:38:12 -04:00
Gregory John Casamento
9070a9d30f Move view rendering to viewAtColumn:row:makeIfNecessary: and eliminate uneeded private method 2024-04-28 15:04:29 -04:00
Gregory John Casamento
4d5957eaf7 Fully refactor delegate calls into NSTableView/NSOutlineView and move outlineColumn drawing to a public method 2024-04-28 09:49:19 -04:00
Gregory Casamento
82dce67eb4
Reduce code duplication in GSThemeDrawing table/outline view drawing methods (#262)
* Reduce code duplication in drawViewCell:... method

* Further reduce code duplication, add common private method for calculating starting and ending column

* Use the tableView in the method that calculates the starting and ending rows

* Add code to properly handle prototypeViews, the XIB is NOT split, I was confused

* Call awakeFromNib on view as well

* Refactor so that the outlineColumn drawing code is shared

* Adjust the image drawing and the clickable area to be more aligned also make it easier to expand or collapse an item in the outline view
2024-04-26 18:40:11 +02:00
Gregory John Casamento
c1e3cf2f08 Fix the image position and refresh when opening and closing items if it is a viewBased outline view. Tested and behavior seems consistent with macOS 14. 2024-04-22 09:00:53 -04:00