Commit graph

7890 commits

Author SHA1 Message Date
Eric Wasylishen
1b70ae827a * Source/NSTableColumn.m (-initWithIdentifier:): Make data
cell editable by default.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34547 72102866-910b-0410-8b05-ffd578937521
2012-01-15 21:34:40 +00:00
Richard Frith-MacDonald
db92916b2f Attempt to get gnome and windows themes working again.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34528 72102866-910b-0410-8b05-ffd578937521
2012-01-14 17:55:43 +00:00
Richard Frith-MacDonald
28460f68e4 Cleanup/simplify code for handling theme names in defaults system
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34527 72102866-910b-0410-8b05-ffd578937521
2012-01-14 16:10:48 +00:00
Fred Kiefer
6149707b77 * Source/GSStandardWindowDecorationView.m (-mouseDown:): Pass the
event on to the super implementation if we don't handle it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34500 72102866-910b-0410-8b05-ffd578937521
2012-01-12 09:42:03 +00:00
Fred Kiefer
e2884bafce * Source/NSImage.m (+_clearFileTypeCaches): Use DESTROY instead of
RELEASE.
Patch by Philippe Roussel <p.o.roussel@free.fr>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34492 72102866-910b-0410-8b05-ffd578937521
2012-01-11 08:12:43 +00:00
Eric Wasylishen
53ac9ad559 * Source/NSImage.m: Remove duplicate #import
* Source/NSImage.m: Correct _clearFileTypeCaches notification
method to take a NSNotification* parameter.
* Soure/NSImage.m (themeDidActivate:): Move to a class method,
and move the GSThemeDidActivateNotification subscription
to +[NSImage initialize]. Now the +_themeDidActivate: updates
all images by looking at all the values in nameDict. This should
function exactly the same as before, but seems to be quite a bit
faster due to fewer notifications being sent (?)
* Source/NSImage.m (+imageNamed:): Remove redundant fetch from
nameDict pointed out by Fred


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34482 72102866-910b-0410-8b05-ffd578937521
2012-01-10 19:16:46 +00:00
Eric Wasylishen
378ca9230e * Source/NSImage.m (+pathForImageNamed:): Add underscore and
move to private category. Also remove use of lock as it is
unnecessary
* Source/NSImage.m: (-themeDidActivate:): Extract method
_resetAndUseFromFile:. Don't reset _size if
flags.sizeWasExplicitlySet was true.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34481 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:55:57 +00:00
Eric Wasylishen
f2fe6fead5 * Source/NSOpenPanel.m: Rewrite/simplify selection handling,
fix bug reported by Riccardo where OK button is disabled when
selecting directories after selecting a file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34480 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:42:04 +00:00
Eric Wasylishen
bfd7621ba5 * Source/GSGhostscriptImageRep.m: Add missing ASSIGN
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34479 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:39:34 +00:00
Eric Wasylishen
bff0f57b54 * Source/GSTheme.m: Remove code which sets and unsets images
on theme activation/deactivation.
* Source/NSImage.m (+imageNamed:): Factor out code for finding
the path for a name to a separate method, +pathForImageNamed.
The code is unchanged otherwise, except for fixing the retrieval
of images from the theme bundle, which was broken.
* Source/NSImage.m (-setName:): Remove code for creating theme
proxy. Subscribe/unscribe to theme change notification when
the receiver is added/removed from the name dictionary.
* Source/NSImage.m (-themeDidActivate:): Method called in
response to a GSThemeDidActivateNotification on images with
a name set. It does a path lookup in the same way that
+imageNamed: would, and checks if the path has changed due
to the theme change. If it has, all reps are discarded and
the image at the new path is loaded. This avoids the need for
the theme proxy objects.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34474 72102866-910b-0410-8b05-ffd578937521
2012-01-10 04:38:10 +00:00
Fred Kiefer
82eac9eaf0 Declare the new method
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34470 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:40:45 +00:00
Fred Kiefer
93403780f3 Cache the file type results for the image reps and clear the cache when these change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34469 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:39:50 +00:00
Fred Kiefer
c1a3a4549b Raise an exception if the PPD file cannot be read. Change make based on
request by Riccardo on the mailing list.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34397 72102866-910b-0410-8b05-ffd578937521
2012-01-03 09:18:51 +00:00
Wolfgang Lux
95c5829fa5 Fix two incorrect comparisons in NSLayoutManager which were causing
range exceptions when moving the cursor up in the first line and down
in the last line of a NSTextView, respectively.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34375 72102866-910b-0410-8b05-ffd578937521
2012-01-01 11:29:20 +00:00
Eric Wasylishen
4eac748b62 * Source/NSPrintOperation.m (_print): Fix read of uninitialized
variable, which was breaking printing of wrap-to-page mode in
TextEdit. TODO: Run the printing code through valgrind, there is
a lot of suspicious code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34373 72102866-910b-0410-8b05-ffd578937521
2011-12-31 22:37:55 +00:00
Wolfgang Lux
cc31ecbeda Change the default text container inset for NSTextView to (0,0) to
reduce blank space around text.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34367 72102866-910b-0410-8b05-ffd578937521
2011-12-29 22:16:50 +00:00
Wolfgang Lux
b046febc21 Get the insertion point rectangle right for character index 0.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34364 72102866-910b-0410-8b05-ffd578937521
2011-12-29 18:34:27 +00:00
Wolfgang Lux
0da1b1f034 Adjust the minimum and maximum sizes of a NSTextView to ensure that
the minimum size is not greater than the current size and the maximum
size is not smaller than the current size.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34362 72102866-910b-0410-8b05-ffd578937521
2011-12-29 16:48:17 +00:00
Germán Arias
a91a93939d Update spanish localizable strings
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34358 72102866-910b-0410-8b05-ffd578937521
2011-12-28 05:30:36 +00:00
Eric Wasylishen
2f0f50cc95 Undo last change as it broke Graphos printing
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34353 72102866-910b-0410-8b05-ffd578937521
2011-12-23 21:22:41 +00:00
Eric Wasylishen
d374f0acae * Source/NSView.m (-beginPageInRect:atPlacement:): Always translate
by the placement value. Previously, we would translate only if the
rect parameter was empty, which doesn't make sense to me.
This fixes the bug where the last page of a document printed from
Ink/TextEdit was incorrectly positioned at the bottom of the
printed page.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34352 72102866-910b-0410-8b05-ffd578937521
2011-12-23 20:33:19 +00:00
Fred Kiefer
e740f7b0cc * Source/NSTextView.m (-setFieldEditor:): Use different values for
both cases.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34347 72102866-910b-0410-8b05-ffd578937521
2011-12-22 22:00:42 +00:00
Eric Wasylishen
30a76f4458 * Source/NSSavePanel.m (-browser:createRowsForColumn:inMatrix:):
Set icon size based on cell's cellSize


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34346 72102866-910b-0410-8b05-ffd578937521
2011-12-22 19:08:47 +00:00
Fred Kiefer
12bbf00d16 Removed a few compiler warnings found by gcc 4.6
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34344 72102866-910b-0410-8b05-ffd578937521
2011-12-22 09:16:04 +00:00
Eric Wasylishen
52b39d8923 * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:):
Restore code to draw the background when the cell is highligted


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34337 72102866-910b-0410-8b05-ffd578937521
2011-12-21 06:43:42 +00:00
Eric Wasylishen
b2e98ecb59 * Source/NSSavePanel.m (-browser:createRowsForColumn:inMatrix:):
Set file icons on browser cells in the open/save panels.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34322 72102866-910b-0410-8b05-ffd578937521
2011-12-19 01:00:07 +00:00
Eric Wasylishen
3445284ccc * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:):
When highlighted, use -image if -alternateImage is nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34321 72102866-910b-0410-8b05-ffd578937521
2011-12-19 00:54:49 +00:00
Eric Wasylishen
d8ed82a8a8 * Source/NSTableView.m (-_isCellEditableColumn:row:): Tweak
criteria for determining cell editability::
- the delegate (if present) must say YES
- and the cell itself must return YES for isEditable
- and the table column must return YES for isEditable
Previously you could edit cells that returned NO for
isEditable if the column they were in was editable.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34320 72102866-910b-0410-8b05-ffd578937521
2011-12-19 00:18:58 +00:00
Eric Wasylishen
0c1a040bda * Source/NSTableHeaderView.m (-initWithCoder:): Remove unneeded
"_tableView = nil" which was causing a problem with my xib file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34319 72102866-910b-0410-8b05-ffd578937521
2011-12-18 23:57:39 +00:00
Eric Wasylishen
58c670f346 * Source/NSBrowserCell.m (-image, -setImage:): Override NSCell
implementation so these methods work without requiring the
cell to be an image cell.
* Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:): Don't
draw background. Remove -(void) isOpaque { return YES; }. Also
pixel-align images and use modern -drawInRect: method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34317 72102866-910b-0410-8b05-ffd578937521
2011-12-18 22:16:20 +00:00
Fred Kiefer
a17f42c6da * Source/NSOutlineView.m (-_openItem:): Changed i fron NSUInteger
to NSInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34316 72102866-910b-0410-8b05-ffd578937521
2011-12-18 21:06:31 +00:00
Fred Kiefer
c35a95998d Make the same change in NSDrawer and also switch to CGFloat.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34314 72102866-910b-0410-8b05-ffd578937521
2011-12-17 20:29:09 +00:00
Fred Kiefer
8ad4aa86c4 Replace some occurences of int with NSInteger
and unsigned with NSUInteger. This allows to recompile gui on 
64 bit systems after the change to NSNotFound in base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
Riccardo Mottola
0a6beb65c6 Tweaked positions and removed fractionary ones.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34302 72102866-910b-0410-8b05-ffd578937521
2011-12-16 07:56:47 +00:00
Eric Wasylishen
6e831e5f00 * Headers/AppKit/NSTextView.h: Change _dragTargetLocation to NSUInteger
because NSNotFound no longer fits in unsigned int on 64-bit


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34295 72102866-910b-0410-8b05-ffd578937521
2011-12-15 18:37:19 +00:00
Eric Wasylishen
10ee7a4dd2 * Source/NSPrintPanel.m:
Move _finalWritePrintInfo: call to the end of _pickedButton:. This
fixes the save and preview buttons for me.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34294 72102866-910b-0410-8b05-ffd578937521
2011-12-15 18:31:34 +00:00
Eric Wasylishen
e395fe88d7 * Source/NSPrinter.m:
* Source/NSPrintOperation.m:
* Source/NSPageLayout.m:
* Source/NSPrintInfo.m:
* Headers/AppKit/NSPrintInfo.h: Migrate printing code to CGFloat
or double.
* Source/NSTextView.m: Rewrite -adjustPageHeightNew🔝bottom:limit:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34288 72102866-910b-0410-8b05-ffd578937521
2011-12-15 06:51:02 +00:00
Eric Wasylishen
44d4221385 * Source/NSImageCell.m: if drawing on a view use -centerScanRect:
to pixel align the drawing rect.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34285 72102866-910b-0410-8b05-ffd578937521
2011-12-14 18:52:42 +00:00
Germán Arias
8936dbf826 Verify if there is error information to be displayed in an Alert panel
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34242 72102866-910b-0410-8b05-ffd578937521
2011-12-02 23:15:07 +00:00
Wolfgang Lux
6365fa5127 Reinstate Fred's change with the additional correction to the string
drawing code he proposed on the mailing list.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34241 72102866-910b-0410-8b05-ffd578937521
2011-12-02 21:36:58 +00:00
Eric Wasylishen
f218a41010 * Source/NSTextView.m
(-_scheduleTextCheckingInVisibleRectIfNeeded): Check for
nil before sending -rectValue to avoid crash


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34238 72102866-910b-0410-8b05-ffd578937521
2011-12-02 05:10:54 +00:00
Gregory John Casamento
14d5d889be revert change by fred.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34230 72102866-910b-0410-8b05-ffd578937521
2011-11-30 15:43:04 +00:00
Fred Kiefer
db75526dee * Source/NSPopUpButtonCell.m (-initWithCoder:): If no selection
index is given select the first item. This should fix bug #34923.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34228 72102866-910b-0410-8b05-ffd578937521
2011-11-28 20:29:35 +00:00
Fred Kiefer
865c22357b * Source/NSTextView.m (-buildUpTextNetwork:): Move setting the
default line framgent padding from here ...
* Source/NSTextContainer.m (-initWithContainerSize:): ... to here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34227 72102866-910b-0410-8b05-ffd578937521
2011-11-28 17:20:45 +00:00
Fred Kiefer
e11f1e26b3 Commit OpenGL patch by Julian Mayer <julian@corecode.at>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34226 72102866-910b-0410-8b05-ffd578937521
2011-11-28 17:16:10 +00:00
Fred Kiefer
6edd461100 Revert change to use AltGr as Alt key. You may still get the same result
by setting a user default.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34225 72102866-910b-0410-8b05-ffd578937521
2011-11-28 17:00:50 +00:00
Gregory John Casamento
e9aaaf4b61 Changes to correct bug#34919. NSTextView should now correctly show the padding set in the lineFragmentPadding attribute of NSTextContainer.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34222 72102866-910b-0410-8b05-ffd578937521
2011-11-28 02:37:58 +00:00
Fred Kiefer
a84a2ca96f * Headers/AppKit/AppKit.h: Add NSColorSpace.h. This fixes bug #34913.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34221 72102866-910b-0410-8b05-ffd578937521
2011-11-27 23:14:26 +00:00
David Chisnall
b1f0f176bb Added ChangeLog entry from last commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34217 72102866-910b-0410-8b05-ffd578937521
2011-11-25 20:27:58 +00:00
David Chisnall
a5bfae5fc4 NSAutoreleasePool* -> id in NSApplication.h, so the header can be used in ARC code (which prohibits explicit references to NSAutoreleasePool).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34216 72102866-910b-0410-8b05-ffd578937521
2011-11-25 20:27:39 +00:00