Commit graph

7676 commits

Author SHA1 Message Date
Fred Kiefer
db2cf18bfe * Source/GSThemeDrawing.m (-drawTableViewRow:clipRect:inView:):
Don't change the value of an edited cell.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37638 72102866-910b-0410-8b05-ffd578937521
2014-01-26 22:01:07 +00:00
Sebastian Reitenbach
74e1e2b088 * Source/NSFontPanel.m
* Some int -> NSInteger and float -> CGFloat transitions

OK Fred



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37635 72102866-910b-0410-8b05-ffd578937521
2014-01-26 12:01:38 +00:00
Wolfgang Lux
1549ee2fa9 Pass nil argument to selector called by NSTextView -doCommandBySelector:
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37633 72102866-910b-0410-8b05-ffd578937521
2014-01-24 09:07:31 +00:00
Fred Kiefer
72f44c1ded * Source/NSDocument.m: Add some NSError return values.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37619 72102866-910b-0410-8b05-ffd578937521
2014-01-19 21:30:23 +00:00
Fred Kiefer
26c365c9f0 * Source/NSTextAttachment.m: Add keyed coding.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37580 72102866-910b-0410-8b05-ffd578937521
2014-01-12 14:55:03 +00:00
Fred Kiefer
ad6f23c0ee * Source/NSAttributedString.m (-fixFontAttributeInRange:): Don't
look for substitutions for control or attachment characters.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37575 72102866-910b-0410-8b05-ffd578937521
2014-01-11 18:09:54 +00:00
Fred Kiefer
e15355d1e0 * Source/NSSavePanel.m (-runModal): Use only last component from
filename.
* Source/NSSavePanel.m (-filename): Return autoreleased copy of
  instance variable.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37570 72102866-910b-0410-8b05-ffd578937521
2014-01-10 16:58:18 +00:00
Niels Grewe
0725950577 Roll back addition of redundant method.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37539 72102866-910b-0410-8b05-ffd578937521
2014-01-05 23:03:35 +00:00
Niels Grewe
ae97581586 Add a method to GSDisplayServer that allows you to obtain the
identifier used by the backend's windowing system instead of
just the GNUstep-internal window number. On X11, the identifier
is useful, among other things, to implement the D-Bus menu 
protocol.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37533 72102866-910b-0410-8b05-ffd578937521
2014-01-01 19:45:26 +00:00
Fred Kiefer
4c0f9fbc97 * Headers/AppKit/NSAnimation.h
* Headers/AppKit/NSApplication.h
        * Headers/AppKit/NSControl.h
        * Headers/AppKit/NSPopover.h
        * Headers/AppKit/NSSavePanel.h
        * Headers/AppKit/NSTableView.h
        * Headers/AppKit/NSTextView.h
        * Headers/AppKit/NSWindow.h: Use GS_PROTOCOLS_HAVE_OPTIONAL to
        protect the @optional keyword in protocol definitions.
        Based on base patch by Marcus Mueller <znek@mulle-kybernetik.com>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37530 72102866-910b-0410-8b05-ffd578937521
2013-12-31 18:30:46 +00:00
Fred Kiefer
dc50232e07 * Source/NSImage.m: Add description method.
Patch by Johannes Lundberg <johannes@brilliantservice.co.jp>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37518 72102866-910b-0410-8b05-ffd578937521
2013-12-26 12:34:57 +00:00
Richard Frith-MacDonald
7de56fb882 Update version and release notes etc
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37505 72102866-910b-0410-8b05-ffd578937521
2013-12-24 06:50:34 +00:00
Fred Kiefer
ef35c71bfc * Update release notes to prepare for upcoming release.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37492 72102866-910b-0410-8b05-ffd578937521
2013-12-23 16:57:18 +00:00
Fred Kiefer
52d1488ad6 * Source/GSXibLoader.m: Handle changed keys for XIB 4.6 format.
Based on patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>.
* Source/GSXibLoader.m (-parser:...): Warn about unsupported XIB 5 format.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37463 72102866-910b-0410-8b05-ffd578937521
2013-12-13 20:34:52 +00:00
Fred Kiefer
9600bd7614 * Source/NSTableView.m (-numberOfRows): Return the current number
of rows not the internal cached value.
  Replace some occurences of int with NSInteger
  and unsigned with NSUInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37461 72102866-910b-0410-8b05-ffd578937521
2013-12-13 15:08:32 +00:00
Fred Kiefer
1b478fabbf * Source/NSClipView.m (-setBounds:, -setBoundsSize:): Use
-setNeedsDisplay: to redraw areas no longer covered by the
        document view.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37441 72102866-910b-0410-8b05-ffd578937521
2013-12-08 14:16:17 +00:00
Fred Kiefer
73b1e01475 * Source/NSClipView.m (-setDocumentView:): Don't take the
background colour from the document view.
  Patch by Jeff Teunissen <deek@d2dc.net>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37440 72102866-910b-0410-8b05-ffd578937521
2013-12-07 20:55:26 +00:00
Fred Kiefer
004c87b9a5 * Source/GSThemeDrawing.m (-drawScrollViewRect:inView:): Use the
scrollview bounds instead of the scroller frame for drawing the
  border.
  Patch by Jeff Teunissen <deek@d2dc.net>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37438 72102866-910b-0410-8b05-ffd578937521
2013-12-07 20:40:47 +00:00
Fred Kiefer
db8253b2d1 * Source/NSBitmapImageRep+JPEG.m: Remove CYGWIN specific define
as it is no longer needed. I leave the code for this in for a
  while.
  Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37435 72102866-910b-0410-8b05-ffd578937521
2013-12-06 17:45:37 +00:00
Fred Kiefer
4a61340345 * Source/NSClipView.m (-setBounds:, -setBoundsSize:): Mark the
documentView as needing redisplay. Fixes #40776.
        Based on patch by Jeff Teunissen <deek@d2dc.net>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37429 72102866-910b-0410-8b05-ffd578937521
2013-12-03 22:18:04 +00:00
Fred Kiefer
ab576bf677 * Source/GSThemeDrawing.m (-drawScrollViewRect:inView:): Use
NSRectFill() instead of line drawing to get sharper separator
        lines.
        * Source/GSThemeDrawing.m (-drawScrollerRect:...): Don't fill
        with window background colour.
        * Source/NSScroller.m (-drawRect:): Draw only the knob slot when
        disabled.
        * Source/NSScroller.m (-mouseDown:): Don't handle mouse down
        event when disabled.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37428 72102866-910b-0410-8b05-ffd578937521
2013-12-03 21:37:41 +00:00
Fred Kiefer
b0bf0e98c6 * Source/NSScroller.m (-drawKnobSlot): Draw the slot even when
the scroller is disabled.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37427 72102866-910b-0410-8b05-ffd578937521
2013-12-02 18:59:04 +00:00
Fred Kiefer
313f18786a * Source/Functions.m (NSFrameRectWithWidth): Use one pixel width
if a value of 0 is given. Fixes bug #40760
        * Source/NSScroller.m: Move disable check out of -rectForPart:.
        Fixes bug #40761.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37425 72102866-910b-0410-8b05-ffd578937521
2013-12-01 20:58:06 +00:00
Fred Kiefer
3ad5c33813 * Headers/Additions/GNUstepGUI/GSModelLoaderFactory.h,
* Source/GSModelLoaderFactory.m: Add new method +supportedTypes.
* Source/NSBundleAdditions.m: Use this new method to implement
  NIB resource detection on top of the base methods instead of doing
  it here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37421 72102866-910b-0410-8b05-ffd578937521
2013-12-01 12:26:12 +00:00
Fred Kiefer
46d7887140 * Source/NSGradient.m: Rearrange code to avoid duplicate
saveGraphicsState calls.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37407 72102866-910b-0410-8b05-ffd578937521
2013-11-24 20:25:23 +00:00
Fred Kiefer
887f3090cc * Source/NSBitmapImageRep+GIF.m: Add define missing in libgif 5.0.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37405 72102866-910b-0410-8b05-ffd578937521
2013-11-24 11:56:33 +00:00
Fred Kiefer
07f47bb507 * Source/NSBrowser.m (-selectionIndexPaths): Actually do the correction.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37404 72102866-910b-0410-8b05-ffd578937521
2013-11-24 11:08:02 +00:00
Fred Kiefer
af132da570 * Source/NSBrowser.m (-selectionIndexPaths): Correct off by one
error in last change.
  Detected by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37403 72102866-910b-0410-8b05-ffd578937521
2013-11-23 17:04:56 +00:00
Fred Kiefer
57bb4c08cd * configure.ac: Detect new GifQuantizeBuffer function.
* configure: regenerate
        * Source/NSBitmapImageRep+GIF.m: Try to handle quantize again
          for libgif 5.0.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37400 72102866-910b-0410-8b05-ffd578937521
2013-11-22 23:02:17 +00:00
Fred Kiefer
dddd3f5e3b * configure.ac: Try to improve the ICU detection.
* configure: regenerate
        * Headers/AppKit/NSTrackingArea.h
        * Source/NSTrackingArea.m: Remove compiler warnings.
        * Headers/AppKit/NSBrowser.h,
        * Source/NSBrowser.m: Add a few new Cocoa methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37399 72102866-910b-0410-8b05-ffd578937521
2013-11-22 22:44:37 +00:00
Germán Arias
26a36530a1 Set _lastPoint only for mouse entered events.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37398 72102866-910b-0410-8b05-ffd578937521
2013-11-22 19:21:02 +00:00
Riccardo Mottola
6c7e20737f Adapt for newer libgif versions of EGifOpen and renamed GifMakeMapObject.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37369 72102866-910b-0410-8b05-ffd578937521
2013-11-08 09:01:50 +00:00
Eric Wasylishen
0bd1257321 * Source/GSThemeDrawing.m (-highlightTableViewSelectionInClipRect:...):
Use color named @"highlightedTableRowBackgroundColor", if present in
the theme, to fill the selected row background.
* Source/GSThemeDrawing.m (-drawTableViewRow:clipRect:inView:):
When the row/column is selected, if the cell is a NSTextFieldCell,
set the text color to @"highlightedTableRowTextColor" before drawing the
cell (only if the theme defines that color).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37363 72102866-910b-0410-8b05-ffd578937521
2013-11-05 21:34:52 +00:00
Sebastian Reitenbach
2c78f52487 * Source/NSSpellChecker.m
int -> NSInteger transition

OK Fred



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37355 72102866-910b-0410-8b05-ffd578937521
2013-11-03 16:04:06 +00:00
Fred Kiefer
072ade9e21 * Source/GSServicesManager.m: Call the more modern
NSDocumentController methods to open documents.
        * Resources/English.lproj/Localizable.strings
        * Resources/Esperanto.lproj/Localizable.strings
        * Resources/French.lproj/Localizable.strings
        * Resources/German.lproj/Localizable.strings
        * Resources/Italian.lproj/Localizable.strings
        * Resources/Lojban.lproj/Localizable.strings
        * Resources/Spanish.lproj/Localizable.strings
        Regenerate string files.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37350 72102866-910b-0410-8b05-ffd578937521
2013-11-01 20:34:29 +00:00
Richard Frith-MacDonald
332554d6fb fix caching for mutated attribute values
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37343 72102866-910b-0410-8b05-ffd578937521
2013-11-01 06:45:18 +00:00
Fred Kiefer
9b69de19d4 * Source/GSHorizontalTypesetter.m (-layoutLineNewParagraph:):
Only adjust max_line_height to minimumLineHeight if it isn't zero.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37296 72102866-910b-0410-8b05-ffd578937521
2013-10-27 20:02:41 +00:00
Riccardo Mottola
d472adfbb1 * Source/NSTextView.m (-mouseDown:): Use container origin for attachment cells.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37283 72102866-910b-0410-8b05-ffd578937521
2013-10-26 15:50:02 +00:00
Fred Kiefer
56803c6c14 * Source/NSMenuView.m (-heightForItem:): Use
-menuItemCellForItemAtIndex: to protect against an index being to
  big. This happens when the menu does not send notifications and a
  non-existing item gets highlighted.
* Source/NSMenuView.m (-menuItemCellForItemAtIndex:): Protect
  against negative index values.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37279 72102866-910b-0410-8b05-ffd578937521
2013-10-25 22:34:18 +00:00
Fred Kiefer
35b547f964 * Source/NSBitmapImageRep+PNG.m: Better cleanup on error.
* Source/NSBitmapImageRep.m (_set_bit_value): Correct error in
bit operation. This should allow the code to work with 16 bit images.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37267 72102866-910b-0410-8b05-ffd578937521
2013-10-20 20:41:52 +00:00
Eric Wasylishen
5c7627d474 * Images/common_SliderHoriz.tiff:
* Images/common_SliderVert.tiff: Bake in the control background
color because the NSSliderCell now draws these without filling
with [NSColor controlBackgroundColor] first.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37250 72102866-910b-0410-8b05-ffd578937521
2013-10-18 02:42:50 +00:00
Fred Kiefer
2c7ebd84a2 Add some OSX 10.6 methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37247 72102866-910b-0410-8b05-ffd578937521
2013-10-17 21:05:15 +00:00
Eric Wasylishen
d9da770d5b * Source/GSThemeDrawing.m:
* Source/GSThemeTools.m:
	* Headers/Additions/GNUstepGUI/GSTheme.h: Small refactor:
	most uses of -[GSTheme fillRect:withTiles:background:] use
	[NSColor clearColor], so add a version without the background:
	param.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37244 72102866-910b-0410-8b05-ffd578937521
2013-10-16 07:19:45 +00:00
Eric Wasylishen
326a3d57f4 * Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add methods
	-menuSubmenuHorizontalOverlap and -menuSubmenuVerticalOverlap
	wrapping user defaults GSMenuSubmenuHorizontalOverlap and
	GSMenuSubmenuVerticalOverlap
	* Source/NSMenuView.m (-locationForSubmenu:): Offset calculations
	by -[GSTheme menuSubmenuHorizontalOverlap] and
	-[GSTheme menuSubmenuVerticalOverlap]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37243 72102866-910b-0410-8b05-ffd578937521
2013-10-16 07:08:15 +00:00
Eric Wasylishen
64432f901d * Source/GSThemePrivate.h:
* Source/GSTheme.m: Add GSStringFromImageFrameStyle
	* Source/GSThemeDrawing.m (-drawBorderForImageFrameStyle:...):
	Use GSStringFromImageFrameStyle to get tiles, if presentwq


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37242 72102866-910b-0410-8b05-ffd578937521
2013-10-16 05:14:32 +00:00
Eric Wasylishen
c05595c8be * Source/GSThemeDrawing.m (-drawColorWellBorder:...): Draw inner
border using part GSColorWellInnerBorder
	* Source/GSTheme.m:
	* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSColorWellInnerBorder
	part name


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37240 72102866-910b-0410-8b05-ffd578937521
2013-10-16 04:11:41 +00:00
Eric Wasylishen
a4fa237d9e * Source/GSThemePrivate.h:
* Source/GSThemeTools.m:
	* Source/GSThemeDrawing.m: Add explicit isFlipped: param to
	-[GSDrawTiles contentRectForRect:]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37239 72102866-910b-0410-8b05-ffd578937521
2013-10-16 03:36:01 +00:00
Eric Wasylishen
310b7d5786 * Headers/Additions/GNUstepGUI/GSTheme.h: Remove GSScrollViewBottomCorner
part name, instead themes should just provide a part called NSScrollView.

	Add -scrollViewScrollersOverlapBorders method.

	* Source/GSTheme.m: Remove GSScrollViewBottomCorner part name.
	* Source/GSThemeDrawing.m: Add -scrollViewScrollersOverlapBorders.
	* Source/GSThemeDrawing.m (-drawBrowserRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the browser background
	with the NSScrollView tile.
	* Source/GSThemeDrawing.m (-drawScrollViewRect:...): If
	-scrollViewScrollersOverlapBorders is enabled, fill the scroll view background
	with the NSScrollView tile.
	* Source/NSScroller.m (-rectForPart:): Change the meaning of the
	GSScrollerKnobOvershoot default so the knob only overlaps the buttons
	by this much (rather than both ends of the track). Turns out this is more
	useful for themes.
	* Source/NSScrollView.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders]
	* Source/NSBrowser.m (-tile): Add support for
	-[GSTheme scrollViewScrollersOverlapBorders] and
	-[GSTheme scrollViewUseBottomCorner]

	The overall point of these additions is to support NSScrollView and
	NSBrowser looking like: http://jesseross.com/clients/gnustep/ui/concepts/


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37238 72102866-910b-0410-8b05-ffd578937521
2013-10-15 23:26:51 +00:00
Eric Wasylishen
4e1aeabe94 * Source/NSTableView.m (-tile): Check the GSScrollViewNoInnerBorder
user default to see whether to expand the corner view by 1pt or not.
* Source/GSThemeDrawing.m (-drawTableHeaderRect:inView:): Remove
special case which reduced the width of the last column header by 1pt.

I don't see any reason for doing that and it looks better to me without
the gap, and more uniform for themeing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37237 72102866-910b-0410-8b05-ffd578937521
2013-10-15 20:33:46 +00:00
Eric Wasylishen
74bd902874 * Source/NSButtonCell.m:
* Source/NSMenuItemCell.m: Make a shared -themeControlState in
NSButtonCell and eliminate duplicated code.
* Source/NSPopUpButtonCell.m: Add private declaration for
-[NSButtonCell themeControlState]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37236 72102866-910b-0410-8b05-ffd578937521
2013-10-15 18:41:17 +00:00