Add a Travis CI build to gnustep-gui to check if everything is really
okay before accepting patches.
Recent events have shown that bad patches have passed through the review
process, specially when it comes to breaking compatibility with GCC. A
CI routine would distinctly avoid these cases.
Objective-C memory management policy specifies that methods named with
alloc, new, copy and mutableCopy are the ones that return objects with
refcount 1.
Additionally, `@property (..., copy, ...)` only modifies the setter; the getter
still returns the object as-is. While it should be correct to create
a new immutable object every time, we should not create an object
with refcount 1, but an autoreleased object.
* Source/NSAttributedString.m: Check for surrogate UTF16
characters to prevent nil strings when trying to attempt fonst
substitution.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40430 72102866-910b-0410-8b05-ffd578937521
Correct JPEG export which was using size instead of pixelsWide and pixelsHigh.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40415 72102866-910b-0410-8b05-ffd578937521
Merge some of the changes from the testplant branch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40406 72102866-910b-0410-8b05-ffd578937521
line rect when needed.
* Source/NSTextView.m (sizeToFit): Don't add extra line rect, as
it is now already included.
* Source/NSStringDrawing.m (cache_lookup): Remove hack for empty string.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40346 72102866-910b-0410-8b05-ffd578937521
* Source/NSStringDrawing.m (cache_lookup): Try to handle case of
empty string.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40342 72102866-910b-0410-8b05-ffd578937521
methods. And make sure we update the menu items before display and
keyEquivalent processing.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40285 72102866-910b-0410-8b05-ffd578937521
* Source/NSColorPanel.m: Remove left over GModel loading code.
Set default mode to colour wheel.
Small cleanups mostly in comments.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40229 72102866-910b-0410-8b05-ffd578937521
bottom wells.
* Source/NSColorWell.m (-performClick:): Add this method and use
it in -mouseUp:.
Patch by Josh Freeman <pikopixel@twilightedge.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40228 72102866-910b-0410-8b05-ffd578937521
* Source/NSBitmapImageRep.m: Set the TIFF subfield type to 0
instead of 255.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40185 72102866-910b-0410-8b05-ffd578937521
an image value of nil. This is needed for Emacs.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40168 72102866-910b-0410-8b05-ffd578937521
Simplify this method and move it in the file.
* Source/NSLayoutManager.m: Use the pre-computed advancement
instead of calculating it every time.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40167 72102866-910b-0410-8b05-ffd578937521
descriptor. Use only the minimal attributes.
* Source/NSFontDescriptor.m (-postscriptName): Generate PS name
from font name itself.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40092 72102866-910b-0410-8b05-ffd578937521
* Source/NSPrintInfo.m: Add a comment so it's clear what
this method is meant for.
* Source/NSView.m: In beginPage🏷️bBox:fonts: align top level
view with current page dimensions.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40002 72102866-910b-0410-8b05-ffd578937521
resulting behaviour is as intended by the author of the last change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39974 72102866-910b-0410-8b05-ffd578937521
count > _dash_count, as NSZoneRealloc() should be allowed to
reduce the allocated block's size.
Additionally, updated ChangeLog.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39287 72102866-910b-0410-8b05-ffd578937521
screen being nil and resize only if moving is not enough.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39126 72102866-910b-0410-8b05-ffd578937521
crashes within a certain window.
Patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39098 72102866-910b-0410-8b05-ffd578937521
(TIFFRepresentationOfImageRepsInArray:): Only return a non-null
NSData object.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39090 72102866-910b-0410-8b05-ffd578937521
the delegate and the controller of the window, this gets done in
setWindow: a bit later.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39087 72102866-910b-0410-8b05-ffd578937521
font descriptors for faster replacement font detection.
* Source/GSFontInfo.m
(GSFontEnumerator-matchingFontDescriptorsFor:): Special handling
for NSFontCharacterSetAttribute.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39079 72102866-910b-0410-8b05-ffd578937521
and use isContinuous method.
* Source/NSSliderCell.m: Replace specific implementation of
-trackMouse:...untilMouseUp: with super class one and move
specific code into helper methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39077 72102866-910b-0410-8b05-ffd578937521
* Source/NSBitmapImageRep.m: Correct bug in fast path for image
premultiply/unpremultiply.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39062 72102866-910b-0410-8b05-ffd578937521
* Source/NSImage.m (-TIFFRepresentation)
(TIFFRepresentationUsingCompression:factor:): Pass on bitmaps
only.
* Source/NSBitmapImageRep.m: Implement methods to generate tiff
for multiple bitmaps.
* Source/tiff.m: Fix long standing bug in TiffHandleSeek.
In NSTiffWrite write image tiff directory to allow for multiple
images.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39050 72102866-910b-0410-8b05-ffd578937521
correct imp type.
* Source/NSButtonCell.m (-setBackgroundColor:): Update the
control view.
* Source/NSSegmentedCell.m (-drawSegment:inFrame:withView:):
* Draw
image if available.
* Source/NSPopUpButtonCell.m (-initWithCoder:): Add work around
for NSClassSwapper cell replacement.
Patches based on changes by Josh Freeman
<pikopixel@twilightedge.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39006 72102866-910b-0410-8b05-ffd578937521
* Source/NSTextView.m: Invalidate insertion point timer in
dealloc.
* Source/NSToolbarItem.m: Check for drawing rect within bounds
before drawing toolbar item.
Patch by Marcian Lytwyn <gna@advcsi.com>.
2015-09-10 Doug Simons <doug.simons@testplant.com> and Paul Landers
<paul.landers@testplant.com>
* Source/NSLayoutManager.m: Fix a bug that would try to adjust
the length of the selected range to a negative number, leading
to an exception and eventual crashes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38986 72102866-910b-0410-8b05-ffd578937521
Patch by Doug Simons <doug.simons@testplant.com>
* Source/NSControl.m (-initWithCoder:): Don't use NSEnabled flag
as it is wrong for NSComboBox.
* Source/NSComboBoxCell.m (_loadButtonCell): Set enabled on
button cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38933 72102866-910b-0410-8b05-ffd578937521
for centerScanRect: with flipped view.
* Source/NSView.m (-centerScanRect:): Change to get the failed
tests to pass.
* Source/GSThemeTools.m (-drawRoundBezel:withColor:): Make round
bezel look a bit nicer.
* Source/NSButtonCell.m (-drawImage:withFrame:inView:): Use
centerScanRect: instead of similar code.
* Source/NSCell.m: Use imageRectForBounds: and
titleRectForBounds: in drawInteriorWithFrame:inView:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38929 72102866-910b-0410-8b05-ffd578937521
* Source/NSNibConnector.m: Move NSNibConnector and subclasses in
separate file. Add isEqual: method from Gorm. Switch to new
libobjc runtime ivar access for NSNibOutletConnector.
* Source/GNUmakefile: Add new file NSNibConnector.m
* Source/GSXibLoader.m: Similar change to IBOutletConnection.
Replace GSMime base64 decode method with standard one.
* Source/GSImageMagickImageRep.m,
* Source/GSTheme.m: Remove unused #import.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38919 72102866-910b-0410-8b05-ffd578937521
escape key and make list of bindings easier to extend.
* KeyBindings/DefaultKeyBindings.dict: Add default escape key
binding to complete: method.
Patch by Marcian Lytwyn <gna@advcsi.com>.
* Source/NSInputManager.m: Fixed alt behaviors for return
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38918 72102866-910b-0410-8b05-ffd578937521
translations.
Patch by Seong-Gu Lee <sgleehd@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38890 72102866-910b-0410-8b05-ffd578937521
autosaveName as nil to fix problem with some nibs.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38889 72102866-910b-0410-8b05-ffd578937521
row/column insert, as Cocoa does.
Clean up and more NSInteger changes.
* ColorPickers/GSStandardColorPicker.m,
* Source/NSColorPanel.m (-_setupPickers): Prevent warning from
NSMatrix.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38883 72102866-910b-0410-8b05-ffd578937521
writeSelectionToPasteboard:... methods.
Based on patch by Adam Fox <adam.fox@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38871 72102866-910b-0410-8b05-ffd578937521
* Source/NSFont.m: Look for xib font property IBIsSystemFont.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38837 72102866-910b-0410-8b05-ffd578937521
* Source/NSTextStorage.m: Fixed a bug with setting _editedRange
for multiple edits when the first one is a delete (which results in
_editedRange having a length of 0) so it gets replaced instead
of expanded to include all edits.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38836 72102866-910b-0410-8b05-ffd578937521
setting divider position. Otherwise, adjustSubviews will wipe out the
setting.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38626 72102866-910b-0410-8b05-ffd578937521
id<NSMenuItem> to NSMenuitem* as it is done by Apple too
fixes warnings in NSApplication.m and NSTextView.m
OK Fred Kiefer
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38568 72102866-910b-0410-8b05-ffd578937521
* Source/NSButtonCell.m (-encodeWithCoder:): Correct bug with
image position in NSButtonFlags.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38526 72102866-910b-0410-8b05-ffd578937521
Previously, under GNUstep, NSLocalizedFailureReasonKey was ignored when
presented with +[NSAlert alertWithError]. Additionally, error set in
-readFromData:ofType:error: was overwritten by two different methods in the
file reading chain.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38483 72102866-910b-0410-8b05-ffd578937521
the save panel's title bar not matching the set title when
the panel is reused for a different purpose.
Patch by Doug Simons <doug.simons@testplant.com>
* Source/NSApplication.m: Adjust modal window position to
relative window requested.
Patch by Marcian Lytwyn <gna@advcsi.com> with small change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38440 72102866-910b-0410-8b05-ffd578937521
* Images/GNUmakefile: Handle new file.
* Source/GSXibLoader.m: Better error reporting for wrong
application class.
* Source/NSOutline.m (-drawRow:clipRect:): Don't set the value
for the edited cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38408 72102866-910b-0410-8b05-ffd578937521
Don't autorelease the returned object as this method starts with
"new".
* Source/NSCollectionViewItem.m (-copyWithZone:): Add call to
new method to copy over the bindings from the old view hierarchy to
the new.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38405 72102866-910b-0410-8b05-ffd578937521
from being 0.
* Source/NSArrayController.m: Revert last change and add proper
handling of arrangeObjects for many cases.
* Source/NSCollectionViewItem.m: Fix reference counting. Add
method -view to have something to display.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38387 72102866-910b-0410-8b05-ffd578937521
content.
* Source/NSViewController.m (-loadView): Don't try to load the
view if there is no name for the NIB.
* Source/NSArrayController.m (-initWithContent:): Sets
automaticallyRearrangesObjects to true.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38384 72102866-910b-0410-8b05-ffd578937521
* Source/NSSpellChecker.m
Two small cleanups.
Patch by Marat Ibadinov <ibadinov@me.com>
* Source/NSLayoutManager.m
Changed == to >= to fix a crash when layout_char is beyond the
length of the string.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38312 72102866-910b-0410-8b05-ffd578937521
from -copyWithZone: to -mutableCopyWithZone:.
* Tests/gui/NSBitmapImageRep/testcopy.m: Test for this change
Patch by Josh Freeman <tedge>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38301 72102866-910b-0410-8b05-ffd578937521
idea by Riccardo Mottola <rm@gnu.org>.
Remove all usages of deprecated types.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38300 72102866-910b-0410-8b05-ffd578937521
disable supermenus that have empty submenus, when there is no
validator.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38289 72102866-910b-0410-8b05-ffd578937521
actions carrying across between different fields with the
fieldEditor.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38288 72102866-910b-0410-8b05-ffd578937521
Base on patch by Marat Ibadinov <ibadinov@me.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38287 72102866-910b-0410-8b05-ffd578937521
nil tests.
Patch by Eric Wasylishen <ewasylishen@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38283 72102866-910b-0410-8b05-ffd578937521
* Source/NSDocumentController.m:
Open recent menu to clear items that have been deleted whenever
it reloads.
Based on patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38242 72102866-910b-0410-8b05-ffd578937521
(a) locationInView was being converted twice, producing invalid
coordinates the second time, when using a provider to get the
tooltips.
(b) Tooltips were not working if you had two tracking rects next
to each other in the same view, when moving from one to the
other,
depending on the order they were processed, one could get the
enter before the other's exit, thus canceling the timer.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38241 72102866-910b-0410-8b05-ffd578937521
* Source/NSTableView.m:
Create working stubs for table view batch insertions/removals of
rows
Patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38240 72102866-910b-0410-8b05-ffd578937521
Based on patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38239 72102866-910b-0410-8b05-ffd578937521
(_insertionPointRectForCharacterIndex:textContainer:): Fix
initial
cursor insertion location with paragraph alignment setting.
This patch has no visual effect as the alignment of the typing
attributes never gets set.
Based on patch by Marcian Lytwyn <gna@advcsi.com>.
* Source/NSLayoutManager.m: Fix some compiler warnings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38238 72102866-910b-0410-8b05-ffd578937521
* Source/GSXibLoader.m: Fix object ID parsing in XIB loading due
to Apple moving to string ID represenatation.
Patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38236 72102866-910b-0410-8b05-ffd578937521
out
tabs in default paragraph style as Apple doesn't seem to have
them.
* Source/GSNibLoading.m: Set the main menu already when
instantiating the top level objects. Thi is needed for newer
versions of NIB files.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38160 72102866-910b-0410-8b05-ffd578937521
(-drawBackgroundForGlyphRange:atPoint:): Make save against
glyph_run being null. Should fix part of #43454.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38141 72102866-910b-0410-8b05-ffd578937521
