Commit graph

110 commits

Author SHA1 Message Date
Fred Kiefer
6974bf8a4f Some int -> NSInteger and float -> CGFloat transitions.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40138 72102866-910b-0410-8b05-ffd578937521
2016-10-08 21:17:53 +00:00
Richard Frith-MacDonald
08910fb913 lintian spelling correctes provided by Eric Heintzmann
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39816 72102866-910b-0410-8b05-ffd578937521
2016-05-28 09:49:15 +00:00
Richard Frith-MacDonald
1efddfc0c6 and a couple more equality tests
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39125 72102866-910b-0410-8b05-ffd578937521
2015-11-02 18:48:36 +00:00
Richard Frith-MacDonald
603322467c another small tweak with map callbacks
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39124 72102866-910b-0410-8b05-ffd578937521
2015-11-02 18:37:00 +00:00
Richard Frith-MacDonald
77bfc5d864 another tweak for using pointer identity rather than object equality
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39123 72102866-910b-0410-8b05-ffd578937521
2015-11-02 18:31:04 +00:00
Richard Frith-MacDonald
716eb9fe5e More cleanup for item identity rather than equality checks.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39119 72102866-910b-0410-8b05-ffd578937521
2015-11-02 16:35:02 +00:00
Richard Frith-MacDonald
ff8d56fd1b possible fix for ivan's StepOPML editor problem
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39118 72102866-910b-0410-8b05-ffd578937521
2015-11-02 16:02:27 +00:00
Fred Kiefer
6d27cf76b1 * Images/NSRemoveTemplate.tiff: Add file.
* Images/GNUmakefile: Handle new file.
        * Source/GSXibLoader.m: Better error reporting for wrong
        application class.
        * Source/NSOutline.m (-drawRow:clipRect:): Don't set the value
        for the edited cell.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38408 72102866-910b-0410-8b05-ffd578937521
2015-03-15 23:31:43 +00:00
Fred Kiefer
9a15cb6b88 * Source/NSViewController.m: Retain the view.
* Source/NSOutline.m(-drawRow:clipRect:): The selected cell
        * shows
        its first responder state.
        Patch by Frank LeGrand <frank.legrand@testplant.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36378 72102866-910b-0410-8b05-ffd578937521
2013-03-17 22:36:34 +00:00
Quentin Mathe
e4e5428122 Replaced -_dataCellForTableColumn:row: by -preparedCellAtColumn:row: new public method from Mac OS X 10.5
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36136 72102866-910b-0410-8b05-ffd578937521
2013-02-14 10:34:20 +00:00
David Chisnall
4850a9feac Fix all current compiler warnings on FreeBSD/x86-64.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36038 72102866-910b-0410-8b05-ffd578937521
2013-01-30 09:48:54 +00:00
Eric Wasylishen
88fdeb6886 * Source/NSWindow.m: Only invoke -prepareForDragOperation: if the
most recent -draggingEntered: or -draggingUpdated: call returned
something other than NSDragOperationNone.
* Source/NSOutlineView.m (-draggingUpdated:): Save the drag operation
value returned from the data source in a static variable.
Previously it was fetched once and then discarded, so all drags were
being mistakenly permitted.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34910 72102866-910b-0410-8b05-ffd578937521
2012-03-09 08:03:45 +00:00
Eric Wasylishen
bd5ff5ba95 * Headers/AppKit/NSOutlineView.h:
* Source/NSOutlineView.m: Add support for
outlineView:dataCellForTableColumn:item: delegate method
* Headers/AppKit/NSTableView.h:
* Source/NSTableView.m: Add support for
tableView:dataCellForTableColumn:row: delegate method


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34717 72102866-910b-0410-8b05-ffd578937521
2012-02-03 21:41:41 +00:00
Fred Kiefer
a17f42c6da * Source/NSOutlineView.m (-_openItem:): Changed i fron NSUInteger
to NSInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34316 72102866-910b-0410-8b05-ffd578937521
2011-12-18 21:06:31 +00:00
Fred Kiefer
8ad4aa86c4 Replace some occurences of int with NSInteger
and unsigned with NSUInteger. This allows to recompile gui on 
64 bit systems after the change to NSNotFound in base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
Eric Wasylishen
bfb415ee79 * Source/NSOutlineView.m: Allow collapsing or expanding multiple
rows at a time using the arrow keys


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33552 72102866-910b-0410-8b05-ffd578937521
2011-07-15 05:39:10 +00:00
Eric Wasylishen
22bfbcc946 * Source/GSGuiPrivate.h: New rounding rounding function
GSRoundTowardsInfinity which is simply floor(x+0.5)
* Source/NSBrowser.m:
* Source/NSSliderCell.m:
* Source/NSButtonCell.m:
* Source/NSClipView.m:
* Source/NSOutlineView.m:
* Source/NSRulerView.m:
Switch rint[f] to GSRoundTowardsInfinity


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33539 72102866-910b-0410-8b05-ffd578937521
2011-07-12 21:12:22 +00:00
Eric Wasylishen
8a9f26ceff * Source/NSOutlineView.m: Implement left arrow key moving selection
to parent node when the current item is collapsed.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33428 72102866-910b-0410-8b05-ffd578937521
2011-07-02 17:40:58 +00:00
Eric Wasylishen
019d81dc22 * Source/NSOutlineView.m: Implement -keyDown: to expand/contract
items.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32954 72102866-910b-0410-8b05-ffd578937521
2011-04-30 05:46:44 +00:00
Fred Kiefer
91c7ca64c0 Correct declaration of data source methods and the implementation
in NSOutlineView.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32746 72102866-910b-0410-8b05-ffd578937521
2011-03-30 08:17:00 +00:00
Fred Kiefer
2cb8461350 Implement the drag and drop support method
namesOfPromisedFilesDroppedAtDestination:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32628 72102866-910b-0410-8b05-ffd578937521
2011-03-17 10:19:11 +00:00
Fred Kiefer
8bacce8660 Send the sort message to the data source not the delegate.
This should fix bug #32806.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32624 72102866-910b-0410-8b05-ffd578937521
2011-03-16 19:07:53 +00:00
Fred Kiefer
89d6cc016c * Source/NSOutlineView.m (-editColumn:...select:): Bring closer
to the new code in [-drawRow:clipRect:].
* Source/GSInfoPanel.m (-initWithDictionary:): Protect against
icon being nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32161 72102866-910b-0410-8b05-ffd578937521
2011-02-14 20:11:57 +00:00
Quentin Mathe
d864f4cbb6 Fixed NSOutlineView to use incremental loading as Mac OS X does.
You can now use an outline view to browse a big tree structure e.g. a filesystem. 
Previously in such a case, NSOutlineView was attempting to traverse the entire 
directory structure on -reloadData.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31429 72102866-910b-0410-8b05-ffd578937521
2010-09-27 12:21:54 +00:00
Wolfgang Lux
e1647e3b1d Update the selected row indexes of an outline view after collapsing or
expanding an item. This fixes bug #29892.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31203 72102866-910b-0410-8b05-ffd578937521
2010-08-27 13:30:23 +00:00
Wolfgang Lux
11dd73b98a If the alt modifier is pressed when the user expands or collapses an
outline view item expand or collapse all children of the item as well.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31185 72102866-910b-0410-8b05-ffd578937521
2010-08-19 16:52:59 +00:00
Fred Kiefer
84f54304e1 * Headers/AppKit/NSOutlineView.h,
* Source/NSOutlineView.m: Add -parentForItem: and -frameOfOutlineCellAtRow:. 
Use the later in -drawRow:clipRect:.
Change methods to use NSInteger and CGFloat.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30514 72102866-910b-0410-8b05-ffd578937521
2010-05-31 22:18:45 +00:00
Doug Simons
9f1fb9cc7c fix occasional exception while dragging
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30234 72102866-910b-0410-8b05-ffd578937521
2010-04-24 19:43:35 +00:00
Fred Kiefer
63638ee055 Remove compiler warnings from clang.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30117 72102866-910b-0410-8b05-ffd578937521
2010-04-10 17:48:46 +00:00
Fred Kiefer
7e289df84b Yet another set of #include -> #import replacement.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30083 72102866-910b-0410-8b05-ffd578937521
2010-03-31 08:14:50 +00:00
Quentin Mathe
f616b91157 Finished to implement the NSTable/OutlineView sort descriptor support.
More changes are needed to get proper sorting support (e.g. visual feedback).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29293 72102866-910b-0410-8b05-ffd578937521
2010-01-16 14:45:13 +00:00
Quentin Mathe
bc821253e3 Fixed broken cell editability in outline views by replicating NSTableView
changes r25091.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29264 72102866-910b-0410-8b05-ffd578937521
2010-01-11 14:04:44 +00:00
Wolfgang Lux
786f376f1b Fix various issues when drawing controls with edited cells. This
includes a fix for the problem of properly resizing and redrawing the
editor when the cell is resized or moved during editing (bug #22678).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29133 72102866-910b-0410-8b05-ffd578937521
2009-12-17 01:03:07 +00:00
Riccardo Mottola
c99387f5f5 removed c99-isms
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29125 72102866-910b-0410-8b05-ffd578937521
2009-12-15 22:22:01 +00:00
Quentin Mathe
cd8dd3494f Fixed drop above indicator when the insertion level doesn't match the previous
row and is based on the horizontal pointer position.

NSOutlineView drag and drop behavior matches Mac OS X very closely now and all 
the bugs I was aware of have been corrected.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29103 72102866-910b-0410-8b05-ffd578937521
2009-12-06 01:36:26 +00:00
Quentin Mathe
fe1ba4f005 Further simplified outline view drag and drop code and wrote detailed documentation.
Added drop on root indicator support.
Fixed exception with auto-expand and root area.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29098 72102866-910b-0410-8b05-ffd578937521
2009-12-05 18:28:45 +00:00
Richard Frith-MacDonald
6949ffef21 minor simplification
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29088 72102866-910b-0410-8b05-ffd578937521
2009-12-01 09:53:54 +00:00
Richard Frith-MacDonald
6a6c7c23ae Make outline view DnD fully functioual.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29083 72102866-910b-0410-8b05-ffd578937521
2009-11-30 18:56:51 +00:00
Richard Frith-MacDonald
4d5f2cec93 First hack at expand/collapse as we drag over expandable items
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29082 72102866-910b-0410-8b05-ffd578937521
2009-11-29 18:02:06 +00:00
Richard Frith-MacDonald
4de733d2b0 improve display
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29079 72102866-910b-0410-8b05-ffd578937521
2009-11-29 13:51:15 +00:00
Richard Frith-MacDonald
8a7cfaf918 fix drawing bug when number of rows decreases
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29065 72102866-910b-0410-8b05-ffd578937521
2009-11-26 20:33:44 +00:00
Fred Kiefer
e1ae97f125 Fix small memory access bug found by valgrind.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28102 72102866-910b-0410-8b05-ffd578937521
2009-03-20 07:55:25 +00:00
Richard Frith-MacDonald
1803fa7fc5 fix #25369
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27646 72102866-910b-0410-8b05-ffd578937521
2009-01-21 07:09:50 +00:00
Gregory John Casamento
8d584d8b43 * Source/NSOutlineView.m: Added change suggested by Doug in
bug #25078.  This should fix the problem in SVN.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27285 72102866-910b-0410-8b05-ffd578937521
2008-12-13 00:32:24 +00:00
Adam Fedor
7afdd32ac1 Revert library license version to 2 until applications can be converted
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
Fred Kiefer
5b5d5ba64a Patch by Quentin Mathe <qmathe@club-internet.fr>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26247 72102866-910b-0410-8b05-ffd578937521
2008-03-07 23:51:55 +00:00
Fred Kiefer
3cbe23c511 Patch for bezier path encoding.
Add support for new dragging methods in table view.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25660 72102866-910b-0410-8b05-ffd578937521
2007-12-02 20:43:32 +00:00
Richard Frith-MacDonald
03a4a96a40 Update includes ... closer MacOS-X compatibility.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25635 72102866-910b-0410-8b05-ffd578937521
2007-11-29 20:28:03 +00:00
Fred Kiefer
193e31e678 Change all files to use GPL 3 and LGPL 3.
Prepare for next release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00
Matt Rice
7030dbfbb9 * Source/NSTableView.m (-_numRows): New quasi private method.
(-noteNumberOfRowsChanged:): Call _numRows instead of data source
        method.
        * Source/NSOutlineView.m (-noteNumberOfRowsChanged:): Don't override
        supers.
        (-_numRows): Implement.
        (-collapseItem:collapseChildren:): Remove use of _selectedObjects.
        (-expandItem:expandChildren:): Ditto.
        (-_removeChildren:): Ditto.
        (-initWithFrame:): Don't initialize _selectedObjects.
        (-initWithCoder:): Ditto.
        * Headers/AppKit/NSOutlineView.h: Mark _selectedObjects as unused.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24478 72102866-910b-0410-8b05-ffd578937521
2007-02-06 01:07:44 +00:00