Commit graph

7208 commits

Author SHA1 Message Date
Gregory John Casamento
5d9e49a2ff Remove both instances where we get properties from the binding where it is not needed during the loading process, per discussion with @fredkiefer 2024-08-08 18:20:00 -04:00
Gregory John Casamento
854af0901e Cleanup of unused or commented out methods 2024-08-08 17:48:16 -04:00
Gregory John Casamento
0ab960e6fc Remove uneeded outside iteration and get the lastIndex more efficiently, also cleanup NSLog per @fredkiefer 2024-08-08 17:44:04 -04:00
williameveretteggplant
dd67057784
push modal window to top later in process 2024-08-08 10:16:27 -06:00
William Everett
8760810340
Revert "Force modal to front"
This reverts commit 1fd80dabc2.
2024-08-08 10:02:52 -06:00
Gregory John Casamento
d8c4c14018 Move _applyBindingsToCell:atRow: to NSTableColumn 2024-08-07 22:55:14 -04:00
williameveretteggplant
1fd80dabc2
Force modal to front 2024-08-07 16:48:39 -06:00
Gregory John Casamento
21d0bc906e Fix issues pointed out by @fredkiefer 2024-08-04 18:44:01 -04:00
Gregory John Casamento
329553c196 Merge branch 'master' into NSTreeController_branch2 2024-08-03 22:20:42 -04:00
Gregory John Casamento
d694efc941 Fix compilation error 2024-08-03 21:44:02 -04:00
Gregory John Casamento
a1b9dc546e Eliminate category, move logic for prepend inline 2024-08-03 21:40:04 -04:00
Gregory John Casamento
300a84c493 Improve adding a child, also do whitespace-cleanup 2024-08-03 21:02:33 -04:00
Gregory John Casamento
13f86ebfa9 Add child index, add category that properly prepends the index to the NSIndexPath 2024-08-03 20:48:09 -04:00
Gregory John Casamento
8059cdadd0 Slight improvements 2024-08-03 20:05:23 -04:00
Gregory John Casamento
27718ee794 Slightly better attempt at getting the index path 2024-08-03 15:05:44 -04:00
Gregory John Casamento
1a8f0fa8e6 First cut at recursive method to find NSIndexPath for non NSTreeNode items 2024-08-03 14:31:51 -04:00
Gregory John Casamento
fbee6dce81 If no indexPaths are found, return the root 2024-08-02 11:20:58 -04:00
Gregory John Casamento
8935a2d2da Fix compilation issue 2024-07-28 21:05:22 -04:00
Gregory John Casamento
ad75804102 Remove method, minor cleanup, per discussion with @fredkiefer 2024-07-28 20:49:18 -04:00
Gregory John Casamento
52eef305b0 Use FOR_IN instead of while loop 2024-07-27 19:46:51 -04:00
Gregory John Casamento
6f2c542b46 Move handling of dictionary creation into GSControllerTreeProxy class, per discussion with @fredkiefer 2024-07-27 18:51:59 -04:00
Gregory John Casamento
abfc782a6c Move check for dataSource or binding into NSOutlineView before calling method to draw the row per discussion with @fredkiefer 2024-07-27 18:29:00 -04:00
Gregory John Casamento
3d59afd2c9 Improvements, per discussion with @fredkiefer 2024-07-27 17:37:04 -04:00
Gregory John Casamento
7b78d9b64e Check for methods for an item-based delegate, per discussion with @fredkiefer 2024-07-27 17:19:16 -04:00
Gregory John Casamento
4e95021973 Update to simplify code per discussion with @fredkiefer 2024-07-27 16:59:05 -04:00
Gregory John Casamento
1d266d7a9b Add back informational comments 2024-07-27 13:49:24 -04:00
Gregory John Casamento
9712490625 Minor cleanup 2024-07-26 21:24:21 -04:00
Gregory John Casamento
71304617b2 Move logic for finding the item for a given column to a private method, call method to get a view controller from the delegate 2024-07-26 10:56:52 -04:00
Gregory John Casamento
3ae1a4b41d Minor whitespace cleanup 2024-07-25 08:39:21 -04:00
Gregory John Casamento
ab737b81d5 Get the previous column when loading a column in item-based mode in _performLoadOfColumn 2024-07-25 08:23:06 -04:00
Gregory John Casamento
782321e063 Consolidate _performLoad methods, get the last item selected 2024-07-25 08:12:49 -04:00
Gregory John Casamento
f5decac3ba Add code to reset column if the delegate is item-based 2024-07-24 11:28:51 -04:00
Gregory John Casamento
ffdf8fb6da Partially correct implementation 2024-07-23 13:08:35 -04:00
Gregory John Casamento
a1dd317d29 Add delegate calls to method _performLoadOfItem:forColumn: 2024-07-22 18:48:54 -04:00
Gregory Casamento
f55d937ab2
Update NSTreeController.m
Remove NSLog from initWithContent:
2024-07-20 12:27:00 -04:00
Gregory John Casamento
1df45b788e Initial changes to start loading each column based on items 2024-07-20 12:11:47 -04:00
Gregory John Casamento
d22d839b0c Correct minor formatting issues 2024-07-19 11:12:24 -04:00
Gregory John Casamento
dc78b11291 Add code to handle insertion methods that are based on selection 2024-07-19 10:14:18 -04:00
Gregory John Casamento
cd41f301a8 Add selection logic for computing indexPaths 2024-07-19 08:04:13 -04:00
Riccardo Mottola
da2803481b Pietas, Enrico passed way, remove email 2024-07-18 13:17:06 +02:00
Gregory John Casamento
c68c459584 Add code to set selection indexes on the controller 2024-07-16 18:03:30 -04:00
Gregory John Casamento
c39095cd61 Add comment/documentation 2024-07-15 07:06:49 -04:00
Gregory John Casamento
74e0c19503 Add bindigns to NSTableColumn and handle font bindings in _applyBindingsToCell:... method 2024-07-15 06:50:20 -04:00
Gregory John Casamento
766a358fb7 Move code to handle enabled/editable bindings to a common method in the parent class 2024-07-14 16:00:18 -04:00
Gregory John Casamento
ca4fe0e078 Add code to get the value of the NSEnabledBinding 2024-07-14 15:40:47 -04:00
Gregory John Casamento
45c0368602 Add code to get the value of the NSEditableBinding 2024-07-14 15:14:07 -04:00
Gregory John Casamento
f253f3fa0e Formatting fixes.. add space before * in return value 2024-07-12 10:39:47 -04:00
Gregory John Casamento
2ba9843537 Add removeSelectionIndexPaths: 2024-07-12 09:42:26 -04:00
Gregory John Casamento
4ddce03859 Add removeObjects... methods 2024-07-12 08:49:52 -04:00
Gregory John Casamento
9b481f10b3 Correctly refresh after adding an item at an index path 2024-07-12 08:11:23 -04:00
Gregory John Casamento
90b3913a1f Add implementation for methods that add nodes at a given indexPath or set of indexPaths 2024-07-12 06:22:56 -04:00
Gregory John Casamento
bbbe9d00b4 Update _setObjectValue:... to update items in arrangedObjects when there is a binding 2024-07-11 12:18:52 -04:00
Gregory John Casamento
8da3d0afb7 Update to use NSObservedKeyPathKey instead of string, add code to _setObjectValue:... in NSTableView to set the value when we have a binding 2024-07-10 07:06:08 -04:00
Gregory John Casamento
aa86a96c55 Update to use NSObservedKeyPathKey instead of string, add code to _setObjectValue:... in NSTableView to set the value when we have a binding 2024-07-10 06:31:55 -04:00
Gregory John Casamento
060b27a854 Update _setObjectValue:... 2024-07-06 23:44:31 -04:00
Gregory John Casamento
fdb35eb869 Add value/setValue: 2024-07-06 23:06:26 -04:00
Gregory John Casamento
435ccfb2c7 Add value/setValue: 2024-07-06 23:03:31 -04:00
Gregory John Casamento
23bcb99166 Initial changes to NSBrowser for NSTreeController/binding integration 2024-07-06 22:02:10 -04:00
Gregory John Casamento
8fbcbdb380 Changes to allow editing 2024-07-05 01:57:09 -04:00
Gregory John Casamento
90d94fea22 Add unbind call to dealloc methods, add children method to proxy class, cleanup 2024-07-05 01:40:51 -04:00
Gregory John Casamento
7aee7f6667 Use ...ForNode: methods so that the path is dependent on the kind of node 2024-07-03 04:08:43 -04:00
Gregory John Casamento
ebf6bdb8d2 Update add method, fix white space issue, remove duplicate methods 2024-07-02 04:05:53 -04:00
Gregory John Casamento
860e1863da Minor correction to spelling 2024-06-30 22:07:54 -04:00
Gregory John Casamento
6b2bddab4c Add code to determine if a node has children and the number if the count key is not specified 2024-06-30 21:58:37 -04:00
Gregory John Casamento
ff97a5bbe2 Remove private method entirely, per discussion with @fredkiefer 2024-06-29 22:06:09 -04:00
Gregory John Casamento
aa4f9b5dbf Remove NSString category per discussion with @fredkiefer 2024-06-29 21:48:27 -04:00
Gregory John Casamento
9a91d04bc0 Merge ChangeLog 2024-06-29 01:48:43 -04:00
Gregory John Casamento
ab2de84a90 Remove unneeded method, per discussion with @fredkiefer 2024-06-28 19:39:10 -04:00
Gregory John Casamento
786b48dd1b Remove unneeded method 2024-06-28 09:45:41 -04:00
Gregory John Casamento
647076cb8a Update copyWithZone: method, provide simple implementation of addSelectionIndexPaths: 2024-06-28 08:39:39 -04:00
Gregory Casamento
b0d02aa7e8
Merge branch 'master' into NSMenuToolbarItem_branch 2024-06-28 08:31:11 -04:00
Gregory John Casamento
6b808f2d24 Whitespace cleanup, remove unneeded methods, remove NSLogs 2024-06-27 05:54:06 -04:00
Gregory John Casamento
930e3b6c0f Update isExpandable: to be used either in the case where we have a dataSource or if we have a binding, also use it in the loadItem... method so the logic for this is in ONE place 2024-06-27 05:37:01 -04:00
Gregory John Casamento
fb2f605e18 Update drawing code to handle binding, add NSString private method to helpers, remove debugging code from binding connector and outline 2024-06-26 18:17:21 -04:00
Gregory John Casamento
340b95c9fa Limit the items we grab from the binding. Check if item is expanded, etc 2024-06-25 19:43:12 -04:00
Gregory John Casamento
3dfcdf6570 Update loading mechanism and add new proxy class for tree node 2024-06-25 17:11:57 -04:00
Gregory John Casamento
f7afc331eb Interim changes before refactor of NSTreeController 2024-06-24 08:50:22 -04:00
Gregory John Casamento
1d29613491 Progress, thusfar... 2024-06-19 03:28:39 -04:00
Gregory John Casamento
bfb33156cf Move code over from old branch, startint new branch since NSOutlineView was refactored 2024-06-19 01:46:27 -04:00
Gregory John Casamento
baca2ae98a Minor cleanup, move storage of view code to conditional where it is created, suggested by @fredkiefer 2024-06-16 21:01:41 -04:00
Gregory John Casamento
cf7b9ebd39 Final changes suggested by @fredkiefer and some small fixes before merge 2024-06-16 20:52:06 -04:00
Gregory John Casamento
f9b89c41e6 Correct minor theme drawing issues, fix issue pointed out by @fredkiefer to address out of order row fetching 2024-06-16 17:36:15 -04:00
Gregory John Casamento
77bf2f823b Move method back, eliminate possible duplicate call to render outline cell, changes suggested by review with @fredkiefer 2024-06-16 16:25:00 -04:00
Gregory John Casamento
b4c98b329b Move method that renders the outline icon per discussion with @fredkiefer, also includes some whitespace fixes 2024-06-16 08:38:12 -04:00
Gregory John Casamento
a815ad5bb8 Edits suggested by @fredkiefer during review 2024-06-16 07:25:44 -04:00
Gregory John Casamento
1d6a850081 Make correctiongs as suggested by @fredkiefer 2024-06-16 07:12:32 -04:00
Gregory John Casamento
f83098bd8d Update changelog 2024-06-16 07:02:13 -04:00
rfm
d312fbe168 Fix for #276 2024-06-03 16:55:33 +01:00
rfm
f93ca6eeb6 Don't use lazy locks any more 2024-05-30 11:15:19 +01:00
rfm
7a98157dc7 gnustep_global_lock is removed 2024-05-30 10:35:02 +01:00
Riccardo
6094e40e8e
Merge pull request #275 from gnustep/Magick_TGA
ImageMagick TGA support fix
2024-05-22 15:06:32 +02:00
Riccardo Mottola
3ec731943c use a constant for signature and use for now only the bytes needed for TGA 2024-05-21 14:38:26 +02:00
Riccardo Mottola
7feeccceab use memset instead of bzeo, to conform to the rest of the file 2024-05-17 11:37:57 +02:00
Riccardo Mottola
f02d54ee8a code reformat 2024-05-17 10:58:37 +02:00
Riccardo
8913711a6d
Merge pull request #271 from gnustep/Endianess_BitmapRep
Improve Endianness support for BitmapRep
2024-05-15 09:48:23 +02:00
Riccardo Mottola
656fe6e576 seek for trailing signature and recognize v2 TGA files and hint that to ImageMagick 2024-05-14 00:56:39 +02:00
Riccardo Mottola
d9b291085d some come indenting cleanup 2024-05-13 22:10:31 +02:00
Riccardo Mottola
41ba427101 call SWAP_LINE_ENDIANNESS iniside the WRITE_SCANLINE macro and thus remove if() duplication 2024-05-13 21:53:06 +02:00
Riccardo Mottola
2328f7e99a use char for bool 2024-05-13 21:43:58 +02:00
Adam Fox
ae6323b042
Revert to defaultParagraphStyle tab stops from 10 years ago (#272)
* Uncomment defaultParagraphStyle tab stop defaults from 10 years ago.

* move creation of tab stops for defaultParagraphStyle into the init method

* Update ChangeLog

* fix build error

* Update ChangeLog
2024-05-13 18:47:42 +02:00