From f6f497fdeee8f08f95802b37b4c99c07939f045b Mon Sep 17 00:00:00 2001 From: fredkiefer Date: Wed, 13 Feb 2013 08:54:34 +0000 Subject: [PATCH] Resolve memory leak for GSXibElement. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36122 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 4 ++++ Source/GSXibLoader.m | 9 ++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6da5a2bdd..c288b6c31 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2013-02-13 Fred Kiefer + + * Source/GSXibLoader.m: Resolve memory leak for GSXibElement. + 2013-02-13 Fred Kiefer * Headers/AppKit/NSEvent.h diff --git a/Source/GSXibLoader.m b/Source/GSXibLoader.m index fd78f3d96..d46cdfe99 100644 --- a/Source/GSXibLoader.m +++ b/Source/GSXibLoader.m @@ -452,7 +452,7 @@ { if ([coder containsValueForKey: @"name"]) { - name = [coder decodeObjectForKey: @"name"]; + ASSIGN(name, [coder decodeObjectForKey: @"name"]); } if ([coder containsValueForKey: @"object"]) { @@ -490,7 +490,7 @@ { if ([coder containsValueForKey: @"name"]) { - name = [coder decodeObjectForKey: @"name"]; + ASSIGN(name, [coder decodeObjectForKey: @"name"]); } if ([coder containsValueForKey: @"object"]) { @@ -1253,7 +1253,10 @@ didStartElement: (NSString*)elementName andAttributes: attributeDict]; NSString *key = [attributeDict objectForKey: @"key"]; NSString *ref = [attributeDict objectForKey: @"id"]; - + + // FIXME: We should use proper memory management here + AUTORELEASE(element); + if (key != nil) { [currentElement setElement: element forKey: key];