gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-23 02:04:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix leak of dictionary object.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@17488 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Adam Fedor 2003-08-18 03:47:42 +00:00
parent 1f8c6011b3
commit db304032af
2 changed files with 41 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
ChangeLog
View file

@ -1,3 +1,40 @@
2003-08-17 Adam Fedor <fedor@gnu.org>
* Source/NSTableView.m ([NSTableView -textDidBeginEditing:]): Fix leak
of dictionary object.
([NSTableView -textDidChange:]): Idem.
([NSTableView -textDidEndEditing:]): Idem.
Fixes #4568.
2003-08-17 Adam Fedor <fedor@gnu.org>
* Source/NSImageCell.m ([NSImageCell -setObjectValue:]): Implement.
2003-08-17 Benhur Stein <benhur@inf.ufsm.br>
* NSBrowser.m:
(-selectRow:inColumn:): cleanup
(-loadedCellAtRow:column:): cleanup
(-matrixInColumn:): return nil if column not in _browserColumns
(-setPath:): cleanup; fix optimization for not loading columns that
are already loaded
(-setLastColumn:): return if column is not loaded; remove unnecessary
call to setNeedsDisplay:; remove columns greater than
_lastVisibleColumn instead of numberOfVisibleColumns; call
scrollColumnToVisible instead of making it by hand.
(-reloadColumn:): reselect previously selected cells by searching them
in reloaded matrix, instead of by position
(-scrollColumnToVisible:): removed test that assumed that if
numberOfVisibleColums is enough to display all loaded columns, they
are all displayed. This is not always the case now.
(-tile): hack to garantee that all visible columns exist. Should fix
the code that's before instead.
(-doClick:): cleanup; removed drawing of matrix's cells
(-moveLeft:): cleanup; move left from firstResponder instead of from
selectedColumn
(-moveRight:): cleanup; move right from firstResponder instead of from
selectedColumn; removed call to doClick:
(-_performLoadOfColumn:): change _lastColumnLoaded if necessary
2003-08-16 Matt Rice <ratmice@yahoo.com>
* Source/NSDocument.m ([NSDocument -init]): Check the count of the

8
Source/NSTableView.m
View file

@ -5605,8 +5605,8 @@ byExtendingSelection: (BOOL)flag
{
NSMutableDictionary *d;
d = [[NSMutableDictionary alloc] initWithDictionary:
[aNotification userInfo]];
d = [NSMutableDictionary dictionaryWithDictionary:
[aNotification userInfo]];
[d setObject: [aNotification object] forKey: @"NSFieldEditor"];
[nc postNotificationName: NSControlTextDidBeginEditingNotification
object: self
@ -5622,7 +5622,7 @@ byExtendingSelection: (BOOL)flag
@selector(textDidChange:)])
[_editedCell textDidChange: aNotification];
d = [[NSMutableDictionary alloc] initWithDictionary:
d = [NSMutableDictionary dictionaryWithDictionary:
[aNotification userInfo]];
[d setObject: [aNotification object] forKey: @"NSFieldEditor"];
[nc postNotificationName: NSControlTextDidChangeNotification
@ -5651,7 +5651,7 @@ byExtendingSelection: (BOOL)flag
_editedColumn = -1;
_editedRow = -1;
d = [[NSMutableDictionary alloc] initWithDictionary:
d = [NSMutableDictionary dictionaryWithDictionary:
[aNotification userInfo]];
[d setObject: [aNotification object] forKey: @"NSFieldEditor"];
[nc postNotificationName: NSControlTextDidEndEditingNotification