gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-24 06:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Attempt to improve a possibly misleading comment about releasing top

Browse source 
level objects of a gorm/nib file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30074 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Wolfgang Lux 2010-03-30 07:09:44 +00:00
parent 58a1f6ec65
commit d22c6be29f
3 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
2010-03-30 Wolfgang Lux <wolfgang.lux@gmail.com>
* Source/GSGormLoading.m:
* Source/GSNibLoading.m: Attempt to improve a possibly misleading
comment about releasing top level objects of a gorm/nib file.
2010-03-28 Fred Kiefer <FredKiefer@gmx.de>
* Headers/AppKit/NSPopUpButtonCell.h

7
Source/GSGormLoading.m
View file

@ -276,9 +276,10 @@ static NSString *GSInternalNibItemAddedNotification = @"_GSInternalNibItemAddedN
if ([topLevelObjects containsObject: o]) // anything already designated a top level item..
{
[topObjects addObject: o];
// All top level objects (that are not retained and
// released by other nib objects) must be released by
// the caller to avoid leaking.
// All top level objects must be released by the
// caller to avoid leaking, unless they are going
// to be released by other nib objects on behalf
// of the owner.
RETAIN(o);
}
}

5
Source/GSNibLoading.m
View file

@ -1911,8 +1911,9 @@ static BOOL _isInInterfaceBuilder = NO;
if ((v == owner || v == _root) && (obj != owner) && (obj != _root))
{
[topLevelObjects addObject: obj];
// All top level objects must be released by
// the caller to avoid leaking.
// All top level objects must be released by the caller to avoid
// leaking, unless they are going to be released by other nib
// objects on behalf of the owner.
RETAIN(obj);
}