From c30f15c8026c9ea77b332ec60fa4781a80f79af2 Mon Sep 17 00:00:00 2001 From: gcasa Date: Sun, 5 Sep 2004 14:32:25 +0000 Subject: [PATCH] Corrected issue with NSTableView. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@19999 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 6 ++++++ Source/NSTableView.m | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 98364be66..7ce881307 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2004-09-05 10:30 Matt Rice + + * Source/NSTableView.m: [NSTableView mouseDown:] removed code which + copied and subsequently DESTROYs dataCell. This was causing a + SIGSEGV. + 2004-09-05 06:23 Matt Rice * Source/GSServicesManager.m: new method -activateIgnoringOtherApps: diff --git a/Source/NSTableView.m b/Source/NSTableView.m index 829146bba..e4b3d7e21 100644 --- a/Source/NSTableView.m +++ b/Source/NSTableView.m @@ -3460,9 +3460,7 @@ inline float computePeriod(NSPoint mouseLocationWin, // Prepare the cell tb = [_tableColumns objectAtIndex: _clickedColumn]; - // NB: need to be released when no longer used - // Not sure if we really need a copy here. - cell = [[tb dataCellForRow: _clickedRow] copy]; + cell = [tb dataCellForRow: _clickedRow]; [cell setObjectValue: [self _objectValueForTableColumn: tb row: _clickedRow]]; cellFrame = [self frameOfCellAtColumn: _clickedColumn @@ -3498,8 +3496,6 @@ inline float computePeriod(NSPoint mouseLocationWin, [cell setHighlighted: NO]; [self setNeedsDisplayInRect: cellFrame]; lastEvent = [NSApp currentEvent]; - - DESTROY(cell); } while (done != YES)