gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-23 02:04:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix dead initialisation found by static analyser.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@32530 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2011-03-10 23:21:04 +00:00
parent 782af1ee89
commit b216539303
5 changed files with 25 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2011-03-11 Fred Kiefer <FredKiefer@gmx.de>
* ColorPickers/GSStandardColorPicker.m
* Source/GSToolbarCustomizationPalette.m
* Source/GSServicesManager.m
* Source/NSSpellChecker.m: Fix dead initialisation found by static
analyser.
2011-03-10 Fred Kiefer <FredKiefer@gmx.de>
* TextConverters/RTF/RTFConsumer.m

2
ColorPickers/GSStandardColorPicker.m
View file

@ -238,7 +238,7 @@
- (void) _showNewPicker: (id) sender
{
NSView *currentView = [currentPicker provideNewView: NO];
NSView *currentView;
//NSLog(@"Old View size %@", NSStringFromRect([currentView frame]));
currentPicker = [pickers objectAtIndex: [sender selectedColumn]];

2
Source/GSServicesManager.m
View file

@ -819,7 +819,6 @@ static NSString *disabledName = @".GNUstepDisabled";
- (void) loadServices
{
NSFileManager *mgr = [NSFileManager defaultManager];
NSDate *stamp = [NSDate date];
BOOL changed = NO;
if ([mgr fileExistsAtPath: _disabledPath])
@ -853,7 +852,6 @@ static NSString *disabledName = @".GNUstepDisabled";
}
}
stamp = [NSDate date];
if ([mgr fileExistsAtPath: _servicesPath])
{
NSDictionary *attr;

1
Source/GSToolbarCustomizationPalette.m
View file

@ -73,7 +73,6 @@
NSEnumerator *e = [items objectEnumerator];
NSToolbarItem *item = nil;
e = [items objectEnumerator];
while ((item = [e nextObject]) != nil)
{
NSToolbarItem *newItem = [item copy];

34
Source/NSSpellChecker.m
View file

@ -327,15 +327,14 @@ static int __documentTag = 0;
language:(NSString *)language
{
int count = 0;
NSRange r = NSMakeRange(0,0);
id<NSSpellServerPrivateProtocol> proxy = [self _serverProxy];
if (proxy != nil)
r = [proxy _findMisspelledWordInString: aString
language: _language
ignoredWords: nil
wordCount: &count
countOnly: YES];
[proxy _findMisspelledWordInString: aString
language: _language
ignoredWords: nil
wordCount: &count
countOnly: YES];
return count;
}
@ -344,7 +343,7 @@ static int __documentTag = 0;
startingAt:(int)startingOffset
{
int wordCount = 0;
NSRange r = NSMakeRange(0,0);
NSRange r;
r = [self checkSpellingOfString: stringToCheck
startingAt: startingOffset
@ -541,7 +540,7 @@ inSpellDocumentWithTag:(int)tag
[self _populateAccessoryView];
}
- _findNext: (id)sender
- (id) _findNext: (id)sender
{
BOOL processed = [[[NSApp mainWindow] firstResponder]
tryToPerform: @selector(checkSpelling:)
@ -555,16 +554,15 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _learn: (id)sender
- (id) _learn: (id)sender
{
NSString *word = [_wordField stringValue];
BOOL result = NO;
// Call server and record the learned word.
NS_DURING
{
result = [[self _serverProxy] _learnWord: word
inDictionary: _language];
[[self _serverProxy] _learnWord: word
inDictionary: _language];
}
NS_HANDLER
{
@ -577,7 +575,7 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _forget: (id)sender
- (id) _forget: (id)sender
{
NSString *word = [_wordField stringValue];
@ -599,7 +597,7 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _ignore: (id)sender
- (id) _ignore: (id)sender
{
BOOL processed = [[[NSApp mainWindow] firstResponder]
tryToPerform: @selector(ignoreSpelling:)
@ -615,14 +613,14 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _guess: (id)sender
- (id) _guess: (id)sender
{
// Fill in the view...
[self _populateAccessoryView];
return self;
}
- _correct: (id)sender
- (id) _correct: (id)sender
{
BOOL processed = [[[NSApp mainWindow] firstResponder]
tryToPerform: @selector(changeSpelling:)
@ -637,7 +635,7 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _switchDictionary: (id)sender
- (id) _switchDictionary: (id)sender
{
id<NSSpellServerPrivateProtocol> proxy = nil;
NSString *language = nil;
@ -663,7 +661,7 @@ inSpellDocumentWithTag:(int)tag
return self;
}
- _highlightGuess: (id)sender
- (id) _highlightGuess: (id)sender
{
NSString *selectedGuess = nil;