* Source/NSTableView.m (selectContiguousRegion): Remove usage of

offsets.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24060 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Matt Rice 2006-11-09 12:59:04 +00:00
parent ab28e892bb
commit affd41f5b1
2 changed files with 11 additions and 8 deletions

View file

@ -1,4 +1,10 @@
2006-11-07 Matt Rice <ratmice@gmail.com>
2006-11-09 Matt Rice <ratmice@gmail.com>
* Source/NSTableView.m (selectContiguousRegion): Remove usage of
offsets.
2006-11-08 Matt Rice <ratmice@gmail.com>
* Source/NSTableView.m: Implement keyboard navigation/selection.
Fixes bug #11942.

View file

@ -3874,11 +3874,10 @@ static BOOL selectContiguousRegion(NSTableView *self,
int oldRow,
int currentRow)
{
int oldDiff = oldRow - originalRow;
int newDiff = currentRow - originalRow;
int offset = (oldDiff < newDiff) ? oldDiff : newDiff;
int first = (oldRow < currentRow) ? oldRow : currentRow;
int last = (oldRow < currentRow) ? currentRow : oldRow;
int row;
BOOL notified = NO;
int i, c;
if (![_selectedRows containsIndex: currentRow])
{
@ -3909,9 +3908,8 @@ static BOOL selectContiguousRegion(NSTableView *self,
* and possibly unselect the oldRow, one of the two will then
* be selected or deselected again in in this loop
*/
for (i = 0, c = abs(oldRow - currentRow); i < c; i++)
for (row = first; row < last; row++)
{
int row = originalRow + offset;
/* check if the old row is between the current row and the original row */
if ((row < currentRow
@ -3943,7 +3941,6 @@ static BOOL selectContiguousRegion(NSTableView *self,
[self _unselectRow: row];
}
}
offset++;
}
return notified;
}