* Source/NSBrowser.m (-doClick:): Don't reselect the selected cells.

Fixes bug #18881
        * Source/NSMatrix.m (-_selectPreviousSelectableCellBeforeRow:column):
        Update _selectedCells for the new selection.
        (-_selectNextSelectableCellAfterRow:column:):
        Ditto.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24483 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Matt Rice 2007-02-06 10:13:43 +00:00
parent c314291668
commit ac14777bba
3 changed files with 19 additions and 0 deletions

View file

@ -1,3 +1,12 @@
2007-02-06 Matt Rice <ratmice@gmail.com>
* Source/NSBrowser.m (-doClick:): Don't reselect the selected cells.
Fixes bug #18881
* Source/NSMatrix.m (-_selectPreviousSelectableCellBeforeRow:column):
Update _selectedCells for the new selection.
(-_selectNextSelectableCellAfterRow:column:):
Ditto.
2007-02-05 Matt Rice <ratmice@gmail.com>
* Headers/AppKit/NSOutlineView.h: Update documentation.

View file

@ -2008,6 +2008,11 @@ static NSTextFieldCell *titleCell;
selectedCellsCount = [selectedCells count];
/* FIXME why were we reselecting already selected cells?
* this caused bug #18881 because -selectCell: will scroll the row to visible.
*/
#if 0
// Select cells that should be selected
if (selectedCellsCount > 0)
{
@ -2015,6 +2020,7 @@ static NSTextFieldCell *titleCell;
while ((cell = [enumerator nextObject]))
[sender selectCell: cell];
}
#endif
[self setLastColumn: column];
// Single selection

View file

@ -4053,6 +4053,7 @@ static SEL getSel;
_selectedCell = [self selectTextAtRow: row column: j];
_selectedRow = row;
_selectedColumn = j;
_selectedCells[row][j] = YES;
return YES;
}
}
@ -4067,6 +4068,7 @@ static SEL getSel;
_selectedCell = [self selectTextAtRow: i column: j];
_selectedRow = i;
_selectedColumn = j;
_selectedCells[i][j] = YES;
return YES;
}
}
@ -4089,6 +4091,7 @@ static SEL getSel;
_selectedCell = [self selectTextAtRow: row column: j];
_selectedRow = row;
_selectedColumn = j;
_selectedCells[row][j] = YES;
return YES;
}
}
@ -4103,6 +4106,7 @@ static SEL getSel;
_selectedCell = [self selectTextAtRow: i column: j];
_selectedRow = i;
_selectedColumn = j;
_selectedCells[i][j] = YES;
return YES;
}
}