gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-23 20:01:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix retain bug in NIB loading.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27772 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2009-02-03 22:43:12 +00:00
parent f35949036f
commit a423d5bdec
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2009-02-03 Fred Kiefer <FredKiefer@gmx.de>
* Source/GSNibLoading.m (NSButtonImageSource -initWithCoder:): Add
missing retain of the named image.
2009-02-03 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSTextContainer.m: Add some frame size checks.

8
Source/GSNibLoading.m
View file

@ -205,6 +205,8 @@ static BOOL _isInInterfaceBuilder = NO;
@implementation NSView (NibCompatibility)
- (void) _setWindow: (id) w
{
// FIXME: Why is this an ASSIGN? The view is held by the window
// not the othe way around.
ASSIGN(_window,w);
}
@ -703,6 +705,7 @@ static BOOL _isInInterfaceBuilder = NO;
}
}
// FIXME: Should release self
return _realObject;
}
else
@ -801,6 +804,7 @@ static BOOL _isInInterfaceBuilder = NO;
- (id) initWithCoder: (NSCoder *)aCoder
{
// FIXME: Should release self
return nil;
}
@ -1444,6 +1448,7 @@ static BOOL _isInInterfaceBuilder = NO;
NSStringFromClass([coder class])];
}
// FIXME: Needs to release self
return _template;
}
@ -2044,7 +2049,7 @@ static BOOL _isInInterfaceBuilder = NO;
}
RELEASE(self);
return [NSImage imageNamed: imageName];
return RETAIN([NSImage imageNamed: imageName]);
}
- (void) encodeWithCoder: (NSCoder *)coder
@ -2208,6 +2213,7 @@ static BOOL _isInInterfaceBuilder = NO;
exponent: exponent
isNegative: negative];
}
// FIXME: Needs to release self
return dn;
}