diff --git a/ChangeLog b/ChangeLog index 469cd54c8..6961d9989 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,17 @@ +2002-02-25 Adam Fedor + + * Source/NSGraphicsContext.m (_postExternalEvent:) Removed, not used. + * Source/NSInterfaceStyle.m: Updated comments. + * Source/NSScroller.m (-setFloatValue:): Don't update + if the new float is the same as our current value. + (-setFloatValue:knobProportion:): Likewise. + +2002-02-18 Willem Rein Oudshoorn + + * gui/Source/NSImage.m ([NSImage -initWithSize:]): removed the + round size down temporary fix. + ([NSImage -setSize:]): removed the round size down temporary fix. + Mon Feb 25 14:51:56 2002 Nicola Pero * Source/NSSavePanel.m (createRowsForColumn:): Use diff --git a/Source/NSGraphicsContext.m b/Source/NSGraphicsContext.m index dec2ee873..0a122082e 100644 --- a/Source/NSGraphicsContext.m +++ b/Source/NSGraphicsContext.m @@ -391,11 +391,6 @@ NSGraphicsContext *GSCurrentContext() return NO; } -- (void) _postExternalEvent: (NSEvent *)event -{ - [self subclassResponsibility: _cmd]; -} - - (void) useFont: (NSString*)name { if ([self isDrawingToScreen] == YES) diff --git a/Source/NSImage.m b/Source/NSImage.m index e3ec96fb6..baf6debd9 100644 --- a/Source/NSImage.m +++ b/Source/NSImage.m @@ -289,12 +289,7 @@ repd_for_rep(NSArray *_reps, NSImageRep *rep) //_flags.flipDraw = NO; if (aSize.width && aSize.height) { - // FIXME: rounding down is just a quick fix. - // the non-integrality of the image should be - // taken care of in the composite methods in - // the backend. - _size.width = (int) aSize.width; - _size.height = (int) aSize.height; + _size = aSize; _flags.sizeWasExplicitlySet = YES; } //_flags.usesEPSOnResolutionMismatch = NO; @@ -493,12 +488,7 @@ repd_for_rep(NSArray *_reps, NSImageRep *rep) - (void) setSize: (NSSize)aSize { - // FIXME: the rounding down is just a quick fix - // it should actually be handled in composite in - // the backend. - _size.width = (int) aSize.width; - _size.height = (int) aSize.height; - + _size = aSize; _flags.sizeWasExplicitlySet = YES; // TODO: This invalidates any cached data } diff --git a/Source/NSInterfaceStyle.m b/Source/NSInterfaceStyle.m index 9776b9596..0d992bc3d 100644 --- a/Source/NSInterfaceStyle.m +++ b/Source/NSInterfaceStyle.m @@ -75,10 +75,14 @@ typedef struct {

Styles can be set using the user defaults system. Currently available - styles are NSNextStepInterfaceStyle, - NSMacintoshInterfaceStyle, - NSWindows95InterfaceStyle, - GSWindowMakerInterfaceStyle. You can set a default style + styles are + + NSNextStepInterfaceStyle, + NSMacintoshInterfaceStyle, + NSWindows95InterfaceStyle, + GSWindowMakerInterfaceStyle. + + You can set a default style for all UI elements using the NSInterfaceStyleDefault key: defaults write NSGlobalDomain NSInterfaceStyleDefault GSWindowMakerInterfaceStyle diff --git a/Source/NSScroller.m b/Source/NSScroller.m index c4ba8bcd7..d222dcf93 100644 --- a/Source/NSScroller.m +++ b/Source/NSScroller.m @@ -337,6 +337,11 @@ static NSColor *scrollBarColor = nil; - (void) setFloatValue: (float)aFloat { + if (_floatValue == aFloat) + { + /* Most likely our trackKnob method initiated this via NSScrollView */ + return; + } if (aFloat < 0) { _floatValue = 0; @@ -355,6 +360,11 @@ static NSColor *scrollBarColor = nil; - (void) setFloatValue: (float)aFloat knobProportion: (float)ratio { + if (_floatValue == aFloat && _knobProportion == ratio) + { + /* Most likely our trackKnob method initiated this via NSScrollView */ + return; + } if (ratio < 0) { _knobProportion = 0;