* Source/NSOutlineView.m ([NSOutlineView -drawRow:clipRect:]):

Add delegate method call. Patch from Yen-Ju Chen
* Source/NSView.m (-menuForEvent:): Add note about this
method being discouraged.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@16981 72102866-910b-0410-8b05-ffd578937521

ChangeLog

@@ -1,3 +1,11 @@
+2003-06-21  Adam Fedor  <fedor@gnu.org>
+
+	* Source/NSOutlineView.m ([NSOutlineView -drawRow:clipRect:]): 
+	Add delegate method call. Patch from Yen-Ju Chen
+
+	* Source/NSView.m (-menuForEvent:): Add note about this
+	method being discouraged.
+
 2003-06-20  Adam Fedor  <fedor@gnu.org>
 
 	* Source/NSFont.m ([NSFont -initWithCoder:]): Use NSFont not isa

Source/NSOutlineView.m

@@ -995,6 +995,14 @@ static NSImage *unexpandable  = nil;
 
 	      imageRect.size.width = [image size].width;
 	      imageRect.size.height = [image size].height;
+	      
+	      if ([_delegate respondsToSelector: @selector(outlineView:willDisplayOutlineCell:forTableColumn:item:)])
+		{
+		  [_delegate outlineView: self
+			     willDisplayOutlineCell: imageCell
+			     forTableColumn: tb
+			     item: item];
+		}
 
 	      [imageCell drawWithFrame: imageRect inView: self];
 

Source/NSView.m

@@ -3818,6 +3818,13 @@ static NSView* findByTag(NSView *view, int aTag, unsigned *level)
  *    (although it seems it can be used for any kind of event)</p>
  * <p>This method is used by NSView's rightMouseDown: method, 
  *    and the returned NSMenu is displayed as a context menu</p> 
+ * <p>Use of this method is discouraged in GNUstep as it breaks many
+ *    user interface guidelines. At the very least, menu items that appear
+ *    in a context sensitive menu should also always appear in a normal
+ *    menu. Otherwise, user are faced with an inconsistant interface where
+ *    the menu items they want are only available in certain (possibly
+ *    unknown) cases, making it difficult for the user to understand how
+ *    the application operates</p>
  * <p> see [NSResponder -menu], [NSResponder -setMenu:],
  *     [NSView +defaultMenu] and [NSView -menu].
  * </p>