Retain the shared user defaults controller before returning it in

initWithCoder:.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28368 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2009-06-21 22:35:23 +00:00
parent 8ed4d5e90e
commit 988c2a8a8b
2 changed files with 13 additions and 2 deletions

View file

@ -1,3 +1,8 @@
2009-06-22 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSUserDefaultsController.m (-initWithCoder:): Retain the
shared controller before returning it.
2009-06-22 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSKeyValueBinding.m (GSKeyValueBinding+initialize):

View file

@ -200,6 +200,12 @@ static id shared = nil;
- (void) dealloc
{
if (self == shared)
{
// Should never get here
shared = nil;
}
[[NSNotificationCenter defaultCenter] removeObserver: self];
RELEASE(_values);
RELEASE(_defaults);
@ -296,7 +302,7 @@ static id shared = nil;
- (void) encodeWithCoder: (NSCoder *)aCoder
{
if ([aCoder allowsKeyedCoding])
if (self == [NSUserDefaultsController sharedUserDefaultsController])
if (self == shared)
{
[aCoder encodeBool: YES forKey: @"NSSharedInstance"];
return;
@ -311,7 +317,7 @@ static id shared = nil;
if ([aDecoder decodeBoolForKey: @"NSSharedInstance"])
{
RELEASE(self);
return [NSUserDefaultsController sharedUserDefaultsController];
return RETAIN([NSUserDefaultsController sharedUserDefaultsController]);
}
return [super initWithCoder: aDecoder];